)]}'
{"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"20df86178d9de204559c4da3c793242e33060d1a","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            try:"},{"line_number":475,"context_line":"                save_output \u003d self.execute(args, run_as_root\u003dTrue)"},{"line_number":476,"context_line":"            except RuntimeError:"},{"line_number":477,"context_line":"                # We could be racing with a cron job deleting namespaces."},{"line_number":478,"context_line":"                # It is useless to try to apply iptables rules over and"},{"line_number":479,"context_line":"                # over again in a endless loop if the namespace does not"},{"line_number":480,"context_line":"                # exist."}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_f3022809","line":477,"range":{"start_line":477,"start_character":18,"end_line":477,"end_character":72},"updated":"2017-03-27 16:10:56.000000000","message":"As you said in the comment, this could be happening for an external process to OpenStack environment.\n\nIf the namespace doesn\u0027t exist, is something remarkable to consider. In this case we should raise the exception and the admin should fix the problem with the external process deleting this namespace.\n\nWith this try/catch we are hidding a problem without even writting a warning message.","commit_id":"1fc7d70652e8f4d3be06b86d5fea4a634dae41f1"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"903feb8d07024237b7896ef0b8bb7446fdb47fa2","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            try:"},{"line_number":475,"context_line":"                save_output \u003d self.execute(args, run_as_root\u003dTrue)"},{"line_number":476,"context_line":"            except RuntimeError:"},{"line_number":477,"context_line":"                # We could be racing with a cron job deleting namespaces."},{"line_number":478,"context_line":"                # It is useless to try to apply iptables rules over and"},{"line_number":479,"context_line":"                # over again in a endless loop if the namespace does not"},{"line_number":480,"context_line":"                # exist."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_67f8e7c3","line":477,"updated":"2017-04-15 00:28:44.000000000","message":"I think logging an error would work fine here.","commit_id":"1fc7d70652e8f4d3be06b86d5fea4a634dae41f1"}]}