)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"83896326d7ee03b37b68cf8a1c1a087a8835dc15","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     AlexSTafeyev \u003calexo101087@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-28 12:40:59 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tempest: Edited bash commands to work with Rhel."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Edited the \"CONFIGURE_VLAN_INTERFACE_COMMANDS\" with commands"},{"line_number":10,"context_line":"full path ( ip \u003d\u003e /sur/sbin/ip) in order to run this test on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_fdf532ee","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":47},"updated":"2017-03-28 09:45:02.000000000","message":"It might be not rhel specific, there might be other guest OSes like Centos that will require full path.","commit_id":"c1d12a8142169087114c4f106443ae896af04c6e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"83896326d7ee03b37b68cf8a1c1a087a8835dc15","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Tempest: Edited bash commands to work with Rhel."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Edited the \"CONFIGURE_VLAN_INTERFACE_COMMANDS\" with commands"},{"line_number":10,"context_line":"full path ( ip \u003d\u003e /sur/sbin/ip) in order to run this test on"},{"line_number":11,"context_line":"rhel properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I73f0f79ac6b34a1a5b1b22406f730dfd1266d5d5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_9de4e63d","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":22},"updated":"2017-03-28 09:45:02.000000000","message":"usr","commit_id":"c1d12a8142169087114c4f106443ae896af04c6e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c5d94542de22d26d92dff729d2a4cf8e8509f61","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Tempest: Edited bash commands to work with multiple OSes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Edited the \"CONFIGURE_VLAN_INTERFACE_COMMANDS\" with commands"},{"line_number":10,"context_line":"full path ( ip \u003d\u003e /usr/sbin/ip) in order to run this test on"},{"line_number":11,"context_line":"rhel properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I73f0f79ac6b34a1a5b1b22406f730dfd1266d5d5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_b7c33e57","line":10,"updated":"2017-03-28 13:13:27.000000000","message":"You have /usr/sbin here but patch uses /sbin.  And since you\u0027re also changing dhclient, maybe:\n\n(e.g. ip \u003d\u003e /sbin/ip)","commit_id":"9579df2814fb5c646bc00d29063ecbabb3220e63"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"aa9382faddf08ad454d6f23a7aa9cbb82871020c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Edited the \"CONFIGURE_VLAN_INTERFACE_COMMANDS\" with commands"},{"line_number":10,"context_line":"full path ( ip \u003d\u003e /sbin/ip) in order to run this test on"},{"line_number":11,"context_line":"rhel properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I73f0f79ac6b34a1a5b1b22406f730dfd1266d5d5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ffa3b31_d62496b1","line":11,"updated":"2017-04-20 05:50:16.000000000","message":"i guess it\u0027s safer to add /bin to PATH","commit_id":"bb6e143452792073270f06949e120aa8ee3e5f1d"}],"neutron/tests/tempest/scenario/test_trunk.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9cf8a9c005fe71f51341cf18e35b34948d5f62f7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027\"/usr/sbin/ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":33,"context_line":"    \u0027/usr/sbin/ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"},{"line_number":34,"context_line":"    \u0027/usr/sbin/dhclient $IFACE.%(tag)d\"\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def get_next_subnet(cidr):"},{"line_number":38,"context_line":"    return netaddr.IPNetwork(cidr).next()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_e0c7c595","line":35,"updated":"2017-03-28 10:02:27.000000000","message":"In my local env(Ubuntu 16.04.1 LTS), \"ip\" is /sbin/ip.\n\nhttp://paste.openstack.org/show/604444/","commit_id":"c1d12a8142169087114c4f106443ae896af04c6e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ab8c10e4660fca1646bead0644e652bf02403a65","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONFIGURE_VLAN_INTERFACE_COMMANDS \u003d ("},{"line_number":30,"context_line":"    \u0027IFACE\u003d$(/bin/ip l | grep \"^[0-9]*: e\" | cut -d \\: -f 2) \u0026\u0026 \u0027"},{"line_number":31,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":32,"context_line":"    \u0027\"/bin/ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":33,"context_line":"    \u0027/bin/ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_b93d7a2c","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":18},"updated":"2017-04-20 08:50:36.000000000","message":"Yamamoto meant to add \"/sbin\" to PATH env variable leaving the \u0027ip\u0027 as executable and not using absolute path.","commit_id":"3b5db4f32c27f08d1cb082e352b8288e24d249a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e8bd17c46956a444b50d2e2718a4805111018733","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONFIGURE_VLAN_INTERFACE_COMMANDS \u003d ("},{"line_number":30,"context_line":"    \u0027IFACE\u003d$(/bin/ip l | grep \"^[0-9]*: e\" | cut -d \\: -f 2) \u0026\u0026 \u0027"},{"line_number":31,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":32,"context_line":"    \u0027\"/bin/ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":33,"context_line":"    \u0027/bin/ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_bc49e831","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":18},"in_reply_to":"7ffa3b31_b93d7a2c","updated":"2017-04-20 09:08:53.000000000","message":"I\u0027m trying to go through man pages to get root\u0027s PATH env var for commands on L32-L34","commit_id":"3b5db4f32c27f08d1cb082e352b8288e24d249a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ac45d7f5ecc0da94aa89fb4ec17b3196f55af37c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONFIGURE_VLAN_INTERFACE_COMMANDS \u003d ("},{"line_number":30,"context_line":"    \u0027IFACE\u003d$(ip l | grep \"^[0-9]*: e\" | cut -d \\: -f 2) \u0026\u0026 \u0027"},{"line_number":31,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":32,"context_line":"    \u0027\"ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026 \u0027"},{"line_number":33,"context_line":"    \u0027ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"},{"line_number":34,"context_line":"    \u0027dhclient $IFACE.%(tag)d\"\u0027)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_98f1916e","side":"PARENT","line":32,"range":{"start_line":32,"start_character":68,"end_line":32,"end_character":69},"updated":"2017-04-20 12:20:30.000000000","message":"Not that it would hurt the line but I don\u0027t think it\u0027s necessary to remove this space","commit_id":"3e61f0962b96a5c3c0c6a8c84ef31f4a5f4f5b34"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"11a5233644eadbab80b3fa0e44b577556caafe52","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONFIGURE_VLAN_INTERFACE_COMMANDS \u003d ("},{"line_number":30,"context_line":"    \u0027IFACE\u003d$(PATH\u003d$PATH:/usr/sbin ip l | grep \"^[0-9]*: e\" | cut -d \\: -f 2) \u0026\u0026 \u0027"},{"line_number":31,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":32,"context_line":"    \u0027\"ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":33,"context_line":"    \u0027ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_38a15d47","line":30,"updated":"2017-04-20 12:22:51.000000000","message":"I think it would make sense to also add a comment here about why this is necessary.\n\nAlso, instead of hardcoding the patch, what about running \"sudo ip l\"?","commit_id":"1907e8fbccb08f71d8c6f591306c1e54df1589a0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"cbc88b3083f0ead0345162ae4208c21d1be8b01a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONFIGURE_VLAN_INTERFACE_COMMANDS \u003d ("},{"line_number":30,"context_line":"    \u0027IFACE\u003d$(PATH\u003d$PATH:/usr/sbin ip l | grep \"^[0-9]*: e\" | cut -d \\: -f 2) \u0026\u0026 \u0027"},{"line_number":31,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":32,"context_line":"    \u0027\"ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":33,"context_line":"    \u0027ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_0cf88678","line":30,"updated":"2017-04-21 07:49:47.000000000","message":"This line is too long and is causing pep8 failure","commit_id":"1907e8fbccb08f71d8c6f591306c1e54df1589a0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1afba73301bdc889546729ff22dd6a28e1051b55","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONFIGURE_VLAN_INTERFACE_COMMANDS \u003d ("},{"line_number":30,"context_line":"    \u0027IFACE\u003d$(PATH\u003d$PATH:/usr/sbin ip l | grep \"^[0-9]*: e\" | cut -d \\: -f 2) \u0026\u0026 \u0027"},{"line_number":31,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":32,"context_line":"    \u0027\"ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":33,"context_line":"    \u0027ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_5b7b037a","line":30,"in_reply_to":"7ffa3b31_38a15d47","updated":"2017-04-20 12:33:52.000000000","message":"I think using \u0027sudo\u0027 is just another alternative approach. Do you see any benefit in running it under root?","commit_id":"1907e8fbccb08f71d8c6f591306c1e54df1589a0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7958b4c9f1de0d89e548eb64f1e36f28fff9dfc9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONFIGURE_VLAN_INTERFACE_COMMANDS \u003d ("},{"line_number":30,"context_line":"    \u0027IFACE\u003d$(PATH\u003d$PATH:/usr/sbin ip l | grep \"^[0-9]*: e\" | cut -d \\: -f 2) \u0026\u0026 \u0027"},{"line_number":31,"context_line":"    \u0027sudo su -c \u0027"},{"line_number":32,"context_line":"    \u0027\"ip l a link $IFACE name $IFACE.%(tag)d type vlan id %(tag)d \u0026\u0026\u0027"},{"line_number":33,"context_line":"    \u0027ip l s up dev $IFACE.%(tag)d \u0026\u0026 \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_5969c8f6","line":30,"in_reply_to":"7ffa3b31_5b7b037a","updated":"2017-04-20 15:10:00.000000000","message":"I meant to say \"hardcoding the path\", I see benefit in not having to do that. Other distros might need /sbin or something else in the future.\n\nAnd we do run \"sudo (su -c) ip\" just below this anyway, so there should be no negative impact from doing it twice.","commit_id":"1907e8fbccb08f71d8c6f591306c1e54df1589a0"}]}
