)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5caf79c008e818b28342d1048c7f0e770e6e7f6f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"raise Exception instead of LOG.error on cookie/mask inconsistency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Follow up to a comment by kevinbeton on Idd0531cedda87224531cb8fb6a912ccd0f1554d5 ."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The rationale is that one should never call delete a flow"},{"line_number":12,"context_line":"with cookie\u003dANY_COOKIE and give a cookie_mask at the same time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_a5dad647","line":9,"updated":"2017-03-28 18:04:21.000000000","message":"Break this line in two","commit_id":"8f98db0dbf8b89c6b3960e226f2da9a54b1c1105"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5caf79c008e818b28342d1048c7f0e770e6e7f6f","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                    # cookie to match flows whatever their cookie is"},{"line_number":346,"context_line":"                    kw.pop(\u0027cookie\u0027)"},{"line_number":347,"context_line":"                    if kw.get(\u0027cookie_mask\u0027):  # non-zero cookie mask"},{"line_number":348,"context_line":"                        raise Exception(\"cookie\u003dCOOKIE_ANY but cookie_mask \""},{"line_number":349,"context_line":"                                        \"set to %s\" % kw.get(\u0027cookie_mask\u0027))"},{"line_number":350,"context_line":"                elif \u0027cookie\u0027 in kw:"},{"line_number":351,"context_line":"                    # a cookie was specified, use it"},{"line_number":352,"context_line":"                    kw[\u0027cookie\u0027] \u003d check_cookie_mask(kw[\u0027cookie\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_c50cbaa6","line":349,"range":{"start_line":348,"start_character":24,"end_line":349,"end_character":76},"updated":"2017-03-28 18:04:21.000000000","message":"You should make a test checking this exception","commit_id":"8f98db0dbf8b89c6b3960e226f2da9a54b1c1105"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e263e1f8eeb7b662a5fcbad5d42ac04a11e8c66d","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                    # cookie to match flows whatever their cookie is"},{"line_number":346,"context_line":"                    kw.pop(\u0027cookie\u0027)"},{"line_number":347,"context_line":"                    if kw.get(\u0027cookie_mask\u0027):  # non-zero cookie mask"},{"line_number":348,"context_line":"                        raise Exception(\"cookie\u003dCOOKIE_ANY but cookie_mask \""},{"line_number":349,"context_line":"                                        \"set to %s\" % kw.get(\u0027cookie_mask\u0027))"},{"line_number":350,"context_line":"                elif \u0027cookie\u0027 in kw:"},{"line_number":351,"context_line":"                    # a cookie was specified, use it"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_bfd37738","line":348,"updated":"2017-04-02 07:52:17.000000000","message":"please use the translation for the exception\n\nis it worthwhile having a specific neutron exception here?","commit_id":"7fbdf77706c112382cd4e90c00c23420b5540f78"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ofswitch.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e263e1f8eeb7b662a5fcbad5d42ac04a11e8c66d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        if cookie \u003d\u003d ovs_lib.COOKIE_ANY:"},{"line_number":113,"context_line":"            cookie \u003d 0"},{"line_number":114,"context_line":"            if cookie_mask !\u003d 0:"},{"line_number":115,"context_line":"                raise Exception(\"cookie\u003dCOOKIE_ANY but cookie_mask set to %s\" %"},{"line_number":116,"context_line":"                                cookie_mask)"},{"line_number":117,"context_line":"        elif cookie \u003d\u003d COOKIE_DEFAULT:"},{"line_number":118,"context_line":"            cookie \u003d self._default_cookie"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_9fd67327","line":115,"updated":"2017-04-02 07:52:17.000000000","message":"same point here","commit_id":"7fbdf77706c112382cd4e90c00c23420b5540f78"}]}
