)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ef0b78d99b948cf5f769e30f2f2a5df26a46c5eb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"mod-flows actions.  When strict is set, the use of priority is allowed"},{"line_number":18,"context_line":"and hence not rejected anymore."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Note that for batched actions in a deffered bridge, we disallow mixing"},{"line_number":21,"context_line":"calls with strict and without strict, which can\u0027t be translated in one CLI"},{"line_number":22,"context_line":"call."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f013ff3_a2882671","line":20,"range":{"start_line":20,"start_character":35,"end_line":20,"end_character":43},"updated":"2017-05-15 08:02:33.000000000","message":"deferred","commit_id":"5981bf416d39f8ec15c937dabaf16d39a101d6ee"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6f6d59e2538161d6f2256d82639f1c66f074b018","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                    kw[\u0027cookie\u0027] \u003d self._default_cookie"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"            if action in (\u0027mod\u0027, \u0027del\u0027) and \u0027priority\u0027 in kw:"},{"line_number":362,"context_line":"                strict \u003d [\u0027--strict\u0027]"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":365,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_2f8671ba","line":362,"updated":"2017-05-01 09:17:10.000000000","message":"it seems like an awkward api to me.\nit\u0027s better to make a user say \"strict\" explicitly.","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"bc12be6f953ae389d22e7de8b01a15b932fb83ba","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                    kw[\u0027cookie\u0027] \u003d self._default_cookie"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"            if action in (\u0027mod\u0027, \u0027del\u0027) and \u0027priority\u0027 in kw:"},{"line_number":362,"context_line":"                strict \u003d [\u0027--strict\u0027]"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":365,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_b48f5f73","line":362,"in_reply_to":"5ff73747_2f8671ba","updated":"2017-05-02 08:42:14.000000000","message":"This \"priority set-\u003eenable strict mode\" comes from current networking-sfc code:\nhttps://github.com/openstack/networking-sfc/commit/b3976682965f82b8d374382b666236c4af720199\nIt made sense there to enable strict mode on deletions, but a \"strict\" parameter works too","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7a54e16eb214641ea0b0df9a2a30cf1e61a6a54c","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                    kw[\u0027cookie\u0027] \u003d self._default_cookie"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"            if action in (\u0027mod\u0027, \u0027del\u0027) and \u0027priority\u0027 in kw:"},{"line_number":362,"context_line":"                strict \u003d [\u0027--strict\u0027]"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":365,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_2fe536dc","line":362,"in_reply_to":"5ff73747_b48f5f73","updated":"2017-05-02 09:20:12.000000000","message":"I can agree with the idea that an explicit parameter would be better, it will avoid \"unvoluntarilly\" use of delete with priority.","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6f6d59e2538161d6f2256d82639f1c66f074b018","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action)"},{"line_number":370,"context_line":"                         for kw in kwargs_list]"},{"line_number":371,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, strict + [\u0027-\u0027],"},{"line_number":372,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":375,"context_line":"        self.do_action_flows(\u0027add\u0027, [kwargs])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_6fb91977","line":372,"updated":"2017-05-01 09:17:10.000000000","message":"i guess it doesn\u0027t actually matter, but the documented usage is:\n\n[--bundle] [--strict] del-flows switch - \u003c file","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7a54e16eb214641ea0b0df9a2a30cf1e61a6a54c","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action)"},{"line_number":370,"context_line":"                         for kw in kwargs_list]"},{"line_number":371,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, strict + [\u0027-\u0027],"},{"line_number":372,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def add_flow(self, **kwargs):"},{"line_number":375,"context_line":"        self.do_action_flows(\u0027add\u0027, [kwargs])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_efd2aeff","line":372,"in_reply_to":"5ff73747_6fb91977","updated":"2017-05-02 09:20:12.000000000","message":"Ok, will change.","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6f6d59e2538161d6f2256d82639f1c66f074b018","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"},{"line_number":394,"context_line":"        if flows:"},{"line_number":395,"context_line":"            retval \u003d \u0027\\n\u0027.join(item for item in flows.splitlines()"},{"line_number":396,"context_line":"                               if \u0027NXST\u0027 not in item and \u0027OFPST\u0027 not in item)"},{"line_number":397,"context_line":"        return retval"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def dump_all_flows(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_ef8be9bc","line":396,"updated":"2017-05-01 09:17:10.000000000","message":"is this related?","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7a54e16eb214641ea0b0df9a2a30cf1e61a6a54c","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"},{"line_number":394,"context_line":"        if flows:"},{"line_number":395,"context_line":"            retval \u003d \u0027\\n\u0027.join(item for item in flows.splitlines()"},{"line_number":396,"context_line":"                               if \u0027NXST\u0027 not in item and \u0027OFPST\u0027 not in item)"},{"line_number":397,"context_line":"        return retval"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def dump_all_flows(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_afd8261d","line":396,"in_reply_to":"5ff73747_d4e30b04","updated":"2017-05-02 09:20:12.000000000","message":"Yes, dunno how I ended up mising the two...","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"bc12be6f953ae389d22e7de8b01a15b932fb83ba","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        flows \u003d self.run_ofctl(\"dump-flows\", [flow_str])"},{"line_number":394,"context_line":"        if flows:"},{"line_number":395,"context_line":"            retval \u003d \u0027\\n\u0027.join(item for item in flows.splitlines()"},{"line_number":396,"context_line":"                               if \u0027NXST\u0027 not in item and \u0027OFPST\u0027 not in item)"},{"line_number":397,"context_line":"        return retval"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def dump_all_flows(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_d4e30b04","line":396,"in_reply_to":"5ff73747_ef8be9bc","updated":"2017-05-02 08:42:14.000000000","message":"I think it should only be \"strictly\" needed in  https://review.openstack.org/#/c/451601","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6f6d59e2538161d6f2256d82639f1c66f074b018","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def dump_all_flows(self):"},{"line_number":400,"context_line":"        return [f for f in self.run_ofctl(\"dump-flows\", []).splitlines()"},{"line_number":401,"context_line":"                if \u0027NXST\u0027 not in f and \u0027OFPST\u0027 not in f]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def deferred(self, **kwargs):"},{"line_number":404,"context_line":"        return DeferredOVSBridge(self, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_cfc02de4","line":401,"updated":"2017-05-01 09:17:10.000000000","message":"ditto","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"7a54e16eb214641ea0b0df9a2a30cf1e61a6a54c","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def dump_all_flows(self):"},{"line_number":400,"context_line":"        return [f for f in self.run_ofctl(\"dump-flows\", []).splitlines()"},{"line_number":401,"context_line":"                if \u0027NXST\u0027 not in f and \u0027OFPST\u0027 not in f]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    def deferred(self, **kwargs):"},{"line_number":404,"context_line":"        return DeferredOVSBridge(self, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_8fd32a01","line":401,"in_reply_to":"5ff73747_cfc02de4","updated":"2017-05-02 09:20:12.000000000","message":"ack","commit_id":"a4890d14905d6a64e22753d5ed72ce5a84d677b1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5ac603c757ee839bd90aeeba6b76c7247128b068","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                    raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        if strict:"},{"line_number":375,"context_line":"            strict_param \u003d [\"--strict\"]"},{"line_number":376,"context_line":"        else:"},{"line_number":377,"context_line":"            strict_param \u003d []"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_cd0c7096","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":39},"updated":"2017-05-03 13:07:05.000000000","message":"This could be:\nstrict_param \u003d [\"--strict\"] if strict else []","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"c142f3fd234bab1c840c120f563dbc22a43453a7","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                    raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        if strict:"},{"line_number":375,"context_line":"            strict_param \u003d [\"--strict\"]"},{"line_number":376,"context_line":"        else:"},{"line_number":377,"context_line":"            strict_param \u003d []"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_afc8f373","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":39},"in_reply_to":"5ff73747_cd0c7096","updated":"2017-05-03 16:02:19.000000000","message":"Done","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5ac603c757ee839bd90aeeba6b76c7247128b068","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action, strict)"},{"line_number":385,"context_line":"                         for kw in kwargs_list]"},{"line_number":386,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, strict_param + [\u0027-\u0027],"},{"line_number":387,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def add_flow(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_ed7cccec","line":386,"range":{"start_line":386,"start_character":60,"end_line":386,"end_character":63},"updated":"2017-05-03 13:07:05.000000000","message":"This should be a comma","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f18820ab66a38ee460a870611547565c9dc19243","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action, strict)"},{"line_number":385,"context_line":"                         for kw in kwargs_list]"},{"line_number":386,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, strict_param + [\u0027-\u0027],"},{"line_number":387,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def add_flow(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_88c2f4e8","line":386,"range":{"start_line":386,"start_character":60,"end_line":386,"end_character":63},"in_reply_to":"3f044301_48398c3f","updated":"2017-05-04 08:00:41.000000000","message":"I trust you: having misaligned eyes/eyesocket/brain sometimes happens to me as well :)","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"c142f3fd234bab1c840c120f563dbc22a43453a7","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action, strict)"},{"line_number":385,"context_line":"                         for kw in kwargs_list]"},{"line_number":386,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, strict_param + [\u0027-\u0027],"},{"line_number":387,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def add_flow(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_ef7cbb21","line":386,"range":{"start_line":386,"start_character":60,"end_line":386,"end_character":63},"in_reply_to":"5ff73747_ed7cccec","updated":"2017-05-03 16:02:19.000000000","message":"I don\u0027t think so: with a comma, strict_param alone would be args, and [\u0027-\u0027] would be process_input .\n\nAm I missing something ?","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3df80b3cc7fb343b4dd467fba6a19a86506732aa","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        else:"},{"line_number":384,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action, strict)"},{"line_number":385,"context_line":"                         for kw in kwargs_list]"},{"line_number":386,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, strict_param + [\u0027-\u0027],"},{"line_number":387,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def add_flow(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_48398c3f","line":386,"range":{"start_line":386,"start_character":60,"end_line":386,"end_character":63},"in_reply_to":"5ff73747_ef7cbb21","updated":"2017-05-04 07:53:29.000000000","message":"Sorry, trust me when I tell you I saw this:\n[strict + \u0027-\u0027]\n\nYour expresion is correct.","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5ac603c757ee839bd90aeeba6b76c7247128b068","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                             flow_dict.pop(\u0027priority\u0027, \u00271\u0027))"},{"line_number":767,"context_line":"    elif \u0027priority\u0027 in flow_dict:"},{"line_number":768,"context_line":"        if strict:"},{"line_number":769,"context_line":"            flow_expr_arr.append(\"priority\u003d%s\" % flow_dict[\u0027priority\u0027])"},{"line_number":770,"context_line":"        else:"},{"line_number":771,"context_line":"            msg \u003d _(\"Cannot match priority on flow deletion or modification \""},{"line_number":772,"context_line":"                    \"without \u0027strict\u0027\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_cdb6b08b","line":769,"range":{"start_line":769,"start_character":48,"end_line":769,"end_character":70},"updated":"2017-05-03 13:07:05.000000000","message":"I think you should pop the value here:\nflow_dict.pop(\u0027priority\u0027)\n\nIf not, you\u0027ll add it again in L786.\n\nBTW, because it\u0027s going to be added in L786, do you need to append it here?","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"c142f3fd234bab1c840c120f563dbc22a43453a7","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                             flow_dict.pop(\u0027priority\u0027, \u00271\u0027))"},{"line_number":767,"context_line":"    elif \u0027priority\u0027 in flow_dict:"},{"line_number":768,"context_line":"        if strict:"},{"line_number":769,"context_line":"            flow_expr_arr.append(\"priority\u003d%s\" % flow_dict[\u0027priority\u0027])"},{"line_number":770,"context_line":"        else:"},{"line_number":771,"context_line":"            msg \u003d _(\"Cannot match priority on flow deletion or modification \""},{"line_number":772,"context_line":"                    \"without \u0027strict\u0027\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_cf9e9f53","line":769,"range":{"start_line":769,"start_character":48,"end_line":769,"end_character":70},"in_reply_to":"5ff73747_cdb6b08b","updated":"2017-05-03 16:02:19.000000000","message":"Good point.\nFixed in next PS.","commit_id":"d04fcc74bd90fe5956863b8c6a342b04528e5721"}]}
