)]}'
{"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":21907,"name":"Arjun Baindur","email":"xagent@gmail.com","username":"arjunbaindur"},"change_message_id":"2a5c1691687d6883d7b62562b8a2c91dc6387e34","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # TODO(haleyb): this can go away after a cycle or two"},{"line_number":402,"context_line":"            if not self._stale_fips_checked:"},{"line_number":403,"context_line":"                stale_cidrs \u003d ("},{"line_number":404,"context_line":"                    ip for ip in router_info.RouterInfo.get_router_cidrs("},{"line_number":405,"context_line":"                        ri, device)"},{"line_number":406,"context_line":"                    if common_utils.is_cidr_host(ip))"},{"line_number":407,"context_line":"                for ip_cidr in stale_cidrs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_507dba6c","line":404,"updated":"2017-03-30 19:30:22.000000000","message":"Is there a reason to import router_info, and pass in the ri object to RouterInfo.get_router_cidrs class method? This function already has the ri object - can\u0027t we just directly call ri.get_router_cidrs(device) instead?\n\nThat is already being done above when we get the dist_fip_count","commit_id":"f84ce9a57ceaf6f931ca51e028bac64c93835d91"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8e78953a85987400c9ba1a7549b3be5a6e71a024","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # TODO(haleyb): this can go away after a cycle or two"},{"line_number":402,"context_line":"            if not self._stale_fips_checked:"},{"line_number":403,"context_line":"                stale_cidrs \u003d ("},{"line_number":404,"context_line":"                    ip for ip in router_info.RouterInfo.get_router_cidrs("},{"line_number":405,"context_line":"                        ri, device)"},{"line_number":406,"context_line":"                    if common_utils.is_cidr_host(ip))"},{"line_number":407,"context_line":"                for ip_cidr in stale_cidrs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_509eda07","line":404,"in_reply_to":"dfeb2761_507dba6c","updated":"2017-03-30 19:54:54.000000000","message":"The ri.get_router_cidrs() call on L398 is actually calling the over-ridden one in the DvrLocalRouter class that is counting routing rules.  We want to call the one in the RouterInfo class which looks for IP addresses.  Right? :)","commit_id":"f84ce9a57ceaf6f931ca51e028bac64c93835d91"},{"author":{"_account_id":21907,"name":"Arjun Baindur","email":"xagent@gmail.com","username":"arjunbaindur"},"change_message_id":"97a24816a1fe5f2a9b745617c02f243e53073ce8","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            # TODO(haleyb): this can go away after a cycle or two"},{"line_number":402,"context_line":"            if not self._stale_fips_checked:"},{"line_number":403,"context_line":"                stale_cidrs \u003d ("},{"line_number":404,"context_line":"                    ip for ip in router_info.RouterInfo.get_router_cidrs("},{"line_number":405,"context_line":"                        ri, device)"},{"line_number":406,"context_line":"                    if common_utils.is_cidr_host(ip))"},{"line_number":407,"context_line":"                for ip_cidr in stale_cidrs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_99f4865d","line":404,"in_reply_to":"dfeb2761_509eda07","updated":"2017-03-31 00:46:15.000000000","message":"Done","commit_id":"f84ce9a57ceaf6f931ca51e028bac64c93835d91"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0a3c1e467bada0491701b5735687fc666be249ec","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                    ip for ip in router_info.RouterInfo.get_router_cidrs("},{"line_number":405,"context_line":"                        ri, device)"},{"line_number":406,"context_line":"                    if common_utils.is_cidr_host(ip))"},{"line_number":407,"context_line":"                for ip_cidr in stale_cidrs:"},{"line_number":408,"context_line":"                    LOG.debug(\"Removing stale floating ip %s from interface \""},{"line_number":409,"context_line":"                              \"%s in namespace %s\","},{"line_number":410,"context_line":"                              ip_cidr, rtr_2_fip_interface, ri.ns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_af2db847","line":407,"range":{"start_line":407,"start_character":31,"end_line":407,"end_character":42},"updated":"2017-03-31 02:06:13.000000000","message":"very small nit : this variable may not be required ...","commit_id":"f84ce9a57ceaf6f931ca51e028bac64c93835d91"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15c9f767e463c9f55830a8d81d5d27de63413cea","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                    ip for ip in router_info.RouterInfo.get_router_cidrs("},{"line_number":405,"context_line":"                        ri, device)"},{"line_number":406,"context_line":"                    if common_utils.is_cidr_host(ip))"},{"line_number":407,"context_line":"                for ip_cidr in stale_cidrs:"},{"line_number":408,"context_line":"                    LOG.debug(\"Removing stale floating ip %s from interface \""},{"line_number":409,"context_line":"                              \"%s in namespace %s\","},{"line_number":410,"context_line":"                              ip_cidr, rtr_2_fip_interface, ri.ns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_77e414ad","line":407,"range":{"start_line":407,"start_character":31,"end_line":407,"end_character":42},"in_reply_to":"dfeb2761_af2db847","updated":"2017-03-31 15:24:13.000000000","message":"I don\u0027t understand.  I realize there\u0027s more than one way to do this, but I pretty much copied this from process_floating_ip_addresses() since that was similar code.","commit_id":"f84ce9a57ceaf6f931ca51e028bac64c93835d91"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0a3c1e467bada0491701b5735687fc666be249ec","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                        ri, device)"},{"line_number":406,"context_line":"                    if common_utils.is_cidr_host(ip))"},{"line_number":407,"context_line":"                for ip_cidr in stale_cidrs:"},{"line_number":408,"context_line":"                    LOG.debug(\"Removing stale floating ip %s from interface \""},{"line_number":409,"context_line":"                              \"%s in namespace %s\","},{"line_number":410,"context_line":"                              ip_cidr, rtr_2_fip_interface, ri.ns_name)"},{"line_number":411,"context_line":"                    device.delete_addr_and_conntrack_state(ip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_afbb78e3","line":408,"range":{"start_line":408,"start_character":24,"end_line":408,"end_character":29},"updated":"2017-03-31 02:06:13.000000000","message":"Should this be Debug?","commit_id":"f84ce9a57ceaf6f931ca51e028bac64c93835d91"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"15c9f767e463c9f55830a8d81d5d27de63413cea","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                        ri, device)"},{"line_number":406,"context_line":"                    if common_utils.is_cidr_host(ip))"},{"line_number":407,"context_line":"                for ip_cidr in stale_cidrs:"},{"line_number":408,"context_line":"                    LOG.debug(\"Removing stale floating ip %s from interface \""},{"line_number":409,"context_line":"                              \"%s in namespace %s\","},{"line_number":410,"context_line":"                              ip_cidr, rtr_2_fip_interface, ri.ns_name)"},{"line_number":411,"context_line":"                    device.delete_addr_and_conntrack_state(ip_cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_77fd3439","line":408,"range":{"start_line":408,"start_character":24,"end_line":408,"end_character":29},"in_reply_to":"dfeb2761_afbb78e3","updated":"2017-03-31 15:24:13.000000000","message":"It could be either debug or warning.  Again, where I copied this from used debug so it seemed appropriate to keep it.","commit_id":"f84ce9a57ceaf6f931ca51e028bac64c93835d91"}]}
