)]}'
{"neutron/agent/linux/utils.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9d17b382df039018b8967233d6cb64dfcd427b3c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return client.execute(cmd, process_input)"},{"line_number":112,"context_line":"    except Exception:"},{"line_number":113,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Rootwrap error running command: %s\"), cmd)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def execute(cmd, process_input\u003dNone, addl_env\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_15bd70d7","line":114,"range":{"start_line":114,"start_character":22,"end_line":114,"end_character":25},"updated":"2017-04-07 20:33:06.000000000","message":"My understanding is that, as of Pike, we don\u0027t translate log messages anymore: https://docs.openstack.org/developer/oslo.i18n/guidelines.html#log-translation","commit_id":"0476ad641dffb4cdcb6fb72e9dd6579ffc21b754"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"014efe6b4dd59958bb97d8b196372a85bb4b6102","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return client.execute(cmd, process_input)"},{"line_number":112,"context_line":"    except Exception:"},{"line_number":113,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Rootwrap error running command: %s\"), cmd)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def execute(cmd, process_input\u003dNone, addl_env\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_b5036473","line":114,"range":{"start_line":114,"start_character":22,"end_line":114,"end_character":25},"in_reply_to":"bff0334d_15bd70d7","updated":"2017-04-07 20:39:11.000000000","message":"We don\u0027t enforce it anymore, yes: https://review.openstack.org/#/c/453211/\n\nThough I am not sure if we want to enforce that at this point. There should be a more broad cleanup effort (with proper hacking enforcement) to make it complete.","commit_id":"0476ad641dffb4cdcb6fb72e9dd6579ffc21b754"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d7e3d2b2833eaec64290a111fdc9d06a7eda7ca7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        return client.execute(cmd, process_input)"},{"line_number":112,"context_line":"    except Exception:"},{"line_number":113,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Rootwrap error running command: %s\"), cmd)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"def execute(cmd, process_input\u003dNone, addl_env\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_157a10f0","line":114,"range":{"start_line":114,"start_character":22,"end_line":114,"end_character":25},"in_reply_to":"bff0334d_b5036473","updated":"2017-04-07 20:42:52.000000000","message":"Fair enough. I\u0027ll approve this patchset","commit_id":"0476ad641dffb4cdcb6fb72e9dd6579ffc21b754"}],"neutron/tests/unit/agent/linux/test_utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1c61dc7a939a033fddb08e53811b101d8543fa8c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(result, expected)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_with_helper_exception(self):"},{"line_number":62,"context_line":"        client_cls_p \u003d mock.patch(\u0027oslo_rootwrap.client.Client\u0027)"},{"line_number":63,"context_line":"        client_cls \u003d client_cls_p.start()"},{"line_number":64,"context_line":"        client_inst \u003d mock.Mock()"},{"line_number":65,"context_line":"        client_inst.execute.side_effect \u003d RuntimeError"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_08a9b98e","line":62,"updated":"2017-04-04 19:50:02.000000000","message":"This seems to be causing the test failure, need to tweak a little.","commit_id":"854d1c11ce4d582ebaef39a3d96ec1fc7145516e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c53fc63663a59e6302ff5c3b9298227180fd7cc3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        with mock.patch.object(utils, \u0027LOG\u0027) as log:"},{"line_number":68,"context_line":"            self.assertRaises(RuntimeError, utils.execute,"},{"line_number":69,"context_line":"                              [\u0027ls\u0027], run_as_root\u003dTrue)"},{"line_number":70,"context_line":"            self.assertTrue(log.error.called)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_stderr_true(self):"},{"line_number":73,"context_line":"        expected \u003d \"%s\\n\" % self.test_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_3132d311","line":70,"updated":"2017-04-07 15:33:59.000000000","message":"that check is a bit shaky in that it doesn\u0027t validate usefulness of the information. ;)","commit_id":"0476ad641dffb4cdcb6fb72e9dd6579ffc21b754"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d279952fb0ffc2ae6fdbf5ee7c92496ab5f6c8eb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        with mock.patch.object(utils, \u0027LOG\u0027) as log:"},{"line_number":68,"context_line":"            self.assertRaises(RuntimeError, utils.execute,"},{"line_number":69,"context_line":"                              [\u0027ls\u0027], run_as_root\u003dTrue)"},{"line_number":70,"context_line":"            self.assertTrue(log.error.called)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_stderr_true(self):"},{"line_number":73,"context_line":"        expected \u003d \"%s\\n\" % self.test_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_54ef85af","line":70,"in_reply_to":"bff0334d_3132d311","updated":"2017-04-07 15:50:06.000000000","message":"Yeah, I was short on ideas here so just copied the test from L104 basically :)","commit_id":"0476ad641dffb4cdcb6fb72e9dd6579ffc21b754"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b4bd3fb9f091775736aa4c2fc4b6d06a2a74f912","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        with mock.patch.object(utils, \u0027LOG\u0027) as log:"},{"line_number":68,"context_line":"            self.assertRaises(RuntimeError, utils.execute,"},{"line_number":69,"context_line":"                              [\u0027ls\u0027], run_as_root\u003dTrue)"},{"line_number":70,"context_line":"            self.assertTrue(log.error.called)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_stderr_true(self):"},{"line_number":73,"context_line":"        expected \u003d \"%s\\n\" % self.test_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_0f9a0a62","line":70,"in_reply_to":"bff0334d_54ef85af","updated":"2017-04-07 16:07:53.000000000","message":"or we can assert on argument or message passed if that has command info ?","commit_id":"0476ad641dffb4cdcb6fb72e9dd6579ffc21b754"}]}
