)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"896e3986d118b1a3f0b1602e675ec43ed23efc5c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"not doing a strip vlan action (case of traffic received on local VM ports)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2f608bdd807be65ea07d2a6fc36198f7e9c1b635"},{"line_number":22,"context_line":"Needed-By: I16a35b5d6c54901899d24fc94bd3438c1f1be05e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfeb2761_205ebb75","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":9},"updated":"2017-04-05 11:46:38.000000000","message":"Depends-On here?","commit_id":"98a388f2cce596b4ec53bde30a62986f78948825"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"b1f26af97f23bb3aa0e985c10f3fd60d72cc5ce4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"not doing a strip vlan action (case of traffic received on local VM ports)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2f608bdd807be65ea07d2a6fc36198f7e9c1b635"},{"line_number":22,"context_line":"Needed-By: I16a35b5d6c54901899d24fc94bd3438c1f1be05e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfeb2761_203d9bdc","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":9},"in_reply_to":"dfeb2761_205ebb75","updated":"2017-04-05 11:56:27.000000000","message":"This change is really \"needed by\"  I16a35b5d6c54901899d24fc94bd3438c1f1be05e , which is why I added the Needed-By, but since the dependency is inside the same project and already captured by the commit parent relation the Needed-By is useless ; I\u0027ll remove it...","commit_id":"98a388f2cce596b4ec53bde30a62986f78948825"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8395f8cf5d0f5cc419aed582b4e2d713c80f8317","unresolved":false,"context_lines":[{"line_number":576,"context_line":"            )"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def _initialize_ingress(self, port):"},{"line_number":579,"context_line":"        # table to strip VLAN tag, if there is any"},{"line_number":580,"context_line":"        #"},{"line_number":581,"context_line":"        # traffic from other bridges via patch ports:"},{"line_number":582,"context_line":"        self._add_flow("}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_5156ba2b","line":579,"updated":"2017-04-06 09:24:33.000000000","message":"This deserves its own method, like _initialize_ingress_strip_vlan()","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"40f1feb03bfc181221b4907fd21062984e5e0872","unresolved":false,"context_lines":[{"line_number":576,"context_line":"            )"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def _initialize_ingress(self, port):"},{"line_number":579,"context_line":"        # table to strip VLAN tag, if there is any"},{"line_number":580,"context_line":"        #"},{"line_number":581,"context_line":"        # traffic from other bridges via patch ports:"},{"line_number":582,"context_line":"        self._add_flow("}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_4654bfca","line":579,"in_reply_to":"bff0334d_5156ba2b","updated":"2017-04-06 09:28:38.000000000","message":"Ok, will do.","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8395f8cf5d0f5cc419aed582b4e2d713c80f8317","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        # table to strip VLAN tag, if there is any"},{"line_number":580,"context_line":"        #"},{"line_number":581,"context_line":"        # traffic from other bridges via patch ports:"},{"line_number":582,"context_line":"        self._add_flow("},{"line_number":583,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":584,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":585,"context_line":"            dl_vlan\u003dport.vlan_tag,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_311a167d","line":582,"updated":"2017-04-06 09:24:33.000000000","message":"Should we go with some default priority? Let\u0027s say 100?","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4df7392f101dd2b2b0b2cae38c7524df506226ec","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        # table to strip VLAN tag, if there is any"},{"line_number":580,"context_line":"        #"},{"line_number":581,"context_line":"        # traffic from other bridges via patch ports:"},{"line_number":582,"context_line":"        self._add_flow("},{"line_number":583,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":584,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":585,"context_line":"            dl_vlan\u003dport.vlan_tag,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_46f39f9f","line":582,"in_reply_to":"bff0334d_06d2375d","updated":"2017-04-06 09:37:29.000000000","message":"In case we want to add a rule with lower priority. Maybe it\u0027s a YAGNI.","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"40f1feb03bfc181221b4907fd21062984e5e0872","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        # table to strip VLAN tag, if there is any"},{"line_number":580,"context_line":"        #"},{"line_number":581,"context_line":"        # traffic from other bridges via patch ports:"},{"line_number":582,"context_line":"        self._add_flow("},{"line_number":583,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":584,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":585,"context_line":"            dl_vlan\u003dport.vlan_tag,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_06d2375d","line":582,"in_reply_to":"bff0334d_311a167d","updated":"2017-04-06 09:28:38.000000000","message":"There aren\u0027t any other flows in this table, so why specify the priority ?","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9f0ee0db143c7b0d047292d3beb2b89c5b10134a","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        # table to strip VLAN tag, if there is any"},{"line_number":580,"context_line":"        #"},{"line_number":581,"context_line":"        # traffic from other bridges via patch ports:"},{"line_number":582,"context_line":"        self._add_flow("},{"line_number":583,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":584,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":585,"context_line":"            dl_vlan\u003dport.vlan_tag,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_d9d67050","line":582,"in_reply_to":"bff0334d_46f39f9f","updated":"2017-04-06 11:43:56.000000000","message":"Yes, I\u0027d say it\u0027s a YAGNI. We can always add a priority the day we need it.","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8395f8cf5d0f5cc419aed582b4e2d713c80f8317","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        self._add_flow("},{"line_number":590,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":591,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":592,"context_line":"            actions\u003d\u0027output:{:d}\u0027.format(port.ofport),"},{"line_number":593,"context_line":"        )"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # Allow incoming ARPs"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_6338d5d2","line":592,"updated":"2017-04-06 09:24:33.000000000","message":"We should make sure that that the packets are not tagged here:\n\n vlan_tci\u003d\u00270/0xefff\u0027","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"9f0ee0db143c7b0d047292d3beb2b89c5b10134a","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        self._add_flow("},{"line_number":590,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":591,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":592,"context_line":"            actions\u003d\u0027output:{:d}\u0027.format(port.ofport),"},{"line_number":593,"context_line":"        )"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # Allow incoming ARPs"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_a818f480","line":592,"in_reply_to":"bff0334d_46483fcb","updated":"2017-04-06 11:43:56.000000000","message":"Adding that provides indeed some safety, but overall it seems that the behavior after this change is not the same as before in the case of a VM sending a tagged packet to another local VM: if my understanding is complete\u0026correct (a risky assumption!), then before this change, such a packet would be subject to a strip_vlan (which does not really make sense, but consistent with the fact vlan transparency is not claimed to be supported by ML2 OVS [1]), and after this change it will not be subject unless the packet tag matches the tag used internally by MLS OVS pipeline for the corresponding Neutron network (which does not make much more sense).\n\nI wonder if we shouldn\u0027t do this strip_vlan only if the in_port is one of the patch ports toward other bridge ?\n\n[1] https://bugs.launchpad.net/neutron/+bug/1604222","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"40f1feb03bfc181221b4907fd21062984e5e0872","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        self._add_flow("},{"line_number":590,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":591,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":592,"context_line":"            actions\u003d\u0027output:{:d}\u0027.format(port.ofport),"},{"line_number":593,"context_line":"        )"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # Allow incoming ARPs"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_e63bd399","line":592,"in_reply_to":"bff0334d_6338d5d2","updated":"2017-04-06 09:28:38.000000000","message":"Tagged packets will match the first, more specific, rule, won\u0027t they ?","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4df7392f101dd2b2b0b2cae38c7524df506226ec","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        self._add_flow("},{"line_number":590,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":591,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":592,"context_line":"            actions\u003d\u0027output:{:d}\u0027.format(port.ofport),"},{"line_number":593,"context_line":"        )"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        # Allow incoming ARPs"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_46483fcb","line":592,"in_reply_to":"bff0334d_e63bd399","updated":"2017-04-06 09:37:29.000000000","message":"They will but what if somehow I get a packet with different dl_vlan than port.ofport here. Isn\u0027t it better to be explicit and safe than sorry?","commit_id":"06a245a681ed77ad586dcc7ec402d9d02483eeaf"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"066811e2a26aab7f740b6d8d3c1e82e4207d879c","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        self._add_flow("},{"line_number":588,"context_line":"            table\u003dovs_consts.INGRESS_STRIP_VLAN_TABLE,"},{"line_number":589,"context_line":"            reg_port\u003dport.ofport,"},{"line_number":590,"context_line":"            vlan_tci\u003d\u00270/0xefff\u0027,"},{"line_number":591,"context_line":"            actions\u003d\u0027output:{:d}\u0027.format(port.ofport),"},{"line_number":592,"context_line":"        )"},{"line_number":593,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_96f08769","line":590,"updated":"2017-04-26 02:35:11.000000000","message":"Shouldn\u0027t this be vlan_tci\u003d0 ?\nOr, do we need to preserve VLAN 0 tag?","commit_id":"3772f18908723020aaa2bed7e1d18306e4f9fc24"}]}