)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"26fed8af3e733cce6a2353d95a3331b0647ef52f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chengqian Liu \u003cxieling1990.happy@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-06 13:09:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"When the address pair is updated, the security group information is also notified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I53b6eb189c7a5a3c54c9f6025d787f98c63e8235"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_bfeb97ae","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":82},"updated":"2017-04-06 05:44:04.000000000","message":"Lets keep this limited to 50 characters ( the heading ) \nand add a body to the commit message as to what is it doing.\n\nAlso mention the bug it closes as\n\nCloses-Bug:#1680305","commit_id":"eb04148a77d854beb1ee709d7d1fa37fe31cc937"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c5f33a1b14ed575c41c13717587b33dd04cb58da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chengqian Liu \u003cxieling1990.happy@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-06 13:09:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"When the address pair is updated, the security group information is also notified."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I53b6eb189c7a5a3c54c9f6025d787f98c63e8235"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_257658a6","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":82},"in_reply_to":"bff0334d_bfeb97ae","updated":"2017-04-06 06:38:12.000000000","message":"Please see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"eb04148a77d854beb1ee709d7d1fa37fe31cc937"}],"neutron/db/securitygroups_rpc_base.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"26fed8af3e733cce6a2353d95a3331b0647ef52f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.notify_security_groups_member_updated_bulk("},{"line_number":101,"context_line":"                context, [original_port, updated_port])"},{"line_number":102,"context_line":"        elif (original_port[\u0027fixed_ips\u0027] !\u003d updated_port[\u0027fixed_ips\u0027] or "},{"line_number":103,"context_line":"                original_port[\u0027allowed_address_pairs\u0027] !\u003d updated_port[\u0027allowed_address_pairs\u0027]):"},{"line_number":104,"context_line":"            self.notify_security_groups_member_updated(context, updated_port)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def is_security_group_member_updated(self, context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_5f480bcb","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":97},"updated":"2017-04-06 05:44:04.000000000","message":"should be limited 79 characters per line","commit_id":"eb04148a77d854beb1ee709d7d1fa37fe31cc937"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c5f33a1b14ed575c41c13717587b33dd04cb58da","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.notify_security_groups_member_updated_bulk("},{"line_number":101,"context_line":"                context, [original_port, updated_port])"},{"line_number":102,"context_line":"        elif (original_port[\u0027fixed_ips\u0027] !\u003d updated_port[\u0027fixed_ips\u0027] or "},{"line_number":103,"context_line":"                original_port[\u0027allowed_address_pairs\u0027] !\u003d updated_port[\u0027allowed_address_pairs\u0027]):"},{"line_number":104,"context_line":"            self.notify_security_groups_member_updated(context, updated_port)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def is_security_group_member_updated(self, context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_856644ed","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":97},"in_reply_to":"bff0334d_5f480bcb","updated":"2017-04-06 06:38:12.000000000","message":"can you please add a unit test for this if possible","commit_id":"eb04148a77d854beb1ee709d7d1fa37fe31cc937"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79d058d88afeb9372beac071cf2393255153172f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"DHCP_RULE_PORT \u003d {4: (67, 68, const.IPv4), 6: (547, 546, const.IPv6)}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ADD_PAIRS \u003d \u0027allowed_address_pairs\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class SecurityGroupServerRpcMixin(sg_db.SecurityGroupDbMixin):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_29181673","line":37,"updated":"2017-04-26 17:51:51.000000000","message":"If you need a shortcut, use ADDRESS_PAIRS defined in neutron.extensions.allowedaddresspairs","commit_id":"c2826a378e474ba1440425549a24887833cce3d4"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3bc968de6a9918e4e8a7a8994cd25f00b0af08cb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            self.notify_security_groups_member_updated_bulk("},{"line_number":103,"context_line":"                context, [original_port, updated_port])"},{"line_number":104,"context_line":"        elif (original_port[\u0027fixed_ips\u0027] !\u003d updated_port[\u0027fixed_ips\u0027] or"},{"line_number":105,"context_line":"                original_port[ADD_PAIRS] !\u003d updated_port[ADD_PAIRS]):"},{"line_number":106,"context_line":"            self.notify_security_groups_member_updated(context, updated_port)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def is_security_group_member_updated(self, context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_735c1b4b","line":105,"updated":"2017-04-17 07:02:25.000000000","message":"as i commented in the bug, i\u0027m not sure if SG should be aware of allowd address pairs in the first place.","commit_id":"c2826a378e474ba1440425549a24887833cce3d4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79d058d88afeb9372beac071cf2393255153172f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            self.notify_security_groups_member_updated_bulk("},{"line_number":103,"context_line":"                context, [original_port, updated_port])"},{"line_number":104,"context_line":"        elif (original_port[\u0027fixed_ips\u0027] !\u003d updated_port[\u0027fixed_ips\u0027] or"},{"line_number":105,"context_line":"                original_port[ADD_PAIRS] !\u003d updated_port[ADD_PAIRS]):"},{"line_number":106,"context_line":"            self.notify_security_groups_member_updated(context, updated_port)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def is_security_group_member_updated(self, context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_295ff60e","line":105,"in_reply_to":"7ffa3b31_735c1b4b","updated":"2017-04-26 17:51:51.000000000","message":"As I commented in the bug, I believe we should include allowed_address_pairs to SG remote groups. At least, we haven\u0027t made an explicit change in this several releases.","commit_id":"c2826a378e474ba1440425549a24887833cce3d4"}],"neutron/tests/unit/db/test_allowedaddresspairs_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"918efd8e37cdf3e52f9e8e4b7613b297d465cf64","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                res \u003d req.get_response(self.api)"},{"line_number":264,"context_line":"                self.assertEqual(400, res.status_int)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def test_update_port_add_address_pairs_changed(self):"},{"line_number":267,"context_line":"            with self.network() as net:"},{"line_number":268,"context_line":"                address_pairs \u003d [{\u0027mac_address\u0027: \u002700:00:00:00:00:01\u0027,"},{"line_number":269,"context_line":"                                  \u0027ip_address\u0027: \u002710.0.0.1\u0027}]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_7873dae8","line":266,"updated":"2017-04-17 06:12:27.000000000","message":"don\u0027t add anything to this file because not all of these are run with the security groups notifier and you aren\u0027t actually asserting a notification here. Add a test to the original file I suggested that explicitly just calls check_and_notify_security_group_member_changed","commit_id":"c2826a378e474ba1440425549a24887833cce3d4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79d058d88afeb9372beac071cf2393255153172f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                res \u003d req.get_response(self.api)"},{"line_number":264,"context_line":"                self.assertEqual(400, res.status_int)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def test_update_port_add_address_pairs_changed(self):"},{"line_number":267,"context_line":"            with self.network() as net:"},{"line_number":268,"context_line":"                address_pairs \u003d [{\u0027mac_address\u0027: \u002700:00:00:00:00:01\u0027,"},{"line_number":269,"context_line":"                                  \u0027ip_address\u0027: \u002710.0.0.1\u0027}]"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_bced8b8c","line":266,"in_reply_to":"7ffa3b31_7873dae8","updated":"2017-04-26 17:51:51.000000000","message":"+1","commit_id":"c2826a378e474ba1440425549a24887833cce3d4"}]}
