)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"12fc73201977c29eccb345114917246aac85a52a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2013-09-06 17:08:00 +0800"},{"line_number":4,"context_line":"Commit:     Jian Wen \u003cjian.wen@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-09 11:21:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test_handle_router_snat_rules_add_rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a unit test to verify that snat rules are added and added in order."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAASn%2F%2FQqE%3D","line":6,"updated":"2013-09-09 04:11:09.000000000","message":"Every commit message should include either the BP or Bug_ID associate with it.","commit_id":"cf0d21f8f10e0cd490ac027c01a88ad532414108"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"9b0e7d78bd053873601540684c626bd21d1c384c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2013-09-06 17:08:00 +0800"},{"line_number":4,"context_line":"Commit:     Jian Wen \u003cjian.wen@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-09 11:21:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test_handle_router_snat_rules_add_rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a unit test to verify that snat rules are added and added in order."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAASn%2F%2FQew%3D","line":6,"in_reply_to":"AAAASn%2F%2FQqE%3D","updated":"2013-09-09 06:28:49.000000000","message":"Done","commit_id":"cf0d21f8f10e0cd490ac027c01a88ad532414108"}],"neutron/tests/unit/test_l3_agent.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4867b5f29f0cb4a232485788b967519ead9c1417","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            wrap_name, internal_cidrs[0],"},{"line_number":533,"context_line":"            ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        self.assertTrue(jump_float_snat_rule in nat_rules)"},{"line_number":536,"context_line":"        self.assertTrue(snat_rule in nat_rules)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        for i in range(len(ri.iptables_manager.ipv4[\u0027nat\u0027].rules)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FUxs%3D","line":535,"updated":"2013-09-06 10:29:53.000000000","message":"assertIn","commit_id":"82b73d55d88b19dd8e8054dfa353298670c5503c"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"559db5e1f06978ac33ece3fba850bae1d96a323e","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            wrap_name, internal_cidrs[0],"},{"line_number":533,"context_line":"            ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        self.assertTrue(jump_float_snat_rule in nat_rules)"},{"line_number":536,"context_line":"        self.assertTrue(snat_rule in nat_rules)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        for i in range(len(ri.iptables_manager.ipv4[\u0027nat\u0027].rules)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FQtg%3D","line":535,"in_reply_to":"AAAASn%2F%2FUxs%3D","updated":"2013-09-09 03:22:50.000000000","message":"Done","commit_id":"82b73d55d88b19dd8e8054dfa353298670c5503c"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4867b5f29f0cb4a232485788b967519ead9c1417","unresolved":false,"context_lines":[{"line_number":533,"context_line":"            ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        self.assertTrue(jump_float_snat_rule in nat_rules)"},{"line_number":536,"context_line":"        self.assertTrue(snat_rule in nat_rules)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        for i in range(len(ri.iptables_manager.ipv4[\u0027nat\u0027].rules)):"},{"line_number":539,"context_line":"            if nat_rules[i] \u003d\u003d jump_float_snat_rule:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FUxk%3D","line":536,"updated":"2013-09-06 10:29:53.000000000","message":"same","commit_id":"82b73d55d88b19dd8e8054dfa353298670c5503c"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"559db5e1f06978ac33ece3fba850bae1d96a323e","unresolved":false,"context_lines":[{"line_number":533,"context_line":"            ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        self.assertTrue(jump_float_snat_rule in nat_rules)"},{"line_number":536,"context_line":"        self.assertTrue(snat_rule in nat_rules)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        for i in range(len(ri.iptables_manager.ipv4[\u0027nat\u0027].rules)):"},{"line_number":539,"context_line":"            if nat_rules[i] \u003d\u003d jump_float_snat_rule:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FQtc%3D","line":536,"in_reply_to":"AAAASn%2F%2FUxk%3D","updated":"2013-09-09 03:22:50.000000000","message":"Done","commit_id":"82b73d55d88b19dd8e8054dfa353298670c5503c"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4867b5f29f0cb4a232485788b967519ead9c1417","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            if nat_rules[i] \u003d\u003d snat_rule:"},{"line_number":542,"context_line":"                snat_rule_index \u003d i"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        self.assertTrue(jump_float_snat_rule_index \u003c snat_rule_index)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def testRoutersWithAdminStateDown(self):"},{"line_number":547,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FUxg%3D","line":544,"updated":"2013-09-06 10:29:53.000000000","message":"assertLess","commit_id":"82b73d55d88b19dd8e8054dfa353298670c5503c"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"559db5e1f06978ac33ece3fba850bae1d96a323e","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            if nat_rules[i] \u003d\u003d snat_rule:"},{"line_number":542,"context_line":"                snat_rule_index \u003d i"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        self.assertTrue(jump_float_snat_rule_index \u003c snat_rule_index)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def testRoutersWithAdminStateDown(self):"},{"line_number":547,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FQtY%3D","line":544,"in_reply_to":"AAAASn%2F%2FUxg%3D","updated":"2013-09-09 03:22:50.000000000","message":"There is no assertLess in py26","commit_id":"82b73d55d88b19dd8e8054dfa353298670c5503c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"effb1d9195ba9f7ff1b32b9e880ab5c7878e81b7","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    def test_handle_router_snat_rules_add_rules(self):"},{"line_number":517,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":518,"context_line":"        id \u003d _uuid()"},{"line_number":519,"context_line":"        ri \u003d l3_agent.RouterInfo(id, self.conf.root_helper,"},{"line_number":520,"context_line":"                                 self.conf.use_namespaces, None)"},{"line_number":521,"context_line":"        ex_gw_port \u003d {\u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u0027192.168.1.4\u0027}]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2Fww4%3D","line":518,"updated":"2013-09-19 18:58:30.000000000","message":"This is aliasing a python function here.  Just use _uuid() directly in 519.","commit_id":"550316573761fcabd3920e293d65dfb79b4a9648"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"283cc0763f4ea3a56b416639c360cc6e64c486ff","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    def test_handle_router_snat_rules_add_rules(self):"},{"line_number":517,"context_line":"        agent \u003d l3_agent.L3NATAgent(HOSTNAME, self.conf)"},{"line_number":518,"context_line":"        id \u003d _uuid()"},{"line_number":519,"context_line":"        ri \u003d l3_agent.RouterInfo(id, self.conf.root_helper,"},{"line_number":520,"context_line":"                                 self.conf.use_namespaces, None)"},{"line_number":521,"context_line":"        ex_gw_port \u003d {\u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u0027192.168.1.4\u0027}]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2Fr9Q%3D","line":518,"in_reply_to":"AAAAS3%2F%2Fww4%3D","updated":"2013-09-22 02:41:26.000000000","message":"Done","commit_id":"550316573761fcabd3920e293d65dfb79b4a9648"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"effb1d9195ba9f7ff1b32b9e880ab5c7878e81b7","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        agent._handle_router_snat_rules(ri, ex_gw_port, internal_cidrs,"},{"line_number":524,"context_line":"                                        \"iface\", \"add_rules\")"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        nat_rules \u003d map(str, ri.iptables_manager.ipv4[\u0027nat\u0027].rules)"},{"line_number":527,"context_line":"        wrap_name \u003d ri.iptables_manager.wrap_name"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        jump_float_rule \u003d \"-A %s-snat -j %s-float-snat\" % (wrap_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2Fwx4%3D","line":526,"updated":"2013-09-19 18:58:30.000000000","message":"You should use a list comprehension here:\n\nnat_rules \u003d [str(r) for r in ri.iptables_manager.ipv4[\u0027nat\u0027].rules]","commit_id":"550316573761fcabd3920e293d65dfb79b4a9648"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"283cc0763f4ea3a56b416639c360cc6e64c486ff","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        agent._handle_router_snat_rules(ri, ex_gw_port, internal_cidrs,"},{"line_number":524,"context_line":"                                        \"iface\", \"add_rules\")"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        nat_rules \u003d map(str, ri.iptables_manager.ipv4[\u0027nat\u0027].rules)"},{"line_number":527,"context_line":"        wrap_name \u003d ri.iptables_manager.wrap_name"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        jump_float_rule \u003d \"-A %s-snat -j %s-float-snat\" % (wrap_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2Fr8w%3D","line":526,"in_reply_to":"AAAAS3%2F%2Fwx4%3D","updated":"2013-09-22 02:41:26.000000000","message":"I don\u0027t think so. The result of map()  is always a list.  http://docs.python.org/2/library/functions.html#map","commit_id":"550316573761fcabd3920e293d65dfb79b4a9648"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"effb1d9195ba9f7ff1b32b9e880ab5c7878e81b7","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        self.assertIn(jump_float_rule, nat_rules)"},{"line_number":537,"context_line":"        self.assertIn(internal_net_rule, nat_rules)"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        for i in range(len(ri.iptables_manager.ipv4[\u0027nat\u0027].rules)):"},{"line_number":540,"context_line":"            if nat_rules[i] \u003d\u003d jump_float_rule:"},{"line_number":541,"context_line":"                jump_float_rule_index \u003d i"},{"line_number":542,"context_line":"            if nat_rules[i] \u003d\u003d internal_net_rule:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2FwxU%3D","line":539,"updated":"2013-09-19 18:58:30.000000000","message":"539-545 can simplified:\n\nself.assertLessThan(\n    nat_rules.index(jump_float_rule),\n    nat_rules.index(internal_net_rule)\n)","commit_id":"550316573761fcabd3920e293d65dfb79b4a9648"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"283cc0763f4ea3a56b416639c360cc6e64c486ff","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        self.assertIn(jump_float_rule, nat_rules)"},{"line_number":537,"context_line":"        self.assertIn(internal_net_rule, nat_rules)"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        for i in range(len(ri.iptables_manager.ipv4[\u0027nat\u0027].rules)):"},{"line_number":540,"context_line":"            if nat_rules[i] \u003d\u003d jump_float_rule:"},{"line_number":541,"context_line":"                jump_float_rule_index \u003d i"},{"line_number":542,"context_line":"            if nat_rules[i] \u003d\u003d internal_net_rule:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2Fr8U%3D","line":539,"in_reply_to":"AAAAS3%2F%2FwxU%3D","updated":"2013-09-22 02:41:26.000000000","message":"There is no assertLessThan in testtools. assertLess is not in py26. So I use assertTrue for the moment.","commit_id":"550316573761fcabd3920e293d65dfb79b4a9648"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"c466065694862d4b9059a2e79155cf269cbc2d18","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        self.assertIn(jump_float_rule, nat_rules)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        self.assertIn(internal_net_rule, nat_rules)"},{"line_number":538,"context_line":"        self.assertTrue(nat_rules.index(jump_float_rule) \u003c"},{"line_number":539,"context_line":"                        nat_rules.index(internal_net_rule))"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def test_routers_with_admin_state_down(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Bh%2Bo%3D","line":538,"updated":"2013-11-25 02:29:43.000000000","message":"self.assertLess()","commit_id":"f264d61764b209867d9175d1e079afd318a3581f"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"937b364b5f1c776121b7d5c46f39b5d47524ee98","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        self.assertIn(jump_float_rule, nat_rules)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        self.assertIn(internal_net_rule, nat_rules)"},{"line_number":538,"context_line":"        self.assertTrue(nat_rules.index(jump_float_rule) \u003c"},{"line_number":539,"context_line":"                        nat_rules.index(internal_net_rule))"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def test_routers_with_admin_state_down(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BVxo%3D","line":538,"in_reply_to":"AAAATn%2F%2BfW4%3D","updated":"2013-11-27 06:58:02.000000000","message":"Done. After reading some code of testtool, I found it is powerful. Thanks.","commit_id":"f264d61764b209867d9175d1e079afd318a3581f"},{"author":{"_account_id":1970,"name":"Jacob Wen","email":"wenjianhn@gmail.com","username":"wenjianhn"},"change_message_id":"3f43259fd791aecf1f066ff257d716332a6aa1d0","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        self.assertIn(jump_float_rule, nat_rules)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        self.assertIn(internal_net_rule, nat_rules)"},{"line_number":538,"context_line":"        self.assertTrue(nat_rules.index(jump_float_rule) \u003c"},{"line_number":539,"context_line":"                        nat_rules.index(internal_net_rule))"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def test_routers_with_admin_state_down(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2Bh6U%3D","line":538,"in_reply_to":"AAAATn%2F%2Bh%2Bo%3D","updated":"2013-11-25 02:49:59.000000000","message":"I remember that assertLess was not in gate-neutron-python26.","commit_id":"f264d61764b209867d9175d1e079afd318a3581f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"70debaee0956a5cc1288b2b5c401cdd3fecaa21e","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        self.assertIn(jump_float_rule, nat_rules)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        self.assertIn(internal_net_rule, nat_rules)"},{"line_number":538,"context_line":"        self.assertTrue(nat_rules.index(jump_float_rule) \u003c"},{"line_number":539,"context_line":"                        nat_rules.index(internal_net_rule))"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    def test_routers_with_admin_state_down(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BfW4%3D","line":538,"in_reply_to":"AAAATn%2F%2Bh6U%3D","updated":"2013-11-25 15:12:25.000000000","message":"Ah right. I forgot that testtools does not provide a complete backport of 2.7 unittest additions (We used to use unittest2 which does provide a 2.6 compatibility).  Please use the testtools form:\n\nself.assertThat(\n    nat_rules.index(jump_float_rule),\n    matchers.LessThan(nat_rules.index(internal_net_rule))","commit_id":"f264d61764b209867d9175d1e079afd318a3581f"}]}
