)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7d478144f862930ab6e2d1cb8f70c8f314e552cb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A lot of clouds using the router service plugin don\u0027t configure for DVR,"},{"line_number":10,"context_line":"but the service plugin still loads the extension, and exposes it via"},{"line_number":11,"context_line":"API. Which will break if users attempt to create new style routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change introduces a new config option that allows to avoid loading"},{"line_number":14,"context_line":"the extension. For complatibility sake, it requires an opt-in from ops"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_e8cf157d","line":11,"updated":"2017-04-06 14:10:41.000000000","message":"the distributed flag is admin-only though isn\u0027t it?","commit_id":"29c7b628bbd863ef19ead8afc81d2c4e8e879bee"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eaa765b6d03b7b11ba66af8dea4287d9ab629ac8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A lot of clouds using the router service plugin don\u0027t configure for DVR,"},{"line_number":10,"context_line":"but the service plugin still loads the extension, and exposes it via"},{"line_number":11,"context_line":"API. Which will break if users attempt to create new style routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change introduces a new config option that allows to avoid loading"},{"line_number":14,"context_line":"the extension. For complatibility sake, it requires an opt-in from ops"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_5ae11c9a","line":11,"in_reply_to":"bff0334d_2884dd0b","updated":"2017-04-06 17:52:42.000000000","message":"Reworded.","commit_id":"29c7b628bbd863ef19ead8afc81d2c4e8e879bee"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5f1cf47ae799fc0f61fbeaa9049d79a89cb874e2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A lot of clouds using the router service plugin don\u0027t configure for DVR,"},{"line_number":10,"context_line":"but the service plugin still loads the extension, and exposes it via"},{"line_number":11,"context_line":"API. Which will break if users attempt to create new style routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change introduces a new config option that allows to avoid loading"},{"line_number":14,"context_line":"the extension. For complatibility sake, it requires an opt-in from ops"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bff0334d_2884dd0b","line":11,"in_reply_to":"bff0334d_e8cf157d","updated":"2017-04-06 14:11:46.000000000","message":"Honestly, the main concern here is that you can\u0027t feed result of ext-list into tempest.conf.","commit_id":"29c7b628bbd863ef19ead8afc81d2c4e8e879bee"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67c009fd6810ae26593d31c6c21b75558b314130","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027enable_dvr\u0027,"},{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d_(\"Determine if setup is configured for DVR. If False, \""},{"line_number":55,"context_line":"                       \"dvr API extension will be disabled.\")),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":"cfg.CONF.register_opts(router_distributed_opts)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_eeddaf70","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":27},"updated":"2017-04-07 13:47:26.000000000","message":"nit: DVR, although the extension alias is \u0027dvr\u0027","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"24ca3059868351ed62b30cb3e7c3de83779f1366","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.BoolOpt(\u0027enable_dvr\u0027,"},{"line_number":53,"context_line":"                default\u003dTrue,"},{"line_number":54,"context_line":"                help\u003d_(\"Determine if setup is configured for DVR. If False, \""},{"line_number":55,"context_line":"                       \"dvr API extension will be disabled.\")),"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":"cfg.CONF.register_opts(router_distributed_opts)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff52f3f_650a428b","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":27},"in_reply_to":"bff0334d_eeddaf70","updated":"2017-04-12 23:19:31.000000000","message":"Done","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"}],"neutron/services/l3_router/l3_router_plugin.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67c009fd6810ae26593d31c6c21b75558b314130","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def disable_dvr_extension_by_config(aliases):"},{"line_number":48,"context_line":"    if not cfg.CONF.enable_dvr:"},{"line_number":49,"context_line":"        LOG.info(_LI(\u0027Disabled dvr extension.\u0027))"},{"line_number":50,"context_line":"        if \u0027dvr\u0027 in aliases:"},{"line_number":51,"context_line":"            aliases.remove(\u0027dvr\u0027)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_0e457317","line":49,"range":{"start_line":49,"start_character":31,"end_line":49,"end_character":34},"updated":"2017-04-07 13:47:26.000000000","message":"nit: DVR, although the extension alias is \u0027dvr\u0027","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"24ca3059868351ed62b30cb3e7c3de83779f1366","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def disable_dvr_extension_by_config(aliases):"},{"line_number":48,"context_line":"    if not cfg.CONF.enable_dvr:"},{"line_number":49,"context_line":"        LOG.info(_LI(\u0027Disabled dvr extension.\u0027))"},{"line_number":50,"context_line":"        if \u0027dvr\u0027 in aliases:"},{"line_number":51,"context_line":"            aliases.remove(\u0027dvr\u0027)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ff52f3f_05f9367f","line":49,"range":{"start_line":49,"start_character":31,"end_line":49,"end_character":34},"in_reply_to":"bff0334d_0e457317","updated":"2017-04-12 23:19:31.000000000","message":"Done","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"}],"releasenotes/notes/add-enable-dvr-knob-636268f775bb4569.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67c009fd6810ae26593d31c6c21b75558b314130","unresolved":false,"context_lines":[{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Consider setting ``enable_dvr`` to ``False`` in ``neutron.conf`` file if"},{"line_number":10,"context_line":"    your setup doesn\u0027t support DVR. This will make Neutron to stop advertising"},{"line_number":11,"context_line":"    support for ``dvr`` API extension via its ``/v2.0/extensions`` API"},{"line_number":12,"context_line":"    endpoint."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_6e063fd1","line":10,"range":{"start_line":10,"start_character":59,"end_line":10,"end_character":61},"updated":"2017-04-07 13:47:26.000000000","message":"d/to","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"24ca3059868351ed62b30cb3e7c3de83779f1366","unresolved":false,"context_lines":[{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Consider setting ``enable_dvr`` to ``False`` in ``neutron.conf`` file if"},{"line_number":10,"context_line":"    your setup doesn\u0027t support DVR. This will make Neutron to stop advertising"},{"line_number":11,"context_line":"    support for ``dvr`` API extension via its ``/v2.0/extensions`` API"},{"line_number":12,"context_line":"    endpoint."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ff52f3f_852ae6e4","line":10,"range":{"start_line":10,"start_character":59,"end_line":10,"end_character":61},"in_reply_to":"bff0334d_6e063fd1","updated":"2017-04-12 23:19:31.000000000","message":"Done","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"67c009fd6810ae26593d31c6c21b75558b314130","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Consider setting ``enable_dvr`` to ``False`` in ``neutron.conf`` file if"},{"line_number":10,"context_line":"    your setup doesn\u0027t support DVR. This will make Neutron to stop advertising"},{"line_number":11,"context_line":"    support for ``dvr`` API extension via its ``/v2.0/extensions`` API"},{"line_number":12,"context_line":"    endpoint."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_0e13330f","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":15},"updated":"2017-04-07 13:47:26.000000000","message":"s/for the","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"24ca3059868351ed62b30cb3e7c3de83779f1366","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Consider setting ``enable_dvr`` to ``False`` in ``neutron.conf`` file if"},{"line_number":10,"context_line":"    your setup doesn\u0027t support DVR. This will make Neutron to stop advertising"},{"line_number":11,"context_line":"    support for ``dvr`` API extension via its ``/v2.0/extensions`` API"},{"line_number":12,"context_line":"    endpoint."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ff52f3f_652fe2f6","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":15},"in_reply_to":"bff0334d_0e13330f","updated":"2017-04-12 23:19:31.000000000","message":"Done","commit_id":"c14f891a7a54aea70220bbd4e3382d5b583fdd2f"}]}
