)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"47860a13cec9435eb93594ac35be73423d51eeb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DocFix: sriov_nic_agent supports qos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The sriov_nic_agent added qos support with this patch[1] and the"},{"line_number":10,"context_line":"document was not updated to reflect that."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit removes QoS from the \"to be supported in the future\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bff0334d_69caaf6d","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":56},"updated":"2017-04-07 18:34:59.000000000","message":"Maybe also point to commits 60325f4ae9ec53734d792d111cbcf24270d57417 and 60325f4ae9ec53734d792d111cbcf24270d57417. Please see my comment at https://review.openstack.org/#/c/454781/4/doc/source/devref/sriov_nic_agent.rst@40","commit_id":"b0b7c8b71d3c0044c9430f6f8b90ff2dde78ffc3"}],"doc/source/devref/sriov_nic_agent.rst":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5b00751b45e72d2191ea35518ab365da1bbd1e4d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"In most common deployments, there are compute and a network nodes."},{"line_number":39,"context_line":"Compute node can support VM connectivity via SR-IOV enabled NIC. SR-IOV NIC Agent manages"},{"line_number":40,"context_line":"Virtual Functions admin state. In the future it will manage additional settings, such as"},{"line_number":41,"context_line":"additioanl quality of service rules, rate limit settings, spoofcheck and more. Quality of"},{"line_number":42,"context_line":"service is partially implemented with the bandwith limit rule."},{"line_number":43,"context_line":"Network node will be usually deployed with either Open vSwitch or Linux Bridge to support network node functionality."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_2a937c51","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":11},"updated":"2017-04-07 16:29:47.000000000","message":"additional","commit_id":"aee85953d79e03034791a86657692b502a985d8a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"db3d20ad694df318017966249454e80bd6875a6c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"In most common deployments, there are compute and a network nodes."},{"line_number":39,"context_line":"Compute node can support VM connectivity via SR-IOV enabled NIC. SR-IOV NIC Agent manages"},{"line_number":40,"context_line":"Virtual Functions admin state. In the future it will manage additional settings, such as"},{"line_number":41,"context_line":"additioanl quality of service rules, rate limit settings, spoofcheck and more. Quality of"},{"line_number":42,"context_line":"service is partially implemented with the bandwith limit rule."},{"line_number":43,"context_line":"Network node will be usually deployed with either Open vSwitch or Linux Bridge to support network node functionality."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_aa230c05","line":42,"range":{"start_line":41,"start_character":78,"end_line":42,"end_character":62},"updated":"2017-04-07 16:33:19.000000000","message":"I\u0027d suggest moving this before In the future it will manage additional settings, like\n\nQuality of service is partially implemented with the bandwith limit rule.  In the future it will manage additional settings, supporting more rules for quality of services like dcsp marking etc. ?","commit_id":"aee85953d79e03034791a86657692b502a985d8a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"fdabd828d67900a40fcfe27ea17ba6a270b06a1f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"In most common deployments, there are compute and a network nodes."},{"line_number":39,"context_line":"Compute node can support VM connectivity via SR-IOV enabled NIC. SR-IOV NIC Agent manages"},{"line_number":40,"context_line":"Virtual Functions admin state. In the future it will manage additional settings, such as"},{"line_number":41,"context_line":"additional quality of service rules, rate limit settings, spoofcheck and more. Quality of"},{"line_number":42,"context_line":"service is partially implemented with the bandwith limit rule."},{"line_number":43,"context_line":"Network node will be usually deployed with either Open vSwitch or Linux Bridge to support network node functionality."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_0ab9d878","line":42,"range":{"start_line":41,"start_character":79,"end_line":42,"end_character":61},"updated":"2017-04-07 16:36:31.000000000","message":"this looks good as it is now, but starting with what it support would be better","commit_id":"f814eb6a724eac0bb7efcbee09a857af6f04e7a4"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"217fd3072e93c02b15087b6b2c0d71e9d687a792","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In most common deployments, there are compute and a network nodes."},{"line_number":39,"context_line":"Compute node can support VM connectivity via SR-IOV enabled NIC. SR-IOV NIC Agent manages"},{"line_number":40,"context_line":"Virtual Functions admin state. Quality of service is partially implemented with the bandwith limit"},{"line_number":41,"context_line":"rule. In the future it will manage additional settings, such as additioanl quality of service rules,"},{"line_number":42,"context_line":"rate limit settings, spoofcheck and more."},{"line_number":43,"context_line":"Network node will be usually deployed with either Open vSwitch or Linux Bridge to support network node functionality."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_a5d8dd7e","line":40,"range":{"start_line":40,"start_character":84,"end_line":40,"end_character":92},"updated":"2017-04-07 16:50:49.000000000","message":"bandwidth","commit_id":"d41eb01be95c2f45986c605970d54780af5a9195"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"217fd3072e93c02b15087b6b2c0d71e9d687a792","unresolved":false,"context_lines":[{"line_number":38,"context_line":"In most common deployments, there are compute and a network nodes."},{"line_number":39,"context_line":"Compute node can support VM connectivity via SR-IOV enabled NIC. SR-IOV NIC Agent manages"},{"line_number":40,"context_line":"Virtual Functions admin state. Quality of service is partially implemented with the bandwith limit"},{"line_number":41,"context_line":"rule. In the future it will manage additional settings, such as additioanl quality of service rules,"},{"line_number":42,"context_line":"rate limit settings, spoofcheck and more."},{"line_number":43,"context_line":"Network node will be usually deployed with either Open vSwitch or Linux Bridge to support network node functionality."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bff0334d_a5469d20","line":41,"range":{"start_line":41,"start_character":64,"end_line":41,"end_character":74},"updated":"2017-04-07 16:50:49.000000000","message":"additional","commit_id":"d41eb01be95c2f45986c605970d54780af5a9195"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"47860a13cec9435eb93594ac35be73423d51eeb2","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"In most common deployments, there are compute and a network nodes."},{"line_number":39,"context_line":"Compute node can support VM connectivity via SR-IOV enabled NIC. SR-IOV NIC Agent manages"},{"line_number":40,"context_line":"Virtual Functions admin state. Quality of service is partially implemented with the bandwidth limit"},{"line_number":41,"context_line":"rule. In the future it will manage additional settings, such as additional quality of service rules,"},{"line_number":42,"context_line":"rate limit settings, spoofcheck and more."},{"line_number":43,"context_line":"Network node will be usually deployed with either Open vSwitch or Linux Bridge to support network node functionality."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bff0334d_6903cfb9","line":41,"range":{"start_line":40,"start_character":84,"end_line":41,"end_character":4},"updated":"2017-04-07 18:34:59.000000000","message":"Last week I reviewed a patchset that includes this: https://review.openstack.org/#/c/426946/21/neutron/services/qos/drivers/sriov/driver.py@34. As you can see, according to that patchset, minimum bandwidth rules are also supported. So I decided to go dig in the repo and found these two patchsets:\n\nhttps://review.openstack.org/#/c/347302/\nhttps://review.openstack.org/#/c/344145/\n\nThese two patchsets are more recent that the one mentioned in the commit message. So it seems to me we should also list minimum bandwidth rules as supported by SR-IOV","commit_id":"b0b7c8b71d3c0044c9430f6f8b90ff2dde78ffc3"}]}