)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6fdb30e401cb6876fd0fed54892129bde72913b6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Because each port calls dhclient to obtain IP address and each dhclient"},{"line_number":23,"context_line":"instance overwrites /etc/resolv.conf there was added a script that"},{"line_number":24,"context_line":"generates fullstack-dhclient-script from an existing dhclient-script"},{"line_number":25,"context_line":"before starting fulltstack tests. This generated script is passed to"},{"line_number":26,"context_line":"each dhclient process running in fake fullstack machine using -sf"},{"line_number":27,"context_line":"parameter."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7ffa3b31_b46e6ac6","line":25,"range":{"start_line":25,"start_character":16,"end_line":25,"end_character":26},"updated":"2017-04-21 16:38:21.000000000","message":"fullstack","commit_id":"bc979efdb85b3ac2722d6607485d21e002718e02"}],"tools/generate_dhclient_script_for_fullstack.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0301568075ef4c4ead99a9c292a4133840e27de1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"DHCLIENT_SCRIPT_NAME\u003ddhclient-script"},{"line_number":13,"context_line":"DHCLIENT_PATH\u003d$(which $DHCLIENT_SCRIPT_NAME)"},{"line_number":14,"context_line":"MAKE_RESOLV_CONF_FUNCTION\u003dmake_resolv_conf"},{"line_number":15,"context_line":"FULLSTACK_DHCLIENT_SCRIPT\u003d$NEUTRON_DIR/neutron/tests/contrib/fullstack-dhclient-script"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"if [ -n \"$DHCLIENT_PATH\" ]; then"},{"line_number":18,"context_line":"    # Return from make_resolv_conf function immediately. This will cause"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7ffa3b31_61116c5d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"updated":"2017-04-20 13:56:32.000000000","message":"This should go to venv otherwise find_executable in machine won\u0027t find it.","commit_id":"b646bfc1bbd1e225234110219027671acd28fc89"}],"tox.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"795a2bf2700f551ae8e848f5a25f624109bc0e71","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  {[testenv]whitelist_externals}"},{"line_number":81,"context_line":"  sudo"},{"line_number":82,"context_line":"commands \u003d"},{"line_number":83,"context_line":"  sudo chattr +i /etc/resolv.conf"},{"line_number":84,"context_line":"  {[testenv]commands}"},{"line_number":85,"context_line":"  sudo chattr -i /etc/resolv.conf"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"9ff52f3f_683217aa","line":83,"updated":"2017-04-13 00:06:18.000000000","message":"hm, so if that is interrupted we leave system in broken state?..","commit_id":"95a70bf746df58760d86030b14e4e2e8dee45d6b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"111e4893ff3636e8e78f0d626071181662bbc373","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  {[testenv]whitelist_externals}"},{"line_number":81,"context_line":"  sudo"},{"line_number":82,"context_line":"commands \u003d"},{"line_number":83,"context_line":"  sudo chattr +i /etc/resolv.conf"},{"line_number":84,"context_line":"  {[testenv]commands}"},{"line_number":85,"context_line":"  sudo chattr -i /etc/resolv.conf"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"7ffa3b31_8e099296","line":83,"in_reply_to":"7ffa3b31_27b678db","updated":"2017-04-18 13:56:48.000000000","message":"So maybe this part should be another patch as it\u0027s not really related to the resync after agent was revived. But having more tests with dhcp agents and more dhclients, it\u0027s likely that dhclients will rewrite resolv.conf with nameservers they got from dnsmasq.","commit_id":"95a70bf746df58760d86030b14e4e2e8dee45d6b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"694d7dc6f4ea6d0c077b8f40a4caf874efacc6dd","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  {[testenv]whitelist_externals}"},{"line_number":81,"context_line":"  sudo"},{"line_number":82,"context_line":"commands \u003d"},{"line_number":83,"context_line":"  sudo chattr +i /etc/resolv.conf"},{"line_number":84,"context_line":"  {[testenv]commands}"},{"line_number":85,"context_line":"  sudo chattr -i /etc/resolv.conf"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"7ffa3b31_e7f410d2","line":83,"in_reply_to":"7ffa3b31_9ec11d32","updated":"2017-04-13 21:47:00.000000000","message":"Good question. In the latest PS, we use the dnsmasq_local_resolv option but is it the right fix? The commit message suggests that it\u0027s dhclient that overrides it, not dnsmasq. So shouldn\u0027t we tell dhclient to stop doing it instead? Or isolate it somehow so that it doesn\u0027t affect the file?","commit_id":"95a70bf746df58760d86030b14e4e2e8dee45d6b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"54016bd34a49fc6c0954494744621a1d14a00e82","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  {[testenv]whitelist_externals}"},{"line_number":81,"context_line":"  sudo"},{"line_number":82,"context_line":"commands \u003d"},{"line_number":83,"context_line":"  sudo chattr +i /etc/resolv.conf"},{"line_number":84,"context_line":"  {[testenv]commands}"},{"line_number":85,"context_line":"  sudo chattr -i /etc/resolv.conf"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"7ffa3b31_27b678db","line":83,"in_reply_to":"7ffa3b31_e7f410d2","updated":"2017-04-13 21:54:22.000000000","message":"It seems to me that instead of messing with the agent, we should ideally make the dhclient to not touch the file; I don\u0027t see an option for that though, so maybe we can explore other clients?\n\nNeither I see an option in dhclient to just ignore dns nameservers specified by options. If nothing else, we may configure dnsmasq to stop sending this particular option, via dnsmasq_dns_servers or dnsmasq_config_file?","commit_id":"95a70bf746df58760d86030b14e4e2e8dee45d6b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"448bd665cd6494b373a551bdfe0ff85c95b04268","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  {[testenv]whitelist_externals}"},{"line_number":81,"context_line":"  sudo"},{"line_number":82,"context_line":"commands \u003d"},{"line_number":83,"context_line":"  sudo chattr +i /etc/resolv.conf"},{"line_number":84,"context_line":"  {[testenv]commands}"},{"line_number":85,"context_line":"  sudo chattr -i /etc/resolv.conf"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"9ff52f3f_fefff831","line":83,"in_reply_to":"9ff52f3f_683217aa","updated":"2017-04-13 07:59:56.000000000","message":"I haven\u0027t found any generic solution. We could also copy the current resolv.conf and move it back after test is done but that would still introduce a possibility that resolv.conf is changed during testrun which can introduce intermittent issues.\n\nIf testrun is interrupted, it always leaves some mess behind like cnt- bridge in OVS, machine namespaces or running neutron processes.\n\nWe could set immutable bit in the Python code using a fixture but if test would be killed, it still would leave immutable bit set.","commit_id":"95a70bf746df58760d86030b14e4e2e8dee45d6b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a24aaf6bdd660fad00ebffa74dc29ae2067f41e0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  {[testenv]whitelist_externals}"},{"line_number":81,"context_line":"  sudo"},{"line_number":82,"context_line":"commands \u003d"},{"line_number":83,"context_line":"  sudo chattr +i /etc/resolv.conf"},{"line_number":84,"context_line":"  {[testenv]commands}"},{"line_number":85,"context_line":"  sudo chattr -i /etc/resolv.conf"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"7ffa3b31_9ec11d32","line":83,"in_reply_to":"9ff52f3f_b4998c20","updated":"2017-04-13 20:07:58.000000000","message":"What is changing in the fullstack framework that is now trying to modify this file?","commit_id":"95a70bf746df58760d86030b14e4e2e8dee45d6b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"aa94cdd1d3234a50a135b7ecf3bf3ad932a1d962","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  {[testenv]whitelist_externals}"},{"line_number":81,"context_line":"  sudo"},{"line_number":82,"context_line":"commands \u003d"},{"line_number":83,"context_line":"  sudo chattr +i /etc/resolv.conf"},{"line_number":84,"context_line":"  {[testenv]commands}"},{"line_number":85,"context_line":"  sudo chattr -i /etc/resolv.conf"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"9ff52f3f_b4998c20","line":83,"in_reply_to":"9ff52f3f_fefff831","updated":"2017-04-13 11:30:57.000000000","message":"I\u0027m exploring dnsmasq_local_resolv option","commit_id":"95a70bf746df58760d86030b14e4e2e8dee45d6b"}]}