)]}'
{"neutron/agent/linux/ovs_lib.py":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"127b1228cd51a56d249943fe4fbb67a7efd209ee","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                self.switch.br_name)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class BaseOVS(object):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __init__(self, root_helper):"},{"line_number":50,"context_line":"        self.root_helper \u003d root_helper"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FPWk%3D","line":47,"updated":"2013-09-09 13:43:07.000000000","message":"I\u0027m curious why you created a new class here instead of just adding this functionality to the OVSBridge class.","commit_id":"d6c2f718ee5474bbae3c2fb24efb472de5b947da"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"afc04e59e9a472cb38d3ca0e7648a4507daadf3b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if check_error:"},{"line_number":58,"context_line":"                raise"},{"line_number":59,"context_line":"            LOG.error(_(\"Unable to execute %(cmd)s. Exception: %(exception)s\"),"},{"line_number":60,"context_line":"                      {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def add_bridge(self, bridge_name):"},{"line_number":63,"context_line":"        self.run_vsctl([\"add-br\", bridge_name])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FzYc%3D","line":60,"updated":"2013-09-18 23:35:36.000000000","message":"Isn\u0027t the case to log the error anyway, even if check_error\u003dTrue?","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"179c2f4ad3980b11785f8cba3a1fc8dec9882c32","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if check_error:"},{"line_number":58,"context_line":"                raise"},{"line_number":59,"context_line":"            LOG.error(_(\"Unable to execute %(cmd)s. Exception: %(exception)s\"),"},{"line_number":60,"context_line":"                      {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def add_bridge(self, bridge_name):"},{"line_number":63,"context_line":"        self.run_vsctl([\"add-br\", bridge_name])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYXI%3D","line":60,"in_reply_to":"AAAAS3%2F%2FzYc%3D","updated":"2013-09-27 19:00:38.000000000","message":"Done","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"afc04e59e9a472cb38d3ca0e7648a4507daadf3b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                      {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def add_bridge(self, bridge_name):"},{"line_number":63,"context_line":"        self.run_vsctl([\"add-br\", bridge_name])"},{"line_number":64,"context_line":"        return OVSBridge(bridge_name, self.root_helper)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete_bridge(self, bridge_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FzYA%3D","line":63,"updated":"2013-09-18 23:35:36.000000000","message":"Use of --may-exist might be considered, unless it\u0027s been omitted on purpose.","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"179c2f4ad3980b11785f8cba3a1fc8dec9882c32","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                      {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def add_bridge(self, bridge_name):"},{"line_number":63,"context_line":"        self.run_vsctl([\"add-br\", bridge_name])"},{"line_number":64,"context_line":"        return OVSBridge(bridge_name, self.root_helper)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete_bridge(self, bridge_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYXY%3D","line":63,"in_reply_to":"AAAAS3%2F%2FzYA%3D","updated":"2013-09-27 19:00:38.000000000","message":"Done","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"afc04e59e9a472cb38d3ca0e7648a4507daadf3b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            return self.run_vsctl([\u0027port-to-br\u0027, port_name], check_error\u003dTrue)"},{"line_number":81,"context_line":"        except RuntimeError as e:"},{"line_number":82,"context_line":"            if \u0027Exit code: 1\u0027 not in str(e):"},{"line_number":83,"context_line":"                raise"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def port_exists(self, port_name):"},{"line_number":86,"context_line":"        return bool(self.get_bridge_name_for_port_name(port_name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FzW4%3D","line":83,"updated":"2013-09-18 23:35:36.000000000","message":"I would raise in error case here, but this is just a personal opinion","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"179c2f4ad3980b11785f8cba3a1fc8dec9882c32","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            return self.run_vsctl([\u0027port-to-br\u0027, port_name], check_error\u003dTrue)"},{"line_number":81,"context_line":"        except RuntimeError as e:"},{"line_number":82,"context_line":"            if \u0027Exit code: 1\u0027 not in str(e):"},{"line_number":83,"context_line":"                raise"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def port_exists(self, port_name):"},{"line_number":86,"context_line":"        return bool(self.get_bridge_name_for_port_name(port_name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FYXM%3D","line":83,"in_reply_to":"AAAAS3%2F%2FzW4%3D","updated":"2013-09-27 19:00:38.000000000","message":"I\u0027m not sure I understand - could you please clarify both the problem and what change is required?","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"16cf934416cdf33b4bd212d1a733abbba37856c4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self.run_vsctl([\u0027br-exists\u0027, bridge_name], check_error\u003dTrue)"},{"line_number":72,"context_line":"        except RuntimeError as e:"},{"line_number":73,"context_line":"            if \u0027Exit code: 2\u0027 in str(e):"},{"line_number":74,"context_line":"                return False"},{"line_number":75,"context_line":"            raise"},{"line_number":76,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2FjRs%3D","line":73,"updated":"2013-10-14 16:31:46.000000000","message":"\u0027Exit code: 2\u0027 matches \u0027Exit code: 2xx\u0027 too. It is better to use \u0027Exit code: 2¥n\u0027 instead. I think it is safer.","commit_id":"a97f62f1086fa134e0ab9ce9766c9d342661ae6d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"86ac38a178fb5746ee9551c0fd8625b10ccba977","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self.run_vsctl([\u0027br-exists\u0027, bridge_name], check_error\u003dTrue)"},{"line_number":72,"context_line":"        except RuntimeError as e:"},{"line_number":73,"context_line":"            if \u0027Exit code: 2\u0027 in str(e):"},{"line_number":74,"context_line":"                return False"},{"line_number":75,"context_line":"            raise"},{"line_number":76,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2FiaA%3D","line":73,"in_reply_to":"AAAATH%2F%2FjRs%3D","updated":"2013-10-14 21:57:18.000000000","message":"Done","commit_id":"a97f62f1086fa134e0ab9ce9766c9d342661ae6d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"16cf934416cdf33b4bd212d1a733abbba37856c4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            return self.run_vsctl([\u0027port-to-br\u0027, port_name], check_error\u003dTrue)"},{"line_number":81,"context_line":"        except RuntimeError as e:"},{"line_number":82,"context_line":"            if \u0027Exit code: 1\u0027 not in str(e):"},{"line_number":83,"context_line":"                raise"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def port_exists(self, port_name):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2FjRo%3D","line":82,"updated":"2013-10-14 16:31:46.000000000","message":"Same as the above. AFAIK, when ovsdb is not running, ovs-vsctl returns 142.","commit_id":"a97f62f1086fa134e0ab9ce9766c9d342661ae6d"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"86ac38a178fb5746ee9551c0fd8625b10ccba977","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            return self.run_vsctl([\u0027port-to-br\u0027, port_name], check_error\u003dTrue)"},{"line_number":81,"context_line":"        except RuntimeError as e:"},{"line_number":82,"context_line":"            if \u0027Exit code: 1\u0027 not in str(e):"},{"line_number":83,"context_line":"                raise"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def port_exists(self, port_name):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATH%2F%2FiZ8%3D","line":82,"in_reply_to":"AAAATH%2F%2FjRo%3D","updated":"2013-10-14 21:57:18.000000000","message":"Done","commit_id":"a97f62f1086fa134e0ab9ce9766c9d342661ae6d"}],"neutron/tests/unit/openvswitch/test_ovs_lib.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4a26e58a9316ca06c6599044a8d68dcd8f2bd11e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(TestBaseOVS, self).setUp()"},{"line_number":33,"context_line":"        self.root_helper \u003d \u0027sudo\u0027"},{"line_number":34,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS(self.root_helper)"},{"line_number":35,"context_line":"        self.br_name \u003d \u0027bridge1\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_add_bridge(self):"},{"line_number":38,"context_line":"        with mock.patch.object(self.ovs, \u0027run_vsctl\u0027) as mock_vsctl:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fd3Y%3D","line":35,"updated":"2013-09-26 08:43:50.000000000","message":"I think this is called before every test_ method. I\u0027d suggest to do:\n @classmethod\n def setup_class(cls):\n     super(TestBaseOVS, self).setup_class()\n     self.root_helper \u003d \u0027sudo\u0027\n     self.br_name \u003d \u0027bridge1\u0027\n     self.ovs \u003d ovs_lib.BaseOVS(self.root_helper)","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"179c2f4ad3980b11785f8cba3a1fc8dec9882c32","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(TestBaseOVS, self).setUp()"},{"line_number":33,"context_line":"        self.root_helper \u003d \u0027sudo\u0027"},{"line_number":34,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS(self.root_helper)"},{"line_number":35,"context_line":"        self.br_name \u003d \u0027bridge1\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_add_bridge(self):"},{"line_number":38,"context_line":"        with mock.patch.object(self.ovs, \u0027run_vsctl\u0027) as mock_vsctl:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FZTU%3D","line":35,"in_reply_to":"AAAAS3%2F%2Fd3Y%3D","updated":"2013-09-27 19:00:38.000000000","message":"I\u0027m afraid that suggestion is a non-starter - setupClass doesn\u0027t work properly with testr\u0027s parallel execution and is effectively deprecated.","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b03ed18d763c9d252b982169e50bffc06a9efa15","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(TestBaseOVS, self).setUp()"},{"line_number":33,"context_line":"        self.root_helper \u003d \u0027sudo\u0027"},{"line_number":34,"context_line":"        self.ovs \u003d ovs_lib.BaseOVS(self.root_helper)"},{"line_number":35,"context_line":"        self.br_name \u003d \u0027bridge1\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_add_bridge(self):"},{"line_number":38,"context_line":"        with mock.patch.object(self.ovs, \u0027run_vsctl\u0027) as mock_vsctl:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fdws%3D","line":35,"in_reply_to":"AAAAS3%2F%2Fd3Y%3D","updated":"2013-09-26 09:20:27.000000000","message":"s/self/cls/g :]","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4a26e58a9316ca06c6599044a8d68dcd8f2bd11e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            with testtools.ExpectedException(RuntimeError):"},{"line_number":86,"context_line":"                self.ovs.get_bridge_name_for_port_name(\u0027bridge1\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _test_port_exists(self, br_name, result):"},{"line_number":89,"context_line":"        with mock.patch.object(self.ovs,"},{"line_number":90,"context_line":"                               \u0027get_bridge_name_for_port_name\u0027,"},{"line_number":91,"context_line":"                               return_value\u003dbr_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fd4Y%3D","line":88,"updated":"2013-09-26 08:43:50.000000000","message":"Two spaces between func name and keyword def","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"179c2f4ad3980b11785f8cba3a1fc8dec9882c32","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            with testtools.ExpectedException(RuntimeError):"},{"line_number":86,"context_line":"                self.ovs.get_bridge_name_for_port_name(\u0027bridge1\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _test_port_exists(self, br_name, result):"},{"line_number":89,"context_line":"        with mock.patch.object(self.ovs,"},{"line_number":90,"context_line":"                               \u0027get_bridge_name_for_port_name\u0027,"},{"line_number":91,"context_line":"                               return_value\u003dbr_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FZS0%3D","line":88,"in_reply_to":"AAAAS3%2F%2Fd4Y%3D","updated":"2013-09-27 19:00:38.000000000","message":"There are not two spaces - there is a leading \u0027_\u0027 to ensure that the method will not be treated as a test by the test runner.  It is a helper method parameterized by the test methods that follow.\n\nNote that the pep8 gate check will automatically find erroneous whitespace so reviewers can focus on non-mechanical review.","commit_id":"d5827902abf0da4073be7cca689114da50f77ebc"}]}
