)]}'
{"neutron/agent/linux/ovsdb_monitor.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd1325d526550eb5c46009be74b6308f73f8e9e4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class OvsdbMonitor(async_process.AsyncProcess):"},{"line_number":27,"context_line":"    \"\"\"Manages an invoction of \u0027ovsdb-client monitor\u0027.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, table_name, columns\u003dNone, format\u003dNone,"},{"line_number":30,"context_line":"                 root_helper\u003dNone, respawn_interval\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FrZc%3D","line":27,"updated":"2013-10-11 11:18:36.000000000","message":"It feels a shame to comment on this, but there is a typo here (invoction)","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2b1350cf21f13d987378ecd548128cbb6d7369a0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class OvsdbMonitor(async_process.AsyncProcess):"},{"line_number":27,"context_line":"    \"\"\"Manages an invoction of \u0027ovsdb-client monitor\u0027.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, table_name, columns\u003dNone, format\u003dNone,"},{"line_number":30,"context_line":"                 root_helper\u003dNone, respawn_interval\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FmkY%3D","line":27,"in_reply_to":"AAAATH%2F%2FrZc%3D","updated":"2013-10-14 22:25:16.000000000","message":"Done","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd1325d526550eb5c46009be74b6308f73f8e9e4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return"},{"line_number":45,"context_line":"        # The default root helper outputs exit errors to stdout due to"},{"line_number":46,"context_line":"        # bug #1219530.  This check can be moved to _read_stderr once"},{"line_number":47,"context_line":"        # the error is correctly output to stderr."},{"line_number":48,"context_line":"        if self.root_helper and self.root_helper in data:"},{"line_number":49,"context_line":"            self._stderr_lines.put(data)"},{"line_number":50,"context_line":"            LOG.error(_(\u0027Error received from ovsdb monitor: %(data)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FrY8%3D","line":47,"updated":"2013-10-11 11:18:36.000000000","message":"another shameful nit: add a #NOTE or #TODO to this comment","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2b1350cf21f13d987378ecd548128cbb6d7369a0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return"},{"line_number":45,"context_line":"        # The default root helper outputs exit errors to stdout due to"},{"line_number":46,"context_line":"        # bug #1219530.  This check can be moved to _read_stderr once"},{"line_number":47,"context_line":"        # the error is correctly output to stderr."},{"line_number":48,"context_line":"        if self.root_helper and self.root_helper in data:"},{"line_number":49,"context_line":"            self._stderr_lines.put(data)"},{"line_number":50,"context_line":"            LOG.error(_(\u0027Error received from ovsdb monitor: %(data)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2Fllo%3D","line":47,"in_reply_to":"AAAATH%2F%2FrY8%3D","updated":"2013-10-14 22:25:16.000000000","message":"Done","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd1325d526550eb5c46009be74b6308f73f8e9e4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            self._stdout_lines.put(data)"},{"line_number":54,"context_line":"            LOG.debug(_(\u0027Output received from ovsdb monitor: %(data)s\u0027) %"},{"line_number":55,"context_line":"                      {\u0027data\u0027: data})"},{"line_number":56,"context_line":"            return data"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _read_stderr(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FrYo%3D","line":55,"updated":"2013-10-11 11:18:36.000000000","message":"as you have a single item in the format string, perhaps the dict is not needed. But if you added for readability, then just keep it.","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2b1350cf21f13d987378ecd548128cbb6d7369a0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            self._stdout_lines.put(data)"},{"line_number":54,"context_line":"            LOG.debug(_(\u0027Output received from ovsdb monitor: %(data)s\u0027) %"},{"line_number":55,"context_line":"                      {\u0027data\u0027: data})"},{"line_number":56,"context_line":"            return data"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _read_stderr(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FmkI%3D","line":55,"in_reply_to":"AAAATH%2F%2FrYo%3D","updated":"2013-10-14 22:25:16.000000000","message":"Done","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"}],"neutron/agent/linux/polling.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c902884047d49973440a309ea85d11698e6d14cd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return True"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class InterfacePollingMinimizer(BasePollingManager):"},{"line_number":85,"context_line":"    \"\"\"Monitors ovsdb to determine when polling is required.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, root_helper\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2FjOY%3D","line":84,"updated":"2013-10-14 18:01:51.000000000","message":"In my understanding, this module is not related to OVS implementation. Isn\u0027t it better to move it to ovs_monitor or ovs_lib?","commit_id":"28e387f989688220921b4830bdd3dfbb7d53289e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cc2d60c74c5b20080589b32a67dd53d08828a770","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return True"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class InterfacePollingMinimizer(BasePollingManager):"},{"line_number":85,"context_line":"    \"\"\"Monitors ovsdb to determine when polling is required.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, root_helper\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2Fh48%3D","line":84,"in_reply_to":"AAAATH%2F%2FiAk%3D","updated":"2013-10-14 22:43:14.000000000","message":"Fair enough.\n\nHow about adding a prefix \"OVS\" to the class name? It is a clearer name.","commit_id":"28e387f989688220921b4830bdd3dfbb7d53289e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"dec9c3725233d19646adda5c0e9b635420dc3623","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return True"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class InterfacePollingMinimizer(BasePollingManager):"},{"line_number":85,"context_line":"    \"\"\"Monitors ovsdb to determine when polling is required.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, root_helper\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2FiAk%3D","line":84,"in_reply_to":"AAAATH%2F%2FjOY%3D","updated":"2013-10-14 22:25:38.000000000","message":"I would suggest that isolating all polling-related code in the polling module will make it easier to remove when the time comes.  Sometimes it may make sense to organize by technology, but other times organizing by function is better, and I think this is one of those cases.","commit_id":"28e387f989688220921b4830bdd3dfbb7d53289e"}],"neutron/tests/functional/agent/linux/test_ovsdb_monitor.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd1325d526550eb5c46009be74b6308f73f8e9e4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                            \u0027ovsdb-client is not installed\u0027)"},{"line_number":94,"context_line":"        self._check_command([\u0027sudo\u0027, \u0027-n\u0027, \u0027ovsdb-client\u0027, \u0027list-dbs\u0027],"},{"line_number":95,"context_line":"                            \u0027Exit code: 1\u0027,"},{"line_number":96,"context_line":"                            \u0027password-less sudo not granted for ovsdb-client\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class TestOvsdbMonitor(BaseMonitorTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FrVE%3D","line":96,"updated":"2013-10-11 11:18:36.000000000","message":"Note: I am ok with actually executing this command because there are functional test tests. ovsdb-client utility will always be installed if running one of the ovs-based plugins. If other people feel differently, comment here.","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2b1350cf21f13d987378ecd548128cbb6d7369a0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                            \u0027ovsdb-client is not installed\u0027)"},{"line_number":94,"context_line":"        self._check_command([\u0027sudo\u0027, \u0027-n\u0027, \u0027ovsdb-client\u0027, \u0027list-dbs\u0027],"},{"line_number":95,"context_line":"                            \u0027Exit code: 1\u0027,"},{"line_number":96,"context_line":"                            \u0027password-less sudo not granted for ovsdb-client\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"class TestOvsdbMonitor(BaseMonitorTest):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2Flhk%3D","line":96,"in_reply_to":"AAAATH%2F%2FrVE%3D","updated":"2013-10-14 22:25:16.000000000","message":"Functional tests are currently being executed as part of the unit test suite, and there is no way to ensure that non-python dependencies are installed.  Until we have a better way to run these tests, I think skipping will be preferable to failure to avoid confusing developers.","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd1325d526550eb5c46009be74b6308f73f8e9e4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        output1 \u003d self.collect_initial_output()"},{"line_number":120,"context_line":"        self.monitor._kill_process()"},{"line_number":121,"context_line":"        while (self.monitor._process.pid \u003d\u003d old_pid):"},{"line_number":122,"context_line":"            eventlet.sleep(0.01)"},{"line_number":123,"context_line":"        output2 \u003d self.collect_initial_output()"},{"line_number":124,"context_line":"        # Initial output should appear twice"},{"line_number":125,"context_line":"        self.assertEqual(output1, output2)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FrVk%3D","line":122,"updated":"2013-10-11 11:18:36.000000000","message":"I guess it is ok that the test hangs instead of failing if the respawn does not work for any reason?","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2b1350cf21f13d987378ecd548128cbb6d7369a0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        output1 \u003d self.collect_initial_output()"},{"line_number":120,"context_line":"        self.monitor._kill_process()"},{"line_number":121,"context_line":"        while (self.monitor._process.pid \u003d\u003d old_pid):"},{"line_number":122,"context_line":"            eventlet.sleep(0.01)"},{"line_number":123,"context_line":"        output2 \u003d self.collect_initial_output()"},{"line_number":124,"context_line":"        # Initial output should appear twice"},{"line_number":125,"context_line":"        self.assertEqual(output1, output2)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FlfM%3D","line":122,"in_reply_to":"AAAATH%2F%2FrVk%3D","updated":"2013-10-14 22:25:16.000000000","message":"No, that\u0027s a bad thing.  The functional test for async_process uses an eventlet timeout and I\u0027ll submit a new patch that does the same for ovsdb_monitor.","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd1325d526550eb5c46009be74b6308f73f8e9e4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                        \u0027Initial call should always be true\u0027)"},{"line_number":141,"context_line":"        self.assertFalse(self.monitor.has_updates,"},{"line_number":142,"context_line":"                         \u0027has_updates without port addition should be False\u0027)"},{"line_number":143,"context_line":"        create_ovs_resource(\u0027test-port-\u0027, self.bridge.add_port)"},{"line_number":144,"context_line":"        self.assertTrue(self.monitor.has_updates,"},{"line_number":145,"context_line":"                        \u0027has_updates after port addition should be True\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FrU4%3D","line":143,"updated":"2013-10-11 11:18:36.000000000","message":"this actually creates a port on a bridge.\nIt won\u0027t harm adding cleanup for this port then","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2b1350cf21f13d987378ecd548128cbb6d7369a0","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                        \u0027Initial call should always be true\u0027)"},{"line_number":141,"context_line":"        self.assertFalse(self.monitor.has_updates,"},{"line_number":142,"context_line":"                         \u0027has_updates without port addition should be False\u0027)"},{"line_number":143,"context_line":"        create_ovs_resource(\u0027test-port-\u0027, self.bridge.add_port)"},{"line_number":144,"context_line":"        self.assertTrue(self.monitor.has_updates,"},{"line_number":145,"context_line":"                        \u0027has_updates after port addition should be True\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2Flfg%3D","line":143,"in_reply_to":"AAAATH%2F%2FrU4%3D","updated":"2013-10-14 22:25:16.000000000","message":"I deemed that unnecessary since there is only a single test and test setup creates and cleans up the bridge itself which ensures port removal.","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bd1325d526550eb5c46009be74b6308f73f8e9e4","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                         \u0027has_updates without port addition should be False\u0027)"},{"line_number":143,"context_line":"        create_ovs_resource(\u0027test-port-\u0027, self.bridge.add_port)"},{"line_number":144,"context_line":"        self.assertTrue(self.monitor.has_updates,"},{"line_number":145,"context_line":"                        \u0027has_updates after port addition should be True\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FrUw%3D","line":145,"updated":"2013-10-11 11:18:36.000000000","message":"This assert is potentially subject to sporadic timing failures since has_updates is set by an async process. Is it worth adding a sleep before it?","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"2b1350cf21f13d987378ecd548128cbb6d7369a0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                         \u0027has_updates without port addition should be False\u0027)"},{"line_number":143,"context_line":"        create_ovs_resource(\u0027test-port-\u0027, self.bridge.add_port)"},{"line_number":144,"context_line":"        self.assertTrue(self.monitor.has_updates,"},{"line_number":145,"context_line":"                        \u0027has_updates after port addition should be True\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FlfI%3D","line":145,"in_reply_to":"AAAATH%2F%2FrUw%3D","updated":"2013-10-14 22:25:16.000000000","message":"Done","commit_id":"412b4af633d817e30b379f174cbb1ba032d46b92"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c902884047d49973440a309ea85d11698e6d14cd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        old_pid \u003d self.monitor._process.pid"},{"line_number":119,"context_line":"        output1 \u003d self.collect_initial_output()"},{"line_number":120,"context_line":"        self.monitor._kill_process()"},{"line_number":121,"context_line":"        while (self.monitor._process.pid \u003d\u003d old_pid):"},{"line_number":122,"context_line":"            eventlet.sleep(0.01)"},{"line_number":123,"context_line":"        output2 \u003d self.collect_initial_output()"},{"line_number":124,"context_line":"        # Initial output should appear twice"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2Fi9g%3D","line":121,"updated":"2013-10-14 18:01:51.000000000","message":"While I don\u0027t think it actually leads to an infinite loop, it seems better to use finite loop to avoid a potential risk.","commit_id":"28e387f989688220921b4830bdd3dfbb7d53289e"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"dec9c3725233d19646adda5c0e9b635420dc3623","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        old_pid \u003d self.monitor._process.pid"},{"line_number":119,"context_line":"        output1 \u003d self.collect_initial_output()"},{"line_number":120,"context_line":"        self.monitor._kill_process()"},{"line_number":121,"context_line":"        while (self.monitor._process.pid \u003d\u003d old_pid):"},{"line_number":122,"context_line":"            eventlet.sleep(0.01)"},{"line_number":123,"context_line":"        output2 \u003d self.collect_initial_output()"},{"line_number":124,"context_line":"        # Initial output should appear twice"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2FiAY%3D","line":121,"in_reply_to":"AAAATH%2F%2Fi9g%3D","updated":"2013-10-14 22:25:38.000000000","message":"Salvatore already commented on this, and I will be submitting an updated patch that addresses your shared concern.","commit_id":"28e387f989688220921b4830bdd3dfbb7d53289e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"cce939461b14ed040d3fc90e8db0cd175f5f6d69","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        old_pid \u003d self.monitor._process.pid"},{"line_number":119,"context_line":"        output1 \u003d self.collect_initial_output()"},{"line_number":120,"context_line":"        self.monitor._kill_process()"},{"line_number":121,"context_line":"        while (self.monitor._process.pid \u003d\u003d old_pid):"},{"line_number":122,"context_line":"            eventlet.sleep(0.01)"},{"line_number":123,"context_line":"        output2 \u003d self.collect_initial_output()"},{"line_number":124,"context_line":"        # Initial output should appear twice"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATH%2F%2Fgwo%3D","line":121,"in_reply_to":"AAAATH%2F%2FiAY%3D","updated":"2013-10-15 07:16:58.000000000","message":"Yes, it\u0027s not a big concern at the moment as these tests are not executed in gate jobs.","commit_id":"28e387f989688220921b4830bdd3dfbb7d53289e"}]}
