)]}'
{"neutron/db/migration/alembic_migrations/versions/pike/expand/349b6fd605a6_add_dns_domain_to_portdnses.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b522e115ba6522b0594e0a34b8a7ed5b3b79fbad","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.add_column(\u0027portdnses\u0027,"},{"line_number":36,"context_line":"                  sa.Column(\u0027dns_domain\u0027,"},{"line_number":37,"context_line":"                            sa.String(length\u003ddns.FQDN_MAX_LEN),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_111f1a6d","line":38,"updated":"2017-04-16 09:38:09.000000000","message":"If it\u0027s not nullable we need a server_default of a blank string so it doesn\u0027t break old server versions after the expand script has run.","commit_id":"b089d144dd47e1244c2e7bb47175404a18ccdec0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"31e47230c1e38700c9629dce4a85e04ba4c3e1d4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    op.add_column(\u0027portdnses\u0027,"},{"line_number":36,"context_line":"                  sa.Column(\u0027dns_domain\u0027,"},{"line_number":37,"context_line":"                            sa.String(length\u003ddns.FQDN_MAX_LEN),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_e999621f","line":38,"in_reply_to":"7ffa3b31_111f1a6d","updated":"2017-04-17 00:23:43.000000000","message":"Done","commit_id":"b089d144dd47e1244c2e7bb47175404a18ccdec0"}],"neutron/db/models/dns.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f5752cbb85af4156f25b956e87019dcfbef99bbf","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    previous_dns_domain \u003d sa.Column(sa.String(255),"},{"line_number":86,"context_line":"                                    nullable\u003dFalse)"},{"line_number":87,"context_line":"    dns_name \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":88,"context_line":"    dns_domain \u003d sa.Column(sa.String(dns.FQDN_MAX_LEN), nullable\u003dFalse)"},{"line_number":89,"context_line":"    # Add a relationship to the Port model in order to instruct"},{"line_number":90,"context_line":"    # SQLAlchemy to eagerly load this association"},{"line_number":91,"context_line":"    port \u003d orm.relationship(models_v2.Port,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_4e2174fb","line":88,"updated":"2017-04-17 07:45:49.000000000","message":"add server_default here as well for synchronization with migration","commit_id":"a2cec0ab031ab2e95618507359b4208d5131f865"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"a545c993af77ddae9c1419ecf3c2c7ca4e3f988b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    previous_dns_domain \u003d sa.Column(sa.String(255),"},{"line_number":86,"context_line":"                                    nullable\u003dFalse)"},{"line_number":87,"context_line":"    dns_name \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":88,"context_line":"    dns_domain \u003d sa.Column(sa.String(dns.FQDN_MAX_LEN), nullable\u003dFalse)"},{"line_number":89,"context_line":"    # Add a relationship to the Port model in order to instruct"},{"line_number":90,"context_line":"    # SQLAlchemy to eagerly load this association"},{"line_number":91,"context_line":"    port \u003d orm.relationship(models_v2.Port,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_1585dfad","line":88,"in_reply_to":"7ffa3b31_4e2174fb","updated":"2017-04-23 22:59:39.000000000","message":"Done! Thanks for the review :-)","commit_id":"a2cec0ab031ab2e95618507359b4208d5131f865"}],"neutron/objects/ports.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8c69d22b59c13e98673d6eb650f4722ada41cc7c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":211,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":212,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":213,"context_line":"            primitive.pop(\u0027dns_domain\u0027)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f1d235d_856d1006","line":213,"updated":"2017-06-30 21:11:12.000000000","message":"IIRC you need to pop(\u0027dns_domain\u0027, None) here if dns_domain is nullable because in that case the key can be missing completely. see \u0027data_plane_status\u0027 on port and \u0027is_default\u0027 on qos policy for example.","commit_id":"f1e676557edcf95304e41dbf5dfc5250bfbf3801"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"922acc5ec46d9177d9583cb25beb777054bc5835","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":211,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":212,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":213,"context_line":"            primitive.pop(\u0027dns_domain\u0027)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f1d235d_77e73f14","line":213,"in_reply_to":"3f1d235d_856d1006","updated":"2017-07-01 22:30:32.000000000","message":"dns_domain is not nullable. But I don\u0027t think adding the None default is going to hurt either. Done","commit_id":"f1e676557edcf95304e41dbf5dfc5250bfbf3801"}]}