)]}'
{"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f36a581fc607c77726b2d5fa789d5286cc02084f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        return self.create_shared_network(**post_body)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    @decorators.idempotent_id(\u00270f05d98e-41f5-4629-dada-9aee269c9602\u0027)"},{"line_number":246,"context_line":"    @testtools.skipUnless(\"vlan\" in config.CONF.neutron_plugin_options."},{"line_number":247,"context_line":"                          available_type_drivers,"},{"line_number":248,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":249,"context_line":"    def test_add_subport(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_c4b8a42b","line":246,"updated":"2017-04-18 09:28:31.000000000","message":"put this up in the skip_checks on L229. This whole class needs vlans.","commit_id":"6c442b1821860c732fe59bd1195271d875569d1b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d1dd12383add01becd33b9263286274c9f684da9","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    @classmethod"},{"line_number":229,"context_line":"    @testtools.skipUnless(\"vlan\" in config.CONF.neutron_plugin_options."},{"line_number":230,"context_line":"                          available_type_drivers,"},{"line_number":231,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":232,"context_line":"    def skip_checks(cls):"},{"line_number":233,"context_line":"        super(TrunkTestInheritJSONBase, cls).skip_checks()"},{"line_number":234,"context_line":"        for ext in cls.required_extensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_18494f8a","line":231,"updated":"2017-04-18 12:03:27.000000000","message":"+1, please match the patter of the rest of these skip checks by having regular inline code raising a cls.skipException as necessary","commit_id":"9165adddfed7d00e4c0caa7fd71380e9bdac2746"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b2f9dafba76d4655335bd6db03248a2f4d2ac54b","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    required_extensions \u003d [\u0027provider\u0027, \u0027trunk\u0027]"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @classmethod"},{"line_number":229,"context_line":"    @testtools.skipUnless(\"vlan\" in config.CONF.neutron_plugin_options."},{"line_number":230,"context_line":"                          available_type_drivers,"},{"line_number":231,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":232,"context_line":"    def skip_checks(cls):"},{"line_number":233,"context_line":"        super(TrunkTestInheritJSONBase, cls).skip_checks()"},{"line_number":234,"context_line":"        for ext in cls.required_extensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_ea78092c","line":231,"range":{"start_line":229,"start_character":3,"end_line":231,"end_character":60},"updated":"2017-04-18 10:46:53.000000000","message":"I think you can move this before L.238 below. we have similar check in skip_checks(). I am not sure it works and skipping skip_checks looks tricky to me.","commit_id":"9165adddfed7d00e4c0caa7fd71380e9bdac2746"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"a06bae622f119d5e56685b263a6d72c70eaa71a3","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    @classmethod"},{"line_number":229,"context_line":"    @testtools.skipUnless(\"vlan\" in config.CONF.neutron_plugin_options."},{"line_number":230,"context_line":"                          available_type_drivers,"},{"line_number":231,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":232,"context_line":"    def skip_checks(cls):"},{"line_number":233,"context_line":"        super(TrunkTestInheritJSONBase, cls).skip_checks()"},{"line_number":234,"context_line":"        for ext in cls.required_extensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_da763407","line":231,"in_reply_to":"7ffa3b31_18494f8a","updated":"2017-04-18 15:36:49.000000000","message":"Done","commit_id":"9165adddfed7d00e4c0caa7fd71380e9bdac2746"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"a06bae622f119d5e56685b263a6d72c70eaa71a3","unresolved":false,"context_lines":[{"line_number":226,"context_line":"    required_extensions \u003d [\u0027provider\u0027, \u0027trunk\u0027]"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    @classmethod"},{"line_number":229,"context_line":"    @testtools.skipUnless(\"vlan\" in config.CONF.neutron_plugin_options."},{"line_number":230,"context_line":"                          available_type_drivers,"},{"line_number":231,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":232,"context_line":"    def skip_checks(cls):"},{"line_number":233,"context_line":"        super(TrunkTestInheritJSONBase, cls).skip_checks()"},{"line_number":234,"context_line":"        for ext in cls.required_extensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_da2194fd","line":231,"range":{"start_line":229,"start_character":3,"end_line":231,"end_character":60},"in_reply_to":"7ffa3b31_ea78092c","updated":"2017-04-18 15:36:49.000000000","message":"Done","commit_id":"9165adddfed7d00e4c0caa7fd71380e9bdac2746"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"929283d605f5aa304168a5b0842449c3496d5166","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":233,"context_line":"                raise cls.skipException(msg)"},{"line_number":234,"context_line":"        if \"vlan\" not in (config.CONF.neutron_plugin_options."},{"line_number":235,"context_line":"                          available_type_drivers):"},{"line_number":236,"context_line":"            raise cls.skipException(\"VLAN type_driver is not enabled\")"},{"line_number":237,"context_line":"        if not config.CONF.neutron_plugin_options.provider_vlans:"},{"line_number":238,"context_line":"            raise cls.skipException(\"No provider VLAN networks available\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_15958d40","line":235,"updated":"2017-04-18 15:51:44.000000000","message":"You already use parenthesis to wrap lines.\nIf so, it is better not to wrap lines in the middle of the variable name.\nConsider:\n\n  if (\"vlan\" not in\n      config.CONF.neutron_plugin_options.available_type_drivers):\n\nI think this fits 80 characters.","commit_id":"09fa172ad06b526a51fe39810ba954c4140a560e"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"5feca67b9a3ed21ef9e21f7e578785c4511f4a0c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":233,"context_line":"                raise cls.skipException(msg)"},{"line_number":234,"context_line":"        if \"vlan\" not in (config.CONF.neutron_plugin_options."},{"line_number":235,"context_line":"                          available_type_drivers):"},{"line_number":236,"context_line":"            raise cls.skipException(\"VLAN type_driver is not enabled\")"},{"line_number":237,"context_line":"        if not config.CONF.neutron_plugin_options.provider_vlans:"},{"line_number":238,"context_line":"            raise cls.skipException(\"No provider VLAN networks available\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_f5d581b8","line":235,"in_reply_to":"7ffa3b31_15958d40","updated":"2017-04-18 15:59:46.000000000","message":"Done","commit_id":"09fa172ad06b526a51fe39810ba954c4140a560e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2432e612f697d95b0b4e60ebc21ad3e64c522d1b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":233,"context_line":"                raise cls.skipException(msg)"},{"line_number":234,"context_line":"        if (\"vlan\" not in"},{"line_number":235,"context_line":"           config.CONF.neutron_plugin_options.available_type_drivers):"},{"line_number":236,"context_line":"            raise cls.skipException(\"VLAN type_driver is not enabled\")"},{"line_number":237,"context_line":"        if not config.CONF.neutron_plugin_options.provider_vlans:"},{"line_number":238,"context_line":"            raise cls.skipException(\"No provider VLAN networks available\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_f00d8f35","line":235,"range":{"start_line":235,"start_character":11,"end_line":235,"end_character":68},"updated":"2017-04-18 16:04:32.000000000","message":"The indent level look wrong. This line needs to be aligned with \"vlan\" (not with the opening parenthesis). Is this my browser issue?","commit_id":"5aa20255096fde4800ff7d66b1ed2fc0f913af59"},{"author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"change_message_id":"efac29d4836618710555214eb99200adedd2d262","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":233,"context_line":"                raise cls.skipException(msg)"},{"line_number":234,"context_line":"        if (\"vlan\" not in"},{"line_number":235,"context_line":"           config.CONF.neutron_plugin_options.available_type_drivers):"},{"line_number":236,"context_line":"            raise cls.skipException(\"VLAN type_driver is not enabled\")"},{"line_number":237,"context_line":"        if not config.CONF.neutron_plugin_options.provider_vlans:"},{"line_number":238,"context_line":"            raise cls.skipException(\"No provider VLAN networks available\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_5a96a1f2","line":235,"range":{"start_line":235,"start_character":11,"end_line":235,"end_character":68},"in_reply_to":"7ffa3b31_5a2fc13e","updated":"2017-04-18 16:47:18.000000000","message":"Done","commit_id":"5aa20255096fde4800ff7d66b1ed2fc0f913af59"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2cc09c57f97526595bcc56c4b6731f1248d69171","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                msg \u003d \"%s extension not enabled.\" % ext"},{"line_number":233,"context_line":"                raise cls.skipException(msg)"},{"line_number":234,"context_line":"        if (\"vlan\" not in"},{"line_number":235,"context_line":"           config.CONF.neutron_plugin_options.available_type_drivers):"},{"line_number":236,"context_line":"            raise cls.skipException(\"VLAN type_driver is not enabled\")"},{"line_number":237,"context_line":"        if not config.CONF.neutron_plugin_options.provider_vlans:"},{"line_number":238,"context_line":"            raise cls.skipException(\"No provider VLAN networks available\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ffa3b31_5a2fc13e","line":235,"range":{"start_line":235,"start_character":11,"end_line":235,"end_character":68},"in_reply_to":"7ffa3b31_f00d8f35","updated":"2017-04-18 16:33:23.000000000","message":"so, you can do this:\n\n  if (\"vlan\" not in\n          config.CONF.neutron_plugin_options.available_type_drivers):\n      raise cls.skipException(\"VLAN type_driver is not enabled\")\n\nExtra four spaces will help you.","commit_id":"5aa20255096fde4800ff7d66b1ed2fc0f913af59"}]}