)]}'
{"neutron/db/segments_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"412299453c15d2ac2a380b6ea7cf010901c26e4f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            NETWORK_TYPE: obj.network_type,"},{"line_number":37,"context_line":"            PHYSICAL_NETWORK: obj.physical_network,"},{"line_number":38,"context_line":"            SEGMENTATION_ID: obj.segmentation_id,"},{"line_number":39,"context_line":"            NETWORK_ID: obj.network_id}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def add_network_segment(context, network_id, segment, segment_index\u003d0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_e848c687","line":39,"updated":"2017-04-20 11:02:27.000000000","message":"This is altering the segment API with the drivers. You will need to update the ML2 tests accordingly.","commit_id":"2b727acde7311b8652aa034e1584068b110d32dc"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"7ed57d407595dc42d487cce689064fb644656cf3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            NETWORK_TYPE: obj.network_type,"},{"line_number":37,"context_line":"            PHYSICAL_NETWORK: obj.physical_network,"},{"line_number":38,"context_line":"            SEGMENTATION_ID: obj.segmentation_id,"},{"line_number":39,"context_line":"            NETWORK_ID: obj.network_id}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def add_network_segment(context, network_id, segment, segment_index\u003d0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_9d95ea35","line":39,"in_reply_to":"7ffa3b31_e848c687","updated":"2017-04-21 02:24:22.000000000","message":"Thanks, will update.","commit_id":"2b727acde7311b8652aa034e1584068b110d32dc"}],"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4c77e3dfbd0e6f19a40e526fbc727fd751c03ec3","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                \u0027Network %(network_id)s with segment %(id)s is type \u0027"},{"line_number":237,"context_line":"                \u0027of %(network_type)s but agent %(agent)s or mechanism driver \u0027"},{"line_number":238,"context_line":"                \u0027only support %(allowed_network_types)s.\u0027,"},{"line_number":239,"context_line":"                {\u0027network_id\u0027: segment.get(\u0027network_id\u0027),"},{"line_number":240,"context_line":"                 \u0027id\u0027: segment[\u0027id\u0027],"},{"line_number":241,"context_line":"                 \u0027network_type\u0027: network_type,"},{"line_number":242,"context_line":"                 \u0027agent\u0027: agent[\u0027host\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_268d9e31","line":239,"updated":"2017-04-21 08:16:39.000000000","message":"segment[\u0027network_id\u0027]\n\nit should always be present. update any tests that break this to provide it.","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"49efdbb890b5a7e3315ca4981aea0d1b207fd34d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                \u0027Network %(network_id)s with segment %(id)s is type \u0027"},{"line_number":237,"context_line":"                \u0027of %(network_type)s but agent %(agent)s or mechanism driver \u0027"},{"line_number":238,"context_line":"                \u0027only support %(allowed_network_types)s.\u0027,"},{"line_number":239,"context_line":"                {\u0027network_id\u0027: segment.get(\u0027network_id\u0027),"},{"line_number":240,"context_line":"                 \u0027id\u0027: segment[\u0027id\u0027],"},{"line_number":241,"context_line":"                 \u0027network_type\u0027: network_type,"},{"line_number":242,"context_line":"                 \u0027agent\u0027: agent[\u0027host\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_2950d10a","line":239,"in_reply_to":"7ffa3b31_268d9e31","updated":"2017-04-21 08:37:11.000000000","message":"Done","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"}],"neutron/tests/unit/plugins/ml2/_test_mech_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4c77e3dfbd0e6f19a40e526fbc727fd751c03ec3","unresolved":false,"context_lines":[{"line_number":192,"context_line":"class AgentMechanismGenericTestCase(AgentMechanismBaseTestCase):"},{"line_number":193,"context_line":"    UNKNOWN_TYPE_SEGMENTS \u003d [{api.ID: \u0027unknown_segment_id\u0027,"},{"line_number":194,"context_line":"                              api.NETWORK_TYPE: \u0027no_such_type\u0027,"},{"line_number":195,"context_line":"                              \u0027network_id\u0027: \u0027fake_network_id\u0027}]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_unknown_type(self):"},{"line_number":198,"context_line":"        context \u003d FakePortContext(self.AGENT_TYPE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_669de664","line":195,"updated":"2017-04-21 08:16:39.000000000","message":"add a new constant to api for the key so this becomes api.NETWORK_ID","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"49efdbb890b5a7e3315ca4981aea0d1b207fd34d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"class AgentMechanismGenericTestCase(AgentMechanismBaseTestCase):"},{"line_number":193,"context_line":"    UNKNOWN_TYPE_SEGMENTS \u003d [{api.ID: \u0027unknown_segment_id\u0027,"},{"line_number":194,"context_line":"                              api.NETWORK_TYPE: \u0027no_such_type\u0027,"},{"line_number":195,"context_line":"                              \u0027network_id\u0027: \u0027fake_network_id\u0027}]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_unknown_type(self):"},{"line_number":198,"context_line":"        context \u003d FakePortContext(self.AGENT_TYPE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_e95549fb","line":195,"in_reply_to":"7ffa3b31_669de664","updated":"2017-04-21 08:37:11.000000000","message":"Done","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4c77e3dfbd0e6f19a40e526fbc727fd751c03ec3","unresolved":false,"context_lines":[{"line_number":206,"context_line":"class AgentMechanismLocalTestCase(AgentMechanismBaseTestCase):"},{"line_number":207,"context_line":"    LOCAL_SEGMENTS \u003d [{api.ID: \u0027unknown_segment_id\u0027,"},{"line_number":208,"context_line":"                       api.NETWORK_TYPE: \u0027no_such_type\u0027,"},{"line_number":209,"context_line":"                       \u0027network_id\u0027: \u0027fake_network_id\u0027},"},{"line_number":210,"context_line":"                      {api.ID: \u0027local_segment_id\u0027,"},{"line_number":211,"context_line":"                       api.NETWORK_TYPE: \u0027local\u0027,"},{"line_number":212,"context_line":"                       \u0027network_id\u0027: \u0027fake_network_id\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_4698aa73","line":209,"updated":"2017-04-21 08:16:39.000000000","message":"ditto for this and the other references of \u0027network_id\u0027 in the dict.","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"49efdbb890b5a7e3315ca4981aea0d1b207fd34d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"class AgentMechanismLocalTestCase(AgentMechanismBaseTestCase):"},{"line_number":207,"context_line":"    LOCAL_SEGMENTS \u003d [{api.ID: \u0027unknown_segment_id\u0027,"},{"line_number":208,"context_line":"                       api.NETWORK_TYPE: \u0027no_such_type\u0027,"},{"line_number":209,"context_line":"                       \u0027network_id\u0027: \u0027fake_network_id\u0027},"},{"line_number":210,"context_line":"                      {api.ID: \u0027local_segment_id\u0027,"},{"line_number":211,"context_line":"                       api.NETWORK_TYPE: \u0027local\u0027,"},{"line_number":212,"context_line":"                       \u0027network_id\u0027: \u0027fake_network_id\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_c9584d32","line":209,"in_reply_to":"7ffa3b31_4698aa73","updated":"2017-04-21 08:37:11.000000000","message":"Done","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"}],"neutron/tests/unit/plugins/ml2/test_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4c77e3dfbd0e6f19a40e526fbc727fd751c03ec3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse,"},{"line_number":77,"context_line":"                         network_id\u003duuidutils.generate_uuid()):"},{"line_number":78,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":79,"context_line":"        new_segments \u003d []"},{"line_number":80,"context_line":"        for segment in segments:"},{"line_number":81,"context_line":"            segments_db.add_network_segment("},{"line_number":82,"context_line":"                self.ctx, network_id, segment,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_06906249","line":79,"updated":"2017-04-21 08:16:39.000000000","message":"a separate list shouldn\u0027t be necessary. you are just adding a value to the dictionary","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"49efdbb890b5a7e3315ca4981aea0d1b207fd34d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse,"},{"line_number":77,"context_line":"                         network_id\u003duuidutils.generate_uuid()):"},{"line_number":78,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":79,"context_line":"        new_segments \u003d []"},{"line_number":80,"context_line":"        for segment in segments:"},{"line_number":81,"context_line":"            segments_db.add_network_segment("},{"line_number":82,"context_line":"                self.ctx, network_id, segment,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_492f9d87","line":79,"in_reply_to":"7ffa3b31_06906249","updated":"2017-04-21 08:37:11.000000000","message":"Done","commit_id":"173d3a76237763e5d4a0f4b4abdd4cde885606a0"}]}
