)]}'
{"neutron/plugins/ml2/drivers/helpers.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"27812547feea44a49206b04d6bff144626d1c6a6","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # saving real exception in case we exceeded amount of attempts"},{"line_number":172,"context_line":"            raise db_exc.RetryRequest("},{"line_number":173,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def get_allocations_from_db(self, ctx):"},{"line_number":176,"context_line":"        allocations \u003d {}"},{"line_number":177,"context_line":"        allocs \u003d ctx.session.query(self.model)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_2a87aab7","line":174,"updated":"2017-04-21 01:42:24.000000000","message":"Let\u0027s put these into a subclass of segmenttypedriver.","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"906e0a841ec55039219cdc8c562df4ad3dcb561c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # saving real exception in case we exceeded amount of attempts"},{"line_number":172,"context_line":"            raise db_exc.RetryRequest("},{"line_number":173,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def get_allocations_from_db(self, ctx):"},{"line_number":176,"context_line":"        allocations \u003d {}"},{"line_number":177,"context_line":"        allocs \u003d ctx.session.query(self.model)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_badbf34c","line":174,"in_reply_to":"7ffa3b31_2a87aab7","updated":"2017-04-21 19:08:44.000000000","message":"Done","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"27812547feea44a49206b04d6bff144626d1c6a6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                if self.is_vlan:"},{"line_number":181,"context_line":"                    allocations[alloc.physical_network] \u003d set()"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    allocations[alloc.physical_network] \u003d {}"},{"line_number":184,"context_line":"            if self.is_vlan:"},{"line_number":185,"context_line":"                allocations[alloc.physical_network].add(alloc)"},{"line_number":186,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_0a906eec","line":183,"updated":"2017-04-21 01:42:24.000000000","message":"instead of putting the differentiation between vlan and others here, how about adding a method like self.populate_allocation that takes allocations and the physical network. Then vlan can implement it to make a set and add to that and QinQ can implement it to create the dict structure and add that way.","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"906e0a841ec55039219cdc8c562df4ad3dcb561c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                if self.is_vlan:"},{"line_number":181,"context_line":"                    allocations[alloc.physical_network] \u003d set()"},{"line_number":182,"context_line":"                else:"},{"line_number":183,"context_line":"                    allocations[alloc.physical_network] \u003d {}"},{"line_number":184,"context_line":"            if self.is_vlan:"},{"line_number":185,"context_line":"                allocations[alloc.physical_network].add(alloc)"},{"line_number":186,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_7ae9ebe3","line":183,"in_reply_to":"7ffa3b31_0a906eec","updated":"2017-04-21 19:08:44.000000000","message":"Done","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"27812547feea44a49206b04d6bff144626d1c6a6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                               physical_network, ranges):"},{"line_number":194,"context_line":"        if physical_network in allocations:"},{"line_number":195,"context_line":"            for alloc in allocations[physical_network]:"},{"line_number":196,"context_line":"                if self.is_vlan and alloc.vlan_id in ranges:"},{"line_number":197,"context_line":"                    ranges.remove(alloc.vlan_id)"},{"line_number":198,"context_line":"                elif self.is_vlan and not alloc.allocated:"},{"line_number":199,"context_line":"                    self.remove_unallocatable(ctx, alloc, allocations,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_ea8c22d8","line":196,"updated":"2017-04-21 01:42:24.000000000","message":"similar here, don\u0027t encode the differences between the two here in base class. make vlan implement it\u0027s approach and qinq implement its. the branching here is too hard to follow otherwise.","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"906e0a841ec55039219cdc8c562df4ad3dcb561c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                               physical_network, ranges):"},{"line_number":194,"context_line":"        if physical_network in allocations:"},{"line_number":195,"context_line":"            for alloc in allocations[physical_network]:"},{"line_number":196,"context_line":"                if self.is_vlan and alloc.vlan_id in ranges:"},{"line_number":197,"context_line":"                    ranges.remove(alloc.vlan_id)"},{"line_number":198,"context_line":"                elif self.is_vlan and not alloc.allocated:"},{"line_number":199,"context_line":"                    self.remove_unallocatable(ctx, alloc, allocations,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_5ae4ef0c","line":196,"in_reply_to":"7ffa3b31_ea8c22d8","updated":"2017-04-21 19:08:44.000000000","message":"Done","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"27812547feea44a49206b04d6bff144626d1c6a6","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        item \u003d None"},{"line_number":228,"context_line":"        if self.is_vlan:"},{"line_number":229,"context_line":"            item \u003d \u0027vlan\u0027"},{"line_number":230,"context_line":"            value \u003d filters.get(\u0027vlan_id\u0027)"},{"line_number":231,"context_line":"        else:"},{"line_number":232,"context_line":"            item \u003d \u0027s_tag\u0027"},{"line_number":233,"context_line":"            value \u003d filters.get(\u0027s_tag\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_cabf265f","line":230,"updated":"2017-04-21 01:42:24.000000000","message":"have the implementing class define the filter in __init__ of this class so you don\u0027t need this branch.","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"906e0a841ec55039219cdc8c562df4ad3dcb561c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        item \u003d None"},{"line_number":228,"context_line":"        if self.is_vlan:"},{"line_number":229,"context_line":"            item \u003d \u0027vlan\u0027"},{"line_number":230,"context_line":"            value \u003d filters.get(\u0027vlan_id\u0027)"},{"line_number":231,"context_line":"        else:"},{"line_number":232,"context_line":"            item \u003d \u0027s_tag\u0027"},{"line_number":233,"context_line":"            value \u003d filters.get(\u0027s_tag\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_fabe1bd3","line":230,"in_reply_to":"7ffa3b31_cabf265f","updated":"2017-04-21 19:08:44.000000000","message":"wasn\u0027t needed afterall","commit_id":"5028e3bf5509318222610ffe74f62fc221dc48d4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b98ef0687109999a47fcf142a15012354ca00a07","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"class VlanQinQHelper(SegmentTypeDriver):"},{"line_number":176,"context_line":"    def populate_allocation(self, db_alloc, allocations):"},{"line_number":177,"context_line":"        \"\"\"Populate allocations dictionary with the current"},{"line_number":178,"context_line":"        allocation from the database, db_alloc."}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_35dc5b73","line":175,"updated":"2017-04-23 19:41:42.000000000","message":"maybe call this PhysnetAllocationHelper instead of VlanQinQHelper so it\u0027s not specific to two drivers.","commit_id":"93307ef9cbf3692f199899af1f4ffe8bcfe27669"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"89ed586faf1f60dbd61fc2b2501ee7f7a16b046c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"class VlanQinQHelper(SegmentTypeDriver):"},{"line_number":176,"context_line":"    def populate_allocation(self, db_alloc, allocations):"},{"line_number":177,"context_line":"        \"\"\"Populate allocations dictionary with the current"},{"line_number":178,"context_line":"        allocation from the database, db_alloc."}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_24be5865","line":175,"in_reply_to":"5ff73747_35dc5b73","updated":"2017-04-24 14:58:23.000000000","message":"Done","commit_id":"93307ef9cbf3692f199899af1f4ffe8bcfe27669"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c559608a8bea920286d5ac64e631796e27e5eff0","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                  \"deleted\","},{"line_number":112,"context_line":"                                  {\"type\": network_type,"},{"line_number":113,"context_line":"                                   \"segment\": raw_segment})"},{"line_number":114,"context_line":"                if \u0027c_tag\u0027 in self.primary_keys and \u0027c_tag\u0027 not in raw_segment:"},{"line_number":115,"context_line":"                    raw_segment[\u0027c_tag\u0027] \u003d random.choice("},{"line_number":116,"context_line":"                        range(p_const.MIN_VLAN_TAG, p_const.MAX_VLAN_TAG + 1))"},{"line_number":117,"context_line":"                # Segment to create or already allocated"},{"line_number":118,"context_line":"                LOG.debug(\"%(type)s segment %(segment)s create started\","},{"line_number":119,"context_line":"                          {\"type\": network_type, \"segment\": raw_segment})"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_aa6c7b36","line":116,"range":{"start_line":114,"start_character":16,"end_line":116,"end_character":78},"updated":"2017-05-18 09:12:14.000000000","message":"Is this part of this patch? Shouldn\u0027t be in https://review.openstack.org/#/c/446047/? This is just a question","commit_id":"65f68ce422c033ed7c22704266fcb1811d4e785d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"c362e733a09f268a730f634dae69c4847cb1c44c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                  \"deleted\","},{"line_number":112,"context_line":"                                  {\"type\": network_type,"},{"line_number":113,"context_line":"                                   \"segment\": raw_segment})"},{"line_number":114,"context_line":"                if \u0027c_tag\u0027 in self.primary_keys and \u0027c_tag\u0027 not in raw_segment:"},{"line_number":115,"context_line":"                    raw_segment[\u0027c_tag\u0027] \u003d random.choice("},{"line_number":116,"context_line":"                        range(p_const.MIN_VLAN_TAG, p_const.MAX_VLAN_TAG + 1))"},{"line_number":117,"context_line":"                # Segment to create or already allocated"},{"line_number":118,"context_line":"                LOG.debug(\"%(type)s segment %(segment)s create started\","},{"line_number":119,"context_line":"                          {\"type\": network_type, \"segment\": raw_segment})"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_07f0f566","line":116,"range":{"start_line":114,"start_character":16,"end_line":116,"end_character":78},"in_reply_to":"ff0f0b1f_4776ed08","updated":"2017-05-18 14:38:36.000000000","message":"I\u0027ll try it again.","commit_id":"65f68ce422c033ed7c22704266fcb1811d4e785d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"1b9896e4cc2c12a1e7258ccc510152c6ee4ab8ba","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                  \"deleted\","},{"line_number":112,"context_line":"                                  {\"type\": network_type,"},{"line_number":113,"context_line":"                                   \"segment\": raw_segment})"},{"line_number":114,"context_line":"                if \u0027c_tag\u0027 in self.primary_keys and \u0027c_tag\u0027 not in raw_segment:"},{"line_number":115,"context_line":"                    raw_segment[\u0027c_tag\u0027] \u003d random.choice("},{"line_number":116,"context_line":"                        range(p_const.MIN_VLAN_TAG, p_const.MAX_VLAN_TAG + 1))"},{"line_number":117,"context_line":"                # Segment to create or already allocated"},{"line_number":118,"context_line":"                LOG.debug(\"%(type)s segment %(segment)s create started\","},{"line_number":119,"context_line":"                          {\"type\": network_type, \"segment\": raw_segment})"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_4776ed08","line":116,"range":{"start_line":114,"start_character":16,"end_line":116,"end_character":78},"in_reply_to":"ff0f0b1f_aa6c7b36","updated":"2017-05-18 14:36:34.000000000","message":"Oh I miss interpreted your question, I see what you mean now. I tried and had a difficult time getting this to work in the other patch nicely..","commit_id":"65f68ce422c033ed7c22704266fcb1811d4e785d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2b90f004540d8ebfd8551ef490920fd3544aecfb","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class PhysnetAllocationHelper(SegmentTypeDriver):"},{"line_number":179,"context_line":"    def populate_allocation(self, db_alloc, allocations):"},{"line_number":180,"context_line":"        \"\"\"Populate allocations dictionary with the current"},{"line_number":181,"context_line":"        allocation from the database, db_alloc."}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_40481bcb","line":178,"updated":"2017-05-18 12:02:27.000000000","message":"what about unit tests for this new class","commit_id":"65f68ce422c033ed7c22704266fcb1811d4e785d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"27d08170e7a3825756677f766df8eadc12ff21af","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class PhysnetAllocationHelper(SegmentTypeDriver):"},{"line_number":179,"context_line":"    def populate_allocation(self, db_alloc, allocations):"},{"line_number":180,"context_line":"        \"\"\"Populate allocations dictionary with the current"},{"line_number":181,"context_line":"        allocation from the database, db_alloc."}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_c1d09ffa","line":178,"in_reply_to":"ff0f0b1f_40481bcb","updated":"2017-05-18 20:18:38.000000000","message":"I was trying to write tests for this, I had trouble becaues it\u0027s an abstract class. I created a dummy class with the methods implemented but then I found the tests to be quite useless. After looking at the jobs you can see unit tests are not needed, you can see the coverage job called neutron-coverage-ubuntu-xenial in the jenkins check.\n\nHere is the link for this patch:\nhttp://logs.openstack.org/31/458531/7/check/neutron-coverage-ubuntu-xenial/1f9f6dd/cover/neutron_plugins_ml2_drivers_helpers_py.html","commit_id":"65f68ce422c033ed7c22704266fcb1811d4e785d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4f6295711473c6a1b03630a1e411c03941e0db9d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                  \"deleted\","},{"line_number":112,"context_line":"                                  {\"type\": network_type,"},{"line_number":113,"context_line":"                                   \"segment\": raw_segment})"},{"line_number":114,"context_line":"                self.add_c_tag_to_segment_to_create_or_already_allocated("},{"line_number":115,"context_line":"                    raw_segment)"},{"line_number":116,"context_line":"                # Segment to create or already allocated"},{"line_number":117,"context_line":"                LOG.debug(\"%(type)s segment %(segment)s create started\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_bf1b6d19","line":114,"range":{"start_line":114,"start_character":21,"end_line":114,"end_character":72},"updated":"2017-05-19 14:55:44.000000000","message":"Yes, that makes more sense. That is what I was talking about in my previous comment.\n\nBut \"add_c_tag_to_segment_to_create_or_already_allocated\" is defined in PhysnetAllocationHelper. Current class, SegmentTypeDriver, inherits from BaseTypeDriver. This function is not in this class.","commit_id":"7bebd6d8e3c6577e698cf3436bfc00ac4922a75a"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e87072e3406888d843ad265498b54607a1112f14","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                  \"deleted\","},{"line_number":112,"context_line":"                                  {\"type\": network_type,"},{"line_number":113,"context_line":"                                   \"segment\": raw_segment})"},{"line_number":114,"context_line":"                self.add_c_tag_to_segment_to_create_or_already_allocated("},{"line_number":115,"context_line":"                    raw_segment)"},{"line_number":116,"context_line":"                # Segment to create or already allocated"},{"line_number":117,"context_line":"                LOG.debug(\"%(type)s segment %(segment)s create started\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_3f5cfd7c","line":114,"range":{"start_line":114,"start_character":21,"end_line":114,"end_character":72},"in_reply_to":"ff0f0b1f_bf1b6d19","updated":"2017-05-19 15:00:25.000000000","message":"yes this rebasing is causing me all kinds of trouble..","commit_id":"7bebd6d8e3c6577e698cf3436bfc00ac4922a75a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4f6295711473c6a1b03630a1e411c03941e0db9d","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        to allocate, a new entry must be created with an unallocated c_tag"},{"line_number":225,"context_line":"        within the range of the configured tag ranges, if any."},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_bfda4d14","line":227,"range":{"start_line":227,"start_character":7,"end_line":227,"end_character":35},"updated":"2017-05-19 14:55:44.000000000","message":"I think you should move this function to \"SegmentTypeDriver\".\n\nAnother thing. If you move this to \"SegmentTypeDriver\", to mantain backwards compatibility, this function should return \"pass\". If any driver type (qinq) wants to overwritte this function, is ok. But the rest of them shouldn\u0027t do it.","commit_id":"7bebd6d8e3c6577e698cf3436bfc00ac4922a75a"},{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"10fb9d8b551b4aeb11826e7d79485c9f46957e8d","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            raise db_exc.RetryRequest("},{"line_number":173,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def add_c_tag_to_segment_to_create_or_already_allocated(self, raw_segment):"},{"line_number":176,"context_line":"        \"\"\"This method is to be used for c_tags only in the case of"},{"line_number":177,"context_line":"        reserving a provider segment when there are no database entries"},{"line_number":178,"context_line":"        to allocate, a new entry must be created with an unallocated c_tag"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_9297d745","line":175,"updated":"2017-05-25 14:55:08.000000000","message":"I think the method should be called add_c_tag_to_segment(). The fact that it needs to be created using defaults (I am looking at the implementation of this method in the qinq type driver) or updated with a pre allocated range, is an implementation detail.","commit_id":"3e2f9395494eb9c69480263993ce92c47936bb7c"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"20aa6dba1cbc5f1cba4d807bc49b0290937d5106","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            raise db_exc.RetryRequest("},{"line_number":173,"context_line":"                exc.NoNetworkFoundInMaximumAllowedAttempts())"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def add_c_tag_to_segment_to_create_or_already_allocated(self, raw_segment):"},{"line_number":176,"context_line":"        \"\"\"This method is to be used for c_tags only in the case of"},{"line_number":177,"context_line":"        reserving a provider segment when there are no database entries"},{"line_number":178,"context_line":"        to allocate, a new entry must be created with an unallocated c_tag"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_28186a1b","line":175,"in_reply_to":"ff0f0b1f_9297d745","updated":"2017-05-30 12:58:56.000000000","message":"Done","commit_id":"3e2f9395494eb9c69480263993ce92c47936bb7c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8cb77f4e776bdd466927fa12ef00d130909d616c","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def get_allocations_from_db(self, ctx):"},{"line_number":195,"context_line":"        allocations \u003d {}"},{"line_number":196,"context_line":"        allocs \u003d ctx.session.query(self.model)"},{"line_number":197,"context_line":"        for alloc in allocs:"},{"line_number":198,"context_line":"            self.populate_allocation(alloc, allocations)"},{"line_number":199,"context_line":"        return allocs, allocations"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_f50b07d3","line":196,"updated":"2017-07-04 17:54:07.000000000","message":"With the merge of https://review.openstack.org/#/c/367810/, we should we using the VlanAllocation OVO to access the DB, shouldn\u0027t we?","commit_id":"2221427772bb47ea9d58342363f360cf73bd64b2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"85170d6aa70ae027b1429b8dc1e3181a534d7fa0","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def get_allocations_from_db(self, ctx):"},{"line_number":195,"context_line":"        allocations \u003d {}"},{"line_number":196,"context_line":"        allocs \u003d ctx.session.query(self.model)"},{"line_number":197,"context_line":"        for alloc in allocs:"},{"line_number":198,"context_line":"            self.populate_allocation(alloc, allocations)"},{"line_number":199,"context_line":"        return allocs, allocations"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_b0b47dd2","line":196,"in_reply_to":"3f1d235d_f50b07d3","updated":"2017-07-04 18:29:54.000000000","message":"Nevermind. I see what you are doing","commit_id":"2221427772bb47ea9d58342363f360cf73bd64b2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8cb77f4e776bdd466927fa12ef00d130909d616c","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # allocated segments. If someone has"},{"line_number":223,"context_line":"        # already allocated, count will return 0 so"},{"line_number":224,"context_line":"        # we don\u0027t delete."},{"line_number":225,"context_line":"        count \u003d db_allocs.filter_by(allocated\u003dFalse,"},{"line_number":226,"context_line":"                                    physical_network\u003dphysical_network,"},{"line_number":227,"context_line":"                                    **filters).update({\"allocated\": False})"},{"line_number":228,"context_line":"        if count:"},{"line_number":229,"context_line":"            ctx.session.delete(alloc)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_75d937f1","line":229,"range":{"start_line":225,"start_character":0,"end_line":229,"end_character":37},"updated":"2017-07-04 17:54:07.000000000","message":"Same here. I think we should go through the OVO layer","commit_id":"2221427772bb47ea9d58342363f360cf73bd64b2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"85170d6aa70ae027b1429b8dc1e3181a534d7fa0","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # allocated segments. If someone has"},{"line_number":223,"context_line":"        # already allocated, count will return 0 so"},{"line_number":224,"context_line":"        # we don\u0027t delete."},{"line_number":225,"context_line":"        count \u003d db_allocs.filter_by(allocated\u003dFalse,"},{"line_number":226,"context_line":"                                    physical_network\u003dphysical_network,"},{"line_number":227,"context_line":"                                    **filters).update({\"allocated\": False})"},{"line_number":228,"context_line":"        if count:"},{"line_number":229,"context_line":"            ctx.session.delete(alloc)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3f1d235d_90cd0168","line":229,"range":{"start_line":225,"start_character":0,"end_line":229,"end_character":37},"in_reply_to":"3f1d235d_75d937f1","updated":"2017-07-04 18:29:54.000000000","message":"Nevermind. Please disregard","commit_id":"2221427772bb47ea9d58342363f360cf73bd64b2"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e0f6959d840bb2096aa6a346be03b04c54fb3a3f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def __init__(self, model):"},{"line_number":61,"context_line":"        super(SegmentTypeDriver, self).__init__()"},{"line_number":62,"context_line":"        self.is_obj \u003d issubclass(model, base_obj.NeutronDbObject)"},{"line_number":63,"context_line":"        if self.is_obj:"},{"line_number":64,"context_line":"            self.model \u003d model.db_model"},{"line_number":65,"context_line":"            self.model_obj \u003d model"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            self.model \u003d model"},{"line_number":68,"context_line":"        self.primary_keys \u003d set(dict(self.model.__table__.columns))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_f94be427","line":65,"range":{"start_line":63,"start_character":8,"end_line":65,"end_character":34},"updated":"2017-07-05 15:15:19.000000000","message":"maybe there is a better way of doing this?","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3785cd71762cc119f446d7b0201fffe35c111445","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def __init__(self, model):"},{"line_number":61,"context_line":"        super(SegmentTypeDriver, self).__init__()"},{"line_number":62,"context_line":"        self.is_obj \u003d issubclass(model, base_obj.NeutronDbObject)"},{"line_number":63,"context_line":"        if self.is_obj:"},{"line_number":64,"context_line":"            self.model \u003d model.db_model"},{"line_number":65,"context_line":"            self.model_obj \u003d model"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            self.model \u003d model"},{"line_number":68,"context_line":"        self.primary_keys \u003d set(dict(self.model.__table__.columns))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_1a7564cb","line":65,"range":{"start_line":63,"start_character":8,"end_line":65,"end_character":34},"in_reply_to":"3f1d235d_f94be427","updated":"2017-07-05 21:45:04.000000000","message":"We are having facing this situation because on the one hand for the vlan type we have an OVO and for the QinQ type we don\u0027t. How about fixing the problem with an OVO for the QinQ type, so in this module we can assume we have always an object and we don\u0027t need to handle special cases?\n\nMy assumption yesterday was that, while implementing an OVO for the QinQ type, you wanted to handle the DB layer directly here","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c6c48460f99b49e76c51a6ef7bd17b170295c04","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        raise NotImplementedError()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_allocations_from_db(self, ctx):"},{"line_number":197,"context_line":"        allocations \u003d {}"},{"line_number":198,"context_line":"        if self.is_obj:"},{"line_number":199,"context_line":"            allocs \u003d self.model_obj.get_objects(ctx)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_47a775be","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":23},"updated":"2017-07-06 08:55:21.000000000","message":"why not call this method - get_allocations?","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e0f6959d840bb2096aa6a346be03b04c54fb3a3f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        raise NotImplementedError()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_allocations_from_db(self, ctx):"},{"line_number":197,"context_line":"        allocations \u003d {}"},{"line_number":198,"context_line":"        if self.is_obj:"},{"line_number":199,"context_line":"            allocs \u003d self.model_obj.get_objects(ctx)"},{"line_number":200,"context_line":"        else:"},{"line_number":201,"context_line":"            allocs \u003d ctx.session.query(self.model)"},{"line_number":202,"context_line":"        for alloc in allocs:"},{"line_number":203,"context_line":"            self.populate_allocation(alloc, allocations)"},{"line_number":204,"context_line":"        return allocs, allocations"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def update_network_ranges(self, ctx, alloc, ranges, allocations,"},{"line_number":207,"context_line":"                              db_allocs, physical_network):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_f974046a","line":204,"range":{"start_line":196,"start_character":4,"end_line":204,"end_character":34},"updated":"2017-07-05 15:15:19.000000000","message":"maybe this should be type_* specific?","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3785cd71762cc119f446d7b0201fffe35c111445","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\""},{"line_number":194,"context_line":"        raise NotImplementedError()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_allocations_from_db(self, ctx):"},{"line_number":197,"context_line":"        allocations \u003d {}"},{"line_number":198,"context_line":"        if self.is_obj:"},{"line_number":199,"context_line":"            allocs \u003d self.model_obj.get_objects(ctx)"},{"line_number":200,"context_line":"        else:"},{"line_number":201,"context_line":"            allocs \u003d ctx.session.query(self.model)"},{"line_number":202,"context_line":"        for alloc in allocs:"},{"line_number":203,"context_line":"            self.populate_allocation(alloc, allocations)"},{"line_number":204,"context_line":"        return allocs, allocations"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def update_network_ranges(self, ctx, alloc, ranges, allocations,"},{"line_number":207,"context_line":"                              db_allocs, physical_network):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_3a0f0038","line":204,"range":{"start_line":196,"start_character":4,"end_line":204,"end_character":34},"in_reply_to":"3f1d235d_f974046a","updated":"2017-07-05 21:45:04.000000000","message":"See comment above","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6c6c48460f99b49e76c51a6ef7bd17b170295c04","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        # allocated segments. If someone has"},{"line_number":228,"context_line":"        # already allocated, count will return 0 so"},{"line_number":229,"context_line":"        # we don\u0027t delete."},{"line_number":230,"context_line":"        if self.is_obj and self.model_obj.update_objects("},{"line_number":231,"context_line":"                               ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":232,"context_line":"                               allocated\u003dFalse, vlan_id\u003dalloc.vlan_id,"},{"line_number":233,"context_line":"                               physical_network\u003dphysical_network):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_079bbd65","line":230,"updated":"2017-07-06 08:55:21.000000000","message":"should this not be:\nif self.obj:\n    if self.model_obj.update_objects ...\n        alloc.delete()\n\nIf the object exists and the objects returns a empty set then it will do and delete from the db.","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e0f6959d840bb2096aa6a346be03b04c54fb3a3f","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                           db_allocs, physical_network)"},{"line_number":217,"context_line":"            del allocations[physical_network]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def remove_unallocatable(self, ctx, alloc, db_allocs, physical_network,"},{"line_number":220,"context_line":"                             log_info, **filters):"},{"line_number":221,"context_line":"        LOG.debug(\"Removing %(item)s %(value)s on physical network \""},{"line_number":222,"context_line":"                  \"%(physical_network)s from pool\", **log_info)"},{"line_number":223,"context_line":"        # This UPDATE WHERE statement blocks anyone"},{"line_number":224,"context_line":"        # from concurrently changing the allocation"},{"line_number":225,"context_line":"        # values to True while our transaction is"},{"line_number":226,"context_line":"        # open so we don\u0027t accidentally delete"},{"line_number":227,"context_line":"        # allocated segments. If someone has"},{"line_number":228,"context_line":"        # already allocated, count will return 0 so"},{"line_number":229,"context_line":"        # we don\u0027t delete."},{"line_number":230,"context_line":"        if self.is_obj and self.model_obj.update_objects("},{"line_number":231,"context_line":"                               ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":232,"context_line":"                               allocated\u003dFalse, vlan_id\u003dalloc.vlan_id,"},{"line_number":233,"context_line":"                               physical_network\u003dphysical_network):"},{"line_number":234,"context_line":"            alloc.delete()"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            count \u003d db_allocs.filter_by(allocated\u003dFalse,"},{"line_number":237,"context_line":"                                        physical_network\u003dphysical_network,"},{"line_number":238,"context_line":"                                        **filters).update({\"allocated\": False})"},{"line_number":239,"context_line":"            if count:"},{"line_number":240,"context_line":"                ctx.session.delete(alloc)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_7906b4d0","line":240,"range":{"start_line":219,"start_character":4,"end_line":240,"end_character":41},"updated":"2017-07-05 15:15:19.000000000","message":"maybe this should be type_* specifc?","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3785cd71762cc119f446d7b0201fffe35c111445","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                           db_allocs, physical_network)"},{"line_number":217,"context_line":"            del allocations[physical_network]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def remove_unallocatable(self, ctx, alloc, db_allocs, physical_network,"},{"line_number":220,"context_line":"                             log_info, **filters):"},{"line_number":221,"context_line":"        LOG.debug(\"Removing %(item)s %(value)s on physical network \""},{"line_number":222,"context_line":"                  \"%(physical_network)s from pool\", **log_info)"},{"line_number":223,"context_line":"        # This UPDATE WHERE statement blocks anyone"},{"line_number":224,"context_line":"        # from concurrently changing the allocation"},{"line_number":225,"context_line":"        # values to True while our transaction is"},{"line_number":226,"context_line":"        # open so we don\u0027t accidentally delete"},{"line_number":227,"context_line":"        # allocated segments. If someone has"},{"line_number":228,"context_line":"        # already allocated, count will return 0 so"},{"line_number":229,"context_line":"        # we don\u0027t delete."},{"line_number":230,"context_line":"        if self.is_obj and self.model_obj.update_objects("},{"line_number":231,"context_line":"                               ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":232,"context_line":"                               allocated\u003dFalse, vlan_id\u003dalloc.vlan_id,"},{"line_number":233,"context_line":"                               physical_network\u003dphysical_network):"},{"line_number":234,"context_line":"            alloc.delete()"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            count \u003d db_allocs.filter_by(allocated\u003dFalse,"},{"line_number":237,"context_line":"                                        physical_network\u003dphysical_network,"},{"line_number":238,"context_line":"                                        **filters).update({\"allocated\": False})"},{"line_number":239,"context_line":"            if count:"},{"line_number":240,"context_line":"                ctx.session.delete(alloc)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_fa04e819","line":240,"range":{"start_line":219,"start_character":4,"end_line":240,"end_character":41},"in_reply_to":"3f1d235d_7906b4d0","updated":"2017-07-05 21:45:04.000000000","message":"See comment above","commit_id":"befbfa0a2cdb7470b8278ff41a084de2293cc0ae"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"81ab969709a92b8c217bbdb5b443f942e3965489","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                      \"started with %(segment)s \","},{"line_number":157,"context_line":"                      {\"type\": network_type,"},{"line_number":158,"context_line":"                       \"segment\": raw_segment})"},{"line_number":159,"context_line":"            count \u003d (session.query(self.model)."},{"line_number":160,"context_line":"                     filter_by(allocated\u003dFalse, **raw_segment)."},{"line_number":161,"context_line":"                     update({\"allocated\": True}))"},{"line_number":162,"context_line":"            if count:"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f1d235d_f680d148","side":"PARENT","line":159,"updated":"2017-07-11 22:31:54.000000000","message":"can you split this into two patches? this seems like two changes to me, one to change all of this from performing direct SQL and another for the new helper.","commit_id":"d2f59caf14fff49bccf06ee8af6df7ee627b87c8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6d0e276f6702ffbb57b9e7a62a6942f780338933","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                  \"deleted\","},{"line_number":115,"context_line":"                                  {\"type\": network_type,"},{"line_number":116,"context_line":"                                   \"segment\": raw_segment})"},{"line_number":117,"context_line":"                self.add_c_tag_to_segment(raw_segment)"},{"line_number":118,"context_line":"                # Segment to create or already allocated"},{"line_number":119,"context_line":"                LOG.debug(\"%(type)s segment %(segment)s create started\","},{"line_number":120,"context_line":"                          {\"type\": network_type, \"segment\": raw_segment})"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff346bd7_4adfc50c","line":117,"updated":"2017-07-27 00:22:35.000000000","message":"we need to call this something else generic (e.g. \u0027_prepare_raw_segment\u0027). c_tag doesn\u0027t make sense for most users of this class","commit_id":"26b5879cd73d27da40d1e766e0ffc48359ad25ff"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"d48143a165d92b8d24c9a2fb052d57345fe5fcb2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                  \"deleted\","},{"line_number":115,"context_line":"                                  {\"type\": network_type,"},{"line_number":116,"context_line":"                                   \"segment\": raw_segment})"},{"line_number":117,"context_line":"                self.add_c_tag_to_segment(raw_segment)"},{"line_number":118,"context_line":"                # Segment to create or already allocated"},{"line_number":119,"context_line":"                LOG.debug(\"%(type)s segment %(segment)s create started\","},{"line_number":120,"context_line":"                          {\"type\": network_type, \"segment\": raw_segment})"}],"source_content_type":"text/x-python","patch_set":28,"id":"df3967d1_2cffc667","line":117,"in_reply_to":"ff346bd7_4adfc50c","updated":"2017-08-04 19:29:49.000000000","message":"Done","commit_id":"26b5879cd73d27da40d1e766e0ffc48359ad25ff"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6d0e276f6702ffbb57b9e7a62a6942f780338933","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # already allocated, update_objects count"},{"line_number":223,"context_line":"        # will return 0 so we don\u0027t delete."},{"line_number":224,"context_line":"        if self.ovo_class.update_objects(ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":225,"context_line":"                                         physical_network\u003dphysical_network,"},{"line_number":226,"context_line":"                                         **filters):"},{"line_number":227,"context_line":"            alloc.delete()"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff346bd7_2ae481e0","line":225,"updated":"2017-07-27 00:22:35.000000000","message":"looks like we lost the allocated\u003dFalse from there. That\u0027s critical because it\u0027s what guarantees us that we are only touching a record in the allocated\u003dFalse state.","commit_id":"26b5879cd73d27da40d1e766e0ffc48359ad25ff"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"d48143a165d92b8d24c9a2fb052d57345fe5fcb2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # already allocated, update_objects count"},{"line_number":223,"context_line":"        # will return 0 so we don\u0027t delete."},{"line_number":224,"context_line":"        if self.ovo_class.update_objects(ctx, values\u003d{\u0027allocated\u0027: False},"},{"line_number":225,"context_line":"                                         physical_network\u003dphysical_network,"},{"line_number":226,"context_line":"                                         **filters):"},{"line_number":227,"context_line":"            alloc.delete()"}],"source_content_type":"text/x-python","patch_set":28,"id":"df3967d1_6c094e94","line":225,"in_reply_to":"ff346bd7_2ae481e0","updated":"2017-08-04 19:29:49.000000000","message":"Done","commit_id":"26b5879cd73d27da40d1e766e0ffc48359ad25ff"}],"neutron/plugins/ml2/drivers/type_vlan.py":[{"author":{"_account_id":6697,"name":"Sandhya Dasu","email":"sandhya.openinfra@gmail.com","username":"sadasu"},"change_message_id":"10fb9d8b551b4aeb11826e7d79485c9f46957e8d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                self.process_network_ranges(ctx, allocations, allocs,"},{"line_number":81,"context_line":"                                            physical_network, vlan_ids)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                for vlan_id in sorted(vlan_ids):"},{"line_number":84,"context_line":"                    alloc \u003d vlan_alloc_model.VlanAllocation("},{"line_number":85,"context_line":"                                           physical_network\u003dphysical_network,"},{"line_number":86,"context_line":"                                           vlan_id\u003dvlan_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_ed2634ce","line":83,"updated":"2017-05-25 14:55:08.000000000","message":"Nit: I think the original code had a comment here which probably got deleted by accident.\n\"# add missing allocatable vlans to table\"","commit_id":"3e2f9395494eb9c69480263993ce92c47936bb7c"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"20aa6dba1cbc5f1cba4d807bc49b0290937d5106","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                self.process_network_ranges(ctx, allocations, allocs,"},{"line_number":81,"context_line":"                                            physical_network, vlan_ids)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                for vlan_id in sorted(vlan_ids):"},{"line_number":84,"context_line":"                    alloc \u003d vlan_alloc_model.VlanAllocation("},{"line_number":85,"context_line":"                                           physical_network\u003dphysical_network,"},{"line_number":86,"context_line":"                                           vlan_id\u003dvlan_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"df140735_08d3663a","line":83,"in_reply_to":"ff0f0b1f_ed2634ce","updated":"2017-05-30 12:58:56.000000000","message":"Done","commit_id":"3e2f9395494eb9c69480263993ce92c47936bb7c"}]}
