)]}'
{"devstack/lib/ovs":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8a5b7f81b92bb4479b5895f3037955092dee38a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    sudo make install"},{"line_number":184,"context_line":"    if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":185,"context_line":"        sudo make INSTALL_MOD_DIR\u003dkernel/net/openvswitch modules_install"},{"line_number":186,"context_line":"        sudo modprobe -r vport_geneve"},{"line_number":187,"context_line":"        sudo modprobe -r openvswitch"},{"line_number":188,"context_line":"        load_module openvswitch"},{"line_number":189,"context_line":"        load_module vport-geneve False"},{"line_number":190,"context_line":"        dmesg | tail"},{"line_number":191,"context_line":"    fi"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    cd $_pwd"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7ffa3b31_0372a249","line":190,"range":{"start_line":186,"start_character":8,"end_line":190,"end_character":20},"updated":"2017-04-20 19:05:02.000000000","message":"should we move this snippet into a common function? \u0027reload_ovs_modules\u0027?","commit_id":"37307ceaf7421bfad0fae30576dc853d7ca85c23"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8346826142543c3ff320f58308dbd006e5bc7fd8","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    sudo make install"},{"line_number":184,"context_line":"    if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":185,"context_line":"        sudo make INSTALL_MOD_DIR\u003dkernel/net/openvswitch modules_install"},{"line_number":186,"context_line":"        sudo modprobe -r vport_geneve"},{"line_number":187,"context_line":"        sudo modprobe -r openvswitch"},{"line_number":188,"context_line":"        load_module openvswitch"},{"line_number":189,"context_line":"        load_module vport-geneve False"},{"line_number":190,"context_line":"        dmesg | tail"},{"line_number":191,"context_line":"    fi"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    cd $_pwd"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7ffa3b31_c605e812","line":190,"range":{"start_line":186,"start_character":8,"end_line":190,"end_character":20},"in_reply_to":"7ffa3b31_0372a249","updated":"2017-04-20 19:24:16.000000000","message":"Done","commit_id":"37307ceaf7421bfad0fae30576dc853d7ca85c23"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8a5b7f81b92bb4479b5895f3037955092dee38a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        ./configure --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":224,"context_line":"    fi"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    action_openvswitch stop"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    make -j$[$(nproc) + 1]"},{"line_number":229,"context_line":"    sudo make INSTALL_MOD_DIR\u003dkernel/net/openvswitch modules_install"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7ffa3b31_43a1ca93","line":226,"updated":"2017-04-20 19:05:02.000000000","message":"Any reason why people may want to avoid stop/start when injecting kernel module from inside compile_ovs? I think it may also go into reload_ovs_modules function.","commit_id":"37307ceaf7421bfad0fae30576dc853d7ca85c23"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ab298b7a84112e597d6ec25c67fb56de8c80128f","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        ./configure --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":224,"context_line":"    fi"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    action_openvswitch stop"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    make -j$[$(nproc) + 1]"},{"line_number":229,"context_line":"    sudo make INSTALL_MOD_DIR\u003dkernel/net/openvswitch modules_install"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7ffa3b31_83e912b8","line":226,"in_reply_to":"7ffa3b31_43a1ca93","updated":"2017-04-20 19:08:07.000000000","message":"The compile_ovs uninstalls the package which stops the service. So it\u0027s relevant only for this function.","commit_id":"37307ceaf7421bfad0fae30576dc853d7ca85c23"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e8a5b7f81b92bb4479b5895f3037955092dee38a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # Because of bug present in current Ubuntu Xenial kernel version"},{"line_number":69,"context_line":"    # we need a fix for VXLAN local tunneling."},{"line_number":70,"context_line":"    if [[ \"$VENV\" \u003d~ \"dsvm-fullstack\" ]]; then"},{"line_number":71,"context_line":"        upgrade_ovs_if_necessary"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # prepare base environment for ./stack.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7ffa3b31_835c72ed","side":"PARENT","line":71,"updated":"2017-04-20 19:05:02.000000000","message":"seems like we no longer use the function except in sfc. Should we issue a deprecation warning from there? Then eventually sfc will either adopt the function, or switch to some other means, and we will be able to kill it.","commit_id":"6ecdfbb82b18d1208d21a60874105c1aecbb5751"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ac9a852d8be4ab427ad07fb7ef9ca283502f2d3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # Because of bug present in current Ubuntu Xenial kernel version"},{"line_number":69,"context_line":"    # we need a fix for VXLAN local tunneling."},{"line_number":70,"context_line":"    if [[ \"$VENV\" \u003d~ \"dsvm-fullstack\" ]]; then"},{"line_number":71,"context_line":"        upgrade_ovs_if_necessary"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # prepare base environment for ./stack.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7ffa3b31_a9a2affa","side":"PARENT","line":71,"in_reply_to":"7ffa3b31_23f11e96","updated":"2017-04-20 20:07:52.000000000","message":"Well I want to make the intent clear that we want to get rid of it in the devstack plugin.","commit_id":"6ecdfbb82b18d1208d21a60874105c1aecbb5751"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ab298b7a84112e597d6ec25c67fb56de8c80128f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # Because of bug present in current Ubuntu Xenial kernel version"},{"line_number":69,"context_line":"    # we need a fix for VXLAN local tunneling."},{"line_number":70,"context_line":"    if [[ \"$VENV\" \u003d~ \"dsvm-fullstack\" ]]; then"},{"line_number":71,"context_line":"        upgrade_ovs_if_necessary"},{"line_number":72,"context_line":"    fi"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # prepare base environment for ./stack.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7ffa3b31_23f11e96","side":"PARENT","line":71,"in_reply_to":"7ffa3b31_835c72ed","updated":"2017-04-20 19:08:07.000000000","message":"Yeah, I checked before that sfc uses it, that\u0027s why I didn\u0027t removed it. I plan to look at why would sfc use a compilation and eventually remove it  or update it there. I don\u0027t think deprecation warning is necessary since it\u0027s used only there, is it?","commit_id":"6ecdfbb82b18d1208d21a60874105c1aecbb5751"}]}