)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0c016c979d721b76a4aa70182c86262188c28ec5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DHCP: Separate local from non-local subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to allow the DHCP agent to service other subnets"},{"line_number":10,"context_line":"on the network in other segments via DHCP relay, we need to"},{"line_number":11,"context_line":"return all subnets regardless of segment association."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, this behavior will break older DHCP agents that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_105167d9","line":10,"updated":"2017-05-29 12:51:21.000000000","message":"where in the API do we enable DHCP relay?","commit_id":"be66e639541ccc4f69e83489ccc12128edaa6b9e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3dfd50f8896d70107349529efa1c670f7bf79f03","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DHCP: Separate local from non-local subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to allow the DHCP agent to service other subnets"},{"line_number":10,"context_line":"on the network in other segments via DHCP relay, we need to"},{"line_number":11,"context_line":"return all subnets regardless of segment association."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, this behavior will break older DHCP agents that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_72e83ee1","line":10,"in_reply_to":"df140735_105167d9","updated":"2017-06-01 19:38:12.000000000","message":"Gary - we don\u0027t enable DHCP relay in neutron, that\u0027s out of scope for this change.  But we should be able to support the case where we get a DHCP request for a known subnet, but we are not connected to it (segment_id doesn\u0027t exist locally).","commit_id":"be66e639541ccc4f69e83489ccc12128edaa6b9e"}],"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c19d092502e7eb22c32222ec7eb83daad50bcfd2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # segments as the host.  Do this only for the networks that are"},{"line_number":172,"context_line":"            # routed because we want non-routed networks to work as"},{"line_number":173,"context_line":"            # before."},{"line_number":174,"context_line":"            nonlocal_subnets \u003d [subnet for subnet in subnets"},{"line_number":175,"context_line":"                                if subnet[\u0027id\u0027] not in seg_subnet_ids]"},{"line_number":176,"context_line":"            subnets \u003d [subnet for subnet in subnets"},{"line_number":177,"context_line":"                       if subnet[\u0027network_id\u0027] not in routed_net_ids or"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_c02c5dad","line":174,"range":{"start_line":174,"start_character":53,"end_line":174,"end_character":60},"updated":"2017-06-19 15:47:30.000000000","message":"I think we should change this to seg_subnets. Otherwise, we end up classifying non routed networks subnets as non local subnets, which is reflected in lines 93 - 94 of the unit test","commit_id":"a17a594d5b02dcec2ba7ffce27da08a7ad7f3f4c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b41ff4a389dee3b26d672182e5c869580e2ca793","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # segments as the host.  Do this only for the networks that are"},{"line_number":172,"context_line":"            # routed because we want non-routed networks to work as"},{"line_number":173,"context_line":"            # before."},{"line_number":174,"context_line":"            nonlocal_subnets \u003d [subnet for subnet in subnets"},{"line_number":175,"context_line":"                                if subnet[\u0027id\u0027] not in seg_subnet_ids]"},{"line_number":176,"context_line":"            subnets \u003d [subnet for subnet in subnets"},{"line_number":177,"context_line":"                       if subnet[\u0027network_id\u0027] not in routed_net_ids or"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_5bc3a2ed","line":174,"range":{"start_line":174,"start_character":53,"end_line":174,"end_character":60},"in_reply_to":"7f231b9d_c02c5dad","updated":"2017-06-19 16:09:33.000000000","message":"That was my fault, I copied the line below not noticing it was different from L222.","commit_id":"a17a594d5b02dcec2ba7ffce27da08a7ad7f3f4c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5a26045d25565f03dbdb53b83af1ce276af066a4","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                # host is not mapped to any segments and this is a routed"},{"line_number":220,"context_line":"                # network, then this host shouldn\u0027t have even been scheduled"},{"line_number":221,"context_line":"                # to."},{"line_number":222,"context_line":"                nonlocal_subnets \u003d [subnet for subnet in seg_subnets"},{"line_number":223,"context_line":"                                    if subnet[\u0027segment_id\u0027] not in segment_ids]"},{"line_number":224,"context_line":"                subnets \u003d [subnet for subnet in seg_subnets"},{"line_number":225,"context_line":"                           if subnet[\u0027segment_id\u0027] in segment_ids]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_1b42ca0f","line":222,"range":{"start_line":222,"start_character":57,"end_line":222,"end_character":68},"updated":"2017-06-19 15:52:16.000000000","message":"In fact, here it is being done correctly","commit_id":"a17a594d5b02dcec2ba7ffce27da08a7ad7f3f4c"}],"neutron/tests/unit/api/rpc/handlers/test_dhcp_rpc.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c19d092502e7eb22c32222ec7eb83daad50bcfd2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        networks \u003d self.callbacks.get_active_networks_info(mock.Mock(),"},{"line_number":91,"context_line":"                                                           host\u003d\u0027host\u0027)"},{"line_number":92,"context_line":"        expected \u003d [{\u0027id\u0027: \u0027a\u0027,"},{"line_number":93,"context_line":"                     \u0027non_local_subnets\u0027: [nonlocal_subnets[0]],"},{"line_number":94,"context_line":"                     \u0027subnets\u0027: [subnets[1]],"},{"line_number":95,"context_line":"                     \u0027ports\u0027: [port]},"},{"line_number":96,"context_line":"                    {\u0027id\u0027: \u0027b\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_db0fb22b","line":93,"updated":"2017-06-19 15:47:30.000000000","message":"In this case, non local subnets should be [], because network a in a non routed network. Please see comment at https://review.openstack.org/#/c/459861/6/neutron/api/rpc/handlers/dhcp_rpc.py@174","commit_id":"a17a594d5b02dcec2ba7ffce27da08a7ad7f3f4c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b41ff4a389dee3b26d672182e5c869580e2ca793","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        networks \u003d self.callbacks.get_active_networks_info(mock.Mock(),"},{"line_number":91,"context_line":"                                                           host\u003d\u0027host\u0027)"},{"line_number":92,"context_line":"        expected \u003d [{\u0027id\u0027: \u0027a\u0027,"},{"line_number":93,"context_line":"                     \u0027non_local_subnets\u0027: [nonlocal_subnets[0]],"},{"line_number":94,"context_line":"                     \u0027subnets\u0027: [subnets[1]],"},{"line_number":95,"context_line":"                     \u0027ports\u0027: [port]},"},{"line_number":96,"context_line":"                    {\u0027id\u0027: \u0027b\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_3bb6a68b","line":93,"in_reply_to":"7f231b9d_db0fb22b","updated":"2017-06-19 16:09:33.000000000","message":"Done","commit_id":"a17a594d5b02dcec2ba7ffce27da08a7ad7f3f4c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3f2c7836d6d65f933c65b7834e8f880bb2b964b3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                                           host\u003d\u0027host\u0027)"},{"line_number":92,"context_line":"        expected \u003d [{\u0027id\u0027: \u0027a\u0027,"},{"line_number":93,"context_line":"                     \u0027non_local_subnets\u0027: [nonlocal_subnets[0]],"},{"line_number":94,"context_line":"                     \u0027subnets\u0027: [subnets[1]],"},{"line_number":95,"context_line":"                     \u0027ports\u0027: [port]},"},{"line_number":96,"context_line":"                    {\u0027id\u0027: \u0027b\u0027,"},{"line_number":97,"context_line":"                     \u0027non_local_subnets\u0027: [nonlocal_subnets[1]],"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_fbb02e45","line":94,"updated":"2017-06-19 15:49:12.000000000","message":"We have subnet id \u0027e\u0027 both here and in non_local_subnets. Doesn\u0027t seem right to me","commit_id":"a17a594d5b02dcec2ba7ffce27da08a7ad7f3f4c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b41ff4a389dee3b26d672182e5c869580e2ca793","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                                           host\u003d\u0027host\u0027)"},{"line_number":92,"context_line":"        expected \u003d [{\u0027id\u0027: \u0027a\u0027,"},{"line_number":93,"context_line":"                     \u0027non_local_subnets\u0027: [nonlocal_subnets[0]],"},{"line_number":94,"context_line":"                     \u0027subnets\u0027: [subnets[1]],"},{"line_number":95,"context_line":"                     \u0027ports\u0027: [port]},"},{"line_number":96,"context_line":"                    {\u0027id\u0027: \u0027b\u0027,"},{"line_number":97,"context_line":"                     \u0027non_local_subnets\u0027: [nonlocal_subnets[1]],"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_fbb38e96","line":94,"in_reply_to":"7f231b9d_fbb02e45","updated":"2017-06-19 16:09:33.000000000","message":"Done","commit_id":"a17a594d5b02dcec2ba7ffce27da08a7ad7f3f4c"}]}
