)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"75a9ee606ddd4f9d4838f5191f59e74240737098","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        results \u003d self.get_ports_attributes("},{"line_number":482,"context_line":"            \u0027Interface\u0027,"},{"line_number":483,"context_line":"            columns\u003d[\u0027name\u0027, \u0027external_ids\u0027, \u0027ofport\u0027, \u0027other_config\u0027],"},{"line_number":484,"context_line":"            if_exists\u003dTrue)"},{"line_number":485,"context_line":"        port_map \u003d {}"},{"line_number":486,"context_line":"        for r in results:"},{"line_number":487,"context_line":"            # fall back to basic interface name"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_e0d5f344","line":484,"updated":"2017-05-03 13:21:50.000000000","message":"function maps external ids to ofport. other_config doesn\u0027t seem necessary.","commit_id":"bf5565889e94865c4e03ae0046255ba966bc25ff"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"6672bf786805975bf382d1324c98bcc7fe4cae63","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        results \u003d self.get_ports_attributes("},{"line_number":482,"context_line":"            \u0027Interface\u0027,"},{"line_number":483,"context_line":"            columns\u003d[\u0027name\u0027, \u0027external_ids\u0027, \u0027ofport\u0027, \u0027other_config\u0027],"},{"line_number":484,"context_line":"            if_exists\u003dTrue)"},{"line_number":485,"context_line":"        port_map \u003d {}"},{"line_number":486,"context_line":"        for r in results:"},{"line_number":487,"context_line":"            # fall back to basic interface name"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_b05f600d","line":484,"in_reply_to":"5ff73747_e0d5f344","updated":"2017-05-03 23:08:59.000000000","message":"Done","commit_id":"bf5565889e94865c4e03ae0046255ba966bc25ff"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"75a9ee606ddd4f9d4838f5191f59e74240737098","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        edge_ports \u003d set()"},{"line_number":498,"context_line":"        results \u003d self.get_ports_attributes("},{"line_number":499,"context_line":"            \u0027Interface\u0027,"},{"line_number":500,"context_line":"            columns\u003d[\u0027name\u0027, \u0027external_ids\u0027, \u0027ofport\u0027, \u0027other_config\u0027],"},{"line_number":501,"context_line":"            if_exists\u003dTrue)"},{"line_number":502,"context_line":"        for result in results:"},{"line_number":503,"context_line":"            if result[\u0027ofport\u0027] \u003d\u003d UNASSIGNED_OFPORT:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_e0ecd32a","line":500,"updated":"2017-05-03 13:21:50.000000000","message":"This method seems to deal mainly with port id\u0027s, so probably doesn\u0027t need the other_config column.","commit_id":"bf5565889e94865c4e03ae0046255ba966bc25ff"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"6672bf786805975bf382d1324c98bcc7fe4cae63","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        edge_ports \u003d set()"},{"line_number":498,"context_line":"        results \u003d self.get_ports_attributes("},{"line_number":499,"context_line":"            \u0027Interface\u0027,"},{"line_number":500,"context_line":"            columns\u003d[\u0027name\u0027, \u0027external_ids\u0027, \u0027ofport\u0027, \u0027other_config\u0027],"},{"line_number":501,"context_line":"            if_exists\u003dTrue)"},{"line_number":502,"context_line":"        for result in results:"},{"line_number":503,"context_line":"            if result[\u0027ofport\u0027] \u003d\u003d UNASSIGNED_OFPORT:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_10ae14e7","line":500,"in_reply_to":"5ff73747_e0ecd32a","updated":"2017-05-03 23:08:59.000000000","message":"Done","commit_id":"bf5565889e94865c4e03ae0046255ba966bc25ff"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4505d7f2398cb248de6902684bde113a0711b86f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.vif_id \u003d vif_id"},{"line_number":95,"context_line":"        self.vif_mac \u003d vif_mac"},{"line_number":96,"context_line":"        self.switch \u003d switch"},{"line_number":97,"context_line":"        self.other_config \u003d other_config or dict()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def __str__(self):"},{"line_number":100,"context_line":"        return (\"iface-id\u003d%s, vif_mac\u003d%s, port_name\u003d%s, ofport\u003d%s, \""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_c199ab79","line":97,"range":{"start_line":97,"start_character":41,"end_line":97,"end_character":50},"updated":"2017-05-08 06:37:26.000000000","message":"is this necessary?","commit_id":"54f87495414fcd269e716c763c3677c0a582926a"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"8d71764446d6223c3bfedf035fd61e1cad69cd44","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.vif_id \u003d vif_id"},{"line_number":95,"context_line":"        self.vif_mac \u003d vif_mac"},{"line_number":96,"context_line":"        self.switch \u003d switch"},{"line_number":97,"context_line":"        self.other_config \u003d other_config or dict()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def __str__(self):"},{"line_number":100,"context_line":"        return (\"iface-id\u003d%s, vif_mac\u003d%s, port_name\u003d%s, ofport\u003d%s, \""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_8696ee4b","line":97,"range":{"start_line":97,"start_character":41,"end_line":97,"end_character":50},"in_reply_to":"3f044301_c199ab79","updated":"2017-05-10 09:42:32.000000000","message":"I was needed since the code checked for the existence of a dictionary key, but I since we moved to external_ids I guess this comment is no longer relevant.","commit_id":"54f87495414fcd269e716c763c3677c0a582926a"}],"neutron/cmd/ovs_cleanup.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"02822e1b10ce51bbe16082368ce93fe6db2ca0f4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    for bridge in bridges:"},{"line_number":51,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":52,"context_line":"        ports +\u003d [port.port_name for port in ovs.get_vif_ports("},{"line_number":53,"context_line":"            skip_cleanup_filter\u003dconstants.SKIP_PORT_CLEANUP)]"},{"line_number":54,"context_line":"    return ports"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_ebb55933","line":53,"updated":"2017-04-27 18:37:53.000000000","message":"in agreement with what Assaf is suggesting, I would rather you just get all of the ports and then filter out ones here you aren\u0027t interested in here . Otherwise we end up putting very use-case specific logic in the lib.","commit_id":"74dcb7bb63699ebbd49a26bc929b57e61d13cc81"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"cf9dcae14b4f46246ce58f69205f51ceef8547a0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    for bridge in bridges:"},{"line_number":51,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":52,"context_line":"        ports +\u003d [port.port_name for port in ovs.get_vif_ports("},{"line_number":53,"context_line":"            skip_cleanup_filter\u003dconstants.SKIP_PORT_CLEANUP)]"},{"line_number":54,"context_line":"    return ports"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_460b2423","line":53,"in_reply_to":"5ff73747_ebb55933","updated":"2017-04-27 19:36:37.000000000","message":"Yeah, I\u0027d just modify VifPort to store an optional \u0027other_config\u0027 and then in ovs_cleanup do the filter. Something like the completely untested https://gist.github.com/otherwiseguy/17749ba7d749cc088afb44a5371737bf","commit_id":"74dcb7bb63699ebbd49a26bc929b57e61d13cc81"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"75a9ee606ddd4f9d4838f5191f59e74240737098","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        LOG.info(_LI(\"Cleaning bridge: %s\"), bridge)"},{"line_number":105,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":106,"context_line":"        if conf.ovs_all_ports:"},{"line_number":107,"context_line":"            port_names \u003d ovs.get_port_name_list()"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            port_names \u003d get_bridge_deletable_ports(ovs)"},{"line_number":110,"context_line":"        for port_name in port_names:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_60cb2372","line":107,"updated":"2017-05-03 13:21:50.000000000","message":"I wonder if the semantics of \"skip_cleanup\" should mean skip even if ovs_all_ports is set. For this particular use case we are asking that a port isn\u0027t deleted if it is created by \"an outside agency\" that creates the port via an interface configuration file. In other words, if this flag were ever enabled for the system services for the octavia server nodes, it would just be broken with no workaround. I guess it depends on what the use case for ovs_all_ports \u003d True is. Thoughts?","commit_id":"bf5565889e94865c4e03ae0046255ba966bc25ff"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"ba125efc9f67a719b04d45b51144f292cba8ff37","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        LOG.info(_LI(\"Cleaning bridge: %s\"), bridge)"},{"line_number":105,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":106,"context_line":"        if conf.ovs_all_ports:"},{"line_number":107,"context_line":"            port_names \u003d ovs.get_port_name_list()"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            port_names \u003d get_bridge_deletable_ports(ovs)"},{"line_number":110,"context_line":"        for port_name in port_names:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5ff73747_7490854f","line":107,"in_reply_to":"5ff73747_60cb2372","updated":"2017-05-03 15:09:15.000000000","message":"That\u0027s a valid point.\nIMHO, I think that in case ovs_all_ports \u003d True, we should delete *all* port.\n\nLooking at the help[1] section for this config option it clearly states \"True to delete all ports on all the OpenvSwitch bridges\"\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/conf/agent/cmd.py#L44-L47","commit_id":"bf5565889e94865c4e03ae0046255ba966bc25ff"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0f4bd7da7f834de7357be5f3b4cc2a7644a43071","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    return [port.port_name for port in br.get_vif_ports()"},{"line_number":54,"context_line":"            if constants.SKIP_CLEANUP not in"},{"line_number":55,"context_line":"            br.get_port_external_ids(port.port_name).keys()]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def collect_neutron_ports(bridges):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_3b33b3f8","line":55,"range":{"start_line":55,"start_character":52,"end_line":55,"end_character":59},"updated":"2017-05-10 08:32:24.000000000","message":"br.get_port_external_ids(port.port_name) is a dictionary. Any fin operation, like \n\nif constants.SKIP_CLEANUP not in            br.get_port_external_ids(port.port_name)\n\nwill look up in the key set. So .keys() is not needed.","commit_id":"5524ab1418fb475d228d5daef93a8989570c0882"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"bdd951c4e607799696f19a0bbd66c823c8891805","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    return [port.port_name for port in br.get_vif_ports()"},{"line_number":54,"context_line":"            if constants.SKIP_CLEANUP not in"},{"line_number":55,"context_line":"            br.get_port_external_ids(port.port_name).keys()]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def collect_neutron_ports(bridges):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3f044301_a6dfaa38","line":55,"range":{"start_line":55,"start_character":52,"end_line":55,"end_character":59},"in_reply_to":"3f044301_3b33b3f8","updated":"2017-05-10 09:40:05.000000000","message":"Done","commit_id":"5524ab1418fb475d228d5daef93a8989570c0882"}],"neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4505d7f2398cb248de6902684bde113a0711b86f","unresolved":false,"context_lines":[{"line_number":150,"context_line":"# callback resource for notifying to ovsdb handler"},{"line_number":151,"context_line":"OVSDB_RESOURCE \u003d \u0027ovsdb\u0027"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Used in ovs port \u0027other_config\u0027 in order mark it for no cleanup when"},{"line_number":154,"context_line":"# ovs_cleanup script is used."},{"line_number":155,"context_line":"SKIP_CLEANUP \u003d \u0027skip_cleanup\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_61e777e6","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":32},"updated":"2017-05-08 06:37:26.000000000","message":"other_config is meant to configure the switch. (ovs)\nwhile we already have some abuse of it, i guess it\u0027s better to coordinate with ovs folks as this usage is somewhat new. ie. beyond ovs-agent internal.\nexternal_ids is probably safer to use, as it\u0027s explicitly documented that its keys are not interpreted by ovs itself.","commit_id":"54f87495414fcd269e716c763c3677c0a582926a"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"8d71764446d6223c3bfedf035fd61e1cad69cd44","unresolved":false,"context_lines":[{"line_number":150,"context_line":"# callback resource for notifying to ovsdb handler"},{"line_number":151,"context_line":"OVSDB_RESOURCE \u003d \u0027ovsdb\u0027"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Used in ovs port \u0027other_config\u0027 in order mark it for no cleanup when"},{"line_number":154,"context_line":"# ovs_cleanup script is used."},{"line_number":155,"context_line":"SKIP_CLEANUP \u003d \u0027skip_cleanup\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f044301_469c6669","line":153,"range":{"start_line":153,"start_character":20,"end_line":153,"end_character":32},"in_reply_to":"3f044301_61e777e6","updated":"2017-05-10 09:42:32.000000000","message":"Done, Moved to using external_ids instead.","commit_id":"54f87495414fcd269e716c763c3677c0a582926a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5da401e9be0c1596dcaeb0ddbb9625dfcde8b409","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Used in ovs port \u0027external_ids\u0027 in order mark it for no cleanup when"},{"line_number":154,"context_line":"# ovs_cleanup script is used."},{"line_number":155,"context_line":"SKIP_CLEANUP \u003d \u0027skip_cleanup\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f013ff3_a776b3a3","line":155,"range":{"start_line":155,"start_character":16,"end_line":155,"end_character":28},"updated":"2017-05-17 06:07:50.000000000","message":"maybe a less generic name is better?","commit_id":"0a4596aa203a74c99f64f3c53e7945894ffdcdd3"}],"neutron/tests/unit/agent/common/test_ovs_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d18046b2243e80a4e31d72ca40b920ceeb2bd20","unresolved":false,"context_lines":[{"line_number":818,"context_line":"                        [\"iface-status\", \"active\"],"},{"line_number":819,"context_line":"                        [\"attached-mac\", mac]]"},{"line_number":820,"context_line":"        data \u003d [[[\"map\", external_ids], \"tap99\","},{"line_number":821,"context_line":"                 ofport if ofport else [\"set\", []]]]"},{"line_number":822,"context_line":"        vif_port \u003d self._test_get_vif_port_by_id(\u0027tap99id\u0027, data)"},{"line_number":823,"context_line":"        self._assert_vif_port(vif_port, ofport, mac)"},{"line_number":824,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_39330aae","line":821,"updated":"2017-05-05 09:31:27.000000000","message":"I think you are missing here the \u0027other_config\u0027 dict.\n\nE.g.:\ndata \u003d [[[\"map\", external_ids], \"tap99\", ofport if ofport else [\"set\", []], {}]]","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"f67704e415fdd6926ee5e75daae54ec069841d4d","unresolved":false,"context_lines":[{"line_number":818,"context_line":"                        [\"iface-status\", \"active\"],"},{"line_number":819,"context_line":"                        [\"attached-mac\", mac]]"},{"line_number":820,"context_line":"        data \u003d [[[\"map\", external_ids], \"tap99\","},{"line_number":821,"context_line":"                 ofport if ofport else [\"set\", []]]]"},{"line_number":822,"context_line":"        vif_port \u003d self._test_get_vif_port_by_id(\u0027tap99id\u0027, data)"},{"line_number":823,"context_line":"        self._assert_vif_port(vif_port, ofport, mac)"},{"line_number":824,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_cc4fadbb","line":821,"in_reply_to":"3f044301_39330aae","updated":"2017-05-07 07:15:20.000000000","message":"Done","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d18046b2243e80a4e31d72ca40b920ceeb2bd20","unresolved":false,"context_lines":[{"line_number":839,"context_line":"    def test_get_vif_by_port_id_different_bridge(self):"},{"line_number":840,"context_line":"        external_ids \u003d [[\"iface-id\", \"tap99id\"],"},{"line_number":841,"context_line":"                        [\"iface-status\", \"active\"]]"},{"line_number":842,"context_line":"        data \u003d [[[\"map\", external_ids], \"tap99\", 1]]"},{"line_number":843,"context_line":"        self.assertIsNone(self._test_get_vif_port_by_id(\u0027tap99id\u0027, data,"},{"line_number":844,"context_line":"                                                        \"br-ext\"))"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_598a561b","line":842,"range":{"start_line":842,"start_character":7,"end_line":842,"end_character":52},"updated":"2017-05-05 09:31:27.000000000","message":"Here too:\n\ndata \u003d [[[\"map\", external_ids], \"tap99\", 1, {}]]","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"f67704e415fdd6926ee5e75daae54ec069841d4d","unresolved":false,"context_lines":[{"line_number":839,"context_line":"    def test_get_vif_by_port_id_different_bridge(self):"},{"line_number":840,"context_line":"        external_ids \u003d [[\"iface-id\", \"tap99id\"],"},{"line_number":841,"context_line":"                        [\"iface-status\", \"active\"]]"},{"line_number":842,"context_line":"        data \u003d [[[\"map\", external_ids], \"tap99\", 1]]"},{"line_number":843,"context_line":"        self.assertIsNone(self._test_get_vif_port_by_id(\u0027tap99id\u0027, data,"},{"line_number":844,"context_line":"                                                        \"br-ext\"))"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_2c5f3173","line":842,"range":{"start_line":842,"start_character":7,"end_line":842,"end_character":52},"in_reply_to":"3f044301_598a561b","updated":"2017-05-07 07:15:20.000000000","message":"Done","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d18046b2243e80a4e31d72ca40b920ceeb2bd20","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        external_ids \u003d [[\"iface-id\", \"tap99id\"],"},{"line_number":848,"context_line":"                        [\"iface-status\", \"active\"],"},{"line_number":849,"context_line":"                        [\"attached-mac\", \"de:ad:be:ef:13:37\"]]"},{"line_number":850,"context_line":"        data \u003d [[[\"map\", external_ids], \"dummytap\", 1],"},{"line_number":851,"context_line":"                [[\"map\", external_ids], \"tap99\", 1337]]"},{"line_number":852,"context_line":"        extra_calls_and_values \u003d ["},{"line_number":853,"context_line":"            (self._vsctl_mock(\"iface-to-br\", \"dummytap\"), \"br-ext\")]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_99da1e15","line":850,"updated":"2017-05-05 09:31:27.000000000","message":"Here too","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"f67704e415fdd6926ee5e75daae54ec069841d4d","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        external_ids \u003d [[\"iface-id\", \"tap99id\"],"},{"line_number":848,"context_line":"                        [\"iface-status\", \"active\"],"},{"line_number":849,"context_line":"                        [\"attached-mac\", \"de:ad:be:ef:13:37\"]]"},{"line_number":850,"context_line":"        data \u003d [[[\"map\", external_ids], \"dummytap\", 1],"},{"line_number":851,"context_line":"                [[\"map\", external_ids], \"tap99\", 1337]]"},{"line_number":852,"context_line":"        extra_calls_and_values \u003d ["},{"line_number":853,"context_line":"            (self._vsctl_mock(\"iface-to-br\", \"dummytap\"), \"br-ext\")]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_8c62c53d","line":850,"in_reply_to":"3f044301_99da1e15","updated":"2017-05-07 07:15:20.000000000","message":"Done","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d18046b2243e80a4e31d72ca40b920ceeb2bd20","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                        [\"iface-status\", \"active\"],"},{"line_number":849,"context_line":"                        [\"attached-mac\", \"de:ad:be:ef:13:37\"]]"},{"line_number":850,"context_line":"        data \u003d [[[\"map\", external_ids], \"dummytap\", 1],"},{"line_number":851,"context_line":"                [[\"map\", external_ids], \"tap99\", 1337]]"},{"line_number":852,"context_line":"        extra_calls_and_values \u003d ["},{"line_number":853,"context_line":"            (self._vsctl_mock(\"iface-to-br\", \"dummytap\"), \"br-ext\")]"},{"line_number":854,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_5906d688","line":851,"updated":"2017-05-05 09:31:27.000000000","message":"Here too","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"f67704e415fdd6926ee5e75daae54ec069841d4d","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                        [\"iface-status\", \"active\"],"},{"line_number":849,"context_line":"                        [\"attached-mac\", \"de:ad:be:ef:13:37\"]]"},{"line_number":850,"context_line":"        data \u003d [[[\"map\", external_ids], \"dummytap\", 1],"},{"line_number":851,"context_line":"                [[\"map\", external_ids], \"tap99\", 1337]]"},{"line_number":852,"context_line":"        extra_calls_and_values \u003d ["},{"line_number":853,"context_line":"            (self._vsctl_mock(\"iface-to-br\", \"dummytap\"), \"br-ext\")]"},{"line_number":854,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f044301_6c653945","line":851,"in_reply_to":"3f044301_5906d688","updated":"2017-05-07 07:15:20.000000000","message":"Done","commit_id":"aca27fc1248e0d9891c421efc6b2af892eee5776"}]}
