)]}'
{"neutron/tests/functional/agent/l3/test_ha_router.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"95fd16310b0e715cd9d587880a1b355363ea3fe8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # Check that RA and forwarding are enabled when there\u0027s no IPv6"},{"line_number":124,"context_line":"        # gateway."},{"line_number":125,"context_line":"        self._test_ipv6_router_advts_and_fwd_helper("},{"line_number":126,"context_line":"            \u0027master\u0027, False, True, True)"},{"line_number":127,"context_line":"        # Check that RA is disabled and forwarding is enabled when an IPv6"},{"line_number":128,"context_line":"        # gateway is configured."},{"line_number":129,"context_line":"        self._test_ipv6_router_advts_and_fwd_helper("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_60232307","line":126,"updated":"2017-05-03 14:23:54.000000000","message":"It would help readability if you\u0027d use keywords instead of context-less booleans:\n\n self._test_ipv6_router_advts_and_fwd_helper(\n   \u0027master\u0027, enable_v6_gw\u003dFalse, expected_ra\u003dTrue, expected_forwarding\u003dTrue","commit_id":"8333aa315043027add4bd4104e72a32d8a780f7a"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"603a5ff8ebc88b8d91ea263450ea60e9f5e51ff2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # Check that RA and forwarding are enabled when there\u0027s no IPv6"},{"line_number":124,"context_line":"        # gateway."},{"line_number":125,"context_line":"        self._test_ipv6_router_advts_and_fwd_helper("},{"line_number":126,"context_line":"            \u0027master\u0027, False, True, True)"},{"line_number":127,"context_line":"        # Check that RA is disabled and forwarding is enabled when an IPv6"},{"line_number":128,"context_line":"        # gateway is configured."},{"line_number":129,"context_line":"        self._test_ipv6_router_advts_and_fwd_helper("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_b9b966ea","line":126,"in_reply_to":"5ff73747_60232307","updated":"2017-05-03 14:37:28.000000000","message":"Done","commit_id":"8333aa315043027add4bd4104e72a32d8a780f7a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f62f6ab35bf5ce7687bf810f39dc83d203374fc6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # IPv6 forwarding is enabled."},{"line_number":107,"context_line":"        router_info \u003d l3_test_common.prepare_router_data("},{"line_number":108,"context_line":"            enable_snat\u003dTrue, enable_ha\u003dTrue, dual_stack\u003dTrue, enable_gw\u003dFalse)"},{"line_number":109,"context_line":"        router \u003d self.manage_router(self.agent, router_info)"},{"line_number":110,"context_line":"        common_utils.wait_until_true(lambda: router.ha_state \u003d\u003d state)"},{"line_number":111,"context_line":"        if state \u003d\u003d \u0027backup\u0027:"},{"line_number":112,"context_line":"            self.fail_ha_router(router)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_cf8100c6","line":109,"updated":"2017-05-03 15:42:25.000000000","message":"(just a question) does manage_router guarantee that after it returns, the device that you will down in line 112 exists? (you would not need to assume that if you wait for the router to become master before proceeding to failing it over).","commit_id":"2fd7c6adfd4c93fbc2ee797e788f707ba6d11982"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"01037f8720d24814f34ad6f53a8b721bdb4b8be8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        # IPv6 forwarding is enabled."},{"line_number":107,"context_line":"        router_info \u003d l3_test_common.prepare_router_data("},{"line_number":108,"context_line":"            enable_snat\u003dTrue, enable_ha\u003dTrue, dual_stack\u003dTrue, enable_gw\u003dFalse)"},{"line_number":109,"context_line":"        router \u003d self.manage_router(self.agent, router_info)"},{"line_number":110,"context_line":"        common_utils.wait_until_true(lambda: router.ha_state \u003d\u003d state)"},{"line_number":111,"context_line":"        if state \u003d\u003d \u0027backup\u0027:"},{"line_number":112,"context_line":"            self.fail_ha_router(router)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_6f042bc7","line":109,"in_reply_to":"5ff73747_cf8100c6","updated":"2017-05-03 15:57:47.000000000","message":"Done","commit_id":"2fd7c6adfd4c93fbc2ee797e788f707ba6d11982"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f62f6ab35bf5ce7687bf810f39dc83d203374fc6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        router_info \u003d l3_test_common.prepare_router_data("},{"line_number":108,"context_line":"            enable_snat\u003dTrue, enable_ha\u003dTrue, dual_stack\u003dTrue, enable_gw\u003dFalse)"},{"line_number":109,"context_line":"        router \u003d self.manage_router(self.agent, router_info)"},{"line_number":110,"context_line":"        common_utils.wait_until_true(lambda: router.ha_state \u003d\u003d state)"},{"line_number":111,"context_line":"        if state \u003d\u003d \u0027backup\u0027:"},{"line_number":112,"context_line":"            self.fail_ha_router(router)"},{"line_number":113,"context_line":"        _ext_dev_name, ex_port \u003d l3_test_common.prepare_ext_gw_test("}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_4fc4d040","line":110,"updated":"2017-05-03 15:42:25.000000000","message":"so for backup case, if router manages to transition to master before we check the state, the test will fail. You should probably fail the router (line 112) before checking the state; and maybe do that only after the router reaches initial master state.","commit_id":"2fd7c6adfd4c93fbc2ee797e788f707ba6d11982"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"01037f8720d24814f34ad6f53a8b721bdb4b8be8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        router_info \u003d l3_test_common.prepare_router_data("},{"line_number":108,"context_line":"            enable_snat\u003dTrue, enable_ha\u003dTrue, dual_stack\u003dTrue, enable_gw\u003dFalse)"},{"line_number":109,"context_line":"        router \u003d self.manage_router(self.agent, router_info)"},{"line_number":110,"context_line":"        common_utils.wait_until_true(lambda: router.ha_state \u003d\u003d state)"},{"line_number":111,"context_line":"        if state \u003d\u003d \u0027backup\u0027:"},{"line_number":112,"context_line":"            self.fail_ha_router(router)"},{"line_number":113,"context_line":"        _ext_dev_name, ex_port \u003d l3_test_common.prepare_ext_gw_test("}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_8f8778b7","line":110,"in_reply_to":"5ff73747_4fc4d040","updated":"2017-05-03 15:57:47.000000000","message":"Yes.. this was done in the original code, I flipped it by mistake, thanks and nice catch!","commit_id":"2fd7c6adfd4c93fbc2ee797e788f707ba6d11982"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f62f6ab35bf5ce7687bf810f39dc83d203374fc6","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                                                    enable_v6_gw\u003dTrue,"},{"line_number":146,"context_line":"                                                    expected_ra\u003dFalse,"},{"line_number":147,"context_line":"                                                    expected_forwarding\u003dFalse)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_keepalived_configuration(self):"},{"line_number":151,"context_line":"        router_info \u003d self.generate_router_info(enable_ha\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_af86b4da","line":148,"updated":"2017-05-03 15:42:25.000000000","message":"this newline is breaking pep8","commit_id":"2fd7c6adfd4c93fbc2ee797e788f707ba6d11982"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"01037f8720d24814f34ad6f53a8b721bdb4b8be8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                                                    enable_v6_gw\u003dTrue,"},{"line_number":146,"context_line":"                                                    expected_ra\u003dFalse,"},{"line_number":147,"context_line":"                                                    expected_forwarding\u003dFalse)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_keepalived_configuration(self):"},{"line_number":151,"context_line":"        router_info \u003d self.generate_router_info(enable_ha\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_2f0e23e5","line":148,"in_reply_to":"5ff73747_af86b4da","updated":"2017-05-03 15:57:47.000000000","message":"Done","commit_id":"2fd7c6adfd4c93fbc2ee797e788f707ba6d11982"}]}
