)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a86b3164fae692f98851fb51424341ae19b8a897","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l3ha: log keepalived.conf contents on (re)spawn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, neither the l3 agent nor keepalived daemon itself logs"},{"line_number":10,"context_line":"whether a particular IP address was actually received from server side"},{"line_number":11,"context_line":"via router update event and processed accordingly. For legacy routers,"},{"line_number":12,"context_line":"that\u0027s not a problem because we can see execute() logs for \u0027ip addr add\u0027"},{"line_number":13,"context_line":"and such, but in case of l3ha, keepalived itself configures IP"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_bc4c32c8","line":10,"updated":"2017-05-12 03:35:21.000000000","message":"can we just explicitly log the IP address in the L3 agent? or is there value in having the full contents of the keepalived conf?","commit_id":"4ea3e760607a25f6bcbf45101d2ab586cdd952c9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"26aa537276aa9160237fa73e5162e34d90b54f6b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l3ha: log keepalived.conf contents on (re)spawn"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At the moment, neither the l3 agent nor keepalived daemon itself logs"},{"line_number":10,"context_line":"whether a particular IP address was actually received from server side"},{"line_number":11,"context_line":"via router update event and processed accordingly. For legacy routers,"},{"line_number":12,"context_line":"that\u0027s not a problem because we can see execute() logs for \u0027ip addr add\u0027"},{"line_number":13,"context_line":"and such, but in case of l3ha, keepalived itself configures IP"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f013ff3_da91bb54","line":10,"in_reply_to":"3f044301_bc4c32c8","updated":"2017-05-16 03:27:54.000000000","message":"We can.","commit_id":"4ea3e760607a25f6bcbf45101d2ab586cdd952c9"}],"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0cfc0f27de82ce41e54962e28ab145f36accf5f4","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                      service_name\u003dKEEPALIVED_SERVICE_NAME,"},{"line_number":442,"context_line":"                                      monitored_process\u003dkeepalived_pm)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        LOG.debug(\u0027Keepalived spawned with config %(path)s:\\n%(contents)s\u0027,"},{"line_number":445,"context_line":"                  {\u0027path\u0027: config_path, \u0027contents\u0027: config_str})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def disable(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_af33a1aa","line":444,"range":{"start_line":444,"start_character":59,"end_line":444,"end_character":61},"updated":"2017-05-01 08:05:17.000000000","message":"i do not think that the \\n should be part of the log message. this is not good for monitoring tools and that information may be lost","commit_id":"4ea3e760607a25f6bcbf45101d2ab586cdd952c9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"58446fc06c520db10b279df5488379cc540cdf15","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                      service_name\u003dKEEPALIVED_SERVICE_NAME,"},{"line_number":442,"context_line":"                                      monitored_process\u003dkeepalived_pm)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        LOG.debug(\u0027Keepalived spawned with config %(path)s:\\n%(contents)s\u0027,"},{"line_number":445,"context_line":"                  {\u0027path\u0027: config_path, \u0027contents\u0027: config_str})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def disable(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_c12d99fe","line":444,"range":{"start_line":444,"start_character":59,"end_line":444,"end_character":61},"in_reply_to":"5ff73747_1ee52538","updated":"2017-05-01 19:47:32.000000000","message":"Yes. Not sure if you have every used tools like splunk or log insight with new lines. its problematic.\nAnyways if this is impossible to change then we can approve","commit_id":"4ea3e760607a25f6bcbf45101d2ab586cdd952c9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"82ce2f78d5ded19a588846d10268aaaeaf4c603b","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                      service_name\u003dKEEPALIVED_SERVICE_NAME,"},{"line_number":442,"context_line":"                                      monitored_process\u003dkeepalived_pm)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        LOG.debug(\u0027Keepalived spawned with config %(path)s:\\n%(contents)s\u0027,"},{"line_number":445,"context_line":"                  {\u0027path\u0027: config_path, \u0027contents\u0027: config_str})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def disable(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_1ee52538","line":444,"range":{"start_line":444,"start_character":59,"end_line":444,"end_character":61},"in_reply_to":"5ff73747_af33a1aa","updated":"2017-05-01 14:51:20.000000000","message":"The \u0027contents\u0027 itself contains newlines. Is it also a concern for you?","commit_id":"4ea3e760607a25f6bcbf45101d2ab586cdd952c9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0bb4ad9b3def864ee5e62882b12dbb06f5284d08","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        config_path \u003d self.get_full_config_file_path(\u0027keepalived.conf\u0027)"},{"line_number":399,"context_line":"        file_utils.replace_file(config_path, config_str)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        return config_path, config_str"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @staticmethod"},{"line_number":404,"context_line":"    def _safe_remove_pid_file(pid_file):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_10a5d004","line":401,"updated":"2017-07-31 20:04:18.000000000","message":"config_str is never used by the caller, what am I missing?","commit_id":"f653cdf007481ee570aa6a1e844ecf7c6b8c14c2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6f3aed1df77488c3db8d834af055a774a39b5f74","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        config_path \u003d self.get_full_config_file_path(\u0027keepalived.conf\u0027)"},{"line_number":399,"context_line":"        file_utils.replace_file(config_path, config_str)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        return config_path, config_str"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @staticmethod"},{"line_number":404,"context_line":"    def _safe_remove_pid_file(pid_file):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_3a766ea6","line":401,"in_reply_to":"df3967d1_10a5d004","updated":"2017-07-31 21:56:51.000000000","message":"Leftover...","commit_id":"f653cdf007481ee570aa6a1e844ecf7c6b8c14c2"}]}