)]}'
{"devstack/lib/l2_agent_sriovnicswitch":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"44627feeae0c702c56593d790d64a1131d2912b1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function start_l2_agent_sriov {"},{"line_number":18,"context_line":"    if is_neutron_legacy_enabled; then"},{"line_number":19,"context_line":"        SERVICE_NAME\u003dq-sriov-agt"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        SERVICE_NAME\u003dneutron-sriov-agent"},{"line_number":22,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5ff73747_1ae2a302","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":20},"updated":"2017-05-02 22:40:09.000000000","message":"bash is not my strong suit, but isn\u0027t this name too generic that it might interfere with other function? Maybe call it SRIOV_SERVICE_NAME or declare it as local to this function. Same question for lines 21, 23, 28, 30 and 32","commit_id":"b1f41af45d280d36874449b6a1a364f565b97617"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2e03c8c7afb9adbfee25d804b857dc6de72d506f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function start_l2_agent_sriov {"},{"line_number":18,"context_line":"    if is_neutron_legacy_enabled; then"},{"line_number":19,"context_line":"        SERVICE_NAME\u003dq-sriov-agt"},{"line_number":20,"context_line":"    else"},{"line_number":21,"context_line":"        SERVICE_NAME\u003dneutron-sriov-agent"},{"line_number":22,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f044301_ad79f8fc","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":20},"in_reply_to":"5ff73747_1ae2a302","updated":"2017-05-08 00:30:26.000000000","message":"Done","commit_id":"b1f41af45d280d36874449b6a1a364f565b97617"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2f21be3e509cca33a88d99a3a94524d1d90b0512","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    else"},{"line_number":22,"context_line":"        SERVICE_NAME\u003dneutron-sriov-agent"},{"line_number":23,"context_line":"    fi"},{"line_number":24,"context_line":"    run_process $SERVICE_NAME \"$SRIOV_AGENT_BINARY --config-file $NEUTRON_CONF --config-file /$SRIOV_AGENT_CONF\""},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function stop_l2_agent_sriov {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3f044301_9e574027","line":24,"range":{"start_line":24,"start_character":95,"end_line":24,"end_character":111},"updated":"2017-05-11 07:20:11.000000000","message":"Could be very interesting to include a new section in doc/source/devref/sriov_niv_agent.rst to know how to add the diferent config parameters, like:\n\n[ml2_sriov]\nagent_required \u003d True\nsupported_pci_vendor_devs \u003d 8086:1584, 8086:154c, 8086:10ed, 8086:10fb\n\n\n[sriov_nic]\nphysical_device_mappings \u003d default:enp8s16f1","commit_id":"38feb491ddf111a0f41a73ef08f51fbaf518c1bc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bddb0f69561d3d17a59e64529d4fd177d0e85bfa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    else"},{"line_number":22,"context_line":"        SERVICE_NAME\u003dneutron-sriov-agent"},{"line_number":23,"context_line":"    fi"},{"line_number":24,"context_line":"    run_process $SERVICE_NAME \"$SRIOV_AGENT_BINARY --config-file $NEUTRON_CONF --config-file /$SRIOV_AGENT_CONF\""},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function stop_l2_agent_sriov {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1f013ff3_8a71bce3","line":24,"range":{"start_line":24,"start_character":95,"end_line":24,"end_character":111},"in_reply_to":"1f013ff3_2921a44e","updated":"2017-05-15 11:32:16.000000000","message":"I agree. But DocImpact should be added to the commit message.","commit_id":"38feb491ddf111a0f41a73ef08f51fbaf518c1bc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"02ffa1f35407f6fa3fa8c9094baa31664d3e8d7d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    else"},{"line_number":22,"context_line":"        SERVICE_NAME\u003dneutron-sriov-agent"},{"line_number":23,"context_line":"    fi"},{"line_number":24,"context_line":"    run_process $SERVICE_NAME \"$SRIOV_AGENT_BINARY --config-file $NEUTRON_CONF --config-file /$SRIOV_AGENT_CONF\""},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function stop_l2_agent_sriov {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1f013ff3_2921a44e","line":24,"range":{"start_line":24,"start_character":95,"end_line":24,"end_character":111},"in_reply_to":"3f044301_9e574027","updated":"2017-05-14 22:43:05.000000000","message":"Yes it would be nice. In my opinion, though, that is another patchset","commit_id":"38feb491ddf111a0f41a73ef08f51fbaf518c1bc"}]}