)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"288864c8cb737f732b8566145801f8120875624d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tempest: Disable port security for trunk tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a bug that makes trunk tests flaky. It already took a lot of"},{"line_number":10,"context_line":"time to fix that bug. Until ovs firewall works with trunk properly, this"},{"line_number":11,"context_line":"patch removes port security from trunk ports."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_58501733","line":10,"range":{"start_line":9,"start_character":45,"end_line":10,"end_character":20},"updated":"2017-05-03 17:27:00.000000000","message":"This commit message is confusing: are you referring to the same bug mentioned in the previous sentence?","commit_id":"f1ed77e8d949faa20c91ecf61f6f9363ea0e6d2e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b2ef7834bfda0ed72c1c675598840ca1f8d2d5a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tempest: Disable port security for trunk tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a bug that makes trunk tests flaky. It already took a lot of"},{"line_number":10,"context_line":"time to fix that bug. Until ovs firewall works with trunk properly, this"},{"line_number":11,"context_line":"patch removes port security from trunk ports."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_23dcfc44","line":10,"range":{"start_line":9,"start_character":45,"end_line":10,"end_character":20},"in_reply_to":"5ff73747_58501733","updated":"2017-05-03 17:40:15.000000000","message":"Yep, it\u0027s all about 1626010. I\u0027ll rephrase.","commit_id":"f1ed77e8d949faa20c91ecf61f6f9363ea0e6d2e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"580594eef4e49b4e832bf1bafbad572f23ef508e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 18:32:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tempest: Disable port security for trunk tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_7c19b986","line":7,"updated":"2017-05-03 19:24:44.000000000","message":"shouldn\u0027t this be specific to ovs job? linuxbridge is not affected, correct?","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"17c465f44d106623515f1e6dcc48f134539431e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 18:32:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tempest: Disable port security for trunk tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_ee9aa16c","line":7,"in_reply_to":"3f044301_7c19b986","updated":"2017-05-04 08:29:27.000000000","message":"Ah, that\u0027s true.","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d4ac71bfd1943e6876160608a634ebc3551a1333","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_a9ab4b73","line":11,"updated":"2017-05-03 18:45:46.000000000","message":"OK, but what\u0027s the action plan? The job is non-voting, is it not?","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"eed9ea6b96bf1dc26e10c467302d15604aa54295","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_6579a32d","line":11,"in_reply_to":"3f044301_1ad8357d","updated":"2017-05-09 18:13:34.000000000","message":"Done","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"943c154706f60d113c5816c6179c05f2109a8b69","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_e9a4c90a","line":11,"in_reply_to":"3f044301_4ea2b59c","updated":"2017-05-04 17:00:42.000000000","message":"OK, I am either unable to explain myself, or unable to understand. That said, I do understand what skipping a test does. What I don\u0027t understand is how you plan to fix it without collecting enough data points by keeping it on. If the test is flaky are you confident you can repro it locally? Why and how is the failure of this test blocking other efforts?\n\nI don\u0027t see this either articulated on the commit message, the ML or even the last CI meeting logs for that matter [1]. I\u0027d like to offer my help, but I don\u0027t have enough context to judge whether this action makes sense or not in the overall scheme of things.\n\n[1] http://eavesdrop.openstack.org/meetings/neutron_ci/2017/neutron_ci.2017-05-02-16.01.log.html","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"90fd9aa8c0596938838e700d3d36921e5fe4fa2b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_e2c1a282","line":11,"in_reply_to":"3f044301_9c55a520","updated":"2017-05-03 20:11:28.000000000","message":"Well, that\u0027s the end goal, not a plan.","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"13c7a7eaba2a604721dc9cf6c08ec5eb644517c7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_1ad8357d","line":11,"in_reply_to":"3f044301_b99f1a4f","updated":"2017-05-05 15:38:37.000000000","message":"now, that\u0027s a good commit message.","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"17c465f44d106623515f1e6dcc48f134539431e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_4ea2b59c","line":11,"in_reply_to":"3f044301_e2c1a282","updated":"2017-05-04 08:29:27.000000000","message":"The plan is to lower the failure rate. Ideally, I should fix the 1626010 bug but it\u0027s taking me already too long. So to unblock the effort of fixing known issues in the non-voting job, we decided to disable port security on trunk ports.","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"38fc178532b7cc236aa770e9802ae36c08b3f03d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_b99f1a4f","line":11,"in_reply_to":"3f044301_e9a4c90a","updated":"2017-05-05 09:29:48.000000000","message":"The issue is easily reproducible and the fix [1] contains a test proving that. While the error is in the firewall driver, we don\u0027t need to have false results for tests aiming trunk quality. Eliminating this failure, we will get better understanding of failure rate of dvr multinode running in-tree tests. Once we eliminate this know failure we can focus on other flaky tests if any.\n\n[1] https://review.openstack.org/#/c/385085/","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"580594eef4e49b4e832bf1bafbad572f23ef508e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug 1626010 makes trunk tests flaky. Until ovs firewall"},{"line_number":10,"context_line":"works with trunk properly, this patch removes port"},{"line_number":11,"context_line":"security from trunk ports in test."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifa25783f8bdeb36edb6975b13cd50030ae6faec7"},{"line_number":14,"context_line":"Related-bug: 1626010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f044301_9c55a520","line":11,"in_reply_to":"5ff73747_a9ab4b73","updated":"2017-05-03 19:24:44.000000000","message":"We want to get it to voting, and blocking that on trunk specific fix is not ideal.","commit_id":"a240af5f2e4d4b25c5687be4d7bbbfa9e0297f13"}],"neutron/tests/tempest/scenario/test_trunk.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"744b7a01991c30797beef8dc5251228bd0da2397","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        \"\"\"If port binding vif type is ovs, disable port security for given"},{"line_number":151,"context_line":"        port."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        This is due to bug 1626010."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        for port_type in (\u0027parent_port\u0027, \u0027subport\u0027):"},{"line_number":156,"context_line":"            # Server is now active so refresh its data"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_f9d22a5c","line":153,"updated":"2017-05-31 10:12:06.000000000","message":"can you put a TODO in the comment so we can catch this in greps?","commit_id":"dbce181a440eb637cdc682f1db813dd18c73771e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1bda7a65acb3aaf0f2d4cd1bb4186521fb55db96","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        \"\"\"If port binding vif type is ovs, disable port security for given"},{"line_number":151,"context_line":"        port."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        This is due to bug 1626010."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        for port_type in (\u0027parent_port\u0027, \u0027subport\u0027):"},{"line_number":156,"context_line":"            # Server is now active so refresh its data"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_924db73f","line":153,"in_reply_to":"df140735_d4d60d28","updated":"2017-06-05 19:31:49.000000000","message":"sorry, missed that one","commit_id":"dbce181a440eb637cdc682f1db813dd18c73771e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7105a5fff4fa0a4ba2f6797afc1354051ed94090","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        \"\"\"If port binding vif type is ovs, disable port security for given"},{"line_number":151,"context_line":"        port."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        This is due to bug 1626010."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        for port_type in (\u0027parent_port\u0027, \u0027subport\u0027):"},{"line_number":156,"context_line":"            # Server is now active so refresh its data"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_d4d60d28","line":153,"in_reply_to":"df140735_f9d22a5c","updated":"2017-05-31 10:56:31.000000000","message":"This whole function should be removed after 1626010 and there is a TODO on L259, do you think that is not enough?","commit_id":"dbce181a440eb637cdc682f1db813dd18c73771e"}]}
