)]}'
{"neutron/tests/unit/plugins/ml2/test_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b360a564c49d4db25b9afa1c9101c1f811d1449e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                    api.SEGMENTATION_ID: 1}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self._create_segments("},{"line_number":187,"context_line":"            [segment1], is_seg_dynamic\u003dTrue, network_id\u003dnet_id)[0]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        segs1 \u003d segments_db.get_dynamic_segment("},{"line_number":190,"context_line":"            self.ctx, net_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_f5d83880","line":187,"updated":"2017-05-12 19:26:50.000000000","message":"remove the [0], you aren\u0027t doing anything with the return value anyway","commit_id":"6f876cfcccc562866f2389fe6ae77772eae33136"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"fe00e17de6843e1ad512378cdb96d1cf08b33a1b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                    api.SEGMENTATION_ID: 1}"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self._create_segments("},{"line_number":187,"context_line":"            [segment1], is_seg_dynamic\u003dTrue, network_id\u003dnet_id)[0]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        segs1 \u003d segments_db.get_dynamic_segment("},{"line_number":190,"context_line":"            self.ctx, net_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_e762cdd8","line":187,"in_reply_to":"1f013ff3_f5d83880","updated":"2017-05-13 04:50:12.000000000","message":"Done","commit_id":"6f876cfcccc562866f2389fe6ae77772eae33136"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"34f368402df9cbf6823e01fc12d0920492b11398","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        segs1 \u003d segments_db.get_dynamic_segment("},{"line_number":190,"context_line":"            self.ctx, net_id)"},{"line_number":191,"context_line":"        self.assertEqual(segs1[api.NETWORK_TYPE], \u0027vlan\u0027)"},{"line_number":192,"context_line":"        self.assertEqual(segs1[api.PHYSICAL_NETWORK], \u0027physnet1\u0027)"},{"line_number":193,"context_line":"        self.assertEqual(segs1[api.SEGMENTATION_ID], 1)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_855c0a4c","line":191,"updated":"2017-05-15 15:12:10.000000000","message":"please set the expected value as the first parameter","commit_id":"a3088468e3c1fae164838ad139a7c912ccc7280f"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"9bec978ecf5ed6798a1b5e7763dc7d4086441062","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        segs1 \u003d segments_db.get_dynamic_segment("},{"line_number":190,"context_line":"            self.ctx, net_id)"},{"line_number":191,"context_line":"        self.assertEqual(segs1[api.NETWORK_TYPE], \u0027vlan\u0027)"},{"line_number":192,"context_line":"        self.assertEqual(segs1[api.PHYSICAL_NETWORK], \u0027physnet1\u0027)"},{"line_number":193,"context_line":"        self.assertEqual(segs1[api.SEGMENTATION_ID], 1)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_c8a907e0","line":191,"in_reply_to":"1f013ff3_855c0a4c","updated":"2017-05-15 15:24:43.000000000","message":"Done","commit_id":"a3088468e3c1fae164838ad139a7c912ccc7280f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ab25d86ecb14cb6117df859157f184c6aa8c3f03","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs1[api.PHYSICAL_NETWORK])"},{"line_number":193,"context_line":"        self.assertEqual(1, segs1[api.SEGMENTATION_ID])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        segs2 \u003d segments_db.get_dynamic_segment("},{"line_number":196,"context_line":"            self.ctx, net_id, physical_network\u003d\u0027physnet1\u0027)"},{"line_number":197,"context_line":"        self.assertEqual(\u0027vlan\u0027, segs2[api.NETWORK_TYPE])"},{"line_number":198,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs2[api.PHYSICAL_NETWORK])"},{"line_number":199,"context_line":"        self.assertEqual(1, segs2[api.SEGMENTATION_ID])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        segs3 \u003d segments_db.get_dynamic_segment("},{"line_number":202,"context_line":"            self.ctx, net_id, segmentation_id\u003d1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_61cc4989","line":199,"range":{"start_line":195,"start_character":0,"end_line":199,"end_character":55},"updated":"2017-05-15 20:42:59.000000000","message":"Isn\u0027t this already tested in lines 1810 - 1820 here: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_plugin.py#L1810? Why duplicate it here?","commit_id":"8595a017028450ba1c5f7cd0da4e6a9bd624666e"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1990a5c4002a39492f4558566aa011bb65ffb6e6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs1[api.PHYSICAL_NETWORK])"},{"line_number":193,"context_line":"        self.assertEqual(1, segs1[api.SEGMENTATION_ID])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        segs2 \u003d segments_db.get_dynamic_segment("},{"line_number":196,"context_line":"            self.ctx, net_id, physical_network\u003d\u0027physnet1\u0027)"},{"line_number":197,"context_line":"        self.assertEqual(\u0027vlan\u0027, segs2[api.NETWORK_TYPE])"},{"line_number":198,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs2[api.PHYSICAL_NETWORK])"},{"line_number":199,"context_line":"        self.assertEqual(1, segs2[api.SEGMENTATION_ID])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        segs3 \u003d segments_db.get_dynamic_segment("},{"line_number":202,"context_line":"            self.ctx, net_id, segmentation_id\u003d1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_4be27fd7","line":199,"range":{"start_line":195,"start_character":0,"end_line":199,"end_character":55},"in_reply_to":"1f013ff3_61cc4989","updated":"2017-05-16 07:02:11.000000000","message":"Hi, Miguel. I think there are different, we pass physical_network in here.","commit_id":"8595a017028450ba1c5f7cd0da4e6a9bd624666e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ab25d86ecb14cb6117df859157f184c6aa8c3f03","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs2[api.PHYSICAL_NETWORK])"},{"line_number":199,"context_line":"        self.assertEqual(1, segs2[api.SEGMENTATION_ID])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        segs3 \u003d segments_db.get_dynamic_segment("},{"line_number":202,"context_line":"            self.ctx, net_id, segmentation_id\u003d1)"},{"line_number":203,"context_line":"        self.assertEqual(\u0027vlan\u0027, segs3[api.NETWORK_TYPE])"},{"line_number":204,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs3[api.PHYSICAL_NETWORK])"},{"line_number":205,"context_line":"        self.assertEqual(1, segs3[api.SEGMENTATION_ID])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def test_add_port_binding(self):"},{"line_number":208,"context_line":"        network_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_a188111f","line":205,"range":{"start_line":201,"start_character":0,"end_line":205,"end_character":55},"updated":"2017-05-15 20:42:59.000000000","message":"Isn\u0027t this already tested in lines 1821 - 1831 here: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_plugin.py#L1821? Same question, why duplicate it here?","commit_id":"8595a017028450ba1c5f7cd0da4e6a9bd624666e"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1990a5c4002a39492f4558566aa011bb65ffb6e6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs2[api.PHYSICAL_NETWORK])"},{"line_number":199,"context_line":"        self.assertEqual(1, segs2[api.SEGMENTATION_ID])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        segs3 \u003d segments_db.get_dynamic_segment("},{"line_number":202,"context_line":"            self.ctx, net_id, segmentation_id\u003d1)"},{"line_number":203,"context_line":"        self.assertEqual(\u0027vlan\u0027, segs3[api.NETWORK_TYPE])"},{"line_number":204,"context_line":"        self.assertEqual(\u0027physnet1\u0027, segs3[api.PHYSICAL_NETWORK])"},{"line_number":205,"context_line":"        self.assertEqual(1, segs3[api.SEGMENTATION_ID])"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def test_add_port_binding(self):"},{"line_number":208,"context_line":"        network_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_ebd02bfa","line":205,"range":{"start_line":201,"start_character":0,"end_line":205,"end_character":55},"in_reply_to":"1f013ff3_a188111f","updated":"2017-05-16 07:02:11.000000000","message":"ditto, pass segmentation_id here.","commit_id":"8595a017028450ba1c5f7cd0da4e6a9bd624666e"}]}