)]}'
{"neutron/plugins/ml2/driver_api.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"81f27e43275243b6bda85965728405185bc4f9f1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":26,"context_line":"NETWORK_TYPE \u003d \u0027network_type\u0027"},{"line_number":27,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":28,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"},{"line_number":29,"context_line":"MTU \u003d \u0027mtu\u0027"},{"line_number":30,"context_line":"NETWORK_ID \u003d \u0027network_id\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ff1785a2","side":"PARENT","line":28,"updated":"2017-06-01 12:29:17.000000000","message":"I think we need to leave behind shims for these because drivers reference them. Why shim the driver class but not the constants the drivers reference?","commit_id":"c430e9b8d41c139284e840be37629afcdbc96b37"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7ab95191c1fdc347242df504fc9fc6c217151b2e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":26,"context_line":"NETWORK_TYPE \u003d \u0027network_type\u0027"},{"line_number":27,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":28,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"},{"line_number":29,"context_line":"MTU \u003d \u0027mtu\u0027"},{"line_number":30,"context_line":"NETWORK_ID \u003d \u0027network_id\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ca5ab8f1","side":"PARENT","line":28,"in_reply_to":"df140735_809386a3","updated":"2017-06-01 15:08:00.000000000","message":"My understanding on the neutron-lib migration policy is to release a new neutron-lib first, then give plugin developers time to consume the neutron-lib interfaces and drop neutron references a bit later.\n\nSo, I wonder why we need to provide a shim of the driver class itself.","commit_id":"c430e9b8d41c139284e840be37629afcdbc96b37"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"237f5e3e07cb2052283103fd053c7129715bd5a0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":26,"context_line":"NETWORK_TYPE \u003d \u0027network_type\u0027"},{"line_number":27,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":28,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"},{"line_number":29,"context_line":"MTU \u003d \u0027mtu\u0027"},{"line_number":30,"context_line":"NETWORK_ID \u003d \u0027network_id\u0027"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_809386a3","side":"PARENT","line":28,"in_reply_to":"df140735_ff1785a2","updated":"2017-06-01 13:45:34.000000000","message":"As you know I don\u0027t think we should even be using shims, but OK, done.","commit_id":"c430e9b8d41c139284e840be37629afcdbc96b37"}],"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eb7f810a7384b99e8a7268e39d28d1d6a2b4d467","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron_lib.callbacks import events"},{"line_number":20,"context_line":"from neutron_lib.callbacks import registry"},{"line_number":21,"context_line":"from neutron_lib import constants"},{"line_number":22,"context_line":"from neutron_lib.plugins.ml2 import api"},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron.agent import securitygroups_rpc"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_f694e738","line":22,"updated":"2017-05-24 17:19:58.000000000","message":"where is it used?","commit_id":"a973cbb7ebd4de0243e3ba44fa991d7145e8a253"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"84d55bd7ce1d4743c958edf569050ae992c9f49e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron_lib.callbacks import events"},{"line_number":20,"context_line":"from neutron_lib.callbacks import registry"},{"line_number":21,"context_line":"from neutron_lib import constants"},{"line_number":22,"context_line":"from neutron_lib.plugins.ml2 import api"},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from neutron.agent import securitygroups_rpc"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_3931efed","line":22,"in_reply_to":"ff0f0b1f_f694e738","updated":"2017-05-26 12:27:41.000000000","message":"Done","commit_id":"a973cbb7ebd4de0243e3ba44fa991d7145e8a253"}]}
