)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b3c867b0cee89a49f8b69d1bd32a604c7265bad3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added document reference to this new parameter."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I4b74269ca1b56a6c29034a42e583db5160122ff9"},{"line_number":12,"context_line":"Closes-Bug: #1687392"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f013ff3_303d84bb","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":20},"updated":"2017-05-15 01:16:55.000000000","message":"While it is great that you are adding devref docs, how about the end user documentation: https://docs.openstack.org/ocata/networking-guide/config-qos.html? The source is here: https://github.com/openstack/openstack-manuals/blob/master/doc/networking-guide/source/config-qos.rst.\n\nAs far as I understand, this change is also relevant from the point of view of the end user. If that is correct, the end user documentation should also be updated and this patchset is only a partial fix of bug #1687392","commit_id":"8c9070165f6878251ba01556ffd26bbd797b4696"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1de10066949a27b4057dcab63f5d73efc084ed7f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Added document reference to this new parameter."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I4b74269ca1b56a6c29034a42e583db5160122ff9"},{"line_number":12,"context_line":"Closes-Bug: #1687392"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f013ff3_a766f850","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":20},"in_reply_to":"1f013ff3_303d84bb","updated":"2017-05-15 07:41:30.000000000","message":"You are right. I\u0027ll submit a modified user doc in the next patch.","commit_id":"8c9070165f6878251ba01556ffd26bbd797b4696"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"71cf91db18d22d56703bef07b6e66209ad3c5804","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"direction\" parameter to QosBandwidthLimitRule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added document reference to this new parameter."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I4b74269ca1b56a6c29034a42e583db5160122ff9"},{"line_number":12,"context_line":"Partial-Bug: #1687392"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f013ff3_e2318eee","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":47},"updated":"2017-05-15 07:55:04.000000000","message":"Better to write it as  \"direction parameter\"","commit_id":"fffdf91ca48837979a53cc5faf4c3c25ee08de35"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"801d5d4c73ebcb6540da23356e5b9b25dc0b716b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \"direction\" parameter to QosBandwidthLimitRule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added document reference to this new parameter."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I4b74269ca1b56a6c29034a42e583db5160122ff9"},{"line_number":12,"context_line":"Partial-Bug: #1687392"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f013ff3_62d0de51","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":47},"in_reply_to":"1f013ff3_e2318eee","updated":"2017-05-15 08:01:13.000000000","message":"Well, it\u0027s in the title.","commit_id":"fffdf91ca48837979a53cc5faf4c3c25ee08de35"}],"doc/source/devref/quality_of_service.rst":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"651c468ee6f6355cd16b12aba3f39de9d46f023f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* QosPolicy: directly maps to the conceptual policy resource, as defined above."},{"line_number":156,"context_line":"* QosBandwidthLimitRule: defines the bandwidth limit rule type, characterized"},{"line_number":157,"context_line":"  by a max_kbps parameter and a max_burst_kbits parameter. This rule has also a"},{"line_number":158,"context_line":"  direction parameter to set the traffic direction, from the instance point of"},{"line_number":159,"context_line":"  view."},{"line_number":160,"context_line":"* QosDscpMarkingRule: defines the DSCP rule type, characterized by an even integer"},{"line_number":161,"context_line":"  between 0 and 56.  These integers are the result of the bits in the DiffServ section"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f044301_7aea320f","line":158,"range":{"start_line":158,"start_character":2,"end_line":158,"end_character":33},"updated":"2017-05-11 17:18:19.000000000","message":"mind adding the allowed direction values here ?","commit_id":"8c9070165f6878251ba01556ffd26bbd797b4696"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c017aa2b70a81b0e430977c35ffdcbf0a198778a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"* QosPolicy: directly maps to the conceptual policy resource, as defined above."},{"line_number":156,"context_line":"* QosBandwidthLimitRule: defines the bandwidth limit rule type, characterized"},{"line_number":157,"context_line":"  by a max_kbps parameter and a max_burst_kbits parameter. This rule has also a"},{"line_number":158,"context_line":"  direction parameter to set the traffic direction, from the instance point of"},{"line_number":159,"context_line":"  view."},{"line_number":160,"context_line":"* QosDscpMarkingRule: defines the DSCP rule type, characterized by an even integer"},{"line_number":161,"context_line":"  between 0 and 56.  These integers are the result of the bits in the DiffServ section"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f013ff3_bb2d07aa","line":158,"range":{"start_line":158,"start_character":2,"end_line":158,"end_character":33},"in_reply_to":"3f044301_7aea320f","updated":"2017-05-12 14:34:47.000000000","message":"It\u0027s commented in the following section, in this patch: https://review.openstack.org/#/c/464038/.","commit_id":"8c9070165f6878251ba01556ffd26bbd797b4696"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"71cf91db18d22d56703bef07b6e66209ad3c5804","unresolved":false,"context_lines":[{"line_number":153,"context_line":"For QoS, the following neutron objects are implemented:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* QosPolicy: directly maps to the conceptual policy resource, as defined above."},{"line_number":156,"context_line":"* QosBandwidthLimitRule: defines the bandwidth limit rule type, characterized"},{"line_number":157,"context_line":"  by a max_kbps parameter and a max_burst_kbits parameter. This rule has also a"},{"line_number":158,"context_line":"  direction parameter to set the traffic direction, from the instance point of"},{"line_number":159,"context_line":"  view."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f013ff3_42404236","line":156,"range":{"start_line":156,"start_character":58,"end_line":156,"end_character":62},"updated":"2017-05-15 07:55:04.000000000","message":"not required","commit_id":"fffdf91ca48837979a53cc5faf4c3c25ee08de35"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"801d5d4c73ebcb6540da23356e5b9b25dc0b716b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"For QoS, the following neutron objects are implemented:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* QosPolicy: directly maps to the conceptual policy resource, as defined above."},{"line_number":156,"context_line":"* QosBandwidthLimitRule: defines the bandwidth limit rule type, characterized"},{"line_number":157,"context_line":"  by a max_kbps parameter and a max_burst_kbits parameter. This rule has also a"},{"line_number":158,"context_line":"  direction parameter to set the traffic direction, from the instance point of"},{"line_number":159,"context_line":"  view."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f013ff3_22d9b682","line":156,"range":{"start_line":156,"start_character":58,"end_line":156,"end_character":62},"in_reply_to":"1f013ff3_42404236","updated":"2017-05-15 08:01:13.000000000","message":"Done","commit_id":"fffdf91ca48837979a53cc5faf4c3c25ee08de35"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"71cf91db18d22d56703bef07b6e66209ad3c5804","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* QosPolicy: directly maps to the conceptual policy resource, as defined above."},{"line_number":156,"context_line":"* QosBandwidthLimitRule: defines the bandwidth limit rule type, characterized"},{"line_number":157,"context_line":"  by a max_kbps parameter and a max_burst_kbits parameter. This rule has also a"},{"line_number":158,"context_line":"  direction parameter to set the traffic direction, from the instance point of"},{"line_number":159,"context_line":"  view."},{"line_number":160,"context_line":"* QosDscpMarkingRule: defines the DSCP rule type, characterized by an even integer"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f013ff3_223d36bb","line":157,"range":{"start_line":157,"start_character":69,"end_line":157,"end_character":78},"updated":"2017-05-15 07:55:04.000000000","message":"also has","commit_id":"fffdf91ca48837979a53cc5faf4c3c25ee08de35"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"801d5d4c73ebcb6540da23356e5b9b25dc0b716b","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* QosPolicy: directly maps to the conceptual policy resource, as defined above."},{"line_number":156,"context_line":"* QosBandwidthLimitRule: defines the bandwidth limit rule type, characterized"},{"line_number":157,"context_line":"  by a max_kbps parameter and a max_burst_kbits parameter. This rule has also a"},{"line_number":158,"context_line":"  direction parameter to set the traffic direction, from the instance point of"},{"line_number":159,"context_line":"  view."},{"line_number":160,"context_line":"* QosDscpMarkingRule: defines the DSCP rule type, characterized by an even integer"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f013ff3_02e6ba45","line":157,"range":{"start_line":157,"start_character":69,"end_line":157,"end_character":78},"in_reply_to":"1f013ff3_223d36bb","updated":"2017-05-15 08:01:13.000000000","message":"Done","commit_id":"fffdf91ca48837979a53cc5faf4c3c25ee08de35"}]}
