)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"791183e8a65f211d6988c39a43915da61f63e6cf","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":131,"context_line":"    def get_security_groups(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":132,"context_line":"                            sorts\u003dNone, limit\u003dNone,"},{"line_number":133,"context_line":"                            marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":134,"context_line":"        marker_obj \u003d db_utils.get_marker_obj(self, context, \u0027security_group\u0027,"},{"line_number":135,"context_line":"                                             limit, marker)"},{"line_number":136,"context_line":"        return model_query.get_collection(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_db79f32f","line":133,"updated":"2017-05-12 14:10:10.000000000","message":"According to [1] (and I agree with this), Neutron should assert the validity of the submitted parameter, not avoid it.\n\nInstead of this, IMO you should modify \"_ensure_default_security_group\" function to read and check the validity of context.tenant_id and:\n- Raise an exception in case it doesn\u0027t exists\n- If project_id is valid, create the default SG if doesn\u0027t exists.\n- If project_id is valid and SG exists, do nothing.\n\n[1] https://bugs.launchpad.net/neutron/+bug/1653025/comments/1","commit_id":"a373fa16d723566e0e3d4df0bfbb79cc5e82e164"}]}
