)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"680349746df90f4a55d9f42e7a512b24a0745d2b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update to match ovdsbapp 0.4.0 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"idl_factory was removed in favor of just passing in an Idl instance"},{"line_number":10,"context_line":"as an Idl doesn\u0027t start a connection until its .run() is called."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Ie6dc0b75fc7c5ae00afc03e274f293b69d897913"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f013ff3_fe2d9446","line":9,"updated":"2017-05-15 19:44:00.000000000","message":"wait, you say you dropped some api that was public and plan to introduce gate breakage in between u-c bump and this?\n\nI am not even sure you will be able to pass reqs gate with unit tests for neutron broken, since we gate on them.","commit_id":"3bd31573c2a12f2ba0cea61ea54f0a1e9a20c680"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ecee5cef8af0168676dd7d727bf79e39dfce694c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"idl_factory was removed in favor of just passing in an Idl instance"},{"line_number":10,"context_line":"as an Idl doesn\u0027t start a connection until its .run() is called."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Ie6dc0b75fc7c5ae00afc03e274f293b69d897913"},{"line_number":13,"context_line":"Change-Id: Id22faa1f6179c2fdf8a136972d65f10749c9fc2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_2ec2d186","line":12,"updated":"2017-05-17 19:25:28.000000000","message":"you will need to remove this, the u-c bump patch won\u0027t be able to merge without this patch in.","commit_id":"01bb5d97156535e8dce4741480a0639424eeed65"}],"neutron/agent/ovsdb/impl_idl.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8e33eabe92259817470975019b6593ed3a7eb852","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            _connection \u003d connection.Connection("},{"line_number":46,"context_line":"                idl\u003dconnection.idl_factory(),"},{"line_number":47,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout)"},{"line_number":48,"context_line":"        except TypeError:"},{"line_number":49,"context_line":"            _connection \u003d connection.Connection("},{"line_number":50,"context_line":"                idl_factory\u003dconnection.idl_factory,"},{"line_number":51,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_26dbd31b","line":48,"updated":"2017-05-16 20:06:02.000000000","message":"smart","commit_id":"eb6540dae5ec809405746cd5ac670b8ba8513cca"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"07cf028c679afacd5b4fd30238c20908212afc36","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            _connection \u003d connection.Connection("},{"line_number":46,"context_line":"                idl\u003dconnection.idl_factory(),"},{"line_number":47,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout)"},{"line_number":48,"context_line":"        except TypeError:"},{"line_number":49,"context_line":"            _connection \u003d connection.Connection("},{"line_number":50,"context_line":"                idl_factory\u003dconnection.idl_factory,"},{"line_number":51,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_13afe5e3","line":48,"updated":"2017-05-17 08:05:57.000000000","message":"This is a pretty broad catch, I assume it\u0027s coming from the attempted call of the factory? If so, can you separate it out so it\u0027s more clear?\n\nidl \u003d connection.idl_factory\ntry:\n    idl \u003d idl()\nexcept TypeError:\n    pass\n_connection \u003d connection.Connection(idl\u003didl, timeout\u003dcfg.CONF.ovs_vsctl_timeout)","commit_id":"01bb5d97156535e8dce4741480a0639424eeed65"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ecee5cef8af0168676dd7d727bf79e39dfce694c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            _connection \u003d connection.Connection("},{"line_number":46,"context_line":"                idl\u003dconnection.idl_factory(),"},{"line_number":47,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout)"},{"line_number":48,"context_line":"        except TypeError:"},{"line_number":49,"context_line":"            _connection \u003d connection.Connection("},{"line_number":50,"context_line":"                idl_factory\u003dconnection.idl_factory,"},{"line_number":51,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_2e477120","line":48,"in_reply_to":"1f013ff3_13afe5e3","updated":"2017-05-17 19:25:28.000000000","message":"It\u0027s because of renamed argument to Connection.__init__. We will clean that up after bumping minimal version to 0.4.0. (Terry could add some TODO for that I guess to clarify the plan.)","commit_id":"01bb5d97156535e8dce4741480a0639424eeed65"}],"neutron/tests/functional/agent/ovsdb/native/test_connection.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8e33eabe92259817470975019b6593ed3a7eb852","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            return idl.Idl(connection, helper)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.connection \u003d connection.Connection("},{"line_number":43,"context_line":"            idl\u003d_idl_factory(),"},{"line_number":44,"context_line":"            timeout\u003dcfg.CONF.ovs_vsctl_timeout,"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        self.connection.start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_a6000369","line":43,"updated":"2017-05-16 20:06:02.000000000","message":"this will fail with older version though no?","commit_id":"eb6540dae5ec809405746cd5ac670b8ba8513cca"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"07cf028c679afacd5b4fd30238c20908212afc36","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                idl\u003d_idl_factory(),"},{"line_number":45,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout,"},{"line_number":46,"context_line":"            )"},{"line_number":47,"context_line":"        except TypeError:"},{"line_number":48,"context_line":"            self.connection \u003d connection.Connection("},{"line_number":49,"context_line":"                idl_factory\u003d_idl_factory,"},{"line_number":50,"context_line":"                timeout\u003dcfg.CONF.ovs_vsctl_timeout,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_33a8a1d9","line":47,"updated":"2017-05-17 08:05:57.000000000","message":"similar comment here, it\u0027s not clear where the typeerror is coming from","commit_id":"01bb5d97156535e8dce4741480a0639424eeed65"}],"neutron/tests/unit/agent/ovsdb/native/test_connection.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8e33eabe92259817470975019b6593ed3a7eb852","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # raise until 3rd retry attempt"},{"line_number":38,"context_line":"        mock_get_schema_helper.side_effect \u003d [Exception(), Exception(),"},{"line_number":39,"context_line":"                                              mock_helper]"},{"line_number":40,"context_line":"        conn \u003d connection.Connection(idl\u003dnative_conn.idl_factory(),"},{"line_number":41,"context_line":"                                     timeout\u003dmock.Mock())"},{"line_number":42,"context_line":"        conn.start()"},{"line_number":43,"context_line":"        self.assertEqual(3, len(mock_get_schema_helper.mock_calls))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_66fafb75","line":40,"updated":"2017-05-16 20:06:02.000000000","message":"this will prolly fail with older version?","commit_id":"eb6540dae5ec809405746cd5ac670b8ba8513cca"}]}
