)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b0a2a9c0869230d42f6306ca4a35abeefc14640e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use SUBNET instead of SUBNET_GATEWAY event in L3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SUBNET_GATEWAY is being superceded by SUBNET, so"},{"line_number":10,"context_line":"we can just use that instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3ef5e6a046df4bae28aa111a796210a59df820fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f013ff3_85b85cc8","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":34},"updated":"2017-05-16 21:34:40.000000000","message":"Nit: superseded","commit_id":"8f2aad8fe169e8d6c9663f808898b90e0b62aefd"}],"neutron/db/l3_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac67d18b7b99e3439f71cd4ee0a297e6c1be3afd","unresolved":false,"context_lines":[{"line_number":1757,"context_line":"        if orig[\u0027gateway_ip\u0027] \u003d\u003d updated[\u0027gateway_ip\u0027]:"},{"line_number":1758,"context_line":"            return"},{"line_number":1759,"context_line":"        network_id \u003d updated[\u0027network_id\u0027]"},{"line_number":1760,"context_line":"        subnet_id \u003d updated[\u0027id\u0027]"},{"line_number":1761,"context_line":"        query \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":1762,"context_line":"                    network_id\u003dnetwork_id,"},{"line_number":1763,"context_line":"                    device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_fa513e64","line":1760,"updated":"2017-05-17 16:03:02.000000000","message":"This is doing more than just change to resources.SUBNET, you should add a unit test for this original_subnet case.","commit_id":"8f2aad8fe169e8d6c9663f808898b90e0b62aefd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4187e6a032d55f0bb973ba15e4063cf7f33d4660","unresolved":false,"context_lines":[{"line_number":1757,"context_line":"        if orig[\u0027gateway_ip\u0027] \u003d\u003d updated[\u0027gateway_ip\u0027]:"},{"line_number":1758,"context_line":"            return"},{"line_number":1759,"context_line":"        network_id \u003d updated[\u0027network_id\u0027]"},{"line_number":1760,"context_line":"        subnet_id \u003d updated[\u0027id\u0027]"},{"line_number":1761,"context_line":"        query \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":1762,"context_line":"                    network_id\u003dnetwork_id,"},{"line_number":1763,"context_line":"                    device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_62943f8c","line":1760,"in_reply_to":"ff0f0b1f_6271f8e0","updated":"2017-05-18 14:48:34.000000000","message":"I didn\u0027t know there was already a test for this, I was just making an assumption based on the code change being different from what the commit message was saying.  I guess the change to SUBNET requires a change in info being sent, just wasn\u0027t obvious, but now it is :)","commit_id":"8f2aad8fe169e8d6c9663f808898b90e0b62aefd"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1821cc0c9b6d66820217eb5610a9f8752becc379","unresolved":false,"context_lines":[{"line_number":1757,"context_line":"        if orig[\u0027gateway_ip\u0027] \u003d\u003d updated[\u0027gateway_ip\u0027]:"},{"line_number":1758,"context_line":"            return"},{"line_number":1759,"context_line":"        network_id \u003d updated[\u0027network_id\u0027]"},{"line_number":1760,"context_line":"        subnet_id \u003d updated[\u0027id\u0027]"},{"line_number":1761,"context_line":"        query \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":1762,"context_line":"                    network_id\u003dnetwork_id,"},{"line_number":1763,"context_line":"                    device_owner\u003dconstants.DEVICE_OWNER_ROUTER_GW)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_6271f8e0","line":1760,"in_reply_to":"ff0f0b1f_fa513e64","updated":"2017-05-17 22:42:20.000000000","message":"I\u0027m not sure what you mean, the test_update_subnet_gateway_for_external_net exercises this callback already. Which logic do you want covered?","commit_id":"8f2aad8fe169e8d6c9663f808898b90e0b62aefd"}]}
