)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cbf42a5aa6e370916aed003dc69bc31fa5846f1b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Mark ports as pending delete on subnet deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The deletion of dhcp ports is done asynchronously"},{"line_number":10,"context_line":"so horizon displays the port after subnet deletion."},{"line_number":11,"context_line":"Need to mark such ports as pending delete to let"},{"line_number":12,"context_line":"horizon filter and not display them"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAASn%2F%2B%2Fxg%3D","line":9,"updated":"2013-09-13 20:54:22.000000000","message":"This is strictly true for plugins that use on the dhcp agent.","commit_id":"14bfbb007279cf7cd13a972bba9eaa922633f8eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a516281195795d2698784ad0c843e73180a8ec2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Mark ports as pending delete on subnet deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The deletion of dhcp ports is done asynchronously"},{"line_number":10,"context_line":"so horizon displays the port after subnet deletion."},{"line_number":11,"context_line":"Need to mark such ports as pending delete to let"},{"line_number":12,"context_line":"horizon filter and not display them"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAS3%2F%2F%2Bpo%3D","line":9,"in_reply_to":"AAAASn%2F%2B%2Fxg%3D","updated":"2013-09-16 08:04:57.000000000","message":"Thanks for pointing. Agree, this patch should also handle plugins that do not use dhcp agent.","commit_id":"14bfbb007279cf7cd13a972bba9eaa922633f8eb"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"965f0991687d6527cc3eae4580340b184e1fb800","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"                    self.update_port("},{"line_number":1273,"context_line":"                        context, a.port_id,"},{"line_number":1274,"context_line":"                        {\u0027port\u0027:"},{"line_number":1275,"context_line":"                            {\u0027status\u0027: constants.PORT_STATUS_PENDING_DELETE}})"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            # remove network owned ports"},{"line_number":1278,"context_line":"            allocated.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FA0A%3D","line":1275,"updated":"2013-09-13 17:18:24.000000000","message":"The commit message says about dhcp port. Is the same applied to other ports as well?","commit_id":"14bfbb007279cf7cd13a972bba9eaa922633f8eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a516281195795d2698784ad0c843e73180a8ec2","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"                    self.update_port("},{"line_number":1273,"context_line":"                        context, a.port_id,"},{"line_number":1274,"context_line":"                        {\u0027port\u0027:"},{"line_number":1275,"context_line":"                            {\u0027status\u0027: constants.PORT_STATUS_PENDING_DELETE}})"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            # remove network owned ports"},{"line_number":1278,"context_line":"            allocated.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F%2Bos%3D","line":1275,"in_reply_to":"AAAASn%2F%2FA0A%3D","updated":"2013-09-16 08:04:57.000000000","message":"Currently AUTO_DELETE_PORT_OWNERS is [\u0027network:dhcp\u0027] so at this point these may only be dhcp ports (an exc will be raised on #1266 otherwise).","commit_id":"14bfbb007279cf7cd13a972bba9eaa922633f8eb"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"62af551a06ec5f99891f4b7d8f17e01c4706c2f8","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"                    self.update_port("},{"line_number":1273,"context_line":"                        context, a.port_id,"},{"line_number":1274,"context_line":"                        {\u0027port\u0027:"},{"line_number":1275,"context_line":"                            {\u0027status\u0027: constants.PORT_STATUS_PENDING_DELETE}})"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            # remove network owned ports"},{"line_number":1278,"context_line":"            allocated.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FAAY%3D","line":1275,"in_reply_to":"AAAASn%2F%2FA0A%3D","updated":"2013-09-13 18:57:43.000000000","message":"This is only true in the situation where a port is associated with exactly one subnet.  If the port is has allocations for multiple subnets this status is inaccurate.","commit_id":"14bfbb007279cf7cd13a972bba9eaa922633f8eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a516281195795d2698784ad0c843e73180a8ec2","unresolved":false,"context_lines":[{"line_number":1272,"context_line":"                    self.update_port("},{"line_number":1273,"context_line":"                        context, a.port_id,"},{"line_number":1274,"context_line":"                        {\u0027port\u0027:"},{"line_number":1275,"context_line":"                            {\u0027status\u0027: constants.PORT_STATUS_PENDING_DELETE}})"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"            # remove network owned ports"},{"line_number":1278,"context_line":"            allocated.delete()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2F%2Bok%3D","line":1275,"in_reply_to":"AAAASn%2F%2FAAY%3D","updated":"2013-09-16 08:04:57.000000000","message":"Agree, thanks for pointing.","commit_id":"14bfbb007279cf7cd13a972bba9eaa922633f8eb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a298b864b3931035cfe1ba311372609d6895ed4f","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"            # mark the dhcp port as pending delete if dhcp agent is used"},{"line_number":1269,"context_line":"            # and the port is not associated with other subnets"},{"line_number":1270,"context_line":"            if cfg.CONF.dhcp_agent_notification:"},{"line_number":1271,"context_line":"                for a in allocated:"},{"line_number":1272,"context_line":"                    if a.port_id and a.ports.device_owner \u003d\u003d \u0027network:dhcp\u0027:"},{"line_number":1273,"context_line":"                        port_subnets \u003d set(fixed_ip.subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FwVw%3D","line":1270,"updated":"2013-10-29 14:31:16.000000000","message":"This does not really determine whether the agent is used or not, the supported_extensions_alias will.","commit_id":"df35940b139b6a8cc4aa874516aba6ef7deb02eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"85e6f615afe9245378ddc00026804ed13ee580bc","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"            # mark the dhcp port as pending delete if dhcp agent is used"},{"line_number":1269,"context_line":"            # and the port is not associated with other subnets"},{"line_number":1270,"context_line":"            if cfg.CONF.dhcp_agent_notification:"},{"line_number":1271,"context_line":"                for a in allocated:"},{"line_number":1272,"context_line":"                    if a.port_id and a.ports.device_owner \u003d\u003d \u0027network:dhcp\u0027:"},{"line_number":1273,"context_line":"                        port_subnets \u003d set(fixed_ip.subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FsyA%3D","line":1270,"in_reply_to":"AAAATn%2F%2FvjY%3D","updated":"2013-10-30 09:13:40.000000000","message":"Thanks, I think checking for supported dhcp_agent_scheduler combined with dhcp_agent_notification set to True is the best option.","commit_id":"df35940b139b6a8cc4aa874516aba6ef7deb02eb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4c3cf0c832d2ca7ebcca783ca1f38a873a2d95eb","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"            # mark the dhcp port as pending delete if dhcp agent is used"},{"line_number":1269,"context_line":"            # and the port is not associated with other subnets"},{"line_number":1270,"context_line":"            if cfg.CONF.dhcp_agent_notification:"},{"line_number":1271,"context_line":"                for a in allocated:"},{"line_number":1272,"context_line":"                    if a.port_id and a.ports.device_owner \u003d\u003d \u0027network:dhcp\u0027:"},{"line_number":1273,"context_line":"                        port_subnets \u003d set(fixed_ip.subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FvjY%3D","line":1270,"in_reply_to":"AAAATn%2F%2FwCs%3D","updated":"2013-10-29 16:26:06.000000000","message":"https://github.com/openstack/neutron/blob/master/neutron/extensions/agent.py\nhttps://github.com/openstack/neutron/blob/master/neutron/extensions/dhcpagentscheduler.py","commit_id":"df35940b139b6a8cc4aa874516aba6ef7deb02eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"49eb3c186f3ddc8bedc5fab739feeeb06a411bb6","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"            # mark the dhcp port as pending delete if dhcp agent is used"},{"line_number":1269,"context_line":"            # and the port is not associated with other subnets"},{"line_number":1270,"context_line":"            if cfg.CONF.dhcp_agent_notification:"},{"line_number":1271,"context_line":"                for a in allocated:"},{"line_number":1272,"context_line":"                    if a.port_id and a.ports.device_owner \u003d\u003d \u0027network:dhcp\u0027:"},{"line_number":1273,"context_line":"                        port_subnets \u003d set(fixed_ip.subnet_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FwCs%3D","line":1270,"in_reply_to":"AAAATn%2F%2FwVw%3D","updated":"2013-10-29 15:19:43.000000000","message":"can you please point which exact extension alias means that dhcp agent is used?","commit_id":"df35940b139b6a8cc4aa874516aba6ef7deb02eb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a298b864b3931035cfe1ba311372609d6895ed4f","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                                           for fixed_ip in a.ports.fixed_ips)"},{"line_number":1275,"context_line":"                        if len(port_subnets) \u003e 1:"},{"line_number":1276,"context_line":"                            continue"},{"line_number":1277,"context_line":"                        self.update_port("},{"line_number":1278,"context_line":"                            context, a.port_id,"},{"line_number":1279,"context_line":"                            {\u0027port\u0027:"},{"line_number":1280,"context_line":"                                {\u0027status\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FwWU%3D","line":1277,"updated":"2013-10-29 14:31:16.000000000","message":"currently this part of the code is affected by race conditions (see bug #1197627), if we add extra computation and extra updates this will only make things worse. I\u0027d rather address the race condition first.","commit_id":"df35940b139b6a8cc4aa874516aba6ef7deb02eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"85e6f615afe9245378ddc00026804ed13ee580bc","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                                           for fixed_ip in a.ports.fixed_ips)"},{"line_number":1275,"context_line":"                        if len(port_subnets) \u003e 1:"},{"line_number":1276,"context_line":"                            continue"},{"line_number":1277,"context_line":"                        self.update_port("},{"line_number":1278,"context_line":"                            context, a.port_id,"},{"line_number":1279,"context_line":"                            {\u0027port\u0027:"},{"line_number":1280,"context_line":"                                {\u0027status\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Fsxs%3D","line":1277,"in_reply_to":"AAAATn%2F%2FwCE%3D","updated":"2013-10-30 09:13:40.000000000","message":"Will rebase this patch on the patch which fixes race condition: https://review.openstack.org/#/c/46563","commit_id":"df35940b139b6a8cc4aa874516aba6ef7deb02eb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"49eb3c186f3ddc8bedc5fab739feeeb06a411bb6","unresolved":false,"context_lines":[{"line_number":1274,"context_line":"                                           for fixed_ip in a.ports.fixed_ips)"},{"line_number":1275,"context_line":"                        if len(port_subnets) \u003e 1:"},{"line_number":1276,"context_line":"                            continue"},{"line_number":1277,"context_line":"                        self.update_port("},{"line_number":1278,"context_line":"                            context, a.port_id,"},{"line_number":1279,"context_line":"                            {\u0027port\u0027:"},{"line_number":1280,"context_line":"                                {\u0027status\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FwCE%3D","line":1277,"in_reply_to":"AAAATn%2F%2FwWU%3D","updated":"2013-10-29 15:19:43.000000000","message":"thanks for pointing, will check this.","commit_id":"df35940b139b6a8cc4aa874516aba6ef7deb02eb"}]}