)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f2ba33e32cb88c2426050f4317ec498cdc88a53","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            # retry reference errors so we can check the port type and"},{"line_number":448,"context_line":"            # cleanup if a network-owned port snuck in without failing"},{"line_number":449,"context_line":"            for subnet in subnets:"},{"line_number":450,"context_line":"                self.delete_subnet(context, subnet[\u0027id\u0027])"},{"line_number":451,"context_line":"            with db_api.context_manager.writer.using(context):"},{"line_number":452,"context_line":"                network_db \u003d self._get_network(context, id)"},{"line_number":453,"context_line":"                network \u003d self._make_network_dict(network_db, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_6b608402","line":450,"updated":"2017-05-16 19:36:29.000000000","message":"Do we need to handle SubnetNotFound here?","commit_id":"132e22bcfc761b56898a0288191782dbeb360452"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"aaf1a04a058e71fa814e8eda6c48e15769287d1a","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            # retry reference errors so we can check the port type and"},{"line_number":448,"context_line":"            # cleanup if a network-owned port snuck in without failing"},{"line_number":449,"context_line":"            for subnet in subnets:"},{"line_number":450,"context_line":"                self.delete_subnet(context, subnet[\u0027id\u0027])"},{"line_number":451,"context_line":"            with db_api.context_manager.writer.using(context):"},{"line_number":452,"context_line":"                network_db \u003d self._get_network(context, id)"},{"line_number":453,"context_line":"                network \u003d self._make_network_dict(network_db, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_c679cf93","line":450,"in_reply_to":"1f013ff3_6b608402","updated":"2017-05-16 19:44:40.000000000","message":"Possibly, though I\u0027d leave this outside the context of this patch, as I\u0027d like to see the failure explicitly","commit_id":"132e22bcfc761b56898a0288191782dbeb360452"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d68557b7ef777fef5fd89c0980b3faf93ca1802b","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            # retry reference errors so we can check the port type and"},{"line_number":448,"context_line":"            # cleanup if a network-owned port snuck in without failing"},{"line_number":449,"context_line":"            for subnet in subnets:"},{"line_number":450,"context_line":"                self.delete_subnet(context, subnet[\u0027id\u0027])"},{"line_number":451,"context_line":"            with db_api.context_manager.writer.using(context):"},{"line_number":452,"context_line":"                network_db \u003d self._get_network(context, id)"},{"line_number":453,"context_line":"                network \u003d self._make_network_dict(network_db, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_616ae5b3","line":450,"in_reply_to":"1f013ff3_c679cf93","updated":"2017-05-16 20:28:26.000000000","message":"Yeah I was thinking the same, keep the patch small and targeted. Now I just need to figure out how to make this work:\n\nhttp://paste.openstack.org/show/609718/","commit_id":"132e22bcfc761b56898a0288191782dbeb360452"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"19a20ec35b3f20fcc412397a59b0aebffc59e497","unresolved":false,"context_lines":[{"line_number":1599,"context_line":"        def fake_delete_port(context, id):"},{"line_number":1600,"context_line":"            # Delete the port for real from the database and then raise"},{"line_number":1601,"context_line":"            # PortNotFound to simulate the race."},{"line_number":1602,"context_line":"            req \u003d self.new_delete_request(\u0027ports\u0027, id)"},{"line_number":1603,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":1604,"context_line":"            self.assertEqual(webob.exc.HTTPNoContent.code, res.status_int)"},{"line_number":1605,"context_line":"            raise lib_exc.PortNotFound(port_id\u003did)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_683ac598","line":1602,"updated":"2017-05-16 21:59:44.000000000","message":"recursion here. new_delete_request for ports will end up calling delete_port, which ends up calling here, which ends up calling delete port. :)","commit_id":"5c1edce174a3b481edaac298efffb44bc9163903"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"976dd2854394fc2b36d4b90297d98770aeb7d180","unresolved":false,"context_lines":[{"line_number":1599,"context_line":"        def fake_delete_port(context, id):"},{"line_number":1600,"context_line":"            # Delete the port for real from the database and then raise"},{"line_number":1601,"context_line":"            # PortNotFound to simulate the race."},{"line_number":1602,"context_line":"            req \u003d self.new_delete_request(\u0027ports\u0027, id)"},{"line_number":1603,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":1604,"context_line":"            self.assertEqual(webob.exc.HTTPNoContent.code, res.status_int)"},{"line_number":1605,"context_line":"            raise lib_exc.PortNotFound(port_id\u003did)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_8e7639a4","line":1602,"in_reply_to":"1f013ff3_683ac598","updated":"2017-05-16 23:42:10.000000000","message":"Gah, crazy computers.","commit_id":"5c1edce174a3b481edaac298efffb44bc9163903"}]}
