)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3fd3a43675d83d58774b81a00f65238d7de4dbba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Songming Yan \u003cyan.songming@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-17 08:16:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change \"is default\" value in network when create a network with"},{"line_number":8,"context_line":"--default and --internal"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1691340"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f013ff3_77697489","line":7,"updated":"2017-05-17 08:29:28.000000000","message":"please see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"fe3893ebc899258b5f1c56898b4c713772b492e4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1071dcf38385cde2f75f201a3667290f03cd95e9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-05-17 08:16:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change \"is default\" value in network when create a network with"},{"line_number":8,"context_line":"--default and --internal"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1691340"},{"line_number":11,"context_line":"Change-Id: I502ef2fb7341056b50e032b5088ba51cffc2572c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff0f0b1f_2891a953","line":8,"updated":"2017-05-17 18:18:23.000000000","message":"The default flag only works with --external networks, we should probably be more explicit about this in the docs.","commit_id":"fe3893ebc899258b5f1c56898b4c713772b492e4"}],"neutron/services/auto_allocate/db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"81488d67f14880a67e32f546cfd540c684d3a0af","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @resource_extend.extends([attributes.NETWORKS])"},{"line_number":112,"context_line":"    def _extend_external_network_default(net_res, net_db):"},{"line_number":113,"context_line":"        \"\"\"Add is_default field to \u0027show\u0027 response.\"\"\""},{"line_number":114,"context_line":"        if net_db.external is not None:"},{"line_number":115,"context_line":"            net_res[IS_DEFAULT] \u003d net_db.external.is_default"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            net_res[IS_DEFAULT] \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_782ba681","line":114,"updated":"2017-05-17 07:36:11.000000000","message":"this conditional isn\u0027t needed anymore, you can assign to net_res always","commit_id":"438289c6ffa67adf51b746432eec3cc788f46783"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1dd6e7aa4846892b88f3b56589a1eab64dec246d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @resource_extend.extends([attributes.NETWORKS])"},{"line_number":112,"context_line":"    def _extend_external_network_default(net_res, net_db):"},{"line_number":113,"context_line":"        \"\"\"Add is_default field to \u0027show\u0027 response.\"\"\""},{"line_number":114,"context_line":"        if net_db.external is not None:"},{"line_number":115,"context_line":"            net_res[IS_DEFAULT] \u003d net_db.external.is_default"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            net_res[IS_DEFAULT] \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_c6557f1f","line":114,"in_reply_to":"1f013ff3_782ba681","updated":"2017-05-17 18:00:20.000000000","message":"The conditional was added to avoid showing the field when not significant.","commit_id":"438289c6ffa67adf51b746432eec3cc788f46783"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3fd3a43675d83d58774b81a00f65238d7de4dbba","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @resource_extend.extends([attributes.NETWORKS])"},{"line_number":112,"context_line":"    def _extend_external_network_default(net_res, net_db):"},{"line_number":113,"context_line":"        \"\"\"Add is_default field to \u0027show\u0027 response.\"\"\""},{"line_number":114,"context_line":"        net_res[IS_DEFAULT] \u003d None"},{"line_number":115,"context_line":"        return net_res"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_auto_allocated_topology(self, context, tenant_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f013ff3_771734ef","line":114,"updated":"2017-05-17 08:29:28.000000000","message":"unit test?","commit_id":"fe3893ebc899258b5f1c56898b4c713772b492e4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"02d2e5b4456267e1b38a80b0680c5499ae5492fe","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @resource_extend.extends([attributes.NETWORKS])"},{"line_number":112,"context_line":"    def _extend_external_network_default(net_res, net_db):"},{"line_number":113,"context_line":"        \"\"\"Add is_default field to \u0027show\u0027 response.\"\"\""},{"line_number":114,"context_line":"        net_res[IS_DEFAULT] \u003d None"},{"line_number":115,"context_line":"        return net_res"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_auto_allocated_topology(self, context, tenant_id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_06c25786","line":114,"in_reply_to":"1f013ff3_771734ef","updated":"2017-05-17 18:17:34.000000000","message":"You can\u0027t unconditionally put this field to NONE. This is clearly broken, and no unit test makes sense. This should really be:\n\nnet_res[IS_DEFAULT] \u003d net_db.external.is_default","commit_id":"fe3893ebc899258b5f1c56898b4c713772b492e4"}]}