)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fe58a18273dbcab62103d03c84029d043e7b5b2e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change simply adds the port ID to the network-changed event"},{"line_number":16,"context_line":"since we have it in scope. Nova can use it or not, but at least"},{"line_number":17,"context_line":"the information is provided for context."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifdaef05208d09ddd9587fed6214cf388e5265ba4"},{"line_number":20,"context_line":"Closes-Bug: #1691602"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff0f0b1f_cb944047","line":17,"updated":"2017-05-18 19:03:46.000000000","message":"Don\u0027t you love the absolute fluidity of this unpublished/unversioned API? :P","commit_id":"bf8e6007cfa50d461790be325e9e97b8b396ae47"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"57265951f3e779b523748ed4e4461d7e3e9ab5f8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change simply adds the port ID to the network-changed event"},{"line_number":16,"context_line":"since we have it in scope. Nova can use it or not, but at least"},{"line_number":17,"context_line":"the information is provided for context."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifdaef05208d09ddd9587fed6214cf388e5265ba4"},{"line_number":20,"context_line":"Closes-Bug: #1691602"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff0f0b1f_bca7f0a7","line":17,"in_reply_to":"ff0f0b1f_cb944047","updated":"2017-05-19 20:21:50.000000000","message":"It\u0027s published:\n\nhttps://developer.openstack.org/api-ref/compute/#create-external-events-os-server-external-events\n\nIf we added new fields those would require microversion changes, but we\u0027re just populating an existing field.\n\nOtherwise yes sometimes the wild west is fun.","commit_id":"bf8e6007cfa50d461790be325e9e97b8b396ae47"}],"neutron/tests/unit/notifiers/test_nova.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"b6bf3cdb4ea946736d1db2f8a766e5e613be3904","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        expected_event \u003d {\u0027server_uuid\u0027: device_id,"},{"line_number":148,"context_line":"                          \u0027name\u0027: \u0027network-changed\u0027,"},{"line_number":149,"context_line":"                          \u0027tag\u0027: returned_obj[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":150,"context_line":"        event \u003d self.nova_notifier.create_port_changed_event(\u0027update_port\u0027,"},{"line_number":151,"context_line":"                                                             {}, returned_obj)"},{"line_number":152,"context_line":"        self.assertEqual(event, expected_event)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_d26eacfe","line":149,"range":{"start_line":149,"start_character":33,"end_line":149,"end_character":59},"updated":"2017-05-23 23:48:20.000000000","message":"It would be cleaner to define \"port_id \u003d u\u0027bee50827-bcee-4cc8-91c1-a27b0ce54222\u0027\" and then use it in both returned_obj and expected_event, in the same way we do with \"device_id\".  This applies below as well.","commit_id":"bf8e6007cfa50d461790be325e9e97b8b396ae47"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1fa3e7138fbfb540d391ae177d193704011b236c","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        expected_event \u003d {\u0027server_uuid\u0027: device_id,"},{"line_number":148,"context_line":"                          \u0027name\u0027: \u0027network-changed\u0027,"},{"line_number":149,"context_line":"                          \u0027tag\u0027: returned_obj[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":150,"context_line":"        event \u003d self.nova_notifier.create_port_changed_event(\u0027update_port\u0027,"},{"line_number":151,"context_line":"                                                             {}, returned_obj)"},{"line_number":152,"context_line":"        self.assertEqual(event, expected_event)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_280c1a92","line":149,"range":{"start_line":149,"start_character":33,"end_line":149,"end_character":59},"in_reply_to":"ff0f0b1f_77331515","updated":"2017-05-25 14:49:07.000000000","message":"Oh, definitely on the nit side.  As for the cleaner part, it\u0027d be basically following the model already used for \"device_id\" in the same routines.  Consistency is nice.\n\nNot going to -1 the patch for this though.","commit_id":"bf8e6007cfa50d461790be325e9e97b8b396ae47"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"607ab5c8368e0d4b769ff3001729aa994751f1e4","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        expected_event \u003d {\u0027server_uuid\u0027: device_id,"},{"line_number":148,"context_line":"                          \u0027name\u0027: \u0027network-changed\u0027,"},{"line_number":149,"context_line":"                          \u0027tag\u0027: returned_obj[\u0027port\u0027][\u0027id\u0027]}"},{"line_number":150,"context_line":"        event \u003d self.nova_notifier.create_port_changed_event(\u0027update_port\u0027,"},{"line_number":151,"context_line":"                                                             {}, returned_obj)"},{"line_number":152,"context_line":"        self.assertEqual(event, expected_event)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_77331515","line":149,"range":{"start_line":149,"start_character":33,"end_line":149,"end_character":59},"in_reply_to":"ff0f0b1f_d26eacfe","updated":"2017-05-25 13:29:51.000000000","message":"Seems pretty nit picky to me, and I don\u0027t really agree that it\u0027s cleaner.","commit_id":"bf8e6007cfa50d461790be325e9e97b8b396ae47"}]}