)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5626ec4f3eff4c7cbfaaea74b40b800e8f77df92","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"            self.extension_manager.process_create_port(context, attrs, result)"},{"line_number":1111,"context_line":"            self._portsec_ext_port_create_processing(context, result, port)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"            # sgids must be got after portsec checked with security group"},{"line_number":1114,"context_line":"            sgids \u003d self._get_security_groups_on_port(context, port)"},{"line_number":1115,"context_line":"            self._process_port_create_security_group(context, result, sgids)"},{"line_number":1116,"context_line":"            network \u003d self.get_network(context, result[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_4f38069f","line":1113,"updated":"2017-05-21 05:49:10.000000000","message":"why are we not skipping this block here too? it seems like this is only addressing the update but not the create.","commit_id":"b4687b235fd95d041f419fecda6bc93202699148"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9b281dc23ead2b335b34a1bb6737b9084accbda5","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"            self.extension_manager.process_create_port(context, attrs, result)"},{"line_number":1111,"context_line":"            self._portsec_ext_port_create_processing(context, result, port)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"            # sgids must be got after portsec checked with security group"},{"line_number":1114,"context_line":"            sgids \u003d self._get_security_groups_on_port(context, port)"},{"line_number":1115,"context_line":"            self._process_port_create_security_group(context, result, sgids)"},{"line_number":1116,"context_line":"            network \u003d self.get_network(context, result[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_52ebe6da","line":1113,"in_reply_to":"ff0f0b1f_4f38069f","updated":"2017-05-22 22:08:29.000000000","message":"I don\u0027t want to start sprinkling the skip all over the place. It\u0027s unnecessary.","commit_id":"b4687b235fd95d041f419fecda6bc93202699148"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5626ec4f3eff4c7cbfaaea74b40b800e8f77df92","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"            if updated_port[addr_pair.ADDRESS_PAIRS]:"},{"line_number":1195,"context_line":"                raise addr_pair.AddressPairAndPortSecurityRequired()"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        # checks if security groups were updated adding/modifying"},{"line_number":1198,"context_line":"        # security groups, port security is set"},{"line_number":1199,"context_line":"        if self._check_update_has_security_groups(port):"},{"line_number":1200,"context_line":"            raise psec.PortSecurityAndIPRequiredForSecurityGroups()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_8fc05e7d","line":1197,"updated":"2017-05-21 05:49:10.000000000","message":"not clear why this whole block is not skipped.\n\nin create do we also want to take care of _process_port_create_security_group?","commit_id":"b4687b235fd95d041f419fecda6bc93202699148"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"964f0e3e443b851f2867b91649992a31bb6cbc2c","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"            if updated_port[addr_pair.ADDRESS_PAIRS]:"},{"line_number":1195,"context_line":"                raise addr_pair.AddressPairAndPortSecurityRequired()"},{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"        # checks if security groups were updated adding/modifying"},{"line_number":1198,"context_line":"        # security groups, port security is set"},{"line_number":1199,"context_line":"        if self._check_update_has_security_groups(port):"},{"line_number":1200,"context_line":"            raise psec.PortSecurityAndIPRequiredForSecurityGroups()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_9ecaaf4b","line":1197,"in_reply_to":"ff0f0b1f_8fc05e7d","updated":"2017-05-22 19:51:29.000000000","message":"To be perfectly honest, I was a little unease to touch this code invasively, and limited my change to the area that indeed addressed the bug. Though it should be harmless (and functionally equivalent) to move the skip clause to line 1199.\n\nAs for _process_port_create_security_group, what do you mean exactly? When the extension is disabled the API request will be rejected way before we hit the business logic.","commit_id":"b4687b235fd95d041f419fecda6bc93202699148"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"73117e3a64cddf4adfed7bef1a92a216820098f0","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            raise psec.PortSecurityAndIPRequiredForSecurityGroups()"},{"line_number":1201,"context_line":"        elif (not"},{"line_number":1202,"context_line":"          self._check_update_deletes_security_groups(port)):"},{"line_number":1203,"context_line":"            if not utils.is_extension_supported(self, \u0027security-group\u0027):"},{"line_number":1204,"context_line":"                return"},{"line_number":1205,"context_line":"            # Update did not have security groups passed in. Check"},{"line_number":1206,"context_line":"            # that port does not have any security groups already on it."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_866136ac","line":1203,"updated":"2017-05-23 06:20:21.000000000","message":"i would move this check to line 1197. the above check is pointless as the security groups cannot be configured as the extension is not enabled.","commit_id":"b4687b235fd95d041f419fecda6bc93202699148"}]}
