)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            self.update_arp_entry_for_dvr_service_port(context,"},{"line_number":363,"context_line":"                                                       service_port_dict)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def _get_floatingip_on_port(self, context, port_id\u003dNone):"},{"line_number":366,"context_line":"        \"\"\"Helper function to retrieve the fip associated with port.\"\"\""},{"line_number":367,"context_line":"        fip_qry \u003d context.session.query(l3_models.FloatingIP)"},{"line_number":368,"context_line":"        floating_ip \u003d fip_qry.filter_by(fixed_port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_aa6f2629","line":365,"updated":"2017-05-24 15:19:32.000000000","message":"Where is this used?","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6c8469e8e3b7afef839c050b180e2d139334cb11","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            self.update_arp_entry_for_dvr_service_port(context,"},{"line_number":363,"context_line":"                                                       service_port_dict)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def _get_floatingip_on_port(self, context, port_id\u003dNone):"},{"line_number":366,"context_line":"        \"\"\"Helper function to retrieve the fip associated with port.\"\"\""},{"line_number":367,"context_line":"        fip_qry \u003d context.session.query(l3_models.FloatingIP)"},{"line_number":368,"context_line":"        floating_ip \u003d fip_qry.filter_by(fixed_port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_dd169ba8","line":365,"in_reply_to":"ff0f0b1f_aa6f2629","updated":"2017-05-24 23:45:19.000000000","message":"Might have got in from the rebase. Will remove it.","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    # Skip if host and dest_host is none and the agent"},{"line_number":650,"context_line":"                    # requesting is not dvr_snat agent, and the fip has"},{"line_number":651,"context_line":"                    # not already been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":652,"context_line":"                    if ((fip_host is None) and (fip_dest_host is None) and"},{"line_number":653,"context_line":"                        agent_mode in [const.L3_AGENT_MODE_LEGACY,"},{"line_number":654,"context_line":"                                       const.L3_AGENT_MODE_DVR] and"},{"line_number":655,"context_line":"                        not floating_ip.get(l3_const.DVR_SNAT_BOUND)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_2a09d694","line":652,"updated":"2017-05-24 15:19:32.000000000","message":"extra parens here","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6c8469e8e3b7afef839c050b180e2d139334cb11","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                    # Skip if host and dest_host is none and the agent"},{"line_number":650,"context_line":"                    # requesting is not dvr_snat agent, and the fip has"},{"line_number":651,"context_line":"                    # not already been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":652,"context_line":"                    if ((fip_host is None) and (fip_dest_host is None) and"},{"line_number":653,"context_line":"                        agent_mode in [const.L3_AGENT_MODE_LEGACY,"},{"line_number":654,"context_line":"                                       const.L3_AGENT_MODE_DVR] and"},{"line_number":655,"context_line":"                        not floating_ip.get(l3_const.DVR_SNAT_BOUND)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_7d842fd3","line":652,"in_reply_to":"ff0f0b1f_2a09d694","updated":"2017-05-24 23:45:19.000000000","message":"will fix it.","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                        continue"},{"line_number":657,"context_line":"                    # Also skip floatingip if the fip port have a host defined"},{"line_number":658,"context_line":"                    # and if the host does not match."},{"line_number":659,"context_line":"                    if (fip_host is not None) and host_mismatch:"},{"line_number":660,"context_line":"                        continue"},{"line_number":661,"context_line":"                    LOG.debug(\"Floating IP host: %s\", fip_host)"},{"line_number":662,"context_line":"                router_floatingips.append(floating_ip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_aafcc66f","line":659,"updated":"2017-05-24 15:19:32.000000000","message":"extra parens","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6c8469e8e3b7afef839c050b180e2d139334cb11","unresolved":false,"context_lines":[{"line_number":656,"context_line":"                        continue"},{"line_number":657,"context_line":"                    # Also skip floatingip if the fip port have a host defined"},{"line_number":658,"context_line":"                    # and if the host does not match."},{"line_number":659,"context_line":"                    if (fip_host is not None) and host_mismatch:"},{"line_number":660,"context_line":"                        continue"},{"line_number":661,"context_line":"                    LOG.debug(\"Floating IP host: %s\", fip_host)"},{"line_number":662,"context_line":"                router_floatingips.append(floating_ip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_3d6a3719","line":659,"in_reply_to":"ff0f0b1f_aafcc66f","updated":"2017-05-24 23:45:19.000000000","message":"will fix it.","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                # device owner should be included as valid ports"},{"line_number":701,"context_line":"                # and updated."},{"line_number":702,"context_line":"                if (port[portbindings.HOST_ID] \u003d\u003d host or port_in_migration or"},{"line_number":703,"context_line":"                    unbound_port_exists):"},{"line_number":704,"context_line":"                    port_dict.update({port[\u0027id\u0027]: port})"},{"line_number":705,"context_line":"            # Add the port binding host to the floatingip dictionary"},{"line_number":706,"context_line":"            for fip in floating_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_cab37ae8","line":703,"updated":"2017-05-24 15:19:32.000000000","message":"Can just inline self._is_unbound_port(port) here, using unbound_port_exists is a little confusing","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6c8469e8e3b7afef839c050b180e2d139334cb11","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                # device owner should be included as valid ports"},{"line_number":701,"context_line":"                # and updated."},{"line_number":702,"context_line":"                if (port[portbindings.HOST_ID] \u003d\u003d host or port_in_migration or"},{"line_number":703,"context_line":"                    unbound_port_exists):"},{"line_number":704,"context_line":"                    port_dict.update({port[\u0027id\u0027]: port})"},{"line_number":705,"context_line":"            # Add the port binding host to the floatingip dictionary"},{"line_number":706,"context_line":"            for fip in floating_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_fd483fb3","line":703,"in_reply_to":"ff0f0b1f_cab37ae8","updated":"2017-05-24 23:45:19.000000000","message":"will fix it.","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                    # Handle the case were there is no host binding"},{"line_number":715,"context_line":"                    # for the private ports that are associated with"},{"line_number":716,"context_line":"                    # floating ip."},{"line_number":717,"context_line":"                    if (not fip[\u0027host\u0027]):"},{"line_number":718,"context_line":"                        fip[l3_const.DVR_SNAT_BOUND] \u003d True"},{"line_number":719,"context_line":"        routers_dict \u003d self._process_routers(context, routers, agent)"},{"line_number":720,"context_line":"        self._process_floating_ips_dvr(context, routers_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_6a9d8e64","line":717,"updated":"2017-05-24 15:19:32.000000000","message":"extra parens","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6c8469e8e3b7afef839c050b180e2d139334cb11","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                    # Handle the case were there is no host binding"},{"line_number":715,"context_line":"                    # for the private ports that are associated with"},{"line_number":716,"context_line":"                    # floating ip."},{"line_number":717,"context_line":"                    if (not fip[\u0027host\u0027]):"},{"line_number":718,"context_line":"                        fip[l3_const.DVR_SNAT_BOUND] \u003d True"},{"line_number":719,"context_line":"        routers_dict \u003d self._process_routers(context, routers, agent)"},{"line_number":720,"context_line":"        self._process_floating_ips_dvr(context, routers_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_9dcf0328","line":717,"in_reply_to":"ff0f0b1f_6a9d8e64","updated":"2017-05-24 23:45:19.000000000","message":"will fix it.","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        return (port[\u0027device_owner\u0027] in ("},{"line_number":738,"context_line":"            const.DEVICE_OWNER_LOADBALANCER,"},{"line_number":739,"context_line":"            const.DEVICE_OWNER_LOADBALANCERV2,"},{"line_number":740,"context_line":"                \u0027\u0027) and not port[portbindings.HOST_ID])"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    def _get_dvr_service_port_hostid(self, context, port_id, port\u003dNone):"},{"line_number":743,"context_line":"        \"\"\"Returns the portbinding host_id for dvr service port.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_4a152ae4","line":740,"updated":"2017-05-24 15:19:32.000000000","message":"extra indentation here\n\nDoes it make sense to define DEVICE_OWNER_NONE \u003d \u0027\u0027 in neutron-lib?  Future change of course.","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        # Also include ports with empty device_owner to consider the"},{"line_number":848,"context_line":"        # VRRP allowed_address_pair ports."},{"line_number":849,"context_line":"        return ((n_utils.is_dvr_serviced(port_dict[\u0027device_owner\u0027]) or"},{"line_number":850,"context_line":"            (port_dict[\u0027device_owner\u0027] \u003d\u003d \u0027\u0027)) and port_dict[\u0027fixed_ips\u0027])"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def _get_subnet_id_for_given_fixed_ip("},{"line_number":853,"context_line":"        self, context, fixed_ip, port_dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_caf49af3","line":850,"updated":"2017-05-24 15:19:32.000000000","message":"nit: can you change this so the indentation shows it\u0027s:\n\n(dvr or \u0027\u0027) and fixed_ips\n\n((dvr or\n  \u0027\u0027) and\n fixed_ips)\n\nAssuming pep8 likes that.\n\nThere\u0027s also an extra () around the \u0027\u0027 check.","commit_id":"40ebfdc91b02e8ef0157ae3db1cee043508cca30"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d26451ebc3c5cd8fc826ade1fb280a8ab90bf739","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        return list(routers_dict.values())"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _is_unbound_port(self, port):"},{"line_number":729,"context_line":"        \"\"\"Check if unbound ports for the specific device_owners exist.\"\"\""},{"line_number":730,"context_line":"        return (port[\u0027device_owner\u0027] in ("},{"line_number":731,"context_line":"            const.DEVICE_OWNER_LOADBALANCER,"},{"line_number":732,"context_line":"            const.DEVICE_OWNER_LOADBALANCERV2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_6bd43bbe","line":729,"updated":"2017-05-26 01:33:02.000000000","message":"why is this tied to device_owner at all? Can\u0027t we just do translation for any unbound port at the network node?","commit_id":"1d40c6263e23f19d580f6d9d5549f25e1685bd19"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d800eb206336007e34c428dce91067b3394c00eb","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        return list(routers_dict.values())"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _is_unbound_port(self, port):"},{"line_number":729,"context_line":"        \"\"\"Check if unbound ports for the specific device_owners exist.\"\"\""},{"line_number":730,"context_line":"        return (port[\u0027device_owner\u0027] in ("},{"line_number":731,"context_line":"            const.DEVICE_OWNER_LOADBALANCER,"},{"line_number":732,"context_line":"            const.DEVICE_OWNER_LOADBALANCERV2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_1467a6bf","line":729,"in_reply_to":"7f231b9d_d0aae417","updated":"2017-06-15 19:40:45.000000000","message":"Ok, will fix this behavior.","commit_id":"1d40c6263e23f19d580f6d9d5549f25e1685bd19"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"75a4f4a4d53c53382e42d54849a62a430bd39f59","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        return list(routers_dict.values())"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _is_unbound_port(self, port):"},{"line_number":729,"context_line":"        \"\"\"Check if unbound ports for the specific device_owners exist.\"\"\""},{"line_number":730,"context_line":"        return (port[\u0027device_owner\u0027] in ("},{"line_number":731,"context_line":"            const.DEVICE_OWNER_LOADBALANCER,"},{"line_number":732,"context_line":"            const.DEVICE_OWNER_LOADBALANCERV2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_d0aae417","line":729,"in_reply_to":"bf091321_1f12a459","updated":"2017-06-09 20:29:59.000000000","message":"Yeah, I\u0027m saying don\u0027t bother looking at device owner. Ideally this type of feature should just work for any port used this way.\n\nIt\u0027s okay if you have to special-case out some router ports or something, but in general unbound ports should behave the same.","commit_id":"1d40c6263e23f19d580f6d9d5549f25e1685bd19"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"bd713908d24355980b08475b680eeb56747e6098","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        return list(routers_dict.values())"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def _is_unbound_port(self, port):"},{"line_number":729,"context_line":"        \"\"\"Check if unbound ports for the specific device_owners exist.\"\"\""},{"line_number":730,"context_line":"        return (port[\u0027device_owner\u0027] in ("},{"line_number":731,"context_line":"            const.DEVICE_OWNER_LOADBALANCER,"},{"line_number":732,"context_line":"            const.DEVICE_OWNER_LOADBALANCERV2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf091321_1f12a459","line":729,"in_reply_to":"ff0f0b1f_6bd43bbe","updated":"2017-06-07 23:26:20.000000000","message":"Are you saying that we should not be checking for device_owner? I need to recall, what was the reason for checking with the device_owner as well.\nLet me check and update based on it","commit_id":"1d40c6263e23f19d580f6d9d5549f25e1685bd19"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3e56ec915d2e42f268978b65c60768c50de996c4","unresolved":false,"context_lines":[{"line_number":639,"context_line":"                if router[\u0027distributed\u0027]:"},{"line_number":640,"context_line":"                    fip_host \u003d floating_ip.get(\u0027host\u0027)"},{"line_number":641,"context_line":"                    fip_dest_host \u003d floating_ip.get(\u0027dest_host\u0027)"},{"line_number":642,"context_line":"                    host_mismatch \u003d ("},{"line_number":643,"context_line":"                        fip_host !\u003d host and"},{"line_number":644,"context_line":"                        fip_dest_host is None)"},{"line_number":645,"context_line":"                    # Skip if host and dest_host is none and the agent"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_fb98c3c0","line":642,"updated":"2017-06-23 08:17:20.000000000","message":"there are a lot of conditionals in here now, can you split all of these checks out into a separate helper function like \u0027should_floating_ip_be_hosted_by_agent\u0027 or something like that for easier testing and readability?","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9a5bb6cf31fec3a5a5a5a798ef70147f3770c227","unresolved":false,"context_lines":[{"line_number":639,"context_line":"                if router[\u0027distributed\u0027]:"},{"line_number":640,"context_line":"                    fip_host \u003d floating_ip.get(\u0027host\u0027)"},{"line_number":641,"context_line":"                    fip_dest_host \u003d floating_ip.get(\u0027dest_host\u0027)"},{"line_number":642,"context_line":"                    host_mismatch \u003d ("},{"line_number":643,"context_line":"                        fip_host !\u003d host and"},{"line_number":644,"context_line":"                        fip_dest_host is None)"},{"line_number":645,"context_line":"                    # Skip if host and dest_host is none and the agent"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_fb361a51","line":642,"in_reply_to":"5f201791_fb98c3c0","updated":"2017-06-27 18:03:00.000000000","message":"Ok, will try to align it to smaller functions.","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3e56ec915d2e42f268978b65c60768c50de996c4","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                    port_profile and"},{"line_number":693,"context_line":"                    port_profile.get(\u0027migrating_to\u0027) \u003d\u003d host)"},{"line_number":694,"context_line":"                # All unbound ports with floatingip and specific"},{"line_number":695,"context_line":"                # device owner should be included as valid ports"},{"line_number":696,"context_line":"                # and updated."},{"line_number":697,"context_line":"                if (port[portbindings.HOST_ID] \u003d\u003d host or port_in_migration or"},{"line_number":698,"context_line":"                    self._is_unbound_port(port)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_db93c7a2","line":695,"updated":"2017-06-23 08:17:20.000000000","message":"it\u0027s not device_owner based anymore right?","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9a5bb6cf31fec3a5a5a5a798ef70147f3770c227","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                    port_profile and"},{"line_number":693,"context_line":"                    port_profile.get(\u0027migrating_to\u0027) \u003d\u003d host)"},{"line_number":694,"context_line":"                # All unbound ports with floatingip and specific"},{"line_number":695,"context_line":"                # device owner should be included as valid ports"},{"line_number":696,"context_line":"                # and updated."},{"line_number":697,"context_line":"                if (port[portbindings.HOST_ID] \u003d\u003d host or port_in_migration or"},{"line_number":698,"context_line":"                    self._is_unbound_port(port)):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_5bcaae1a","line":695,"in_reply_to":"5f201791_db93c7a2","updated":"2017-06-27 18:03:00.000000000","message":"Yes, not device owner based, I returning all portbindings.HOST irrespective of the device_owner.","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5de1ef067a3bf3b677016b2b5b0b87bec5523692","unresolved":false,"context_lines":[{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def _get_dvr_service_port_hostid(self, context, port_id, port\u003dNone):"},{"line_number":738,"context_line":"        \"\"\"Returns the portbinding host_id for dvr service port.\"\"\""},{"line_number":739,"context_line":"        port_db \u003d port or self._core_plugin.get_port(context, port_id)"},{"line_number":740,"context_line":"        if port_db[portbindings.HOST_ID]:"},{"line_number":741,"context_line":"            return port_db[portbindings.HOST_ID]"},{"line_number":742,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_d7728949","line":739,"updated":"2017-06-22 21:24:13.000000000","message":"return port_db[portbindings.HOST_ID] or None","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"163311bca6e794204505345e801f162534a4ac3c","unresolved":false,"context_lines":[{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def _get_dvr_service_port_hostid(self, context, port_id, port\u003dNone):"},{"line_number":738,"context_line":"        \"\"\"Returns the portbinding host_id for dvr service port.\"\"\""},{"line_number":739,"context_line":"        port_db \u003d port or self._core_plugin.get_port(context, port_id)"},{"line_number":740,"context_line":"        if port_db[portbindings.HOST_ID]:"},{"line_number":741,"context_line":"            return port_db[portbindings.HOST_ID]"},{"line_number":742,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_77d175cd","line":739,"in_reply_to":"5f201791_d7728949","updated":"2017-06-22 21:33:09.000000000","message":"Ok will fix it.","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3e56ec915d2e42f268978b65c60768c50de996c4","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"            host \u003d self._get_dvr_service_port_hostid(context, fixed_port_id)"},{"line_number":1039,"context_line":"            dest_host \u003d self._get_dvr_migrating_service_port_hostid("},{"line_number":1040,"context_line":"                context, fixed_port_id)"},{"line_number":1041,"context_line":"            self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":1042,"context_line":"                context, [router_id], host)"},{"line_number":1043,"context_line":"            if dest_host and dest_host !\u003d host:"},{"line_number":1044,"context_line":"                self.l3_rpc_notifier.routers_updated_on_host("}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_bb924b9d","line":1041,"updated":"2017-06-23 08:17:20.000000000","message":"Sorry, I mean right here we are calling routers_updated_on_host when host can be None. If I\u0027m tracing the code correctly that lands here which will end up calling prepare(server\u003dNone).\n\nIt seems like we need to put an \u0027if host:\u0027 conditional before this call.","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5de1ef067a3bf3b677016b2b5b0b87bec5523692","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"            host \u003d self._get_dvr_service_port_hostid(context, fixed_port_id)"},{"line_number":1039,"context_line":"            dest_host \u003d self._get_dvr_migrating_service_port_hostid("},{"line_number":1040,"context_line":"                context, fixed_port_id)"},{"line_number":1041,"context_line":"            self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":1042,"context_line":"                context, [router_id], host)"},{"line_number":1043,"context_line":"            if dest_host and dest_host !\u003d host:"},{"line_number":1044,"context_line":"                self.l3_rpc_notifier.routers_updated_on_host("}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_b78f0d22","line":1041,"updated":"2017-06-22 21:24:13.000000000","message":"What does this function do when host is None?","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"163311bca6e794204505345e801f162534a4ac3c","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"            host \u003d self._get_dvr_service_port_hostid(context, fixed_port_id)"},{"line_number":1039,"context_line":"            dest_host \u003d self._get_dvr_migrating_service_port_hostid("},{"line_number":1040,"context_line":"                context, fixed_port_id)"},{"line_number":1041,"context_line":"            self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":1042,"context_line":"                context, [router_id], host)"},{"line_number":1043,"context_line":"            if dest_host and dest_host !\u003d host:"},{"line_number":1044,"context_line":"                self.l3_rpc_notifier.routers_updated_on_host("}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_b7c70d13","line":1041,"in_reply_to":"5f201791_b78f0d22","updated":"2017-06-22 21:33:09.000000000","message":"This would try to notify the agents by calling \u0027notify_router_updated\u0027 instead of \u0027notify_routers_updated_on_host\u0027.\nThis would send message to all agents instead of specific agents.\n\nThe other way to do is find out the SNAT agents and send it to all SNAT agents in the list ( if there are more than one with ha enabled).\n\nWhat do you think?","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9a5bb6cf31fec3a5a5a5a798ef70147f3770c227","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"            host \u003d self._get_dvr_service_port_hostid(context, fixed_port_id)"},{"line_number":1039,"context_line":"            dest_host \u003d self._get_dvr_migrating_service_port_hostid("},{"line_number":1040,"context_line":"                context, fixed_port_id)"},{"line_number":1041,"context_line":"            self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":1042,"context_line":"                context, [router_id], host)"},{"line_number":1043,"context_line":"            if dest_host and dest_host !\u003d host:"},{"line_number":1044,"context_line":"                self.l3_rpc_notifier.routers_updated_on_host("}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_3be5b138","line":1041,"in_reply_to":"5f201791_bb924b9d","updated":"2017-06-27 18:03:00.000000000","message":"Sure, based on the recent change, we should test for if host.\nWill fix it.","commit_id":"bcb3aba90e53c301138d880f45c822f71fa43611"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"226bb8162e5497fcc9700edd04fe17aed963553f","unresolved":false,"context_lines":[{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    def _check_floating_ip_valid_for_given_host("},{"line_number":656,"context_line":"        self, fip_host, fip_dest_host, host):"},{"line_number":657,"context_line":"        \"\"\"Function to check if floating match for given host.\"\"\""},{"line_number":658,"context_line":"        host_mismatch \u003d ("},{"line_number":659,"context_line":"            fip_host !\u003d host and fip_dest_host is None)"},{"line_number":660,"context_line":"        return (fip_host is not None and host_mismatch)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_6549d489","line":657,"updated":"2017-06-30 21:11:27.000000000","message":"can you add to the docstring a small statement describing the scenario where these mismatch and why we skip in that case? It\u0027s not obvious from reading the code here that it has to do with migrations.","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9be178d1a488c212fe6b59f270792b2166015ba6","unresolved":false,"context_lines":[{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    def _check_floating_ip_valid_for_given_host("},{"line_number":656,"context_line":"        self, fip_host, fip_dest_host, host):"},{"line_number":657,"context_line":"        \"\"\"Function to check if floating match for given host.\"\"\""},{"line_number":658,"context_line":"        host_mismatch \u003d ("},{"line_number":659,"context_line":"            fip_host !\u003d host and fip_dest_host is None)"},{"line_number":660,"context_line":"        return (fip_host is not None and host_mismatch)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_f0b3604c","line":657,"in_reply_to":"3f1d235d_6549d489","updated":"2017-06-30 21:22:11.000000000","message":"Sure will add.","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"226bb8162e5497fcc9700edd04fe17aed963553f","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                    port_profile and"},{"line_number":708,"context_line":"                    port_profile.get(\u0027migrating_to\u0027) \u003d\u003d host)"},{"line_number":709,"context_line":"                # All unbound ports with floatingip and specific"},{"line_number":710,"context_line":"                # device owner should be included as valid ports"},{"line_number":711,"context_line":"                # and updated."},{"line_number":712,"context_line":"                if (port[portbindings.HOST_ID] \u003d\u003d host or port_in_migration or"},{"line_number":713,"context_line":"                    self._is_unbound_port(port)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_45601802","line":710,"updated":"2017-06-30 21:11:27.000000000","message":"sorry, i should have specified on the last patch what i meant. since we aren\u0027t using device owner this comment needs to be updated to not mention device owner :)","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9be178d1a488c212fe6b59f270792b2166015ba6","unresolved":false,"context_lines":[{"line_number":707,"context_line":"                    port_profile and"},{"line_number":708,"context_line":"                    port_profile.get(\u0027migrating_to\u0027) \u003d\u003d host)"},{"line_number":709,"context_line":"                # All unbound ports with floatingip and specific"},{"line_number":710,"context_line":"                # device owner should be included as valid ports"},{"line_number":711,"context_line":"                # and updated."},{"line_number":712,"context_line":"                if (port[portbindings.HOST_ID] \u003d\u003d host or port_in_migration or"},{"line_number":713,"context_line":"                    self._is_unbound_port(port)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_90f30c0b","line":710,"in_reply_to":"3f1d235d_45601802","updated":"2017-06-30 21:22:11.000000000","message":"I thought I removed, may be missed it.","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"226bb8162e5497fcc9700edd04fe17aed963553f","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        return list(routers_dict.values())"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    def _is_unbound_port(self, port):"},{"line_number":746,"context_line":"        \"\"\"Check for port-binding irrespecitive of device_owner.\"\"\""},{"line_number":747,"context_line":"        if not port[portbindings.HOST_ID]:"},{"line_number":748,"context_line":"            return True"},{"line_number":749,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_255bdc54","line":746,"updated":"2017-06-30 21:11:27.000000000","message":"return not port[portbindings.HOST_ID]","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9be178d1a488c212fe6b59f270792b2166015ba6","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        return list(routers_dict.values())"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"    def _is_unbound_port(self, port):"},{"line_number":746,"context_line":"        \"\"\"Check for port-binding irrespecitive of device_owner.\"\"\""},{"line_number":747,"context_line":"        if not port[portbindings.HOST_ID]:"},{"line_number":748,"context_line":"            return True"},{"line_number":749,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_50dd746e","line":746,"in_reply_to":"3f1d235d_255bdc54","updated":"2017-06-30 21:22:11.000000000","message":"will fix it.","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"226bb8162e5497fcc9700edd04fe17aed963553f","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                     \u0027subnet_id\u0027: subnet}"},{"line_number":849,"context_line":"        notifier(context, router_id, arp_table)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    def _should_update_arp_entry_for_dvr_service_port(self, port_dict):"},{"line_number":852,"context_line":"        # Check this is a valid VM or service port"},{"line_number":853,"context_line":"        # Also include ports with empty device_owner to consider the"},{"line_number":854,"context_line":"        # VRRP allowed_address_pair ports."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_055a204e","line":851,"updated":"2017-06-30 21:11:27.000000000","message":"what is this function used for? Is there a reason we shouldn\u0027t just do this for all device_owners as well?","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6870f57993892fb8cfd35709ffc203812e330ea5","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                     \u0027subnet_id\u0027: subnet}"},{"line_number":849,"context_line":"        notifier(context, router_id, arp_table)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    def _should_update_arp_entry_for_dvr_service_port(self, port_dict):"},{"line_number":852,"context_line":"        # Check this is a valid VM or service port"},{"line_number":853,"context_line":"        # Also include ports with empty device_owner to consider the"},{"line_number":854,"context_line":"        # VRRP allowed_address_pair ports."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_4bd02920","line":851,"updated":"2017-06-30 22:32:14.000000000","message":"would there be a negative side effect for doing it for all device_owners? I was just hoping to remove as many special cases as possible based on that owner field.","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9be178d1a488c212fe6b59f270792b2166015ba6","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                     \u0027subnet_id\u0027: subnet}"},{"line_number":849,"context_line":"        notifier(context, router_id, arp_table)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    def _should_update_arp_entry_for_dvr_service_port(self, port_dict):"},{"line_number":852,"context_line":"        # Check this is a valid VM or service port"},{"line_number":853,"context_line":"        # Also include ports with empty device_owner to consider the"},{"line_number":854,"context_line":"        # VRRP allowed_address_pair ports."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_b0d5e845","line":851,"in_reply_to":"3f1d235d_055a204e","updated":"2017-06-30 21:22:11.000000000","message":"May be a left over, but let me check.","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"2bb576068c7e911d033e849137e877e37200294a","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                     \u0027subnet_id\u0027: subnet}"},{"line_number":849,"context_line":"        notifier(context, router_id, arp_table)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    def _should_update_arp_entry_for_dvr_service_port(self, port_dict):"},{"line_number":852,"context_line":"        # Check this is a valid VM or service port"},{"line_number":853,"context_line":"        # Also include ports with empty device_owner to consider the"},{"line_number":854,"context_line":"        # VRRP allowed_address_pair ports."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_f0c0002d","line":851,"in_reply_to":"3f1d235d_055a204e","updated":"2017-06-30 21:42:58.000000000","message":"This is to update the arp entry in each namespace for the router associated ports.","commit_id":"3eb352c02e344035bfbded779ef9978cd7867faa"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0017ec5c3eabe638f629ef638e96702b878f19d8","unresolved":false,"context_lines":[{"line_number":641,"context_line":"                    fip_dest_host \u003d floating_ip.get(\u0027dest_host\u0027)"},{"line_number":642,"context_line":"                    # Skip if floatingip need not be processed for the"},{"line_number":643,"context_line":"                    # given agent."},{"line_number":644,"context_line":"                    if self._should_floating_ip_be_processed_for_given_agent("},{"line_number":645,"context_line":"                        floating_ip, fip_host, fip_dest_host, agent):"},{"line_number":646,"context_line":"                        continue"},{"line_number":647,"context_line":"                    # Also skip floatingip if the fip port have a host defined"},{"line_number":648,"context_line":"                    # and if the host does not match."}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_03758895","line":645,"range":{"start_line":644,"start_character":23,"end_line":645,"end_character":68},"updated":"2017-07-13 12:56:56.000000000","message":"Nit: If this call returns True then the floating IP is not appended to the router\u0027s list of Floating IPs, The name of the function implies the opposite should happen.\n\nBut I might be reading this wrong.","commit_id":"2e0cbf9ff737e5952d9325a6c20e1a3f3359f9bc"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"0017ec5c3eabe638f629ef638e96702b878f19d8","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                        continue"},{"line_number":647,"context_line":"                    # Also skip floatingip if the fip port have a host defined"},{"line_number":648,"context_line":"                    # and if the host does not match."},{"line_number":649,"context_line":"                    if self._check_floating_ip_valid_for_given_host("},{"line_number":650,"context_line":"                        fip_host, fip_dest_host, host):"},{"line_number":651,"context_line":"                        continue"},{"line_number":652,"context_line":"                    LOG.debug(\"Floating IP host: %s\", fip_host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f1a1f67_836078d0","line":649,"range":{"start_line":649,"start_character":28,"end_line":649,"end_character":67},"updated":"2017-07-13 12:56:56.000000000","message":"ditto","commit_id":"2e0cbf9ff737e5952d9325a6c20e1a3f3359f9bc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6798d24e88ca6b360c7e246a8f2c07042ee1bbe6","unresolved":false,"context_lines":[{"line_number":911,"context_line":"        port, those fixed_ips should be removed from the ARP table."},{"line_number":912,"context_line":"        \"\"\""},{"line_number":913,"context_line":"        fixed_ips \u003d port_dict[\u0027fixed_ips\u0027]"},{"line_number":914,"context_line":"        if not port_dict[\u0027fixed_ips\u0027]:"},{"line_number":915,"context_line":"            return"},{"line_number":916,"context_line":"        if not fixed_ips_to_delete:"},{"line_number":917,"context_line":"            allowed_address_pair_fixed_ips \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_bcbdc969","line":914,"updated":"2017-07-10 20:31:28.000000000","message":"This should just be \u0027if not fixed_ips:\u0027","commit_id":"2e0cbf9ff737e5952d9325a6c20e1a3f3359f9bc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"05feeaf6d67b1af67272e96437b1d76d4a4aaea5","unresolved":false,"context_lines":[{"line_number":663,"context_line":"            fip_host !\u003d host and fip_dest_host is None)"},{"line_number":664,"context_line":"        return (fip_host is not None and host_mismatch)"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def _should_skip_floating_ip_processed_for_given_agent("},{"line_number":667,"context_line":"        self, floating_ip, fip_host, fip_dest_host, agent):"},{"line_number":668,"context_line":"        \"\"\"Function to check if floatingip need to be processed or skipped."},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_47c13980","line":666,"range":{"start_line":666,"start_character":33,"end_line":666,"end_character":42},"updated":"2017-07-13 21:25:33.000000000","message":"nit: s/processing\n\nI have started shaving the yak...","commit_id":"1a65fb386c8b2122d292ab291c6238cd1e5d6ca2"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"20a1090f553037b71745b9551d69ca08c97e17d9","unresolved":false,"context_lines":[{"line_number":663,"context_line":"            fip_host !\u003d host and fip_dest_host is None)"},{"line_number":664,"context_line":"        return (fip_host is not None and host_mismatch)"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def _should_skip_floating_ip_processed_for_given_agent("},{"line_number":667,"context_line":"        self, floating_ip, fip_host, fip_dest_host, agent):"},{"line_number":668,"context_line":"        \"\"\"Function to check if floatingip need to be processed or skipped."},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f1a1f67_e7d3a537","line":666,"range":{"start_line":666,"start_character":33,"end_line":666,"end_character":42},"in_reply_to":"1f1a1f67_47c13980","updated":"2017-07-13 21:29:28.000000000","message":"The key is commitment... and a very patient yak...","commit_id":"1a65fb386c8b2122d292ab291c6238cd1e5d6ca2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2385285ee4bca1148ca981c6647201b2f70608f3","unresolved":false,"context_lines":[{"line_number":352,"context_line":"                            return"},{"line_number":353,"context_line":"                        self._inherit_service_port_and_arp_update("},{"line_number":354,"context_line":"                            context, addr_pair_active_service_port_list[0],"},{"line_number":355,"context_line":"                            port)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _inherit_service_port_and_arp_update("},{"line_number":358,"context_line":"        self, context, service_port, allowed_address_port):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f1a1f67_11bbad0e","line":355,"range":{"start_line":355,"start_character":28,"end_line":355,"end_character":32},"updated":"2017-07-20 21:22:50.000000000","message":"We don\u0027t need to pass this anymore. See comment to L358","commit_id":"cced31c6b9cef33022a2cfb97d5aac6d02e75cb8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2385285ee4bca1148ca981c6647201b2f70608f3","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                            port)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _inherit_service_port_and_arp_update("},{"line_number":358,"context_line":"        self, context, service_port, allowed_address_port):"},{"line_number":359,"context_line":"        \"\"\"Function inherits port host bindings for allowed_address_pair.\"\"\""},{"line_number":360,"context_line":"        service_port_dict \u003d self.l3plugin._core_plugin._make_port_dict("},{"line_number":361,"context_line":"            service_port)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f1a1f67_ae3938f3","line":358,"range":{"start_line":358,"start_character":37,"end_line":358,"end_character":57},"updated":"2017-07-20 21:22:50.000000000","message":"We don\u0027t need this argument anymore","commit_id":"cced31c6b9cef33022a2cfb97d5aac6d02e75cb8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2385285ee4bca1148ca981c6647201b2f70608f3","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            service_port)"},{"line_number":362,"context_line":"        address_pair_list \u003d service_port_dict.get(\u0027allowed_address_pairs\u0027)"},{"line_number":363,"context_line":"        for address_pair in address_pair_list:"},{"line_number":364,"context_line":"            self.update_arp_entry_for_dvr_service_port(context,"},{"line_number":365,"context_line":"                                                       service_port_dict)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    @registry.receives(resources.ROUTER_INTERFACE, [events.BEFORE_CREATE])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f1a1f67_ee8df5d3","line":364,"range":{"start_line":364,"start_character":12,"end_line":364,"end_character":54},"updated":"2017-07-20 21:22:50.000000000","message":"Shouldn\u0027t this be self.l3plugin.update_arp_entry_for_dvr_service_port? Otherwise we are undoing https://review.openstack.org/#/c/457592","commit_id":"cced31c6b9cef33022a2cfb97d5aac6d02e75cb8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2385285ee4bca1148ca981c6647201b2f70608f3","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        not already been assigned \u0027dvr_snat_bound\u0027 state."},{"line_number":673,"context_line":"        \"\"\""},{"line_number":674,"context_line":"        agent_mode \u003d self._get_agent_mode(agent)"},{"line_number":675,"context_line":"        return (fip_host is None and (fip_dest_host is None) and"},{"line_number":676,"context_line":"                agent_mode in [const.L3_AGENT_MODE_LEGACY,"},{"line_number":677,"context_line":"                               const.L3_AGENT_MODE_DVR] and"},{"line_number":678,"context_line":"                not floating_ip.get(l3_const.DVR_SNAT_BOUND))"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f1a1f67_77908c4f","line":675,"range":{"start_line":675,"start_character":37,"end_line":675,"end_character":60},"updated":"2017-07-20 21:22:50.000000000","message":"do we need the parenthesis?","commit_id":"cced31c6b9cef33022a2cfb97d5aac6d02e75cb8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2385285ee4bca1148ca981c6647201b2f70608f3","unresolved":false,"context_lines":[{"line_number":725,"context_line":"                    fip[\u0027dest_host\u0027] \u003d ("},{"line_number":726,"context_line":"                        self._get_dvr_migrating_service_port_hostid("},{"line_number":727,"context_line":"                            context, fip[\u0027port_id\u0027], port\u003dvm_port))"},{"line_number":728,"context_line":"                    # Handle the case were there is no host binding"},{"line_number":729,"context_line":"                    # for the private ports that are associated with"},{"line_number":730,"context_line":"                    # floating ip."},{"line_number":731,"context_line":"                    if not fip[\u0027host\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f1a1f67_17195887","line":728,"range":{"start_line":728,"start_character":38,"end_line":728,"end_character":42},"updated":"2017-07-20 21:22:50.000000000","message":"Nit: where","commit_id":"cced31c6b9cef33022a2cfb97d5aac6d02e75cb8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2385285ee4bca1148ca981c6647201b2f70608f3","unresolved":false,"context_lines":[{"line_number":985,"context_line":"                    context, [router_id], host)"},{"line_number":986,"context_line":"                if dest_host and dest_host !\u003d host:"},{"line_number":987,"context_line":"                    self.l3_rpc_notifier.routers_updated_on_host("},{"line_number":988,"context_line":"                        context, [router_id], dest_host)"},{"line_number":989,"context_line":"            else:"},{"line_number":990,"context_line":"                self.notify_router_updated(context, router_id)"},{"line_number":991,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f1a1f67_ce611914","line":988,"updated":"2017-07-20 21:22:50.000000000","message":"If you stick a return statement here, you could eliminate L989-991 and shift L992 one tab to the left","commit_id":"cced31c6b9cef33022a2cfb97d5aac6d02e75cb8"}],"neutron/tests/unit/db/test_l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3382e890e8dbbd879c1ccad142c298c31e4f6b7","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def test_floatingip_on_port_not_host(self):"},{"line_number":389,"context_line":"        router, fip \u003d self._floatingip_on_port_test_setup(None)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        self.assertNotIn(const.FLOATINGIP_KEY, router)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def test_floatingip_on_port_with_host(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_6a4eaec1","side":"PARENT","line":390,"updated":"2017-05-24 15:19:32.000000000","message":"random whitespace change","commit_id":"de59e1c198a201781052cae0b48b344911fae378"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6c8469e8e3b7afef839c050b180e2d139334cb11","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def test_floatingip_on_port_not_host(self):"},{"line_number":389,"context_line":"        router, fip \u003d self._floatingip_on_port_test_setup(None)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        self.assertNotIn(const.FLOATINGIP_KEY, router)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def test_floatingip_on_port_with_host(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_15cd0784","side":"PARENT","line":390,"in_reply_to":"ff0f0b1f_6a4eaec1","updated":"2017-05-24 23:45:19.000000000","message":"will fix it.","commit_id":"de59e1c198a201781052cae0b48b344911fae378"}]}
