)]}'
{"neutron/tests/tempest/api/test_subnetpools.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ab643312f974bb519edd5120161d2ce74c9ebf29","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        subnetpools \u003d body[\u0027subnetpools\u0027]"},{"line_number":335,"context_line":"        for subnetpool in subnetpools:"},{"line_number":336,"context_line":"            if subnetpool.get(\u0027is_default\u0027):"},{"line_number":337,"context_line":"                msg \u003d \u0027Default subnetpool exists, only allows one default.\u0027"},{"line_number":338,"context_line":"                raise cls.skipException(msg)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    @decorators.idempotent_id(\u00274c6963c2-f54c-4347-b288-75d18421c4c4\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_5c1663f3","line":337,"range":{"start_line":337,"start_character":42,"end_line":337,"end_character":73},"updated":"2017-07-04 21:59:44.000000000","message":"Nit: already exists. Only one is allowed","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        subnetpools \u003d body[\u0027subnetpools\u0027]"},{"line_number":335,"context_line":"        for subnetpool in subnetpools:"},{"line_number":336,"context_line":"            if subnetpool.get(\u0027is_default\u0027):"},{"line_number":337,"context_line":"                msg \u003d \u0027Default subnetpool exists, only allows one default.\u0027"},{"line_number":338,"context_line":"                raise cls.skipException(msg)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    @decorators.idempotent_id(\u00274c6963c2-f54c-4347-b288-75d18421c4c4\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_13cfb129","line":337,"range":{"start_line":337,"start_character":42,"end_line":337,"end_character":73},"in_reply_to":"3f1d235d_5c1663f3","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":342,"context_line":"    def test_tenant_create_subnetpool(self):"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        Test create a subnetpool, the \"is_default\" attribute is False."},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        created_subnetpool \u003d self._create_subnetpool()"},{"line_number":347,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_3c0727cd","line":344,"range":{"start_line":344,"start_character":13,"end_line":344,"end_character":19},"updated":"2017-07-04 21:57:32.000000000","message":"Nit: creates","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":342,"context_line":"    def test_tenant_create_subnetpool(self):"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        Test create a subnetpool, the \"is_default\" attribute is False."},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        created_subnetpool \u003d self._create_subnetpool()"},{"line_number":347,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_f3d315d4","line":344,"range":{"start_line":344,"start_character":13,"end_line":344,"end_character":19},"in_reply_to":"3f1d235d_3c0727cd","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        Test create a subnetpool, the \"is_default\" attribute is False."},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        created_subnetpool \u003d self._create_subnetpool()"},{"line_number":347,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"},{"line_number":348,"context_line":"                        created_subnetpool[\u0027id\u0027])"},{"line_number":349,"context_line":"        self.assertFalse(created_subnetpool[\u0027is_default\u0027])"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_3c6287af","line":347,"updated":"2017-07-04 21:57:32.000000000","message":"I don\u0027t think you need this. _create_subnetpool calls https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L414, which adds your subnetpools to the list of subnet pools to be deleted at the end. They are deleted be resource_cleanup: https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L180-L186","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        Test create a subnetpool, the \"is_default\" attribute is False."},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        created_subnetpool \u003d self._create_subnetpool()"},{"line_number":347,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"},{"line_number":348,"context_line":"                        created_subnetpool[\u0027id\u0027])"},{"line_number":349,"context_line":"        self.assertFalse(created_subnetpool[\u0027is_default\u0027])"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_d3dc99e5","line":347,"in_reply_to":"3f1d235d_3c6287af","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":353,"context_line":"    def test_admin_create_default_subnetpool(self):"},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        Test use administrative credentials to create a default subnetpool,"},{"line_number":356,"context_line":"        using the is_default\u003dTrue."},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        created_subnetpool \u003d self._create_subnetpool(is_admin\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_fc0c0fed","line":355,"range":{"start_line":355,"start_character":13,"end_line":355,"end_character":16},"updated":"2017-07-04 21:57:32.000000000","message":"Nit: uses","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":353,"context_line":"    def test_admin_create_default_subnetpool(self):"},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        Test use administrative credentials to create a default subnetpool,"},{"line_number":356,"context_line":"        using the is_default\u003dTrue."},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        created_subnetpool \u003d self._create_subnetpool(is_admin\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_13e8d179","line":355,"range":{"start_line":355,"start_character":13,"end_line":355,"end_character":16},"in_reply_to":"3f1d235d_fc0c0fed","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        created_subnetpool \u003d self._create_subnetpool(is_admin\u003dTrue,"},{"line_number":359,"context_line":"                                                     is_default\u003dTrue)"},{"line_number":360,"context_line":"        self.addCleanup(self.admin_client.delete_subnetpool,"},{"line_number":361,"context_line":"                        created_subnetpool[\u0027id\u0027])"},{"line_number":362,"context_line":"        self.assertTrue(created_subnetpool[\u0027is_default\u0027])"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_fc576fc9","line":360,"updated":"2017-07-04 21:57:32.000000000","message":"Please see comment to L347","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        created_subnetpool \u003d self._create_subnetpool(is_admin\u003dTrue,"},{"line_number":359,"context_line":"                                                     is_default\u003dTrue)"},{"line_number":360,"context_line":"        self.addCleanup(self.admin_client.delete_subnetpool,"},{"line_number":361,"context_line":"                        created_subnetpool[\u0027id\u0027])"},{"line_number":362,"context_line":"        self.assertTrue(created_subnetpool[\u0027is_default\u0027])"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_d305b947","line":360,"in_reply_to":"3f1d235d_fc576fc9","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":366,"context_line":"    def test_convert_subnetpool_to_default_subnetpool(self):"},{"line_number":367,"context_line":"        \"\"\""},{"line_number":368,"context_line":"        Test create a subnetpool, which is non default subnetpool."},{"line_number":369,"context_line":"        Then it will update to a default subnetpool, by setting \"is_default\""},{"line_number":370,"context_line":"        attribute to True."},{"line_number":371,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_9cf75bd4","line":368,"range":{"start_line":368,"start_character":13,"end_line":368,"end_character":19},"updated":"2017-07-04 21:57:32.000000000","message":"Nit: creates","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":366,"context_line":"    def test_convert_subnetpool_to_default_subnetpool(self):"},{"line_number":367,"context_line":"        \"\"\""},{"line_number":368,"context_line":"        Test create a subnetpool, which is non default subnetpool."},{"line_number":369,"context_line":"        Then it will update to a default subnetpool, by setting \"is_default\""},{"line_number":370,"context_line":"        attribute to True."},{"line_number":371,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_93fbc145","line":368,"range":{"start_line":368,"start_character":13,"end_line":368,"end_character":19},"in_reply_to":"3f1d235d_9cf75bd4","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        self.admin_client.update_subnetpool(subnetpool_id,"},{"line_number":377,"context_line":"                                            **subnetpool_data)"},{"line_number":378,"context_line":"        show_body \u003d self.client.show_subnetpool(subnetpool_id)"},{"line_number":379,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"},{"line_number":380,"context_line":"                        subnetpool_id)"},{"line_number":381,"context_line":"        self.assertTrue(show_body[\u0027subnetpool\u0027][\u0027is_default\u0027])"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_9c72bb7a","line":379,"updated":"2017-07-04 21:57:32.000000000","message":"Please see comment to L347","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        self.admin_client.update_subnetpool(subnetpool_id,"},{"line_number":377,"context_line":"                                            **subnetpool_data)"},{"line_number":378,"context_line":"        show_body \u003d self.client.show_subnetpool(subnetpool_id)"},{"line_number":379,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"},{"line_number":380,"context_line":"                        subnetpool_id)"},{"line_number":381,"context_line":"        self.assertTrue(show_body[\u0027subnetpool\u0027][\u0027is_default\u0027])"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_539769ed","line":379,"in_reply_to":"3f1d235d_9c72bb7a","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":385,"context_line":"    def test_convert_default_subnetpool_to_non_default(self):"},{"line_number":386,"context_line":"        \"\"\""},{"line_number":387,"context_line":"        Test use administrative credentials to create a default subnetpool,"},{"line_number":388,"context_line":"        using the is_default\u003dTrue."},{"line_number":389,"context_line":"        Then it will update \"is_default\" attribute to False."},{"line_number":390,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_7c00ffab","line":387,"range":{"start_line":387,"start_character":13,"end_line":387,"end_character":16},"updated":"2017-07-04 21:57:32.000000000","message":"Nit: uses","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":385,"context_line":"    def test_convert_default_subnetpool_to_non_default(self):"},{"line_number":386,"context_line":"        \"\"\""},{"line_number":387,"context_line":"        Test use administrative credentials to create a default subnetpool,"},{"line_number":388,"context_line":"        using the is_default\u003dTrue."},{"line_number":389,"context_line":"        Then it will update \"is_default\" attribute to False."},{"line_number":390,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_339ced0d","line":387,"range":{"start_line":387,"start_character":13,"end_line":387,"end_character":16},"in_reply_to":"3f1d235d_7c00ffab","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a9d0fc869ff796feb557fed6d98f6cd143380f3","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        self.admin_client.update_subnetpool(subnetpool_id,"},{"line_number":397,"context_line":"                                            **subnetpool_data)"},{"line_number":398,"context_line":"        show_body \u003d self.client.show_subnetpool(subnetpool_id)"},{"line_number":399,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"},{"line_number":400,"context_line":"                        subnetpool_id)"},{"line_number":401,"context_line":"        self.assertFalse(show_body[\u0027subnetpool\u0027][\u0027is_default\u0027])"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_bc233756","line":399,"updated":"2017-07-04 21:57:32.000000000","message":"Please see comment to L347","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"044058e5a568bfa557494b30711275c5a265af20","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        self.admin_client.update_subnetpool(subnetpool_id,"},{"line_number":397,"context_line":"                                            **subnetpool_data)"},{"line_number":398,"context_line":"        show_body \u003d self.client.show_subnetpool(subnetpool_id)"},{"line_number":399,"context_line":"        self.addCleanup(self.client.delete_subnetpool,"},{"line_number":400,"context_line":"                        subnetpool_id)"},{"line_number":401,"context_line":"        self.assertFalse(show_body[\u0027subnetpool\u0027][\u0027is_default\u0027])"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_139d7109","line":399,"in_reply_to":"3f1d235d_bc233756","updated":"2017-07-05 07:08:27.000000000","message":"Done","commit_id":"49e14825c810d15a5e6240050fef21f062246e94"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f4876aa1d386a0119143a8d1847c45977e20cc79","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    @decorators.idempotent_id(\u00274c6963c2-f54c-4347-b288-75d18421c4c4\u0027)"},{"line_number":341,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":342,"context_line":"    def test_tenant_create_subnetpool(self):"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        Test creates a subnetpool, the \"is_default\" attribute is False."},{"line_number":345,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_b7b9e9cc","line":342,"updated":"2017-07-05 20:57:03.000000000","message":"Maybe we can move this test case to SubnetPoolsTest above. This way it gets executed regardless of whether there is a default subnetpool already in the environment","commit_id":"0ebe0f91cada03485b99e5b7b2bdba975ed58ca0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"598ed72694814a1e164af32262b798db6e0e855e","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    @decorators.idempotent_id(\u00274c6963c2-f54c-4347-b288-75d18421c4c4\u0027)"},{"line_number":341,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":342,"context_line":"    def test_tenant_create_subnetpool(self):"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":"        Test creates a subnetpool, the \"is_default\" attribute is False."},{"line_number":345,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_063f4db4","line":342,"in_reply_to":"3f1d235d_b7b9e9cc","updated":"2017-07-06 00:44:09.000000000","message":"Thanks for suggestion, I\u0027ll update.","commit_id":"0ebe0f91cada03485b99e5b7b2bdba975ed58ca0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fc7e9b7fca90aab023643a6866a2b2b297406e5e","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u00274c6963c2-f54c-4347-b288-75d18421c4c4\u0027)"},{"line_number":328,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":329,"context_line":"    def test_tenant_create_subnetpool(self):"},{"line_number":330,"context_line":"        \"\"\""},{"line_number":331,"context_line":"        Test creates a subnetpool, the \"is_default\" attribute is False."},{"line_number":332,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_301ffc08","line":329,"range":{"start_line":329,"start_character":8,"end_line":329,"end_character":37},"updated":"2017-07-06 16:42:56.000000000","message":"Nit: In the context of this class, consider renaming this test case to something like test_tenant_create_non_default_subnetpool.","commit_id":"9ca875196c00bc74b97db13dfad486dd35649f03"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8f07e14240b432aecaf3a265a9261f10051b79fd","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    @decorators.idempotent_id(\u00274c6963c2-f54c-4347-b288-75d18421c4c4\u0027)"},{"line_number":328,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":329,"context_line":"    def test_tenant_create_subnetpool(self):"},{"line_number":330,"context_line":"        \"\"\""},{"line_number":331,"context_line":"        Test creates a subnetpool, the \"is_default\" attribute is False."},{"line_number":332,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_f0706442","line":329,"range":{"start_line":329,"start_character":8,"end_line":329,"end_character":37},"in_reply_to":"3f1d235d_301ffc08","updated":"2017-07-06 16:49:08.000000000","message":"Done","commit_id":"9ca875196c00bc74b97db13dfad486dd35649f03"}],"neutron/tests/tempest/api/test_subnetpools_negative.py":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"dde2ef23189a7ce46d3e30e5f2e76048d4d7f9c3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertRaises(lib_exc.Forbidden, self._create_subnetpool,"},{"line_number":60,"context_line":"                          is_admin\u003dFalse, shared\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"},{"line_number":63,"context_line":"    @decorators.idempotent_id(\u00276ae09d8f-95be-40ed-b1cf-8b850d45bab5\u0027)"},{"line_number":64,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":65,"context_line":"    def test_tenant_create_default_subnetpool(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_0fb4a434","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":31},"updated":"2017-05-26 06:56:26.000000000","message":"Function \u0027tempest.test.attr()\u0027 has been moved to \u0027tempest.lib.decorators.attr()\u0027 in Pike and will be removed in a future version [1]. So shall we use decorators.attr here?\n\n[1]https://review.openstack.org/#/c/456236/","commit_id":"06356f0f115e132be934451fce4635579f2e4c8d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2166809645163f9579ee5d49706fbc24282be8c6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertRaises(lib_exc.Forbidden, self._create_subnetpool,"},{"line_number":60,"context_line":"                          is_admin\u003dFalse, shared\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"},{"line_number":63,"context_line":"    @decorators.idempotent_id(\u00276ae09d8f-95be-40ed-b1cf-8b850d45bab5\u0027)"},{"line_number":64,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":65,"context_line":"    def test_tenant_create_default_subnetpool(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_0fc5c45b","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":31},"in_reply_to":"ff0f0b1f_0fb4a434","updated":"2017-05-26 07:10:06.000000000","message":"+1","commit_id":"06356f0f115e132be934451fce4635579f2e4c8d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"9b1c0caf436630594f7f2137e8bf135a38fb1213","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertRaises(lib_exc.Forbidden, self._create_subnetpool,"},{"line_number":60,"context_line":"                          is_admin\u003dFalse, shared\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"},{"line_number":63,"context_line":"    @decorators.idempotent_id(\u00276ae09d8f-95be-40ed-b1cf-8b850d45bab5\u0027)"},{"line_number":64,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":65,"context_line":"    def test_tenant_create_default_subnetpool(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_85bbf370","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":31},"in_reply_to":"ff0f0b1f_0fb4a434","updated":"2017-05-26 08:46:09.000000000","message":"Done","commit_id":"06356f0f115e132be934451fce4635579f2e4c8d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"9b1c0caf436630594f7f2137e8bf135a38fb1213","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertRaises(lib_exc.Forbidden, self._create_subnetpool,"},{"line_number":60,"context_line":"                          is_admin\u003dFalse, shared\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"},{"line_number":63,"context_line":"    @decorators.idempotent_id(\u00276ae09d8f-95be-40ed-b1cf-8b850d45bab5\u0027)"},{"line_number":64,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":65,"context_line":"    def test_tenant_create_default_subnetpool(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_65b0df8c","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":31},"in_reply_to":"ff0f0b1f_0fc5c45b","updated":"2017-05-26 08:46:09.000000000","message":"Done","commit_id":"06356f0f115e132be934451fce4635579f2e4c8d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"e52525f7f4f04e6846e4b6d049b08463047d168e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertRaises(lib_exc.Forbidden, self._create_subnetpool,"},{"line_number":60,"context_line":"                          is_admin\u003dFalse, shared\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"},{"line_number":63,"context_line":"    @decorators.idempotent_id(\u00276ae09d8f-95be-40ed-b1cf-8b850d45bab5\u0027)"},{"line_number":64,"context_line":"    @test.requires_ext(extension\u003d\u0027default-subnetpools\u0027, service\u003d\u0027network\u0027)"},{"line_number":65,"context_line":"    def test_tenant_create_default_subnetpool(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_a8824eff","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":31},"in_reply_to":"ff0f0b1f_65b0df8c","updated":"2017-05-26 09:07:31.000000000","message":"Maybe we need to wait for tempest update in test-requirements.","commit_id":"06356f0f115e132be934451fce4635579f2e4c8d"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"dde2ef23189a7ce46d3e30e5f2e76048d4d7f9c3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertRaises(lib_exc.Forbidden, self._create_subnetpool,"},{"line_number":68,"context_line":"                          is_admin\u003dFalse, is_default\u003dTrue)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @test.attr(type\u003d\u0027negative\u0027)"},{"line_number":71,"context_line":"    @decorators.idempotent_id(\u00274be84d30-60ca-4bd3-8512-db5b36ce1378\u0027)"},{"line_number":72,"context_line":"    def test_update_non_existent_subnetpool(self):"},{"line_number":73,"context_line":"        non_exist_id \u003d data_utils.rand_name(\u0027subnetpool\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_af7c9872","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":31},"updated":"2017-05-26 06:56:26.000000000","message":"ditto!","commit_id":"06356f0f115e132be934451fce4635579f2e4c8d"}]}