)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":10,"context_line":"below:"},{"line_number":11,"context_line":"- Provide create, update and delete log api for log drivers"},{"line_number":12,"context_line":"- Reserve a rpc notification api for log drivers if a log driver"},{"line_number":13,"context_line":"require rpc."},{"line_number":14,"context_line":"- Reserve a rpc listiner for listening callback from log drivers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d50356dd1da49af6faaaa8969b6ae9041f81063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"9f436f4f_832fa986","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"updated":"2017-08-15 19:44:16.000000000","message":"requires","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":10,"context_line":"below:"},{"line_number":11,"context_line":"- Provide create, update and delete log api for log drivers"},{"line_number":12,"context_line":"- Reserve a rpc notification api for log drivers if a log driver"},{"line_number":13,"context_line":"require rpc."},{"line_number":14,"context_line":"- Reserve a rpc listiner for listening callback from log drivers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d50356dd1da49af6faaaa8969b6ae9041f81063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"9f436f4f_a67989c8","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"in_reply_to":"9f436f4f_832fa986","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Provide create, update and delete log api for log drivers"},{"line_number":12,"context_line":"- Reserve a rpc notification api for log drivers if a log driver"},{"line_number":13,"context_line":"require rpc."},{"line_number":14,"context_line":"- Reserve a rpc listiner for listening callback from log drivers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d50356dd1da49af6faaaa8969b6ae9041f81063"},{"line_number":17,"context_line":"Partially-implements: blueprint security-group-logging"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"9f436f4f_037299ad","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":24},"updated":"2017-08-15 19:44:16.000000000","message":"listener","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Provide create, update and delete log api for log drivers"},{"line_number":12,"context_line":"- Reserve a rpc notification api for log drivers if a log driver"},{"line_number":13,"context_line":"require rpc."},{"line_number":14,"context_line":"- Reserve a rpc listiner for listening callback from log drivers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d50356dd1da49af6faaaa8969b6ae9041f81063"},{"line_number":17,"context_line":"Partially-implements: blueprint security-group-logging"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"9f436f4f_667f21ab","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":24},"in_reply_to":"9f436f4f_037299ad","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- Reserve a rpc notification api for log drivers if a log driver"},{"line_number":13,"context_line":"require rpc."},{"line_number":14,"context_line":"- Reserve a rpc listiner for listening callback from log drivers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d50356dd1da49af6faaaa8969b6ae9041f81063"},{"line_number":17,"context_line":"Partially-implements: blueprint security-group-logging"},{"line_number":18,"context_line":"Related-Bug: #1468366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"9f436f4f_6563a5b3","line":15,"updated":"2017-08-15 19:44:16.000000000","message":"Shouldn\u0027t you also list the DB methods that are added in this patchset?","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- Reserve a rpc notification api for log drivers if a log driver"},{"line_number":13,"context_line":"require rpc."},{"line_number":14,"context_line":"- Reserve a rpc listiner for listening callback from log drivers."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7d50356dd1da49af6faaaa8969b6ae9041f81063"},{"line_number":17,"context_line":"Partially-implements: blueprint security-group-logging"},{"line_number":18,"context_line":"Related-Bug: #1468366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"9f436f4f_467addb9","line":15,"in_reply_to":"9f436f4f_6563a5b3","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"}],"neutron/services/logapi/agent/drivers/base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        \"\"\"Create log_objs invocation."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":80,"context_line":"        to update the backend where necessary with the specific policy"},{"line_number":81,"context_line":"        information."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param context: current running context information"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_3d383eed","line":80,"range":{"start_line":80,"start_character":64,"end_line":80,"end_character":70},"updated":"2017-07-05 06:01:08.000000000","message":"bad copy-and-paste?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        \"\"\"Create log_objs invocation."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":80,"context_line":"        to update the backend where necessary with the specific policy"},{"line_number":81,"context_line":"        information."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param context: current running context information"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_6201b804","line":80,"range":{"start_line":80,"start_character":64,"end_line":80,"end_character":70},"in_reply_to":"3f1d235d_3d383eed","updated":"2017-07-11 12:31:53.000000000","message":"Done","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\"Update log_objs invocation."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":92,"context_line":"        to update the backend where necessary with the specific policy"},{"line_number":93,"context_line":"        information."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param context: current running context information"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_e03d7dc4","line":92,"range":{"start_line":92,"start_character":64,"end_line":92,"end_character":70},"updated":"2017-07-05 06:01:08.000000000","message":"ditto","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\"Update log_objs invocation."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":92,"context_line":"        to update the backend where necessary with the specific policy"},{"line_number":93,"context_line":"        information."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param context: current running context information"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_4208fc26","line":92,"range":{"start_line":92,"start_character":64,"end_line":92,"end_character":70},"in_reply_to":"3f1d235d_e03d7dc4","updated":"2017-07-11 12:31:53.000000000","message":"Done","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \"\"\"Delete log_objs invocation."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":104,"context_line":"        to update the backend where necessary with the specific policy"},{"line_number":105,"context_line":"        information."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        :param context: current running context information"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_c03a81ca","line":104,"range":{"start_line":104,"start_character":64,"end_line":104,"end_character":70},"updated":"2017-07-05 06:01:08.000000000","message":"ditto","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \"\"\"Delete log_objs invocation."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":104,"context_line":"        to update the backend where necessary with the specific policy"},{"line_number":105,"context_line":"        information."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        :param context: current running context information"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_02120459","line":104,"range":{"start_line":104,"start_character":64,"end_line":104,"end_character":70},"in_reply_to":"3f1d235d_c03a81ca","updated":"2017-07-11 12:31:53.000000000","message":"Done","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"}],"neutron/services/logapi/agent/drivers/manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9fe9a5eb0b8e830a176779faf75d5985e6e32310","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                           events.AFTER_CREATE)"},{"line_number":58,"context_line":"        registry.subscribe(self._handle_sg_rule_callback,"},{"line_number":59,"context_line":"                           resources.SECURITY_GROUP_RULE,"},{"line_number":60,"context_line":"                           events.AFTER_DELETE)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def drivers(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f1a1f67_be7bd989","line":60,"updated":"2017-07-19 11:51:20.000000000","message":"consider to use decorators. has_registry_receivers and receives.","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"08d3263cc8b2c50bc6696a211e45207a038ebc5d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                           events.AFTER_CREATE)"},{"line_number":58,"context_line":"        registry.subscribe(self._handle_sg_rule_callback,"},{"line_number":59,"context_line":"                           resources.SECURITY_GROUP_RULE,"},{"line_number":60,"context_line":"                           events.AFTER_DELETE)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @property"},{"line_number":63,"context_line":"    def drivers(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_c7b899c9","line":60,"in_reply_to":"1f1a1f67_be7bd989","updated":"2017-07-25 08:01:05.000000000","message":"Done","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9fe9a5eb0b8e830a176779faf75d5985e6e32310","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                constants.DEVICE_OWNER_COMPUTE_PREFIX):"},{"line_number":132,"context_line":"            if not validators.validate_log_type_for_port("},{"line_number":133,"context_line":"                    \u0027security_group\u0027, port):"},{"line_number":134,"context_line":"                msg \u003d (_(\"Logging type %(log_type)s is not supported on port\""},{"line_number":135,"context_line":"                         \"%(port_id)s.\") %"},{"line_number":136,"context_line":"                       {\u0027log_type\u0027: \u0027security_group\u0027, \u0027port_id\u0027: port_id})"},{"line_number":137,"context_line":"                LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f1a1f67_5eb16546","line":134,"range":{"start_line":134,"start_character":23,"end_line":134,"end_character":24},"updated":"2017-07-19 11:51:20.000000000","message":"do not translate log messages.","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"08d3263cc8b2c50bc6696a211e45207a038ebc5d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                constants.DEVICE_OWNER_COMPUTE_PREFIX):"},{"line_number":132,"context_line":"            if not validators.validate_log_type_for_port("},{"line_number":133,"context_line":"                    \u0027security_group\u0027, port):"},{"line_number":134,"context_line":"                msg \u003d (_(\"Logging type %(log_type)s is not supported on port\""},{"line_number":135,"context_line":"                         \"%(port_id)s.\") %"},{"line_number":136,"context_line":"                       {\u0027log_type\u0027: \u0027security_group\u0027, \u0027port_id\u0027: port_id})"},{"line_number":137,"context_line":"                LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_a7bb55c2","line":134,"range":{"start_line":134,"start_character":23,"end_line":134,"end_character":24},"in_reply_to":"1f1a1f67_5eb16546","updated":"2017-07-25 08:01:05.000000000","message":"Done","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9fe9a5eb0b8e830a176779faf75d5985e6e32310","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                msg \u003d (_(\"Logging type %(log_type)s is not supported on port\""},{"line_number":135,"context_line":"                         \"%(port_id)s.\") %"},{"line_number":136,"context_line":"                       {\u0027log_type\u0027: \u0027security_group\u0027, \u0027port_id\u0027: port_id})"},{"line_number":137,"context_line":"                LOG.exception(msg)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def _handle_sg_rule_callback(self, resource, event, trigger, **kwargs):"},{"line_number":140,"context_line":"        context \u003d kwargs[\u0027context\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f1a1f67_7ea66111","line":137,"range":{"start_line":137,"start_character":20,"end_line":137,"end_character":29},"updated":"2017-07-19 11:51:20.000000000","message":"this is not an exception","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"08d3263cc8b2c50bc6696a211e45207a038ebc5d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                msg \u003d (_(\"Logging type %(log_type)s is not supported on port\""},{"line_number":135,"context_line":"                         \"%(port_id)s.\") %"},{"line_number":136,"context_line":"                       {\u0027log_type\u0027: \u0027security_group\u0027, \u0027port_id\u0027: port_id})"},{"line_number":137,"context_line":"                LOG.exception(msg)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def _handle_sg_rule_callback(self, resource, event, trigger, **kwargs):"},{"line_number":140,"context_line":"        context \u003d kwargs[\u0027context\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_67b56dcd","line":137,"range":{"start_line":137,"start_character":20,"end_line":137,"end_character":29},"in_reply_to":"1f1a1f67_7ea66111","updated":"2017-07-25 08:01:05.000000000","message":"Done","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"}],"neutron/services/logapi/agent/log_extension.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            self.defer_apply_off()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class LoggingApiStub(object):"},{"line_number":87,"context_line":"    \"\"\"Stub proxy code for agent-\u003eserver communication"},{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_0309132b","line":86,"updated":"2017-10-11 16:16:08.000000000","message":"I think we should move the stub to different module. Something like neutron.services.logapi.rpc.agent","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            self.defer_apply_off()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class LoggingApiStub(object):"},{"line_number":87,"context_line":"    \"\"\"Stub proxy code for agent-\u003eserver communication"},{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_683744e5","line":86,"in_reply_to":"5f4e5783_0309132b","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class LoggingApiStub(object):"},{"line_number":87,"context_line":"    \"\"\"Stub proxy code for agent-\u003eserver communication"},{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_c312db58","line":87,"updated":"2017-10-11 16:16:08.000000000","message":"super-nit: Missing period","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class LoggingApiStub(object):"},{"line_number":87,"context_line":"    \"\"\"Stub proxy code for agent-\u003eserver communication"},{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_28314ced","line":87,"in_reply_to":"5f4e5783_c312db58","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.rpc_client \u003d n_rpc.get_client(target)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @log_helpers.log_method_call"},{"line_number":99,"context_line":"    def get_sg_log_info(self, context, **kwargs):"},{"line_number":100,"context_line":"        \"\"\"Return list log info\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        cctxt \u003d self.rpc_client.prepare()"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_0d90194e","line":99,"range":{"start_line":99,"start_character":39,"end_line":99,"end_character":47},"updated":"2017-10-11 16:16:08.000000000","message":"There should be a defined parameters for RPC so you are able to do versioning correctly. You\u0027ll get issues running new server with older agent code if the method changes.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.rpc_client \u003d n_rpc.get_client(target)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @log_helpers.log_method_call"},{"line_number":99,"context_line":"    def get_sg_log_info(self, context, **kwargs):"},{"line_number":100,"context_line":"        \"\"\"Return list log info\"\"\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        cctxt \u003d self.rpc_client.prepare()"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_0877b0a2","line":99,"range":{"start_line":99,"start_character":39,"end_line":99,"end_character":47},"in_reply_to":"5f4e5783_0d90194e","updated":"2017-10-13 08:13:57.000000000","message":"Thanks for your suggestion. Done!","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"}],"neutron/services/logapi/common/db_api.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _get_ports_attached_to_sg(context, sg_id):"},{"line_number":32,"context_line":"    \"\"\"Return a list of ports are attached to a security group\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":35,"context_line":"        ports \u003d context.session.query("}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_94423daa","line":32,"range":{"start_line":32,"start_character":30,"end_line":32,"end_character":33},"updated":"2017-08-15 19:44:16.000000000","message":"Just remove this","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _get_ports_attached_to_sg(context, sg_id):"},{"line_number":32,"context_line":"    \"\"\"Return a list of ports are attached to a security group\"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":35,"context_line":"        ports \u003d context.session.query("}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_0652953b","line":32,"range":{"start_line":32,"start_character":30,"end_line":32,"end_character":33},"in_reply_to":"9f436f4f_94423daa","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_sgs_log_for_port(context, sg_log, port_id):"},{"line_number":98,"context_line":"    \"\"\"Return a list of security group ids are logged for a port\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":101,"context_line":"    sg_ids \u003d _get_sgs_attached_to_port(context, port_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_f97182a9","line":98,"range":{"start_line":98,"start_character":43,"end_line":98,"end_character":46},"updated":"2017-08-15 19:44:16.000000000","message":"being","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def _get_sgs_log_for_port(context, sg_log, port_id):"},{"line_number":98,"context_line":"    \"\"\"Return a list of security group ids are logged for a port\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":101,"context_line":"    sg_ids \u003d _get_sgs_attached_to_port(context, port_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_a662a908","line":98,"range":{"start_line":98,"start_character":43,"end_line":98,"end_character":46},"in_reply_to":"9f436f4f_f97182a9","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            return [sg_id]"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            return []"},{"line_number":107,"context_line":"    else:"},{"line_number":108,"context_line":"        return sg_ids"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def _get_sg_rules(context, sg_ids):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_94a6bdaa","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":21},"updated":"2017-08-15 19:44:16.000000000","message":"Does this mean that all the security groups associated to the port are being logged? Is this correct?","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            return [sg_id]"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            return []"},{"line_number":107,"context_line":"    else:"},{"line_number":108,"context_line":"        return sg_ids"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def _get_sg_rules(context, sg_ids):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_263479fb","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":21},"in_reply_to":"9f436f4f_94a6bdaa","updated":"2017-08-16 09:01:32.000000000","message":"Yes, you\u0027re right.","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def _get_sg_rules(context, sg_ids):"},{"line_number":112,"context_line":"    \"\"\"Return a list of sg_rules under security groups, which are logged"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    if not sg_ids:"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_16dc1544","line":113,"updated":"2017-08-15 19:44:16.000000000","message":"I don\u0027t think we need this blank line","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def _get_sg_rules(context, sg_ids):"},{"line_number":112,"context_line":"    \"\"\"Return a list of sg_rules under security groups, which are logged"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    \"\"\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    if not sg_ids:"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_862205b8","line":113,"in_reply_to":"9f436f4f_16dc1544","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        return []"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    sgr_sgid \u003d sg_db.SecurityGroupRule.security_group_id"},{"line_number":120,"context_line":"    rules_in_db \u003d context.session.query(sg_db.SecurityGroupRule).\\"},{"line_number":121,"context_line":"        filter(sgr_sgid.in_(sg_ids)).all()"},{"line_number":122,"context_line":"    rules \u003d []"},{"line_number":123,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":124,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_568dfd2f","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":42},"updated":"2017-08-15 19:44:16.000000000","message":"You could get rid of that \\ by breaking this as follows:\n\n     rules_in_db \u003d context.session.query(\n         sg_db.SecurityGroupRule).filter(sgr_sgid.in_(sg_ids)).all()\n\nFurthermore, you are accessing the rules directly in the DB layer. Shouldn\u0027t you be using OVO for this? Please see https://github.com/openstack/neutron/blob/master/neutron/objects/securitygroup.py#L86","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        return []"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    sgr_sgid \u003d sg_db.SecurityGroupRule.security_group_id"},{"line_number":120,"context_line":"    rules_in_db \u003d context.session.query(sg_db.SecurityGroupRule).\\"},{"line_number":121,"context_line":"        filter(sgr_sgid.in_(sg_ids)).all()"},{"line_number":122,"context_line":"    rules \u003d []"},{"line_number":123,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":124,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_860b2528","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":42},"in_reply_to":"9f436f4f_568dfd2f","updated":"2017-08-16 09:01:32.000000000","message":"Thanks for your suggestion. Done.","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":133,"context_line":"                    direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":134,"context_line":"                    rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":135,"context_line":"                    continue"},{"line_number":136,"context_line":"                rule_dict[key] \u003d rule_in_db[key]"},{"line_number":137,"context_line":"        rule_dict[\u0027security_group_id\u0027] \u003d rule_in_db[\u0027security_group_id\u0027]"},{"line_number":138,"context_line":"        rules.append(rule_dict)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_f9586231","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":28},"updated":"2017-08-15 19:44:16.000000000","message":"Why not just else here? IMO, it would be clearer","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":133,"context_line":"                    direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":134,"context_line":"                    rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":135,"context_line":"                    continue"},{"line_number":136,"context_line":"                rule_dict[key] \u003d rule_in_db[key]"},{"line_number":137,"context_line":"        rule_dict[\u0027security_group_id\u0027] \u003d rule_in_db[\u0027security_group_id\u0027]"},{"line_number":138,"context_line":"        rules.append(rule_dict)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_61494b5e","line":135,"range":{"start_line":135,"start_character":20,"end_line":135,"end_character":28},"in_reply_to":"9f436f4f_f9586231","updated":"2017-08-16 09:01:32.000000000","message":"Actually, this is copy-and pate from [1]. However, \u0027else\u0027 here more clearly.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/securitygroups_rpc_base.py#L214-L221","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_logs_bound_port(context, port_id):"},{"line_number":163,"context_line":"    \"\"\"Return a list of log_resources bound a port\"\"\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    log_resources \u003d []"},{"line_number":166,"context_line":"    port \u003d port_objects.Port.get_object(context, id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_d6768d70","line":163,"range":{"start_line":163,"start_character":44,"end_line":163,"end_character":45},"updated":"2017-08-15 19:44:16.000000000","message":"to a","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"def get_logs_bound_port(context, port_id):"},{"line_number":163,"context_line":"    \"\"\"Return a list of log_resources bound a port\"\"\""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    log_resources \u003d []"},{"line_number":166,"context_line":"    port \u003d port_objects.Port.get_object(context, id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_41440747","line":163,"range":{"start_line":163,"start_character":44,"end_line":163,"end_character":45},"in_reply_to":"9f436f4f_d6768d70","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def get_logs_bound_sg(context, sg_id):"},{"line_number":183,"context_line":"    \"\"\"Return a list of log_resources bound a security group\"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    project_id \u003d context.tenant_id"},{"line_number":186,"context_line":"    log_objs \u003d log_object.Log.get_objects("}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_16f2d506","line":183,"range":{"start_line":183,"start_character":44,"end_line":183,"end_character":45},"updated":"2017-08-15 19:44:16.000000000","message":"to a","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"def get_logs_bound_sg(context, sg_id):"},{"line_number":183,"context_line":"    \"\"\"Return a list of log_resources bound a security group\"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    project_id \u003d context.tenant_id"},{"line_number":186,"context_line":"    log_objs \u003d log_object.Log.get_objects("}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_017cbf80","line":183,"range":{"start_line":183,"start_character":44,"end_line":183,"end_character":45},"in_reply_to":"9f436f4f_16f2d506","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":222,"context_line":"             ..."},{"line_number":223,"context_line":"        ]"},{"line_number":224,"context_line":"    :param context: current running context information"},{"line_number":225,"context_line":"    :param kwargs: a list of log_resources or port_id need to get"},{"line_number":226,"context_line":"                   security groups log info"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_b66789e9","line":225,"range":{"start_line":225,"start_character":54,"end_line":225,"end_character":58},"updated":"2017-08-15 19:44:16.000000000","message":"needed","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":222,"context_line":"             ..."},{"line_number":223,"context_line":"        ]"},{"line_number":224,"context_line":"    :param context: current running context information"},{"line_number":225,"context_line":"    :param kwargs: a list of log_resources or port_id need to get"},{"line_number":226,"context_line":"                   security groups log info"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_e16e5bc7","line":225,"range":{"start_line":225,"start_character":54,"end_line":225,"end_character":58},"in_reply_to":"9f436f4f_b66789e9","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"2200616debac1c3d94d0a29da0d8afd9bb8b83b9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    if not sg_ids:"},{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"},{"line_number":119,"context_line":"    rules_in_db \u003d sg_object.SecurityGroupRule.get_objects(context, **filters)"},{"line_number":120,"context_line":"    rules \u003d []"},{"line_number":121,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":122,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":35,"id":"9f436f4f_5a3973ef","line":119,"range":{"start_line":118,"start_character":0,"end_line":119,"end_character":76},"updated":"2017-08-17 06:43:50.000000000","message":"Is it correct?","commit_id":"2179af25b4e490eb5dc47c48abdecaa85cd74c44"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DIRECTION_IP_PREFIX \u003d {\u0027ingress\u0027: \u0027source_ip_prefix\u0027,"},{"line_number":29,"context_line":"                       \u0027egress\u0027: \u0027dest_ip_prefix\u0027}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_237bef8c","line":28,"updated":"2017-10-11 16:16:08.000000000","message":"This looks very familiar to http://git.openstack.org/cgit/openstack/neutron/tree/neutron/agent/firewall.py#n31\n\nWe should mode that map from neutron.agent.firewall to some security group common module and re-use it.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DIRECTION_IP_PREFIX \u003d {\u0027ingress\u0027: \u0027source_ip_prefix\u0027,"},{"line_number":29,"context_line":"                       \u0027egress\u0027: \u0027dest_ip_prefix\u0027}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_28b4ac34","line":28,"in_reply_to":"5f4e5783_237bef8c","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":36,"context_line":"        ports \u003d context.session.query("},{"line_number":37,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id).filter("},{"line_number":38,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id \u003d\u003d"},{"line_number":39,"context_line":"                    sg_id).all()"},{"line_number":40,"context_line":"    return set([port for (port,) in ports])"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_0f36d204","line":37,"updated":"2017-10-11 16:16:08.000000000","message":"Indentation","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":36,"context_line":"        ports \u003d context.session.query("},{"line_number":37,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id).filter("},{"line_number":38,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id \u003d\u003d"},{"line_number":39,"context_line":"                    sg_id).all()"},{"line_number":40,"context_line":"    return set([port for (port,) in ports])"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_e887b460","line":37,"in_reply_to":"5f4e5783_0f36d204","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id).filter("},{"line_number":38,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id \u003d\u003d"},{"line_number":39,"context_line":"                    sg_id).all()"},{"line_number":40,"context_line":"    return set([port for (port,) in ports])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _get_ports_filter_in_tenant(context, tenant_id):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_6f2e66a6","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":15},"updated":"2017-10-11 16:16:08.000000000","message":"This creates a list and then re-types to set. Following code should be a bit faster:\n\n return {port for (port,) in ports}\n\nBTW is it even possible to get same port models from the query?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id).filter("},{"line_number":38,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id \u003d\u003d"},{"line_number":39,"context_line":"                    sg_id).all()"},{"line_number":40,"context_line":"    return set([port for (port,) in ports])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _get_ports_filter_in_tenant(context, tenant_id):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_a8f65cf8","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":15},"in_reply_to":"5f4e5783_6f2e66a6","updated":"2017-10-13 08:13:57.000000000","message":"Yeah! thanks for your teaching.\n \n\u003e BTW is it even possible to get same port models from the query?\n\nYes, each port can be associated with multiple security groups.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d58e85e06f12e77ab3900733589700e3a2a699d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id).filter("},{"line_number":38,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id \u003d\u003d"},{"line_number":39,"context_line":"                    sg_id).all()"},{"line_number":40,"context_line":"    return set([port for (port,) in ports])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _get_ports_filter_in_tenant(context, tenant_id):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_ee51a537","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":15},"in_reply_to":"5f4e5783_a8f65cf8","updated":"2017-10-17 13:48:00.000000000","message":"But you pass only a single security group id. That would mean one port can be associated with one security group multiple times, no?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"99dce29e9554995dbc9d543a1ac240110a275069","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id).filter("},{"line_number":38,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id \u003d\u003d"},{"line_number":39,"context_line":"                    sg_id).all()"},{"line_number":40,"context_line":"    return set([port for (port,) in ports])"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _get_ports_filter_in_tenant(context, tenant_id):"}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_aa4ecbbe","line":40,"range":{"start_line":40,"start_character":11,"end_line":40,"end_character":15},"in_reply_to":"5f4e5783_ee51a537","updated":"2017-10-18 08:08:04.000000000","message":"You\u0027re right. I misunderstood here. So we no need to put port_id to a set. But can I keep \u0027set\u0027 for this case? :)","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    try:"},{"line_number":47,"context_line":"        sg_id \u003d sg_db.SecurityGroupPortBinding.security_group_id"},{"line_number":48,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":49,"context_line":"            ports \u003d context.session.query("},{"line_number":50,"context_line":"                sg_db.SecurityGroupPortBinding.port_id).join("},{"line_number":51,"context_line":"                sg_db.SecurityGroup, sg_db.SecurityGroup.id \u003d\u003d sg_id).filter("}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_652e87a6","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":42},"updated":"2017-10-11 16:16:08.000000000","message":"We probably need somebody from DB team to confirm, but should be \u0027reader\u0027 here instead of \u0027writer\u0027?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    try:"},{"line_number":47,"context_line":"        sg_id \u003d sg_db.SecurityGroupPortBinding.security_group_id"},{"line_number":48,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":49,"context_line":"            ports \u003d context.session.query("},{"line_number":50,"context_line":"                sg_db.SecurityGroupPortBinding.port_id).join("},{"line_number":51,"context_line":"                sg_db.SecurityGroup, sg_db.SecurityGroup.id \u003d\u003d sg_id).filter("}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_08d33062","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":42},"in_reply_to":"5f4e5783_652e87a6","updated":"2017-10-13 08:13:57.000000000","message":"It should be \"reader\" session. Thanks.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def _get_sgs_attached_to_port(context, port_id):"},{"line_number":59,"context_line":"    \"\"\"Return a list of security groups are associated to a port\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":62,"context_line":"        sg_ids \u003d context.session.query("},{"line_number":63,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id).filter("},{"line_number":64,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id \u003d\u003d port_id).all()"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_ed35bddb","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":38},"updated":"2017-10-11 16:16:08.000000000","message":"Ditto","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def _get_sgs_attached_to_port(context, port_id):"},{"line_number":59,"context_line":"    \"\"\"Return a list of security groups are associated to a port\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":62,"context_line":"        sg_ids \u003d context.session.query("},{"line_number":63,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id).filter("},{"line_number":64,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id \u003d\u003d port_id).all()"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_e8d57444","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":38},"in_reply_to":"5f4e5783_ed35bddb","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":62,"context_line":"        sg_ids \u003d context.session.query("},{"line_number":63,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id).filter("},{"line_number":64,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id \u003d\u003d port_id).all()"},{"line_number":65,"context_line":"    return [sg_id for (sg_id, ) in sg_ids]"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_ef137665","line":63,"updated":"2017-10-11 16:16:08.000000000","message":"Indentation","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    with db_api.context_manager.writer.using(context):"},{"line_number":62,"context_line":"        sg_ids \u003d context.session.query("},{"line_number":63,"context_line":"                    sg_db.SecurityGroupPortBinding.security_group_id).filter("},{"line_number":64,"context_line":"                    sg_db.SecurityGroupPortBinding.port_id \u003d\u003d port_id).all()"},{"line_number":65,"context_line":"    return [sg_id for (sg_id, ) in sg_ids]"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_c8ccf8bd","line":63,"in_reply_to":"5f4e5783_ef137665","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"\"\"Return a list of ports under a log_resource\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    port_ids \u003d []"},{"line_number":72,"context_line":"    port_id \u003d sg_log.get(\u0027target_id\u0027, None)"},{"line_number":73,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":74,"context_line":"    # if \u0027target_id\u0027 (port_id) is specified in a log_resource"},{"line_number":75,"context_line":"    if port_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_caa9c8df","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":42},"updated":"2017-10-11 16:16:08.000000000","message":"This is implicit","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"\"\"Return a list of ports under a log_resource\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    port_ids \u003d []"},{"line_number":72,"context_line":"    port_id \u003d sg_log.get(\u0027target_id\u0027, None)"},{"line_number":73,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":74,"context_line":"    # if \u0027target_id\u0027 (port_id) is specified in a log_resource"},{"line_number":75,"context_line":"    if port_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_6d0e6d8e","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":35},"updated":"2017-10-11 16:16:08.000000000","message":"Would be good to stick to project_id","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d58e85e06f12e77ab3900733589700e3a2a699d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"\"\"Return a list of ports under a log_resource\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    port_ids \u003d []"},{"line_number":72,"context_line":"    port_id \u003d sg_log.get(\u0027target_id\u0027, None)"},{"line_number":73,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":74,"context_line":"    # if \u0027target_id\u0027 (port_id) is specified in a log_resource"},{"line_number":75,"context_line":"    if port_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_ce126962","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":42},"in_reply_to":"5f4e5783_28170cf0","updated":"2017-10-17 13:48:00.000000000","message":"Gerrit doesn\u0027t show me to which comment your answer was :) If it was to \"This is implicit\" than I was just stating that\n\n sg_log.get(\u0027target_id\u0027)\n\nis equal to\n\n sg_log.get(\u0027target_id\u0027, None)\n\nbut it\u0027s really a nit :)\n\nIf sg_log always contains \u0027target_id\u0027 then why is there L75?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"\"\"Return a list of ports under a log_resource\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    port_ids \u003d []"},{"line_number":72,"context_line":"    port_id \u003d sg_log.get(\u0027target_id\u0027, None)"},{"line_number":73,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":74,"context_line":"    # if \u0027target_id\u0027 (port_id) is specified in a log_resource"},{"line_number":75,"context_line":"    if port_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_28170cf0","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":42},"in_reply_to":"5f4e5783_caa9c8df","updated":"2017-10-13 08:13:57.000000000","message":"Because sg_log object always has key \u0027target_id\u0027. So I couldn\u0027t use try..except for this block-code. I just modify to make this code less implicit. Any recommendations are appreciated.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"99dce29e9554995dbc9d543a1ac240110a275069","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"\"\"Return a list of ports under a log_resource\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    port_ids \u003d []"},{"line_number":72,"context_line":"    port_id \u003d sg_log.get(\u0027target_id\u0027, None)"},{"line_number":73,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":74,"context_line":"    # if \u0027target_id\u0027 (port_id) is specified in a log_resource"},{"line_number":75,"context_line":"    if port_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_ca8467b4","line":72,"range":{"start_line":72,"start_character":36,"end_line":72,"end_character":42},"in_reply_to":"5f4e5783_ce126962","updated":"2017-10-18 08:08:04.000000000","message":"Sorry for made you confused. My answer for \u0027this is implicit.\u0027.:) sg_log always contains key \u0027target_id\u0027, but the value can be None. That mean target_id isn\u0027t specified in a request create a log_resource.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    # both \u0027resource_id\u0027 and \u0027target_id\u0027 aren\u0027t specified in a log_resource"},{"line_number":81,"context_line":"    else:"},{"line_number":82,"context_line":"        tenant_id \u003d sg_log[\u0027project_id\u0027]"},{"line_number":83,"context_line":"        port_ids \u003d _get_ports_filter_in_tenant(context, tenant_id)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    ports \u003d []"},{"line_number":86,"context_line":"    for port_id in port_ids:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_ad2b45e9","line":83,"range":{"start_line":83,"start_character":56,"end_line":83,"end_character":65},"updated":"2017-10-11 16:16:08.000000000","message":"consider just passing sg_log[\u0027project_id\u0027]","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    # both \u0027resource_id\u0027 and \u0027target_id\u0027 aren\u0027t specified in a log_resource"},{"line_number":81,"context_line":"    else:"},{"line_number":82,"context_line":"        tenant_id \u003d sg_log[\u0027project_id\u0027]"},{"line_number":83,"context_line":"        port_ids \u003d _get_ports_filter_in_tenant(context, tenant_id)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    ports \u003d []"},{"line_number":86,"context_line":"    for port_id in port_ids:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_08d4501f","line":83,"range":{"start_line":83,"start_character":56,"end_line":83,"end_character":65},"in_reply_to":"5f4e5783_ad2b45e9","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        tenant_id \u003d sg_log[\u0027project_id\u0027]"},{"line_number":83,"context_line":"        port_ids \u003d _get_ports_filter_in_tenant(context, tenant_id)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    ports \u003d []"},{"line_number":86,"context_line":"    for port_id in port_ids:"},{"line_number":87,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"},{"line_number":88,"context_line":"        if validators.validate_log_type_for_port(\u0027security_group\u0027, port):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_10515263","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":9},"updated":"2017-10-11 16:16:08.000000000","message":"The meaning is quite misleading as you\u0027re storing port_ids there.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        tenant_id \u003d sg_log[\u0027project_id\u0027]"},{"line_number":83,"context_line":"        port_ids \u003d _get_ports_filter_in_tenant(context, tenant_id)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    ports \u003d []"},{"line_number":86,"context_line":"    for port_id in port_ids:"},{"line_number":87,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"},{"line_number":88,"context_line":"        if validators.validate_log_type_for_port(\u0027security_group\u0027, port):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_28c5cc5b","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":9},"in_reply_to":"5f4e5783_10515263","updated":"2017-10-13 08:13:57.000000000","message":"Yes. I\u0027ve modified to \u0027validated_port_ids\u0027. Do you think that\u0027s good name?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d58e85e06f12e77ab3900733589700e3a2a699d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        tenant_id \u003d sg_log[\u0027project_id\u0027]"},{"line_number":83,"context_line":"        port_ids \u003d _get_ports_filter_in_tenant(context, tenant_id)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    ports \u003d []"},{"line_number":86,"context_line":"    for port_id in port_ids:"},{"line_number":87,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"},{"line_number":88,"context_line":"        if validators.validate_log_type_for_port(\u0027security_group\u0027, port):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_d120ce9d","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":9},"in_reply_to":"5f4e5783_28c5cc5b","updated":"2017-10-17 13:48:00.000000000","message":"Yes, sounds better :)","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"def _get_sgs_log_for_port(context, sg_log, port_id):"},{"line_number":99,"context_line":"    \"\"\"Return a list of security group ids being logged for a port\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":102,"context_line":"    sg_ids \u003d _get_sgs_attached_to_port(context, port_id)"},{"line_number":103,"context_line":"    if sg_id:"},{"line_number":104,"context_line":"        if sg_id in sg_ids:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_f0b8f62a","line":101,"range":{"start_line":101,"start_character":36,"end_line":101,"end_character":42},"updated":"2017-10-11 16:16:08.000000000","message":"nit: implicit","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"def _get_sgs_log_for_port(context, sg_log, port_id):"},{"line_number":99,"context_line":"    \"\"\"Return a list of security group ids being logged for a port\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":102,"context_line":"    sg_ids \u003d _get_sgs_attached_to_port(context, port_id)"},{"line_number":103,"context_line":"    if sg_id:"},{"line_number":104,"context_line":"        if sg_id in sg_ids:"},{"line_number":105,"context_line":"            return [sg_id]"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            return []"},{"line_number":108,"context_line":"    else:"},{"line_number":109,"context_line":"        return sg_ids"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def _get_sg_rules(context, sg_ids):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_d0fdfab1","line":109,"range":{"start_line":101,"start_character":0,"end_line":109,"end_character":21},"updated":"2017-10-11 16:16:08.000000000","message":"Consider:\n\n sg_ids \u003d _get_sgs_attached_to_port(context, port_id)\n try:\n     sg_id \u003d sg_log[\u0027resource_id\u0027]\n except KeyError:\n     return sg_ids\n\n if sg_id in sg_ids:\n    return [sg_id]\n\n return []","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"99dce29e9554995dbc9d543a1ac240110a275069","unresolved":false,"context_lines":[{"line_number":98,"context_line":"def _get_sgs_log_for_port(context, sg_log, port_id):"},{"line_number":99,"context_line":"    \"\"\"Return a list of security group ids being logged for a port\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":102,"context_line":"    sg_ids \u003d _get_sgs_attached_to_port(context, port_id)"},{"line_number":103,"context_line":"    if sg_id:"},{"line_number":104,"context_line":"        if sg_id in sg_ids:"},{"line_number":105,"context_line":"            return [sg_id]"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            return []"},{"line_number":108,"context_line":"    else:"},{"line_number":109,"context_line":"        return sg_ids"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def _get_sg_rules(context, sg_ids):"}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_aa06cb1f","line":109,"range":{"start_line":101,"start_character":0,"end_line":109,"end_character":21},"in_reply_to":"5f4e5783_11878664","updated":"2017-10-18 08:08:04.000000000","message":"Because the value of \u0027resource_id\u0027 can be None. That mean resource_id isn\u0027t specified in a request create a log resource.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d58e85e06f12e77ab3900733589700e3a2a699d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"def _get_sgs_log_for_port(context, sg_log, port_id):"},{"line_number":99,"context_line":"    \"\"\"Return a list of security group ids being logged for a port\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":102,"context_line":"    sg_ids \u003d _get_sgs_attached_to_port(context, port_id)"},{"line_number":103,"context_line":"    if sg_id:"},{"line_number":104,"context_line":"        if sg_id in sg_ids:"},{"line_number":105,"context_line":"            return [sg_id]"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            return []"},{"line_number":108,"context_line":"    else:"},{"line_number":109,"context_line":"        return sg_ids"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def _get_sg_rules(context, sg_ids):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_11878664","line":109,"range":{"start_line":101,"start_character":0,"end_line":109,"end_character":21},"in_reply_to":"5f4e5783_28a82c75","updated":"2017-10-17 13:48:00.000000000","message":"Why is there L103 then?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":98,"context_line":"def _get_sgs_log_for_port(context, sg_log, port_id):"},{"line_number":99,"context_line":"    \"\"\"Return a list of security group ids being logged for a port\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    sg_id \u003d sg_log.get(\u0027resource_id\u0027, None)"},{"line_number":102,"context_line":"    sg_ids \u003d _get_sgs_attached_to_port(context, port_id)"},{"line_number":103,"context_line":"    if sg_id:"},{"line_number":104,"context_line":"        if sg_id in sg_ids:"},{"line_number":105,"context_line":"            return [sg_id]"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            return []"},{"line_number":108,"context_line":"    else:"},{"line_number":109,"context_line":"        return sg_ids"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def _get_sg_rules(context, sg_ids):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_28a82c75","line":109,"range":{"start_line":101,"start_character":0,"end_line":109,"end_character":21},"in_reply_to":"5f4e5783_d0fdfab1","updated":"2017-10-13 08:13:57.000000000","message":"Because sg_log always has key \u0027resource_id\u0027 :(. I couldn\u0027t use try .. except. So I just modified to make that less implicit.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"},{"line_number":119,"context_line":"    rules_in_db \u003d sg_object.SecurityGroupRule.get_objects(context, **filters)"},{"line_number":120,"context_line":"    rules \u003d []"},{"line_number":121,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":122,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_d0ebbad9","line":119,"range":{"start_line":119,"start_character":46,"end_line":119,"end_character":77},"updated":"2017-10-11 16:16:08.000000000","message":"Does it work? You are comparing security_group_id (UUID) against a list","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"},{"line_number":119,"context_line":"    rules_in_db \u003d sg_object.SecurityGroupRule.get_objects(context, **filters)"},{"line_number":120,"context_line":"    rules \u003d []"},{"line_number":121,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":122,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_68cce460","line":119,"range":{"start_line":119,"start_character":46,"end_line":119,"end_character":77},"in_reply_to":"5f4e5783_118498d3","updated":"2017-10-13 08:13:57.000000000","message":"Thank Ihar. It work well. :)","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d58e85e06f12e77ab3900733589700e3a2a699d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"},{"line_number":119,"context_line":"    rules_in_db \u003d sg_object.SecurityGroupRule.get_objects(context, **filters)"},{"line_number":120,"context_line":"    rules \u003d []"},{"line_number":121,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":122,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_11d54644","line":119,"range":{"start_line":119,"start_character":46,"end_line":119,"end_character":77},"in_reply_to":"5f4e5783_68cce460","updated":"2017-10-17 13:48:00.000000000","message":"So assuming we pass [sg1, sg2] as security_group_id then the SQL query will be like \" ... WHERE SecurityGroupRule.security_group_id \u003d\u003d sg1 OR SecurityGroupRule.security_group_id \u003d\u003d sg2\" ? Nice, I didn\u0027t know that","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"17dd6220da94b911ebda56c83cb6eca26e6bd3aa","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"},{"line_number":119,"context_line":"    rules_in_db \u003d sg_object.SecurityGroupRule.get_objects(context, **filters)"},{"line_number":120,"context_line":"    rules \u003d []"},{"line_number":121,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":122,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_118498d3","line":119,"range":{"start_line":119,"start_character":46,"end_line":119,"end_character":77},"in_reply_to":"5f4e5783_d0ebbad9","updated":"2017-10-12 14:34:52.000000000","message":"SQLAlchemy, and hence OVO, supports it. It works as OR.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"},{"line_number":119,"context_line":"    rules_in_db \u003d sg_object.SecurityGroupRule.get_objects(context, **filters)"},{"line_number":120,"context_line":"    rules \u003d []"},{"line_number":121,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":122,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"},{"line_number":123,"context_line":"        rule_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_10f5d283","line":120,"range":{"start_line":120,"start_character":4,"end_line":120,"end_character":14},"updated":"2017-10-11 16:16:08.000000000","message":"Consider making the code below another function and then calling just:\n\n return [_create_rule_dict(rule_in_db) for rule_in_db in rules_in_db]","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"},{"line_number":119,"context_line":"    rules_in_db \u003d sg_object.SecurityGroupRule.get_objects(context, **filters)"},{"line_number":120,"context_line":"    rules \u003d []"},{"line_number":121,"context_line":"    for rule_in_db in rules_in_db:"},{"line_number":122,"context_line":"        direction \u003d rule_in_db[\u0027direction\u0027]"},{"line_number":123,"context_line":"        rule_dict \u003d {"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_e809f494","line":120,"range":{"start_line":120,"start_character":4,"end_line":120,"end_character":14},"in_reply_to":"5f4e5783_10f5d283","updated":"2017-10-13 08:13:57.000000000","message":"Yeah! This code looks more pretty, now. Thanks.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for key in (\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,"},{"line_number":128,"context_line":"                    \u0027remote_ip_prefix\u0027, \u0027remote_group_id\u0027):"},{"line_number":129,"context_line":"            if rule_in_db.get(key) is not None:"},{"line_number":130,"context_line":"                if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":131,"context_line":"                    direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":132,"context_line":"                    rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":133,"context_line":"                else:"},{"line_number":134,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":135,"context_line":"        rule_dict[\u0027security_group_id\u0027] \u003d rule_in_db[\u0027security_group_id\u0027]"},{"line_number":136,"context_line":"        rules.append(rule_dict)"},{"line_number":137,"context_line":"    return rules"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_f0ac768d","line":134,"range":{"start_line":129,"start_character":0,"end_line":134,"end_character":52},"updated":"2017-10-11 16:16:08.000000000","message":"Consider:\n\n for key in (\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,\n             \u0027remote_group_id\u0027):\n    try:\n        rule_dict[key] \u003d rule_in_db[key]\n    except KeyError:\n        pass\n\n direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]\n try:\n     rule_dict[dirextion_ip_prefix] \u003d rule_in_db[\u0027remote_ip_prefix\u0027]\n except KeyError:\n     pass","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"99dce29e9554995dbc9d543a1ac240110a275069","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for key in (\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,"},{"line_number":128,"context_line":"                    \u0027remote_ip_prefix\u0027, \u0027remote_group_id\u0027):"},{"line_number":129,"context_line":"            if rule_in_db.get(key) is not None:"},{"line_number":130,"context_line":"                if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":131,"context_line":"                    direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":132,"context_line":"                    rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":133,"context_line":"                else:"},{"line_number":134,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":135,"context_line":"        rule_dict[\u0027security_group_id\u0027] \u003d rule_in_db[\u0027security_group_id\u0027]"},{"line_number":136,"context_line":"        rules.append(rule_dict)"},{"line_number":137,"context_line":"    return rules"}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_6d890d25","line":134,"range":{"start_line":129,"start_character":0,"end_line":134,"end_character":52},"in_reply_to":"5f4e5783_1108a6d7","updated":"2017-10-18 08:08:04.000000000","message":"Your code looks simpler. thanks. I\u0027ve modified them as:\n\nrule_dict.update({\n        key: rule_in_db[key]\n        for key in (\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,\n                    \u0027remote_group_id\u0027) if rule_in_db[key] is not None})\n\nremote_ip_prefix \u003d rule_in_db[\u0027remote_ip_prefix\u0027]\nif remote_ip_prefix is not None:\n    direction_ip_prefix \u003d firewall.DIRECTION_IP_PREFIX[direction]\n    rule_dict[direction_ip_prefix] \u003d remote_ip_prefix\n\nDo you think is good?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4d58e85e06f12e77ab3900733589700e3a2a699d","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for key in (\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,"},{"line_number":128,"context_line":"                    \u0027remote_ip_prefix\u0027, \u0027remote_group_id\u0027):"},{"line_number":129,"context_line":"            if rule_in_db.get(key) is not None:"},{"line_number":130,"context_line":"                if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":131,"context_line":"                    direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":132,"context_line":"                    rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":133,"context_line":"                else:"},{"line_number":134,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":135,"context_line":"        rule_dict[\u0027security_group_id\u0027] \u003d rule_in_db[\u0027security_group_id\u0027]"},{"line_number":136,"context_line":"        rules.append(rule_dict)"},{"line_number":137,"context_line":"    return rules"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_1108a6d7","line":134,"range":{"start_line":129,"start_character":0,"end_line":134,"end_character":52},"in_reply_to":"5f4e5783_6884e4b1","updated":"2017-10-17 13:48:00.000000000","message":"You don\u0027t need to use get() method then as it looks like you\u0027re not expecting anything there. The code would look even simpler then:\n\n rule_dict.update({\n     key: rule_in_db[key]\n     for key in (\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,\n                 \u0027remote_group_id\u0027)})\n\n direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]\n try:\n     rule_dict[dirextion_ip_prefix] \u003d rule_in_db[\u0027remote_ip_prefix\u0027]\n except KeyError:\n     pass","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for key in (\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,"},{"line_number":128,"context_line":"                    \u0027remote_ip_prefix\u0027, \u0027remote_group_id\u0027):"},{"line_number":129,"context_line":"            if rule_in_db.get(key) is not None:"},{"line_number":130,"context_line":"                if key \u003d\u003d \u0027remote_ip_prefix\u0027:"},{"line_number":131,"context_line":"                    direction_ip_prefix \u003d DIRECTION_IP_PREFIX[direction]"},{"line_number":132,"context_line":"                    rule_dict[direction_ip_prefix] \u003d rule_in_db[key]"},{"line_number":133,"context_line":"                else:"},{"line_number":134,"context_line":"                    rule_dict[key] \u003d rule_in_db[key]"},{"line_number":135,"context_line":"        rule_dict[\u0027security_group_id\u0027] \u003d rule_in_db[\u0027security_group_id\u0027]"},{"line_number":136,"context_line":"        rules.append(rule_dict)"},{"line_number":137,"context_line":"    return rules"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_6884e4b1","line":134,"range":{"start_line":129,"start_character":0,"end_line":134,"end_character":52},"in_reply_to":"5f4e5783_f0ac768d","updated":"2017-10-13 08:13:57.000000000","message":"Because a rule_in_db always has key even though its value can be None. I couldn\u0027t use try... except here. So I\u0027d like to keep this code.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def _get_port_log_dict(context, port_id, sg_log):"},{"line_number":141,"context_line":"    port_log_dict \u003d {}"},{"line_number":142,"context_line":"    port_log_dict[\u0027port_id\u0027] \u003d port_id"},{"line_number":143,"context_line":"    sg_ids \u003d _get_sgs_log_for_port(context, sg_log, port_id)"},{"line_number":144,"context_line":"    port_log_dict[\u0027security_group_rules\u0027] \u003d _get_sg_rules(context, sg_ids)"},{"line_number":145,"context_line":"    return port_log_dict"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"def _make_log_dict(context, sg_log, ports_log):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_901782a4","line":145,"range":{"start_line":141,"start_character":0,"end_line":145,"end_character":24},"updated":"2017-10-11 16:16:08.000000000","message":"Consider:\n\n return \u003d {\n     \u0027port_id\u0027: port_id,\n     \u0027securiry_group_rules\u0027: _get_sg_rules(context, sg_log, port_id)\n }\n\nand then call _get_sgs_log_for_port() from inside of _get_sg_rules() as you use both functions only here.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def _get_port_log_dict(context, port_id, sg_log):"},{"line_number":141,"context_line":"    port_log_dict \u003d {}"},{"line_number":142,"context_line":"    port_log_dict[\u0027port_id\u0027] \u003d port_id"},{"line_number":143,"context_line":"    sg_ids \u003d _get_sgs_log_for_port(context, sg_log, port_id)"},{"line_number":144,"context_line":"    port_log_dict[\u0027security_group_rules\u0027] \u003d _get_sg_rules(context, sg_ids)"},{"line_number":145,"context_line":"    return port_log_dict"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"def _make_log_dict(context, sg_log, ports_log):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_68f50483","line":145,"range":{"start_line":141,"start_character":0,"end_line":145,"end_character":24},"in_reply_to":"5f4e5783_901782a4","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"def _make_log_dict(context, sg_log, ports_log):"},{"line_number":149,"context_line":"    log_dict \u003d {}"},{"line_number":150,"context_line":"    log_dict[\u0027id\u0027] \u003d sg_log[\u0027id\u0027]"},{"line_number":151,"context_line":"    log_dict[\u0027ports_log\u0027] \u003d []"},{"line_number":152,"context_line":"    for port_log in ports_log:"},{"line_number":153,"context_line":"        log_dict[\u0027ports_log\u0027].append(_get_port_log_dict("},{"line_number":154,"context_line":"            context, port_log, sg_log))"},{"line_number":155,"context_line":"    log_dict[\u0027event\u0027] \u003d sg_log[\u0027event\u0027]"},{"line_number":156,"context_line":"    log_dict[\u0027project_id\u0027] \u003d sg_log[\u0027project_id\u0027]"},{"line_number":157,"context_line":"    return log_dict"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_logs_bound_port(context, port_id):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_659207f9","line":157,"range":{"start_line":149,"start_character":0,"end_line":157,"end_character":19},"updated":"2017-10-11 16:16:08.000000000","message":"Consider:\n\n  return {\n     \u0027id\u0027: sg_log[\u0027id\u0027],\n     \u0027ports_log\u0027: [_get_port_log_dict(context, port_log, sg_log)\n                   for port_log in ports_log],\n     \u0027event\u0027 \u003d sg_log[\u0027event\u0027],\n     \u0027project_id\u0027 \u003d sg_log[\u0027project_id\u0027],\n }","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"def _make_log_dict(context, sg_log, ports_log):"},{"line_number":149,"context_line":"    log_dict \u003d {}"},{"line_number":150,"context_line":"    log_dict[\u0027id\u0027] \u003d sg_log[\u0027id\u0027]"},{"line_number":151,"context_line":"    log_dict[\u0027ports_log\u0027] \u003d []"},{"line_number":152,"context_line":"    for port_log in ports_log:"},{"line_number":153,"context_line":"        log_dict[\u0027ports_log\u0027].append(_get_port_log_dict("},{"line_number":154,"context_line":"            context, port_log, sg_log))"},{"line_number":155,"context_line":"    log_dict[\u0027event\u0027] \u003d sg_log[\u0027event\u0027]"},{"line_number":156,"context_line":"    log_dict[\u0027project_id\u0027] \u003d sg_log[\u0027project_id\u0027]"},{"line_number":157,"context_line":"    return log_dict"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def get_logs_bound_port(context, port_id):"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_28ef0cb1","line":157,"range":{"start_line":149,"start_character":0,"end_line":157,"end_character":19},"in_reply_to":"5f4e5783_659207f9","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    project_id \u003d port[\u0027project_id\u0027]"},{"line_number":166,"context_line":"    logs \u003d log_object.Log.get_objects(context, project_id\u003dproject_id)"},{"line_number":167,"context_line":"    for log in logs:"},{"line_number":168,"context_line":"        if not log.enabled:"},{"line_number":169,"context_line":"            continue"},{"line_number":170,"context_line":"        if log.resource_id is not None:"},{"line_number":171,"context_line":"            if log.resource_id in port.security_group_ids:"},{"line_number":172,"context_line":"                log_resources.append(log)"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_4d81714a","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":20},"updated":"2017-10-11 16:16:08.000000000","message":"Can we limit only the get_objects() above to return only enabled log objects?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    project_id \u003d port[\u0027project_id\u0027]"},{"line_number":166,"context_line":"    logs \u003d log_object.Log.get_objects(context, project_id\u003dproject_id)"},{"line_number":167,"context_line":"    for log in logs:"},{"line_number":168,"context_line":"        if not log.enabled:"},{"line_number":169,"context_line":"            continue"},{"line_number":170,"context_line":"        if log.resource_id is not None:"},{"line_number":171,"context_line":"            if log.resource_id in port.security_group_ids:"},{"line_number":172,"context_line":"                log_resources.append(log)"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_683aa434","line":169,"range":{"start_line":168,"start_character":0,"end_line":169,"end_character":20},"in_reply_to":"5f4e5783_4d81714a","updated":"2017-10-13 08:13:57.000000000","message":"Thanks. Done.","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    for log in logs:"},{"line_number":168,"context_line":"        if not log.enabled:"},{"line_number":169,"context_line":"            continue"},{"line_number":170,"context_line":"        if log.resource_id is not None:"},{"line_number":171,"context_line":"            if log.resource_id in port.security_group_ids:"},{"line_number":172,"context_line":"                log_resources.append(log)"},{"line_number":173,"context_line":"        elif log.target_id \u003d\u003d port.id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_4d12910b","line":170,"range":{"start_line":170,"start_character":11,"end_line":170,"end_character":38},"updated":"2017-10-11 16:16:08.000000000","message":"nit: not log.resource_id\n\nI see in the function below you have it correctly idiomatic :)","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    for log in logs:"},{"line_number":168,"context_line":"        if not log.enabled:"},{"line_number":169,"context_line":"            continue"},{"line_number":170,"context_line":"        if log.resource_id is not None:"},{"line_number":171,"context_line":"            if log.resource_id in port.security_group_ids:"},{"line_number":172,"context_line":"                log_resources.append(log)"},{"line_number":173,"context_line":"        elif log.target_id \u003d\u003d port.id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_e82e94f8","line":170,"range":{"start_line":170,"start_character":11,"end_line":170,"end_character":38},"in_reply_to":"5f4e5783_4d12910b","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        context, project_id\u003dproject_id)"},{"line_number":186,"context_line":"    log_resources \u003d []"},{"line_number":187,"context_line":"    for log_obj in log_objs:"},{"line_number":188,"context_line":"        if not log_obj.enabled:"},{"line_number":189,"context_line":"            continue"},{"line_number":190,"context_line":"        if log_obj.resource_id \u003d\u003d sg_id:"},{"line_number":191,"context_line":"            log_resources.append(log_obj)"},{"line_number":192,"context_line":"        elif log_obj.target_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_4d5df1e7","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":20},"updated":"2017-10-11 16:16:08.000000000","message":"ditto","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        context, project_id\u003dproject_id)"},{"line_number":186,"context_line":"    log_resources \u003d []"},{"line_number":187,"context_line":"    for log_obj in log_objs:"},{"line_number":188,"context_line":"        if not log_obj.enabled:"},{"line_number":189,"context_line":"            continue"},{"line_number":190,"context_line":"        if log_obj.resource_id \u003d\u003d sg_id:"},{"line_number":191,"context_line":"            log_resources.append(log_obj)"},{"line_number":192,"context_line":"        elif log_obj.target_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_484928ce","line":189,"range":{"start_line":188,"start_character":0,"end_line":189,"end_character":20},"in_reply_to":"5f4e5783_4d5df1e7","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    return log_resources"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def get_sg_log_info_cb(context, **kwargs):"},{"line_number":203,"context_line":"    \"\"\"Return a list of security groups log info"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    This method provides a list of security groups log info related to"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_0dcb7972","line":202,"range":{"start_line":202,"start_character":32,"end_line":202,"end_character":40},"updated":"2017-10-11 16:16:08.000000000","message":"Should we make this more strict by\n\n port_id\u003dNone, log_resources\u003dNone)","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    return log_resources"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def get_sg_log_info_cb(context, **kwargs):"},{"line_number":203,"context_line":"    \"\"\"Return a list of security groups log info"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    This method provides a list of security groups log info related to"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_2844acb6","line":202,"range":{"start_line":202,"start_character":32,"end_line":202,"end_character":40},"in_reply_to":"5f4e5783_0dcb7972","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            logs_info.append(_make_log_dict(context, sg_log, [port_id]))"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    for sg_log in log_resources:"},{"line_number":237,"context_line":"        ports \u003d _get_ports_attached_to_logging(context, sg_log)"},{"line_number":238,"context_line":"        logs_info.append(_make_log_dict(context, sg_log, ports))"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    return logs_info"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_6db2ede8","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":13},"updated":"2017-10-11 16:16:08.000000000","message":"port_ids","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            logs_info.append(_make_log_dict(context, sg_log, [port_id]))"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    for sg_log in log_resources:"},{"line_number":237,"context_line":"        ports \u003d _get_ports_attached_to_logging(context, sg_log)"},{"line_number":238,"context_line":"        logs_info.append(_make_log_dict(context, sg_log, ports))"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    return logs_info"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_a811bcae","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":13},"in_reply_to":"5f4e5783_6db2ede8","updated":"2017-10-13 08:13:57.000000000","message":"Done","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7dfe6c8b7a71715510029a0d59cfc3e531005bdd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                sg_db.SecurityGroup.tenant_id \u003d\u003d tenant_id).all()"},{"line_number":51,"context_line":"            return {port for (port,) in ports}"},{"line_number":52,"context_line":"    except orm_exc.NoResultFound:"},{"line_number":53,"context_line":"        return []"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def _get_sgs_attached_to_port(context, port_id):"}],"source_content_type":"text/x-python","patch_set":40,"id":"5f4e5783_841fc959","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":17},"updated":"2017-10-17 20:24:38.000000000","message":"for consistency, should we return set(), since in L51 you return a set?","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"24852f013f648ec5d767cd00be3935c37bb559a2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                sg_db.SecurityGroup.tenant_id \u003d\u003d tenant_id).all()"},{"line_number":51,"context_line":"            return {port for (port,) in ports}"},{"line_number":52,"context_line":"    except orm_exc.NoResultFound:"},{"line_number":53,"context_line":"        return []"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def _get_sgs_attached_to_port(context, port_id):"}],"source_content_type":"text/x-python","patch_set":40,"id":"3f4b6375_2d9e7507","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":17},"in_reply_to":"5f4e5783_841fc959","updated":"2017-10-18 08:11:42.000000000","message":"Done","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7dfe6c8b7a71715510029a0d59cfc3e531005bdd","unresolved":false,"context_lines":[{"line_number":135,"context_line":"def _get_sg_rules(context, sg_log, port_id):"},{"line_number":136,"context_line":"    \"\"\"Return a list of sg_rules log for a port being logged\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    sg_ids \u003d _get_sg_ids_log_for_port(context, sg_log\u003dsg_log, port_id\u003dport_id)"},{"line_number":139,"context_line":"    if not sg_ids:"},{"line_number":140,"context_line":"        return []"},{"line_number":141,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"}],"source_content_type":"text/x-python","patch_set":40,"id":"5f4e5783_a9373eff","line":138,"range":{"start_line":138,"start_character":62,"end_line":138,"end_character":70},"updated":"2017-10-17 20:24:38.000000000","message":"Not needed","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7dfe6c8b7a71715510029a0d59cfc3e531005bdd","unresolved":false,"context_lines":[{"line_number":135,"context_line":"def _get_sg_rules(context, sg_log, port_id):"},{"line_number":136,"context_line":"    \"\"\"Return a list of sg_rules log for a port being logged\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    sg_ids \u003d _get_sg_ids_log_for_port(context, sg_log\u003dsg_log, port_id\u003dport_id)"},{"line_number":139,"context_line":"    if not sg_ids:"},{"line_number":140,"context_line":"        return []"},{"line_number":141,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"}],"source_content_type":"text/x-python","patch_set":40,"id":"5f4e5783_c9327a10","line":138,"range":{"start_line":138,"start_character":47,"end_line":138,"end_character":54},"updated":"2017-10-17 20:24:38.000000000","message":"Not needed","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"24852f013f648ec5d767cd00be3935c37bb559a2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"def _get_sg_rules(context, sg_log, port_id):"},{"line_number":136,"context_line":"    \"\"\"Return a list of sg_rules log for a port being logged\"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    sg_ids \u003d _get_sg_ids_log_for_port(context, sg_log\u003dsg_log, port_id\u003dport_id)"},{"line_number":139,"context_line":"    if not sg_ids:"},{"line_number":140,"context_line":"        return []"},{"line_number":141,"context_line":"    filters \u003d {\u0027security_group_id\u0027: sg_ids}"}],"source_content_type":"text/x-python","patch_set":40,"id":"3f4b6375_0da3b951","line":138,"range":{"start_line":138,"start_character":47,"end_line":138,"end_character":54},"in_reply_to":"5f4e5783_c9327a10","updated":"2017-10-18 08:11:42.000000000","message":"Done","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7dfe6c8b7a71715510029a0d59cfc3e531005bdd","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    return logs_info"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def get_sg_log_info_cb(context, port_id\u003dNone, log_resources\u003dNone):"},{"line_number":219,"context_line":"    \"\"\"Return a list of security groups log info"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    This method provides a list of security groups log info related to"}],"source_content_type":"text/x-python","patch_set":40,"id":"5f4e5783_d93fc884","line":218,"range":{"start_line":218,"start_character":20,"end_line":218,"end_character":22},"updated":"2017-10-17 20:24:38.000000000","message":"is cb for callback? I don\u0027t think we need it. This is not a callback. It is a DB access method that happens to be called by a callback","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"24852f013f648ec5d767cd00be3935c37bb559a2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    return logs_info"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def get_sg_log_info_cb(context, port_id\u003dNone, log_resources\u003dNone):"},{"line_number":219,"context_line":"    \"\"\"Return a list of security groups log info"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    This method provides a list of security groups log info related to"}],"source_content_type":"text/x-python","patch_set":40,"id":"3f4b6375_cd8481b4","line":218,"range":{"start_line":218,"start_character":20,"end_line":218,"end_character":22},"in_reply_to":"5f4e5783_d93fc884","updated":"2017-10-18 08:11:42.000000000","message":"Done! Thanks.","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bbe335a50d132dedaf8a34a342d6208ab2e6d31e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from sqlalchemy.orm import exc as orm_exc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent import firewall"},{"line_number":20,"context_line":"from neutron.db import api as db_api"},{"line_number":21,"context_line":"from neutron.db.models import securitygroup as sg_db"},{"line_number":22,"context_line":"from neutron.objects.logapi import logging_resource as log_object"}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_e8c29284","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":34},"updated":"2017-10-27 14:44:54.000000000","message":"We should put the DIRECTION_IP_PREFIX into some common module to avoid importing agent modules on server-side code.","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"79bf7c8cc9b750b01c1c066ac986ec28b085d797","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from sqlalchemy.orm import exc as orm_exc"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent import firewall"},{"line_number":20,"context_line":"from neutron.db import api as db_api"},{"line_number":21,"context_line":"from neutron.db.models import securitygroup as sg_db"},{"line_number":22,"context_line":"from neutron.objects.logapi import logging_resource as log_object"}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_964ab852","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":34},"in_reply_to":"3f4b6375_e8c29284","updated":"2017-11-01 06:29:22.000000000","message":"Done","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bbe335a50d132dedaf8a34a342d6208ab2e6d31e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                sg_db.SecurityGroupPortBinding.port_id).join("},{"line_number":49,"context_line":"                sg_db.SecurityGroup, sg_db.SecurityGroup.id \u003d\u003d sg_id).filter("},{"line_number":50,"context_line":"                sg_db.SecurityGroup.tenant_id \u003d\u003d tenant_id).all()"},{"line_number":51,"context_line":"            return {port for (port,) in ports}"},{"line_number":52,"context_line":"    except orm_exc.NoResultFound:"},{"line_number":53,"context_line":"        return set()"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_c85236de","line":51,"updated":"2017-10-27 14:44:54.000000000","message":"No-action-required: I still find this line confusing :)","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"79bf7c8cc9b750b01c1c066ac986ec28b085d797","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                sg_db.SecurityGroupPortBinding.port_id).join("},{"line_number":49,"context_line":"                sg_db.SecurityGroup, sg_db.SecurityGroup.id \u003d\u003d sg_id).filter("},{"line_number":50,"context_line":"                sg_db.SecurityGroup.tenant_id \u003d\u003d tenant_id).all()"},{"line_number":51,"context_line":"            return {port for (port,) in ports}"},{"line_number":52,"context_line":"    except orm_exc.NoResultFound:"},{"line_number":53,"context_line":"        return set()"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_aa49ceb7","line":51,"in_reply_to":"3f4b6375_c85236de","updated":"2017-11-01 06:29:22.000000000","message":"From my understanding: a port can be associated to multiple security groups. So SecuirtyGroupPortBinding table may have multiple records of the port. In this case, we collect all ports in a tenant, so maybe there are multiple records of each port. So I\u0027d like to keep this to return a list of unique ports.","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bbe335a50d132dedaf8a34a342d6208ab2e6d31e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # list of validated ports\u0027s being logged"},{"line_number":83,"context_line":"    validated_port_ids \u003d []"},{"line_number":84,"context_line":"    for port_id in port_ids:"},{"line_number":85,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"},{"line_number":86,"context_line":"        if validators.validate_log_type_for_port(\u0027security_group\u0027, port):"},{"line_number":87,"context_line":"            validated_port_ids.append(port_id)"},{"line_number":88,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_03802ff4","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":64},"updated":"2017-10-27 14:44:54.000000000","message":"So if SQLAlchemy supports lists, can we do here the same as what\u0027s done on L144?\n\n ports \u003d port_objects.Port.get_objects(context, id\u003dport_ids)\n for port in ports:\n     if validate ...","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"79bf7c8cc9b750b01c1c066ac986ec28b085d797","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # list of validated ports\u0027s being logged"},{"line_number":83,"context_line":"    validated_port_ids \u003d []"},{"line_number":84,"context_line":"    for port_id in port_ids:"},{"line_number":85,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"},{"line_number":86,"context_line":"        if validators.validate_log_type_for_port(\u0027security_group\u0027, port):"},{"line_number":87,"context_line":"            validated_port_ids.append(port_id)"},{"line_number":88,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_2a027e70","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":64},"in_reply_to":"3f4b6375_03802ff4","updated":"2017-11-01 06:29:22.000000000","message":"Done","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bbe335a50d132dedaf8a34a342d6208ab2e6d31e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    project_id \u003d port[\u0027project_id\u0027]"},{"line_number":171,"context_line":"    logs \u003d log_object.Log.get_objects("},{"line_number":172,"context_line":"        context, project_id\u003dproject_id, enabled\u003dTrue)"},{"line_number":173,"context_line":"    for log in logs:"},{"line_number":174,"context_line":"        if log.resource_id:"},{"line_number":175,"context_line":"            if log.resource_id in port.security_group_ids:"},{"line_number":176,"context_line":"                log_resources.append(log)"},{"line_number":177,"context_line":"        elif log.target_id \u003d\u003d port.id:"},{"line_number":178,"context_line":"            log_resources.append(log)"},{"line_number":179,"context_line":"        elif not log.target_id and not log.resource_id:"},{"line_number":180,"context_line":"            log_resources.append(log)"},{"line_number":181,"context_line":"    return log_resources"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"def get_logs_bound_sg(context, sg_id):"}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_23e8cbb0","line":181,"range":{"start_line":173,"start_character":0,"end_line":181,"end_character":24},"updated":"2017-10-27 14:44:54.000000000","message":"This could be a list comprehension:\n\n is_bound \u003d lambda log: (log.resource_id in port.security_group_ids\n                         or log.target_id \u003d\u003d port.id\n                         or (not log.target_id and not log.resource_id))\n return [log for log in logs if is_bound(log)]","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"79bf7c8cc9b750b01c1c066ac986ec28b085d797","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    project_id \u003d port[\u0027project_id\u0027]"},{"line_number":171,"context_line":"    logs \u003d log_object.Log.get_objects("},{"line_number":172,"context_line":"        context, project_id\u003dproject_id, enabled\u003dTrue)"},{"line_number":173,"context_line":"    for log in logs:"},{"line_number":174,"context_line":"        if log.resource_id:"},{"line_number":175,"context_line":"            if log.resource_id in port.security_group_ids:"},{"line_number":176,"context_line":"                log_resources.append(log)"},{"line_number":177,"context_line":"        elif log.target_id \u003d\u003d port.id:"},{"line_number":178,"context_line":"            log_resources.append(log)"},{"line_number":179,"context_line":"        elif not log.target_id and not log.resource_id:"},{"line_number":180,"context_line":"            log_resources.append(log)"},{"line_number":181,"context_line":"    return log_resources"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"def get_logs_bound_sg(context, sg_id):"}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_0af9027f","line":181,"range":{"start_line":173,"start_character":0,"end_line":181,"end_character":24},"in_reply_to":"3f4b6375_23e8cbb0","updated":"2017-11-01 06:29:22.000000000","message":"Done","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"}],"neutron/services/logapi/drivers/base.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\"Delete a log_obj invocation."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":127,"context_line":"        to update the backend where necessary with a specific log object."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param context: current running context information"},{"line_number":130,"context_line":"        :param log_obj: a log_object being deleted"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_c31ff105","line":127,"range":{"start_line":127,"start_character":11,"end_line":127,"end_character":17},"updated":"2017-08-15 19:44:16.000000000","message":"This has to be delete","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\"Delete a log_obj invocation."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        This method can be implemented by the specific driver subclass"},{"line_number":127,"context_line":"        to update the backend where necessary with a specific log object."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param context: current running context information"},{"line_number":130,"context_line":"        :param log_obj: a log_object being deleted"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_c17117aa","line":127,"range":{"start_line":127,"start_character":11,"end_line":127,"end_character":17},"in_reply_to":"9f436f4f_c31ff105","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def resource_update(self, context, log_objs):"},{"line_number":145,"context_line":"        \"\"\"Tell to agent when resource related to log_objects,"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        which are updated."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param context: current running context information"},{"line_number":150,"context_line":"        :param log_objs: a list of log_objects, which resources related to"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_03161956","line":147,"range":{"start_line":145,"start_character":11,"end_line":147,"end_character":26},"updated":"2017-08-15 19:44:16.000000000","message":"Tell the agent when resources related to log objects are being updated\n\nAlso, we don\u0027t need blank L146","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def resource_update(self, context, log_objs):"},{"line_number":145,"context_line":"        \"\"\"Tell to agent when resource related to log_objects,"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        which are updated."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param context: current running context information"},{"line_number":150,"context_line":"        :param log_objs: a list of log_objects, which resources related to"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_a16cd3cd","line":147,"range":{"start_line":145,"start_character":11,"end_line":147,"end_character":26},"in_reply_to":"9f436f4f_03161956","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        which are updated."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param context: current running context information"},{"line_number":150,"context_line":"        :param log_objs: a list of log_objects, which resources related to"},{"line_number":151,"context_line":"                        them are updated."},{"line_number":152,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_16089525","line":151,"range":{"start_line":150,"start_character":48,"end_line":151,"end_character":41},"updated":"2017-08-15 19:44:16.000000000","message":"whose related resources are being updated\n\nAlso, this line is under indented by one character","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        which are updated."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param context: current running context information"},{"line_number":150,"context_line":"        :param log_objs: a list of log_objects, which resources related to"},{"line_number":151,"context_line":"                        them are updated."},{"line_number":152,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_61626bda","line":151,"range":{"start_line":150,"start_character":48,"end_line":151,"end_character":41},"in_reply_to":"9f436f4f_16089525","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f8c575b77f036af071ce4967850fc6e8a285a5b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":79,"context_line":"        return supported"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def create_log(self, context, log_obj):"},{"line_number":82,"context_line":"        \"\"\"Create a log_obj invocation."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        This method can be implemented by the specific driver subclass"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_d08dfad3","line":81,"updated":"2017-10-11 16:16:08.000000000","message":"Should be all methods abstract methods?","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b9a7ea66dcfa2b17cd819de9dd8a3b6242391353","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":79,"context_line":"        return supported"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def create_log(self, context, log_obj):"},{"line_number":82,"context_line":"        \"\"\"Create a log_obj invocation."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        This method can be implemented by the specific driver subclass"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f4e5783_abcf76ae","line":81,"in_reply_to":"5f4e5783_d08dfad3","updated":"2017-10-13 08:13:57.000000000","message":"I think we shouldn\u0027t enforce that to a driver. If the driver prefers to use existing RPC service, that mean \u0027self.require_rpc\u003dTrue\u0027. So I\u0027d like to keep current version. Do you think so? :)","commit_id":"9afc7d08574355d466cc5cbfaa53fedbbbd086a4"}],"neutron/services/logapi/drivers/manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"75ebd26675be263c94e0b72757fec2e70e68468a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if exc_list:"},{"line_number":90,"context_line":"            raise exceptions.DriverCallError(exc_list\u003dexc_list)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if self.rpc_required:"},{"line_number":93,"context_line":"            context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":94,"context_line":"            log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":95,"context_line":"            if method_name \u003d\u003d log_const.CREATE_LOG:"},{"line_number":96,"context_line":"                self.logging_rpc.create_log(context, log_obj)"},{"line_number":97,"context_line":"            elif method_name \u003d\u003d log_const.UPDATE_LOG:"},{"line_number":98,"context_line":"                self.logging_rpc.update_log(context, log_obj)"},{"line_number":99,"context_line":"            elif method_name \u003d\u003d log_const.DELETE_LOG:"},{"line_number":100,"context_line":"                self.logging_rpc.delete_log(context, log_obj)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @registry.receives(resources.PORT,"},{"line_number":103,"context_line":"                       [events.PRECOMMIT_CREATE, events.PRECOMMIT_UPDATE])"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_c86a8c7f","line":100,"range":{"start_line":92,"start_character":0,"end_line":100,"end_character":61},"updated":"2017-07-27 11:14:21.000000000","message":"only this part is rpc related, right?\n\ni\u0027d suggest to separate driver api stuff and rpc stuff into separate patches.\nor at least tweak the commit message.","commit_id":"ad4bbdd152cbd7c739ac50e277e05aa945121842"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3e56cbc6332f73bcb3ae524429b2e25fd3b77d5c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if exc_list:"},{"line_number":90,"context_line":"            raise exceptions.DriverCallError(exc_list\u003dexc_list)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if self.rpc_required:"},{"line_number":93,"context_line":"            context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":94,"context_line":"            log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":95,"context_line":"            if method_name \u003d\u003d log_const.CREATE_LOG:"},{"line_number":96,"context_line":"                self.logging_rpc.create_log(context, log_obj)"},{"line_number":97,"context_line":"            elif method_name \u003d\u003d log_const.UPDATE_LOG:"},{"line_number":98,"context_line":"                self.logging_rpc.update_log(context, log_obj)"},{"line_number":99,"context_line":"            elif method_name \u003d\u003d log_const.DELETE_LOG:"},{"line_number":100,"context_line":"                self.logging_rpc.delete_log(context, log_obj)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @registry.receives(resources.PORT,"},{"line_number":103,"context_line":"                       [events.PRECOMMIT_CREATE, events.PRECOMMIT_UPDATE])"}],"source_content_type":"text/x-python","patch_set":20,"id":"df3967d1_b6d5f2bb","line":100,"range":{"start_line":92,"start_character":0,"end_line":100,"end_character":61},"in_reply_to":"ff346bd7_c86a8c7f","updated":"2017-07-31 09:38:51.000000000","message":"you\u0027re right. will update commit message.","commit_id":"ad4bbdd152cbd7c739ac50e277e05aa945121842"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"75ebd26675be263c94e0b72757fec2e70e68468a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                need_updates.append(log_obj)"},{"line_number":144,"context_line":"        if need_updates:"},{"line_number":145,"context_line":"            self.call("},{"line_number":146,"context_line":"                log_const.UPDATE_LOG, context, need_updates)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_a8fce8b4","line":146,"range":{"start_line":146,"start_character":47,"end_line":146,"end_character":59},"updated":"2017-07-27 11:14:21.000000000","message":"it seems UPDATE_LOG sometimes take an object and sometimes take a list of objects. is it intentional? it\u0027s confusing.\n\nalso, these log objects themselves are not updated here.\nusing the same method (UPDATE_LOG) as update_log() and here seems confusing.\n\nhow do you think?","commit_id":"ad4bbdd152cbd7c739ac50e277e05aa945121842"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3e56cbc6332f73bcb3ae524429b2e25fd3b77d5c","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                need_updates.append(log_obj)"},{"line_number":144,"context_line":"        if need_updates:"},{"line_number":145,"context_line":"            self.call("},{"line_number":146,"context_line":"                log_const.UPDATE_LOG, context, need_updates)"}],"source_content_type":"text/x-python","patch_set":20,"id":"df3967d1_76ae6a2f","line":146,"range":{"start_line":146,"start_character":47,"end_line":146,"end_character":59},"in_reply_to":"ff346bd7_a8fce8b4","updated":"2017-07-31 09:38:51.000000000","message":"I agree! So I have changed it to \u0027resource_update method. This method will tell to agent when resources related log_objecs, which are updated.","commit_id":"ad4bbdd152cbd7c739ac50e277e05aa945121842"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    msg \u003d ((\"Logging type %(log_type)s is not supported on\""},{"line_number":123,"context_line":"                            \"port %(port_id)s.\") %"},{"line_number":124,"context_line":"                           {\u0027log_type\u0027: log_type, \u0027port_id\u0027: port_id})"},{"line_number":125,"context_line":"                    LOG.warning(msg)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"},{"line_number":128,"context_line":"                       [events.AFTER_CREATE, events.AFTER_DELETE])"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_6a093294","line":125,"updated":"2017-08-15 19:44:16.000000000","message":"So the purpose of this method is just to log a warning. Why do we do this?","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3620a0b7f3c0dbf8b26e9e4dfd66b4f9790aca1e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    msg \u003d ((\"Logging type %(log_type)s is not supported on\""},{"line_number":123,"context_line":"                            \"port %(port_id)s.\") %"},{"line_number":124,"context_line":"                           {\u0027log_type\u0027: log_type, \u0027port_id\u0027: port_id})"},{"line_number":125,"context_line":"                    LOG.warning(msg)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"},{"line_number":128,"context_line":"                       [events.AFTER_CREATE, events.AFTER_DELETE])"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_e1f1bb02","line":125,"in_reply_to":"9f436f4f_6a093294","updated":"2017-08-16 09:11:45.000000000","message":"I want log a warning message at here to help operators can aware logging will be not supported on this port. It will be useful in system has multiple mechanism drivers. Does that make sense?","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"11d774ce9c4f4c5e36fa55b0a2fcd4313cefedd4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    msg \u003d ((\"Logging type %(log_type)s is not supported on\""},{"line_number":123,"context_line":"                            \"port %(port_id)s.\") %"},{"line_number":124,"context_line":"                           {\u0027log_type\u0027: log_type, \u0027port_id\u0027: port_id})"},{"line_number":125,"context_line":"                    LOG.warning(msg)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"},{"line_number":128,"context_line":"                       [events.AFTER_CREATE, events.AFTER_DELETE])"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f4e5783_48b48d35","line":125,"in_reply_to":"9f436f4f_e1f1bb02","updated":"2017-10-13 04:02:55.000000000","message":"Hi Miguel,\n\nAfter double check, I think checking whether logging types are supported on a port has done by https://review.openstack.org/#/c/468265/34/neutron/services/logapi/common/db_api.py@87. So I\u0027d like to remove it. Do you think so?","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7dfe6c8b7a71715510029a0d59cfc3e531005bdd","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        else:"},{"line_number":112,"context_line":"            sg_id \u003d kwargs.get(\u0027security_group_id\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        need_updates \u003d db_api.get_logs_bound_sg(context, sg_id)"},{"line_number":115,"context_line":"        if need_updates:"},{"line_number":116,"context_line":"            self.call("},{"line_number":117,"context_line":"                log_const.RESOURCE_UPDATE, context, need_updates)"}],"source_content_type":"text/x-python","patch_set":40,"id":"5f4e5783_1ec1c6e5","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":20},"updated":"2017-10-17 20:24:38.000000000","message":"get_logs_bound_sg returns log resources. why not log_resources?","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"24852f013f648ec5d767cd00be3935c37bb559a2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        else:"},{"line_number":112,"context_line":"            sg_id \u003d kwargs.get(\u0027security_group_id\u0027)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        need_updates \u003d db_api.get_logs_bound_sg(context, sg_id)"},{"line_number":115,"context_line":"        if need_updates:"},{"line_number":116,"context_line":"            self.call("},{"line_number":117,"context_line":"                log_const.RESOURCE_UPDATE, context, need_updates)"}],"source_content_type":"text/x-python","patch_set":40,"id":"3f4b6375_ad9145f4","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":20},"in_reply_to":"5f4e5783_1ec1c6e5","updated":"2017-10-18 08:11:42.000000000","message":"Done! Thanks.","commit_id":"5bbcc66e4b5f4a8b62633f75310379dc473e43f9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            raise exceptions.DriverCallError(exc_list\u003dexc_list)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if self.rpc_required:"},{"line_number":87,"context_line":"            context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":88,"context_line":"            log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":89,"context_line":"            if method_name \u003d\u003d log_const.CREATE_LOG:"},{"line_number":90,"context_line":"                self.logging_rpc.create_log(context, log_obj)"},{"line_number":91,"context_line":"            elif method_name \u003d\u003d log_const.UPDATE_LOG:"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_ef2c8603","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":54},"updated":"2017-11-24 13:55:57.000000000","message":"I don\u0027t think this is generic enough.","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if self.rpc_required:"},{"line_number":87,"context_line":"            context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":88,"context_line":"            log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":89,"context_line":"            if method_name \u003d\u003d log_const.CREATE_LOG:"},{"line_number":90,"context_line":"                self.logging_rpc.create_log(context, log_obj)"},{"line_number":91,"context_line":"            elif method_name \u003d\u003d log_const.UPDATE_LOG:"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_2ff10e96","line":88,"updated":"2017-11-24 13:55:57.000000000","message":"If in any case None is passed to log_obj, you\u0027ll get an ugly IndexError here that would be sort of hard to debug.","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"94fd99bdc556943b554e2603566a96623ff45c2d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            raise exceptions.DriverCallError(exc_list\u003dexc_list)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if self.rpc_required:"},{"line_number":87,"context_line":"            context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":88,"context_line":"            log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":89,"context_line":"            if method_name \u003d\u003d log_const.CREATE_LOG:"},{"line_number":90,"context_line":"                self.logging_rpc.create_log(context, log_obj)"},{"line_number":91,"context_line":"            elif method_name \u003d\u003d log_const.UPDATE_LOG:"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_b48ebc76","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":54},"in_reply_to":"ff82abbf_ef2c8603","updated":"2017-11-27 09:17:09.000000000","message":"Yes. I think it should be added a try...except. Do you think so?","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if self.rpc_required:"},{"line_number":87,"context_line":"            context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":88,"context_line":"            log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":89,"context_line":"            if method_name \u003d\u003d log_const.CREATE_LOG:"},{"line_number":90,"context_line":"                self.logging_rpc.create_log(context, log_obj)"},{"line_number":91,"context_line":"            elif method_name \u003d\u003d log_const.UPDATE_LOG:"},{"line_number":92,"context_line":"                self.logging_rpc.update_log(context, log_obj)"},{"line_number":93,"context_line":"            elif method_name \u003d\u003d log_const.DELETE_LOG:"},{"line_number":94,"context_line":"                self.logging_rpc.delete_log(context, log_obj)"},{"line_number":95,"context_line":"            elif method_name \u003d\u003d log_const.RESOURCE_UPDATE:"},{"line_number":96,"context_line":"                self.logging_rpc.resource_update(context, log_obj)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"},{"line_number":99,"context_line":"                       [events.AFTER_CREATE, events.AFTER_DELETE])"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_6ffb9678","line":96,"range":{"start_line":89,"start_character":0,"end_line":96,"end_character":66},"updated":"2017-11-24 13:55:57.000000000","message":"Can it be generalized as on L75?\n\n try:\n     method \u003d getattr(self.logging_rpc, method_name)\n except AttributeError:\n     LOG.error(\"Method %s is not implemented in logging RPC\", method_name)\n method(context, log_obj)","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"94fd99bdc556943b554e2603566a96623ff45c2d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if self.rpc_required:"},{"line_number":87,"context_line":"            context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":88,"context_line":"            log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":89,"context_line":"            if method_name \u003d\u003d log_const.CREATE_LOG:"},{"line_number":90,"context_line":"                self.logging_rpc.create_log(context, log_obj)"},{"line_number":91,"context_line":"            elif method_name \u003d\u003d log_const.UPDATE_LOG:"},{"line_number":92,"context_line":"                self.logging_rpc.update_log(context, log_obj)"},{"line_number":93,"context_line":"            elif method_name \u003d\u003d log_const.DELETE_LOG:"},{"line_number":94,"context_line":"                self.logging_rpc.delete_log(context, log_obj)"},{"line_number":95,"context_line":"            elif method_name \u003d\u003d log_const.RESOURCE_UPDATE:"},{"line_number":96,"context_line":"                self.logging_rpc.resource_update(context, log_obj)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"},{"line_number":99,"context_line":"                       [events.AFTER_CREATE, events.AFTER_DELETE])"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_d48b4065","line":96,"range":{"start_line":89,"start_character":0,"end_line":96,"end_character":66},"in_reply_to":"ff82abbf_6ffb9678","updated":"2017-11-27 09:17:09.000000000","message":"Thanks for your suggestion. Done!","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ec01a8dcc5b3993104ae4748a4c51e5a1d642610","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":89,"context_line":"                log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":90,"context_line":"            except IndexError as exc:"},{"line_number":91,"context_line":"                LOG.error(\"Argument error %s\", exc)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            try:"},{"line_number":94,"context_line":"                rpc_method \u003d getattr(self.logging_rpc, method_name)"}],"source_content_type":"text/x-python","patch_set":49,"id":"ff82abbf_ca829b00","line":91,"updated":"2017-11-28 09:32:25.000000000","message":"The exc would likely contain something like \"list index out of range\" which is not particularly useful for debugging. Also note that log_obj is not be defined in case of IndexError and will be still passed on L98, which will cause another error. Maybe we could make a helper function to extract parameters:\n\n def _get_param(args, kwargs, name, index):\n     try:\n          return kwargs[name]\n     except KeyError:\n          try:\n              return args[index]\n          except IndexError:\n              raise LogapiDriverException(\"Missing parameter %s\", name)\n\n ...\n\n context \u003d _get_param(args, kwargs, \u0027context\u0027, index\u003d0)\n log_obj \u003d _get_param(args, kwargs, \u0027log_obj\u0027, index\u003d1)","commit_id":"6617b0c98456f6e0c813f20d03df4af0d660ea61"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"a459181e9d5adc17ffa56a6ef32a7a02e1a44320","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                context \u003d kwargs.get(\u0027context\u0027) or args[0]"},{"line_number":89,"context_line":"                log_obj \u003d kwargs.get(\u0027log_obj\u0027) or args[1]"},{"line_number":90,"context_line":"            except IndexError as exc:"},{"line_number":91,"context_line":"                LOG.error(\"Argument error %s\", exc)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            try:"},{"line_number":94,"context_line":"                rpc_method \u003d getattr(self.logging_rpc, method_name)"}],"source_content_type":"text/x-python","patch_set":49,"id":"ff82abbf_f05d1079","line":91,"in_reply_to":"ff82abbf_ca829b00","updated":"2017-11-28 11:01:08.000000000","message":"Thanks for your suggestion. Done","commit_id":"6617b0c98456f6e0c813f20d03df4af0d660ea61"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cf6c780ff317765847e41e2ba91bc4b9d43cea38","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _get_param(args, kwargs, name, index):"},{"line_number":31,"context_line":"    try:"},{"line_number":32,"context_line":"        return kwargs[name]"},{"line_number":33,"context_line":"    except KeyError:"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_f3ebda74","line":30,"updated":"2017-11-28 11:43:45.000000000","message":"Would be good to cover this with UT to be on safe side but it can be done as a followup.","commit_id":"75ea8180b3c7eb2ce7f9b089f72cacfd6a03f4c3"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"159c6e386dfd7bc0a5ed331f3e551e86420175f3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _get_param(args, kwargs, name, index):"},{"line_number":31,"context_line":"    try:"},{"line_number":32,"context_line":"        return kwargs[name]"},{"line_number":33,"context_line":"    except KeyError:"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_0c4e3f37","line":30,"in_reply_to":"ff82abbf_f3ebda74","updated":"2017-11-29 09:48:14.000000000","message":"Done","commit_id":"75ea8180b3c7eb2ce7f9b089f72cacfd6a03f4c3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"edc22bde1a624bd2135eca1aa7384b9712ffd364","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            raise exceptions.DriverCallError(exc_list\u003dexc_list)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if self.rpc_required:"},{"line_number":99,"context_line":"            context \u003d _get_param(args, kwargs, \u0027context\u0027, index\u003d0)"},{"line_number":100,"context_line":"            log_obj \u003d _get_param(args, kwargs, \u0027log_obj\u0027, index\u003d1)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_461f4607","line":99,"range":{"start_line":99,"start_character":58,"end_line":99,"end_character":63},"updated":"2017-11-29 08:46:16.000000000","message":"why do we need the index here?","commit_id":"75ea8180b3c7eb2ce7f9b089f72cacfd6a03f4c3"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"159c6e386dfd7bc0a5ed331f3e551e86420175f3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            raise exceptions.DriverCallError(exc_list\u003dexc_list)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if self.rpc_required:"},{"line_number":99,"context_line":"            context \u003d _get_param(args, kwargs, \u0027context\u0027, index\u003d0)"},{"line_number":100,"context_line":"            log_obj \u003d _get_param(args, kwargs, \u0027log_obj\u0027, index\u003d1)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_2c97834a","line":99,"range":{"start_line":99,"start_character":58,"end_line":99,"end_character":63},"in_reply_to":"ff82abbf_461f4607","updated":"2017-11-29 09:48:14.000000000","message":"From my understanding, there are 2 ways to pass parameter to \u0027call\u0027 function as below:\n- call(method_name, context, log_obj)\n- call(method_name, context\u003dcontext, log_obj\u003dlog_obj)\n\nSo I think we need a explicit index here to get \u0027context\u0027 or \u0027log_obj\u0027 exactly for first case.","commit_id":"75ea8180b3c7eb2ce7f9b089f72cacfd6a03f4c3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"edc22bde1a624bd2135eca1aa7384b9712ffd364","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                rpc_method \u003d getattr(self.logging_rpc, method_name)"},{"line_number":104,"context_line":"            except AttributeError:"},{"line_number":105,"context_line":"                LOG.error(\"Method %s is not implemented in logging RPC\","},{"line_number":106,"context_line":"                          method_name)"},{"line_number":107,"context_line":"            rpc_method(context, log_obj)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_66db6a4e","line":106,"updated":"2017-11-29 08:46:16.000000000","message":"you should return here - this would result in an exception below as rpc_method is not defined","commit_id":"75ea8180b3c7eb2ce7f9b089f72cacfd6a03f4c3"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"159c6e386dfd7bc0a5ed331f3e551e86420175f3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                rpc_method \u003d getattr(self.logging_rpc, method_name)"},{"line_number":104,"context_line":"            except AttributeError:"},{"line_number":105,"context_line":"                LOG.error(\"Method %s is not implemented in logging RPC\","},{"line_number":106,"context_line":"                          method_name)"},{"line_number":107,"context_line":"            rpc_method(context, log_obj)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"}],"source_content_type":"text/x-python","patch_set":50,"id":"ff82abbf_2c4d433d","line":106,"in_reply_to":"ff82abbf_66db6a4e","updated":"2017-11-29 09:48:14.000000000","message":"Done","commit_id":"75ea8180b3c7eb2ce7f9b089f72cacfd6a03f4c3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a96c582a3f9804ccb3f91f0c93b7ba1b2016e7d7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            except AttributeError:"},{"line_number":105,"context_line":"                LOG.error(\"Method %s is not implemented in logging RPC\","},{"line_number":106,"context_line":"                          method_name)"},{"line_number":107,"context_line":"                return"},{"line_number":108,"context_line":"            rpc_method(context, log_obj)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @registry.receives(resources.SECURITY_GROUP_RULE,"}],"source_content_type":"text/x-python","patch_set":51,"id":"ff82abbf_603caa2e","line":107,"updated":"2017-11-29 12:48:48.000000000","message":"As a followup, we should add a unittest that validates behavior if logging_rpc doesn\u0027t have the requested method.","commit_id":"a25323152290bc1ec061ecebc24a832ee9ca1277"}],"neutron/services/logapi/logging_plugin.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8019d5dd9b415d0517ec715f0546a343650591dc","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self):"},{"line_number":44,"context_line":"        super(LoggingApiPlugin, self).__init__()"},{"line_number":45,"context_line":"        self.start_rpc_listeners()"},{"line_number":46,"context_line":"        self.logging_rpc \u003d server_rpc.LoggingApiNotification()"},{"line_number":47,"context_line":"        self.driver_manager \u003d driver_mgr.LoggingServiceDriverManager()"},{"line_number":48,"context_line":"        registry.subscribe(self._handle_parent_resources_updated,"},{"line_number":49,"context_line":"                           resources.PORT, events.PRECOMMIT_UPDATE)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_1d9c650d","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":62},"updated":"2017-06-02 06:44:00.000000000","message":"can you separate rpc stuff into a driver or something,\nrather than hardcoding in the plugin?\n\nrpc is not appropriate for many of sdn-like backends.\nmidonet, odl, ovn, etc.","commit_id":"520355dd6ef7182aad1e95352deda6f872b79a6a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b895b0c47a65227ac155381410179a1266a5e1a7","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self):"},{"line_number":44,"context_line":"        super(LoggingApiPlugin, self).__init__()"},{"line_number":45,"context_line":"        self.start_rpc_listeners()"},{"line_number":46,"context_line":"        self.logging_rpc \u003d server_rpc.LoggingApiNotification()"},{"line_number":47,"context_line":"        self.driver_manager \u003d driver_mgr.LoggingServiceDriverManager()"},{"line_number":48,"context_line":"        registry.subscribe(self._handle_parent_resources_updated,"},{"line_number":49,"context_line":"                           resources.PORT, events.PRECOMMIT_UPDATE)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_0012ba62","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":62},"in_reply_to":"df140735_1d9c650d","updated":"2017-06-02 07:48:15.000000000","message":"Thanks for your suggestion. I will do separate it.","commit_id":"520355dd6ef7182aad1e95352deda6f872b79a6a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8019d5dd9b415d0517ec715f0546a343650591dc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            log_obj \u003d log_object.Log(context, id\u003did)"},{"line_number":134,"context_line":"            log_obj.update_fields(log_data, reset_changes\u003dTrue)"},{"line_number":135,"context_line":"            log_obj.update()"},{"line_number":136,"context_line":"        if log_data.get(\u0027enabled\u0027, None) is not None:"},{"line_number":137,"context_line":"            self.logging_rpc.update_log(context, [log_obj])"},{"line_number":138,"context_line":"        return log_obj"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_3dc049e1","line":136,"updated":"2017-06-02 06:44:00.000000000","message":"can you explain this condition?","commit_id":"520355dd6ef7182aad1e95352deda6f872b79a6a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b895b0c47a65227ac155381410179a1266a5e1a7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            log_obj \u003d log_object.Log(context, id\u003did)"},{"line_number":134,"context_line":"            log_obj.update_fields(log_data, reset_changes\u003dTrue)"},{"line_number":135,"context_line":"            log_obj.update()"},{"line_number":136,"context_line":"        if log_data.get(\u0027enabled\u0027, None) is not None:"},{"line_number":137,"context_line":"            self.logging_rpc.update_log(context, [log_obj])"},{"line_number":138,"context_line":"        return log_obj"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_2b78ff8d","line":136,"in_reply_to":"df140735_3dc049e1","updated":"2017-06-02 07:48:15.000000000","message":"It means that if we only update \u0027name\u0027 or \u0027description\u0027, then notifying to agent is not necessary. However, if \u0027enabled\u0027 is updated (That means we enable/disable collect event log), then notifying to agent is necessary. That\u0027s my idea. Do you have a better idea for this code?","commit_id":"520355dd6ef7182aad1e95352deda6f872b79a6a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                           resources.SECURITY_GROUP_RULE,"},{"line_number":53,"context_line":"                           events.AFTER_DELETE)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _validate_port_callback(self, resource, event, trigger, **kwargs):"},{"line_number":56,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":57,"context_line":"        port_id \u003d kwargs[\u0027port\u0027][\u0027id\u0027]"},{"line_number":58,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_40c3115e","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":31},"updated":"2017-07-05 06:01:08.000000000","message":"i\u0027m not sure why this is a part of this \"Add rpc consume\" patch.","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":57,"context_line":"        port_id \u003d kwargs[\u0027port\u0027][\u0027id\u0027]"},{"line_number":58,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"},{"line_number":59,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d \u0027compute:nova\u0027:"},{"line_number":60,"context_line":"            if not validators.validate_log_type_for_port("},{"line_number":61,"context_line":"                    \u0027security_group\u0027, port):"},{"line_number":62,"context_line":"                raise log_exc.LoggingTypeNotSupported("}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_2007f51a","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":50},"updated":"2017-07-05 06:01:08.000000000","message":"do you mean to check DEVICE_OWNER_COMPUTE_PREFIX?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":57,"context_line":"        port_id \u003d kwargs[\u0027port\u0027][\u0027id\u0027]"},{"line_number":58,"context_line":"        port \u003d port_objects.Port.get_object(context, id\u003dport_id)"},{"line_number":59,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d \u0027compute:nova\u0027:"},{"line_number":60,"context_line":"            if not validators.validate_log_type_for_port("},{"line_number":61,"context_line":"                    \u0027security_group\u0027, port):"},{"line_number":62,"context_line":"                raise log_exc.LoggingTypeNotSupported("}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_c2340ce1","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":50},"in_reply_to":"3f1d235d_2007f51a","updated":"2017-07-11 12:31:53.000000000","message":"Yes, Thanks for your suggestion.","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d \u0027compute:nova\u0027:"},{"line_number":60,"context_line":"            if not validators.validate_log_type_for_port("},{"line_number":61,"context_line":"                    \u0027security_group\u0027, port):"},{"line_number":62,"context_line":"                raise log_exc.LoggingTypeNotSupported("},{"line_number":63,"context_line":"                    \u0027security_group\u0027, port_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _handle_sg_rule_callback(self, resource, event, trigger, **kwargs):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_4091d14d","line":62,"range":{"start_line":62,"start_character":30,"end_line":62,"end_character":53},"updated":"2017-07-05 06:01:08.000000000","message":"does this mean to prevent operations on ports if logging feature doesn\u0027t support it?\nit\u0027s rather a surprising behaviour to me.\nwhat\u0027s the rationale?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d \u0027compute:nova\u0027:"},{"line_number":60,"context_line":"            if not validators.validate_log_type_for_port("},{"line_number":61,"context_line":"                    \u0027security_group\u0027, port):"},{"line_number":62,"context_line":"                raise log_exc.LoggingTypeNotSupported("},{"line_number":63,"context_line":"                    \u0027security_group\u0027, port_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _handle_sg_rule_callback(self, resource, event, trigger, **kwargs):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_5580b146","line":62,"range":{"start_line":62,"start_character":30,"end_line":62,"end_character":53},"in_reply_to":"3f1d235d_4091d14d","updated":"2017-07-11 12:31:53.000000000","message":"No, I just want log a exception to warning to operators. So they can be aware logging will be not supported on this port. That\u0027s my idea. Do you have any suggestion for me in this case?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                raise log_exc.LoggingTypeNotSupported("},{"line_number":63,"context_line":"                    \u0027security_group\u0027, port_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _handle_sg_rule_callback(self, resource, event, trigger, **kwargs):"},{"line_number":66,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":67,"context_line":"        project_id \u003d context.tenant_id"},{"line_number":68,"context_line":"        sg_rules \u003d kwargs.get(\u0027security_group_rule\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_002bd92f","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":32},"updated":"2017-07-05 06:01:08.000000000","message":"i guess it\u0027s better to separate SG-specific stuff from the main plugin class.","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                raise log_exc.LoggingTypeNotSupported("},{"line_number":63,"context_line":"                    \u0027security_group\u0027, port_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _handle_sg_rule_callback(self, resource, event, trigger, **kwargs):"},{"line_number":66,"context_line":"        context \u003d kwargs[\u0027context\u0027]"},{"line_number":67,"context_line":"        project_id \u003d context.tenant_id"},{"line_number":68,"context_line":"        sg_rules \u003d kwargs.get(\u0027security_group_rule\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_55431114","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":32},"in_reply_to":"3f1d235d_002bd92f","updated":"2017-07-11 12:31:53.000000000","message":"I have moved it to LoggingServiceDriverManager. How do you think about it?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            # We need to remove redundant keyword."},{"line_number":136,"context_line":"            log_data.pop(\u0027tenant_id\u0027, None)"},{"line_number":137,"context_line":"            log_obj \u003d log_object.Log(context\u003dcontext, **log_data)"},{"line_number":138,"context_line":"            log_obj.create()"},{"line_number":139,"context_line":"        if log_data.get(\u0027enabled\u0027, True):"},{"line_number":140,"context_line":"            self.driver_manager.call("},{"line_number":141,"context_line":"                log_const.CREATE_LOG, context, [log_obj])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_408b116d","line":138,"updated":"2017-07-05 06:01:08.000000000","message":"can you consider to introduce precommit methods as well?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            # We need to remove redundant keyword."},{"line_number":136,"context_line":"            log_data.pop(\u0027tenant_id\u0027, None)"},{"line_number":137,"context_line":"            log_obj \u003d log_object.Log(context\u003dcontext, **log_data)"},{"line_number":138,"context_line":"            log_obj.create()"},{"line_number":139,"context_line":"        if log_data.get(\u0027enabled\u0027, True):"},{"line_number":140,"context_line":"            self.driver_manager.call("},{"line_number":141,"context_line":"                log_const.CREATE_LOG, context, [log_obj])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_a25d9016","line":138,"in_reply_to":"3f1d235d_408b116d","updated":"2017-07-11 12:31:53.000000000","message":"Done","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            log_data.pop(\u0027tenant_id\u0027, None)"},{"line_number":137,"context_line":"            log_obj \u003d log_object.Log(context\u003dcontext, **log_data)"},{"line_number":138,"context_line":"            log_obj.create()"},{"line_number":139,"context_line":"        if log_data.get(\u0027enabled\u0027, True):"},{"line_number":140,"context_line":"            self.driver_manager.call("},{"line_number":141,"context_line":"                log_const.CREATE_LOG, context, [log_obj])"},{"line_number":142,"context_line":"        return log_obj"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_00a879d8","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":41},"updated":"2017-07-05 06:01:08.000000000","message":"this means a driver might see an update without seeing the corresponding create, right?  (just a question)","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            log_data.pop(\u0027tenant_id\u0027, None)"},{"line_number":137,"context_line":"            log_obj \u003d log_object.Log(context\u003dcontext, **log_data)"},{"line_number":138,"context_line":"            log_obj.create()"},{"line_number":139,"context_line":"        if log_data.get(\u0027enabled\u0027, True):"},{"line_number":140,"context_line":"            self.driver_manager.call("},{"line_number":141,"context_line":"                log_const.CREATE_LOG, context, [log_obj])"},{"line_number":142,"context_line":"        return log_obj"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_22a7400e","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":41},"in_reply_to":"3f1d235d_00a879d8","updated":"2017-07-11 12:31:53.000000000","message":"Sorry, It\u0027s my mistake. Done.","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            log_obj.create()"},{"line_number":139,"context_line":"        if log_data.get(\u0027enabled\u0027, True):"},{"line_number":140,"context_line":"            self.driver_manager.call("},{"line_number":141,"context_line":"                log_const.CREATE_LOG, context, [log_obj])"},{"line_number":142,"context_line":"        return log_obj"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @db_base_plugin_common.convert_result_to_dict"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_005ab928","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":56},"updated":"2017-07-05 06:01:08.000000000","message":"why to take a list?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            log_obj.create()"},{"line_number":139,"context_line":"        if log_data.get(\u0027enabled\u0027, True):"},{"line_number":140,"context_line":"            self.driver_manager.call("},{"line_number":141,"context_line":"                log_const.CREATE_LOG, context, [log_obj])"},{"line_number":142,"context_line":"        return log_obj"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @db_base_plugin_common.convert_result_to_dict"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_5537914e","line":141,"range":{"start_line":141,"start_character":47,"end_line":141,"end_character":56},"in_reply_to":"3f1d235d_005ab928","updated":"2017-07-11 12:31:53.000000000","message":"Basically, I want to pass a list log_objects in case of logging plugin received security group rule\u0027s update event Because a security group rule can be related to multiple log_object.","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"099d7000cf79dfa92df6c2fdc1224c94a50189a6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            log_obj \u003d log_object.Log(context, id\u003dlog_id)"},{"line_number":150,"context_line":"            log_obj.update_fields(log_data, reset_changes\u003dTrue)"},{"line_number":151,"context_line":"            log_obj.update()"},{"line_number":152,"context_line":"        if log_data.get(\u0027enabled\u0027, None) is not None:"},{"line_number":153,"context_line":"            self.driver_manager.call("},{"line_number":154,"context_line":"                log_const.UPDATE_LOG, context, [log_obj])"},{"line_number":155,"context_line":"        return log_obj"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_c0ade1e9","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":53},"updated":"2017-07-05 06:01:08.000000000","message":"do you mean is_attr_set?","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"af48875aab853215abac83059f577d45485b7a74","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            log_obj \u003d log_object.Log(context, id\u003dlog_id)"},{"line_number":150,"context_line":"            log_obj.update_fields(log_data, reset_changes\u003dTrue)"},{"line_number":151,"context_line":"            log_obj.update()"},{"line_number":152,"context_line":"        if log_data.get(\u0027enabled\u0027, None) is not None:"},{"line_number":153,"context_line":"            self.driver_manager.call("},{"line_number":154,"context_line":"                log_const.UPDATE_LOG, context, [log_obj])"},{"line_number":155,"context_line":"        return log_obj"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_3573f582","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":53},"in_reply_to":"3f1d235d_c0ade1e9","updated":"2017-07-11 12:31:53.000000000","message":"I mean log_object is updated with \u0027enabled\u0027 attribute.","commit_id":"591fe7cd662ebdda137eb1784091bcbd928f5e18"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0babf6f6b4f740eb1a8a837f466798ced8f513ff","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                \u0027context\u0027: context,"},{"line_number":110,"context_line":"                \u0027log\u0027: log_obj"},{"line_number":111,"context_line":"            }"},{"line_number":112,"context_line":"            registry.notify(log_const.LOGGING,"},{"line_number":113,"context_line":"                            events.PRECOMMIT_UPDATE,"},{"line_number":114,"context_line":"                            self, **kwargs)"},{"line_number":115,"context_line":"        if \u0027enabled\u0027 in log_data:"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f1a1f67_fe66f1ba","line":112,"range":{"start_line":112,"start_character":21,"end_line":112,"end_character":27},"updated":"2017-07-19 11:58:48.000000000","message":"i\u0027ve heard publish is preferred for new code.","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"08d3263cc8b2c50bc6696a211e45207a038ebc5d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                \u0027context\u0027: context,"},{"line_number":110,"context_line":"                \u0027log\u0027: log_obj"},{"line_number":111,"context_line":"            }"},{"line_number":112,"context_line":"            registry.notify(log_const.LOGGING,"},{"line_number":113,"context_line":"                            events.PRECOMMIT_UPDATE,"},{"line_number":114,"context_line":"                            self, **kwargs)"},{"line_number":115,"context_line":"        if \u0027enabled\u0027 in log_data:"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_87abb187","line":112,"range":{"start_line":112,"start_character":21,"end_line":112,"end_character":27},"in_reply_to":"1f1a1f67_fe66f1ba","updated":"2017-07-25 08:01:05.000000000","message":"Thanks.","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0babf6f6b4f740eb1a8a837f466798ced8f513ff","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            registry.notify(log_const.LOGGING,"},{"line_number":113,"context_line":"                            events.PRECOMMIT_UPDATE,"},{"line_number":114,"context_line":"                            self, **kwargs)"},{"line_number":115,"context_line":"        if \u0027enabled\u0027 in log_data:"},{"line_number":116,"context_line":"            self.driver_manager.call("},{"line_number":117,"context_line":"                log_const.UPDATE_LOG, context, log_obj)"},{"line_number":118,"context_line":"        return log_obj"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f1a1f67_9ea93d91","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":33},"updated":"2017-07-19 11:58:48.000000000","message":"this kind of optimization should be consistent between precommit and postcommit.","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"08d3263cc8b2c50bc6696a211e45207a038ebc5d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            registry.notify(log_const.LOGGING,"},{"line_number":113,"context_line":"                            events.PRECOMMIT_UPDATE,"},{"line_number":114,"context_line":"                            self, **kwargs)"},{"line_number":115,"context_line":"        if \u0027enabled\u0027 in log_data:"},{"line_number":116,"context_line":"            self.driver_manager.call("},{"line_number":117,"context_line":"                log_const.UPDATE_LOG, context, log_obj)"},{"line_number":118,"context_line":"        return log_obj"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_4795c93f","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":33},"in_reply_to":"1f1a1f67_9ea93d91","updated":"2017-07-25 08:01:05.000000000","message":"Done","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0babf6f6b4f740eb1a8a837f466798ced8f513ff","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                            self, **kwargs)"},{"line_number":115,"context_line":"        if \u0027enabled\u0027 in log_data:"},{"line_number":116,"context_line":"            self.driver_manager.call("},{"line_number":117,"context_line":"                log_const.UPDATE_LOG, context, log_obj)"},{"line_number":118,"context_line":"        return log_obj"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def delete_log(self, context, log_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f1a1f67_7eb781f6","line":117,"updated":"2017-07-19 11:58:48.000000000","message":"why to use different methods (driver_manager.call vs registry.notify) for precommit and postcommit?","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"08d3263cc8b2c50bc6696a211e45207a038ebc5d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                            self, **kwargs)"},{"line_number":115,"context_line":"        if \u0027enabled\u0027 in log_data:"},{"line_number":116,"context_line":"            self.driver_manager.call("},{"line_number":117,"context_line":"                log_const.UPDATE_LOG, context, log_obj)"},{"line_number":118,"context_line":"        return log_obj"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def delete_log(self, context, log_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_279e4554","line":117,"in_reply_to":"1f1a1f67_7eb781f6","updated":"2017-07-25 08:01:05.000000000","message":"Sorry, I misunderstood your previous comments. So I will update it as your comment. Could you please review next patch-set? Thanks!","commit_id":"01e45043ca8c50066480784c2cf071b9d7991013"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bbe335a50d132dedaf8a34a342d6208ab2e6d31e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            log_obj \u003d log_object.Log(context, id\u003dlog_id)"},{"line_number":95,"context_line":"            log_obj.update_fields(log_data, reset_changes\u003dTrue)"},{"line_number":96,"context_line":"            log_obj.update()"},{"line_number":97,"context_line":"            need_notify \u003d \u0027enabled\u0027 in log_data or None"},{"line_number":98,"context_line":"            if need_notify:"},{"line_number":99,"context_line":"                self.driver_manager.call("},{"line_number":100,"context_line":"                    log_const.UPDATE_LOG_PRECOMMIT, context, log_obj)"}],"source_content_type":"text/x-python","patch_set":42,"id":"3f4b6375_e38513ae","line":97,"range":{"start_line":97,"start_character":47,"end_line":97,"end_character":55},"updated":"2017-10-27 14:44:54.000000000","message":"This should go away","commit_id":"ebe62e769f542a0915abffb0310c0b224b9a690f"}],"neutron/services/logapi/rpc/server.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                  fanout\u003dFalse)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @log_helpers.log_method_call"},{"line_number":41,"context_line":"    def get_sg_log_info(self, context, port_id\u003dNone, log_resources\u003dNone):"},{"line_number":42,"context_line":"        return db_api.get_sg_log_info(context, port_id, log_resources)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_3c570e29","line":41,"updated":"2017-11-24 13:55:57.000000000","message":"Just a question: Is there a reason to have just a single RPC method that consumes two mutual exclusive parameters? Why don\u0027t we call\n\n get_sg_log_info_for_port() and get_sg_log_info_for_log_resources() \n\ndirectly?","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"94fd99bdc556943b554e2603566a96623ff45c2d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                  fanout\u003dFalse)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @log_helpers.log_method_call"},{"line_number":41,"context_line":"    def get_sg_log_info(self, context, port_id\u003dNone, log_resources\u003dNone):"},{"line_number":42,"context_line":"        return db_api.get_sg_log_info(context, port_id, log_resources)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_d4e02029","line":41,"in_reply_to":"ff82abbf_3c570e29","updated":"2017-11-27 09:17:09.000000000","message":"Actually, there is no reason to have just a single RPC method here. So It should be separate as your suggestion. Thanks.","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"}],"neutron/tests/unit/services/logapi/drivers/test_manager.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        for method in log_const.LOG_CALL_METHODS:"},{"line_number":96,"context_line":"            with mock.patch.object(log_driver_base.DriverBase, method) as \\"},{"line_number":97,"context_line":"                    method_fnc:"},{"line_number":98,"context_line":"                context \u003d mock.Mock()"},{"line_number":99,"context_line":"                log_obj \u003d mock.Mock()"},{"line_number":100,"context_line":"                self.driver_manager.call("},{"line_number":101,"context_line":"                    method, context\u003dcontext, log_objs\u003d[log_obj])"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_6f4076a6","line":98,"range":{"start_line":98,"start_character":25,"end_line":98,"end_character":37},"updated":"2017-11-24 13:55:57.000000000","message":"consider using mock.sentinel.context, it\u0027s more lightweight than Mock","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"94fd99bdc556943b554e2603566a96623ff45c2d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        for method in log_const.LOG_CALL_METHODS:"},{"line_number":96,"context_line":"            with mock.patch.object(log_driver_base.DriverBase, method) as \\"},{"line_number":97,"context_line":"                    method_fnc:"},{"line_number":98,"context_line":"                context \u003d mock.Mock()"},{"line_number":99,"context_line":"                log_obj \u003d mock.Mock()"},{"line_number":100,"context_line":"                self.driver_manager.call("},{"line_number":101,"context_line":"                    method, context\u003dcontext, log_objs\u003d[log_obj])"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_74d35461","line":98,"range":{"start_line":98,"start_character":25,"end_line":98,"end_character":37},"in_reply_to":"ff82abbf_6f4076a6","updated":"2017-11-27 09:17:09.000000000","message":"Done","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            with mock.patch.object(log_driver_base.DriverBase, method) as \\"},{"line_number":97,"context_line":"                    method_fnc:"},{"line_number":98,"context_line":"                context \u003d mock.Mock()"},{"line_number":99,"context_line":"                log_obj \u003d mock.Mock()"},{"line_number":100,"context_line":"                self.driver_manager.call("},{"line_number":101,"context_line":"                    method, context\u003dcontext, log_objs\u003d[log_obj])"},{"line_number":102,"context_line":"                method_fnc.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_8f3dba2c","line":99,"updated":"2017-11-24 13:55:57.000000000","message":"ditto, mock.sentinel.log_obj","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"94fd99bdc556943b554e2603566a96623ff45c2d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            with mock.patch.object(log_driver_base.DriverBase, method) as \\"},{"line_number":97,"context_line":"                    method_fnc:"},{"line_number":98,"context_line":"                context \u003d mock.Mock()"},{"line_number":99,"context_line":"                log_obj \u003d mock.Mock()"},{"line_number":100,"context_line":"                self.driver_manager.call("},{"line_number":101,"context_line":"                    method, context\u003dcontext, log_objs\u003d[log_obj])"},{"line_number":102,"context_line":"                method_fnc.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_34c94cab","line":99,"in_reply_to":"ff82abbf_8f3dba2c","updated":"2017-11-27 09:17:09.000000000","message":"Done","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    context\u003dcontext, log_objs\u003d[log_obj])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_not_implemented_call_methods(self):"},{"line_number":106,"context_line":"        context \u003d mock.Mock()"},{"line_number":107,"context_line":"        log_obj \u003d mock.Mock()"},{"line_number":108,"context_line":"        self.assertRaises(exceptions.DriverCallError, self.driver_manager.call,"},{"line_number":109,"context_line":"                          \u0027wrong_method\u0027, context\u003dcontext, log_objs\u003d[log_obj])"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_4f4332b0","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":29},"updated":"2017-11-24 13:55:57.000000000","message":"ditto","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"94fd99bdc556943b554e2603566a96623ff45c2d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    context\u003dcontext, log_objs\u003d[log_obj])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_not_implemented_call_methods(self):"},{"line_number":106,"context_line":"        context \u003d mock.Mock()"},{"line_number":107,"context_line":"        log_obj \u003d mock.Mock()"},{"line_number":108,"context_line":"        self.assertRaises(exceptions.DriverCallError, self.driver_manager.call,"},{"line_number":109,"context_line":"                          \u0027wrong_method\u0027, context\u003dcontext, log_objs\u003d[log_obj])"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_14c44890","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":29},"in_reply_to":"ff82abbf_4f4332b0","updated":"2017-11-27 09:17:09.000000000","message":"Done","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"}],"neutron/tests/unit/services/logapi/rpc/test_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cadcee7e89e1e2b6f32638ef05d6be175430e037","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.tests import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class LoggingApiStubTestCase(base.BaseTestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @mock.patch(\"neutron.common.rpc.get_client\")"},{"line_number":27,"context_line":"    def test___init__(self, mocked_get_client):"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_6f6e3630","line":24,"updated":"2017-11-24 13:55:57.000000000","message":"Consider removing this UT completely. It doesn\u0027t bring much value to test that particular method called get_client with _target. This should be covered by an integration test that uses real RPC communication.","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"94fd99bdc556943b554e2603566a96623ff45c2d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.tests import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class LoggingApiStubTestCase(base.BaseTestCase):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    @mock.patch(\"neutron.common.rpc.get_client\")"},{"line_number":27,"context_line":"    def test___init__(self, mocked_get_client):"}],"source_content_type":"text/x-python","patch_set":46,"id":"ff82abbf_7438349f","line":24,"in_reply_to":"ff82abbf_6f6e3630","updated":"2017-11-27 09:17:09.000000000","message":"Done","commit_id":"2d02bf905bdf09dd9ba30f15b3a44fe78ff998d1"}],"neutron/tests/unit/services/logapi/test_logging_plugin.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            init_log_mock.assert_called_once_with("},{"line_number":239,"context_line":"                context\u003dself.ctxt, **log_data[\u0027log\u0027])"},{"line_number":240,"context_line":"            self.assertTrue(new_log.create.called)"},{"line_number":241,"context_line":"        self.assertFalse("},{"line_number":242,"context_line":"            self.log_plugin.driver_manager.call.called)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def test_create_log_with_unsupported_logging_type(self):"},{"line_number":245,"context_line":"        log \u003d {\u0027log\u0027: {\u0027resource_type\u0027: \u0027fake_type\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_65872564","line":242,"range":{"start_line":241,"start_character":0,"end_line":242,"end_character":55},"updated":"2017-08-15 19:44:16.000000000","message":"Couldn\u0027t this be replaced by :\n\nself.log_plugin.driver_manager.call.assert_not_called()","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            init_log_mock.assert_called_once_with("},{"line_number":239,"context_line":"                context\u003dself.ctxt, **log_data[\u0027log\u0027])"},{"line_number":240,"context_line":"            self.assertTrue(new_log.create.called)"},{"line_number":241,"context_line":"        self.assertFalse("},{"line_number":242,"context_line":"            self.log_plugin.driver_manager.call.called)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def test_create_log_with_unsupported_logging_type(self):"},{"line_number":245,"context_line":"        log \u003d {\u0027log\u0027: {\u0027resource_type\u0027: \u0027fake_type\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_01a15ff8","line":242,"range":{"start_line":241,"start_character":0,"end_line":242,"end_character":55},"in_reply_to":"9f436f4f_65872564","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"5c47a5f589735b0af252750e7c27a3ebfb1ec327","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            new_log.update_fields.assert_called_once_with(log_data[\u0027log\u0027],"},{"line_number":302,"context_line":"                                                          reset_changes\u003dTrue)"},{"line_number":303,"context_line":"            self.assertTrue(new_log.update.called)"},{"line_number":304,"context_line":"        self.assertFalse("},{"line_number":305,"context_line":"            self.log_plugin.driver_manager.call.called)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_delete_log(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_85e0c927","line":304,"updated":"2017-08-15 19:44:16.000000000","message":"See comment to L242","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"343d32514d9e8d3efb0e463348baa03feeafd590","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            new_log.update_fields.assert_called_once_with(log_data[\u0027log\u0027],"},{"line_number":302,"context_line":"                                                          reset_changes\u003dTrue)"},{"line_number":303,"context_line":"            self.assertTrue(new_log.update.called)"},{"line_number":304,"context_line":"        self.assertFalse("},{"line_number":305,"context_line":"            self.log_plugin.driver_manager.call.called)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_delete_log(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_e1a3fbfe","line":304,"in_reply_to":"9f436f4f_85e0c927","updated":"2017-08-16 09:01:32.000000000","message":"Done","commit_id":"5a62a70632d0ab1bdac83968aad46b19f4e4fe78"}]}
