)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"07f1090acb25cbb98bf853ee6fd8b1a77b5b5faf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[log]: add driver manager to LoggingPlugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch added driver manger to LoggingPlugin to manage"},{"line_number":10,"context_line":"logging drivers are enabled belong ML2 dirver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Yushiro FURUKAWA \u003cy.furukawa_2@jp.fujitsu.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"ff346bd7_4b90b24a","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":16},"updated":"2017-07-28 08:40:05.000000000","message":"adds","commit_id":"c5baa98074582ab0c901e082c14d51b39ff3e55e"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"07f1090acb25cbb98bf853ee6fd8b1a77b5b5faf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[log]: add driver manager to LoggingPlugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch added driver manger to LoggingPlugin to manage"},{"line_number":10,"context_line":"logging drivers are enabled belong ML2 dirver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Yushiro FURUKAWA \u003cy.furukawa_2@jp.fujitsu.com\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"ff346bd7_8ba69aaa","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":45},"updated":"2017-07-28 08:40:05.000000000","message":"I guess you wanted to say\n\n\"which ML2 drivers enable logging drivers\"","commit_id":"c5baa98074582ab0c901e082c14d51b39ff3e55e"}],"neutron/services/logapi/agent/drivers/base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5b7330e482c34c6cf26cfd0156f139aa3b0a49ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"1f1a1f67_10d52344","updated":"2017-07-19 08:33:07.000000000","message":"why these files are under \"agent\" directory?","commit_id":"f69f6787b09d1cf1328c1bf81d3fb36522e3cd08"}],"neutron/services/logapi/agent/drivers/manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e7ac9f3e79c3d52541189fb8a42566af06c6b303","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log_types \u003d set()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":56,"context_line":"        LOG.debug(\"Supported resource types: %s\", log_types)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f1d235d_bdb0ce8b","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":35},"updated":"2017-07-05 06:02:17.000000000","message":"can you give me an example when it\u0027s useful?","commit_id":"5b36d905d11f302384e307f01fe74fe2eb30db97"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"4ea8dafebe79b2cac02def1885f0be62a890eab0","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log_types \u003d set()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":56,"context_line":"        LOG.debug(\"Supported resource types: %s\", log_types)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f1d235d_150beed5","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":35},"in_reply_to":"3f1d235d_0b29b5e4","updated":"2017-07-06 04:31:17.000000000","message":"I think that will be make sense if this function return a common subset of set of logging types of all loaded log drivers same as Qos had worked. Do you think so?","commit_id":"5b36d905d11f302384e307f01fe74fe2eb30db97"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"4a3419bcc9d4e33907ca5590943f79b28ca57c3e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log_types \u003d set()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":56,"context_line":"        LOG.debug(\"Supported resource types: %s\", log_types)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f1d235d_0b29b5e4","line":53,"range":{"start_line":52,"start_character":0,"end_line":53,"end_character":35},"in_reply_to":"3f1d235d_bdb0ce8b","updated":"2017-07-05 09:54:49.000000000","message":"Actually, It\u0027s bad copy and pate from QoS code. It should be to remove comments. Do you think \u0027supported_logging_types\u0027 function should return a set of supported logging types based on \u0027Union\u0027 or \u0027Intersect\u0027 of set of supported logging types of each log_driver? Which option make sense to you? Thanks in advance.","commit_id":"5b36d905d11f302384e307f01fe74fe2eb30db97"}],"neutron/services/logapi/common/constants.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"32db2a2a371d8e11c8b2392c3cdfb0466a35fc70","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ACCEPT_EVENT \u003d \u0027ACCEPT\u0027"},{"line_number":17,"context_line":"DROP_EVENT \u003d \u0027DROP\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_d8d681c4","line":14,"updated":"2017-08-08 04:23:18.000000000","message":"unrelated change","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"de64c0f56843cc571d8f571caa2e1894870fe81d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ACCEPT_EVENT \u003d \u0027ACCEPT\u0027"},{"line_number":17,"context_line":"DROP_EVENT \u003d \u0027DROP\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_de5b0952","line":14,"in_reply_to":"9f436f4f_d8d681c4","updated":"2017-08-08 06:42:28.000000000","message":"Done","commit_id":"5166d861981ba2687147031d3ef23885add7e843"}],"neutron/services/logapi/common/exceptions.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f6c276de55d057559ffde1df041e0b3de55aa586","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    message \u003d _(\"Invalid log resource_type: %(resource_type)s.\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class LoggingTypeNotSupported(n_exc.Conflict):"},{"line_number":30,"context_line":"    message \u003d _(\"Logging type %(log_type)s is not supported on \""},{"line_number":31,"context_line":"                \"port %(port_id)s.\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"1f1a1f67_906c93ce","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":36},"updated":"2017-07-19 08:30:27.000000000","message":"where is this used?","commit_id":"f69f6787b09d1cf1328c1bf81d3fb36522e3cd08"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"93b96791dfb0a5da4e5cc4fc31f51127ad9b2d9b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    message \u003d _(\"Invalid log resource_type: %(resource_type)s.\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class LoggingTypeNotSupported(n_exc.Conflict):"},{"line_number":30,"context_line":"    message \u003d _(\"Logging type %(log_type)s is not supported on \""},{"line_number":31,"context_line":"                \"port %(port_id)s.\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"1f1a1f67_d0b0cbdf","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":36},"in_reply_to":"1f1a1f67_906c93ce","updated":"2017-07-19 08:42:52.000000000","message":"Actually, It is used at https://review.openstack.org/#/c/467976/18/neutron/services/logapi/common/validators.py@107. It should be moved to I10f2441fc2c7bdbda51b05002549b235743a7deb","commit_id":"f69f6787b09d1cf1328c1bf81d3fb36522e3cd08"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6a75798cb153fc85b4d206180a7420b5d1d70d78","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LogResourceNotFound(n_exc.NotFound):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_a000db68","line":18,"updated":"2017-07-25 09:21:44.000000000","message":"why do we need this change? this is unrelated to the patch set","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"2b371d816cec5f00f7fcba60eeb6d50dc0124efd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LogResourceNotFound(n_exc.NotFound):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_7c2f22a1","line":18,"in_reply_to":"ff346bd7_a000db68","updated":"2017-07-26 02:08:05.000000000","message":"Yes, you\u0027re right. However, I\u0027d like to make it looks more pretty by moving third party to first. Is it ok? :)","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"32db2a2a371d8e11c8b2392c3cdfb0466a35fc70","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LogResourceNotFound(n_exc.NotFound):"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_b8e3bda4","line":18,"updated":"2017-08-08 04:23:18.000000000","message":"unrelated change","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"de64c0f56843cc571d8f571caa2e1894870fe81d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LogResourceNotFound(n_exc.NotFound):"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_7e309d08","line":18,"in_reply_to":"9f436f4f_639feab4","updated":"2017-08-08 06:42:28.000000000","message":"Done","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"8f382c76e03e8f728641a411216842db24c7ec5a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LogResourceNotFound(n_exc.NotFound):"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_639feab4","line":18,"in_reply_to":"9f436f4f_b8e3bda4","updated":"2017-08-08 04:43:07.000000000","message":"Actually, it\u0027s not related change. But I\u0027d like to make code looks more pretty by import third party first. Is it OK to you?","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"32db2a2a371d8e11c8b2392c3cdfb0466a35fc70","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    message \u003d _(\"Log resource %(log_id)s could not be found.\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class InvalidLogResourceType(n_exc.InvalidInput):"},{"line_number":26,"context_line":"    message \u003d _(\"Invalid log resource_type: %(resource_type)s.\")"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_98e0f998","line":25,"updated":"2017-08-08 04:23:18.000000000","message":"unrelated change","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"de64c0f56843cc571d8f571caa2e1894870fe81d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    message \u003d _(\"Log resource %(log_id)s could not be found.\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class InvalidLogResourceType(n_exc.InvalidInput):"},{"line_number":26,"context_line":"    message \u003d _(\"Invalid log resource_type: %(resource_type)s.\")"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_9e034110","line":25,"in_reply_to":"9f436f4f_23d0c250","updated":"2017-08-08 06:42:28.000000000","message":"I got it.","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"57f6a1a4fc9207e039d5234062209cf4294356f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    message \u003d _(\"Log resource %(log_id)s could not be found.\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class InvalidLogResourceType(n_exc.InvalidInput):"},{"line_number":26,"context_line":"    message \u003d _(\"Invalid log resource_type: %(resource_type)s.\")"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_23d0c250","line":25,"in_reply_to":"9f436f4f_23f7a2f8","updated":"2017-08-08 04:45:43.000000000","message":"ideally unrelated changes should be separated.\ni don\u0027t insist though.","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"8f382c76e03e8f728641a411216842db24c7ec5a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    message \u003d _(\"Log resource %(log_id)s could not be found.\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class InvalidLogResourceType(n_exc.InvalidInput):"},{"line_number":26,"context_line":"    message \u003d _(\"Invalid log resource_type: %(resource_type)s.\")"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_23f7a2f8","line":25,"in_reply_to":"9f436f4f_98e0f998","updated":"2017-08-08 04:43:07.000000000","message":"Indeed, It not related this change. However, it\u0027s very small change to correct name. So I\u0027d like keep it in this change. Is it ok to you. I won\u0027t hesitate if it need a follow-up change.","commit_id":"5166d861981ba2687147031d3ef23885add7e843"}],"neutron/services/logapi/drivers/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.supported_logging_types \u003d supported_logging_types"},{"line_number":42,"context_line":"        self.requires_rpc \u003d requires_rpc"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(log_const.LOGGING_PLUGIN, [events.AFTER_INIT])"},{"line_number":45,"context_line":"    def _register(self, resource, event, trigger, **kwargs):"},{"line_number":46,"context_line":"        if self.is_loaded:"},{"line_number":47,"context_line":"            # trigger is the LoggingServiceDriverManager"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_9640ae37","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":69},"updated":"2017-07-31 09:23:18.000000000","message":"From the code maintenance perspective, it is better to describe why you need to use a callback for AFTER_INIT is required. Perhaps there is a reason you cannot use a straight-forward way to load drivers (RPC initialization?). it would be nice if some reason is explained here as a comment.","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.supported_logging_types \u003d supported_logging_types"},{"line_number":42,"context_line":"        self.requires_rpc \u003d requires_rpc"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(log_const.LOGGING_PLUGIN, [events.AFTER_INIT])"},{"line_number":45,"context_line":"    def _register(self, resource, event, trigger, **kwargs):"},{"line_number":46,"context_line":"        if self.is_loaded:"},{"line_number":47,"context_line":"            # trigger is the LoggingServiceDriverManager"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_6928ad33","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":69},"in_reply_to":"df3967d1_9640ae37","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def is_loaded(self):"},{"line_number":51,"context_line":"        \"\"\"True if the driver is active for the Neutron Server."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Implement this property to determine if your driver is actively"},{"line_number":54,"context_line":"        configured for this Neutron Server deployment."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_d013de65","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":31},"updated":"2017-07-31 09:23:18.000000000","message":"method? Or if you use this as property, you need @property decorator.","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def is_loaded(self):"},{"line_number":51,"context_line":"        \"\"\"True if the driver is active for the Neutron Server."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        Implement this property to determine if your driver is actively"},{"line_number":54,"context_line":"        configured for this Neutron Server deployment."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_2922a553","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":31},"in_reply_to":"df3967d1_d013de65","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return True"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def is_vif_type_compatible(self, vif_type):"},{"line_number":59,"context_line":"        \"\"\"True if the driver is compatible with the VIF type.\"\"\""},{"line_number":60,"context_line":"        return vif_type in self.vif_types"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def is_vnic_compatible(self, vnic_type):"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_d36f68c3","line":59,"range":{"start_line":59,"start_character":32,"end_line":59,"end_character":44},"updated":"2017-07-31 09:23:18.000000000","message":"What does \"compatible\" here mean? Do you want to use \"supported\"?\n\n(I am not a native speaker, so I am not sure it is good or not)","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return True"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def is_vif_type_compatible(self, vif_type):"},{"line_number":59,"context_line":"        \"\"\"True if the driver is compatible with the VIF type.\"\"\""},{"line_number":60,"context_line":"        return vif_type in self.vif_types"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def is_vnic_compatible(self, vnic_type):"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_e9c93d78","line":59,"range":{"start_line":59,"start_character":32,"end_line":59,"end_character":44},"in_reply_to":"df3967d1_d36f68c3","updated":"2017-08-01 04:24:08.000000000","message":"I mean that, it\u0027s \"supported\". However, I\u0027m not a native speaker too. So I\u0027d like to keep it as qos or trunk has worked. Do you think so? I won\u0027t hesitate if it need to be change. :)","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return vnic_type in self.vnic_types"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def is_logging_type_supported(self, log_type):"},{"line_number":67,"context_line":"        supported_types \u003d log_type in self.supported_logging_types"},{"line_number":68,"context_line":"        if not supported_types:"},{"line_number":69,"context_line":"            LOG.debug(\"logging type %(log_type)s is not supported by \""},{"line_number":70,"context_line":"                      \"%(driver_name)s\","}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_53e6d846","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":23},"updated":"2017-07-31 09:23:18.000000000","message":"The variable name looks a bit odd since this variable stores a boolean. How about \u0027is_supported\u0027 or \u0027supported\u0027?","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return vnic_type in self.vnic_types"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def is_logging_type_supported(self, log_type):"},{"line_number":67,"context_line":"        supported_types \u003d log_type in self.supported_logging_types"},{"line_number":68,"context_line":"        if not supported_types:"},{"line_number":69,"context_line":"            LOG.debug(\"logging type %(log_type)s is not supported by \""},{"line_number":70,"context_line":"                      \"%(driver_name)s\","}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_c9c43962","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":23},"in_reply_to":"df3967d1_53e6d846","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                      \"%(driver_name)s\","},{"line_number":71,"context_line":"                      {\u0027log_type\u0027: log_type,"},{"line_number":72,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_f3d6ec4f","line":74,"range":{"start_line":73,"start_character":7,"end_line":74,"end_character":19},"updated":"2017-07-31 09:23:18.000000000","message":"(just my preference) I think you do just \u0027return supported_types\u0027 here.","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                      \"%(driver_name)s\","},{"line_number":71,"context_line":"                      {\u0027log_type\u0027: log_type,"},{"line_number":72,"context_line":"                       \u0027driver_name\u0027: self.name})"},{"line_number":73,"context_line":"            return False"},{"line_number":74,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_a9a1f5ab","line":74,"range":{"start_line":73,"start_character":7,"end_line":74,"end_character":19},"in_reply_to":"df3967d1_f3d6ec4f","updated":"2017-08-01 04:24:08.000000000","message":"Done! Thanks.","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c13723351674716d62d574a046d4881c5ec0a53c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.supported_logging_types \u003d supported_logging_types"},{"line_number":42,"context_line":"        self.requires_rpc \u003d requires_rpc"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # The log driver should advertise itself as supported driver by calling"},{"line_number":45,"context_line":"    # register_driver() on the LoggingServiceDriverManager. Therefore,"},{"line_number":46,"context_line":"    # logging plugin can discover which resources types are supported by"},{"line_number":47,"context_line":"    # the log driver."},{"line_number":48,"context_line":"    @registry.receives(log_const.LOGGING_PLUGIN, [events.AFTER_INIT])"},{"line_number":49,"context_line":"    def _register(self, resource, event, trigger, **kwargs):"},{"line_number":50,"context_line":"        if self.is_loaded:"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_c13a9396","line":47,"range":{"start_line":44,"start_character":3,"end_line":47,"end_character":21},"updated":"2017-08-02 17:47:44.000000000","message":"I still don\u0027t understand why dynamic loading is required. How is a list of logging drivers specified? In a usual approach, the driver manager loads all specified drivers (as we do in ML2 drivers or agent extensions). What I cannot understand so far is why such approach cannot be used and you need to use dynamic loading with the event callback mechanism.","commit_id":"c6d2fe1784090020ac438eba2faf96ce0dfeda84"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"002a592849761f94e3990e8ca109d0992049c85a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.supported_logging_types \u003d supported_logging_types"},{"line_number":42,"context_line":"        self.requires_rpc \u003d requires_rpc"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # The log driver should advertise itself as supported driver by calling"},{"line_number":45,"context_line":"    # register_driver() on the LoggingServiceDriverManager. Therefore,"},{"line_number":46,"context_line":"    # logging plugin can discover which resources types are supported by"},{"line_number":47,"context_line":"    # the log driver."},{"line_number":48,"context_line":"    @registry.receives(log_const.LOGGING_PLUGIN, [events.AFTER_INIT])"},{"line_number":49,"context_line":"    def _register(self, resource, event, trigger, **kwargs):"},{"line_number":50,"context_line":"        if self.is_loaded:"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_de725bad","line":47,"range":{"start_line":44,"start_character":3,"end_line":47,"end_character":21},"in_reply_to":"df3967d1_149c4d0d","updated":"2017-08-03 08:00:01.000000000","message":"Indeed, It\u0027s mimic from trunk and qos. Is there any problem with this approach?","commit_id":"c6d2fe1784090020ac438eba2faf96ce0dfeda84"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fd9500a0cd5e1d312f70e6a23949081cfb1720b3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.supported_logging_types \u003d supported_logging_types"},{"line_number":42,"context_line":"        self.requires_rpc \u003d requires_rpc"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # The log driver should advertise itself as supported driver by calling"},{"line_number":45,"context_line":"    # register_driver() on the LoggingServiceDriverManager. Therefore,"},{"line_number":46,"context_line":"    # logging plugin can discover which resources types are supported by"},{"line_number":47,"context_line":"    # the log driver."},{"line_number":48,"context_line":"    @registry.receives(log_const.LOGGING_PLUGIN, [events.AFTER_INIT])"},{"line_number":49,"context_line":"    def _register(self, resource, event, trigger, **kwargs):"},{"line_number":50,"context_line":"        if self.is_loaded:"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_149c4d0d","line":47,"range":{"start_line":44,"start_character":3,"end_line":47,"end_character":21},"in_reply_to":"df3967d1_c13a9396","updated":"2017-08-03 03:09:09.000000000","message":"I think this is attempting to mimic what was done in the trunk plugin case [1], though I don\u0027t have enough to understand if the same mechanism is applicable here.\n\nIn the trunk case, the mechanism drivers for ML2 dictate what trunk drivers can be selected. The user only defines the ML2 driver and the trunk plugin is smart enough to select to appropriate trunk driver or fail if none are available.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/services/trunk/drivers/base.py#L26","commit_id":"c6d2fe1784090020ac438eba2faf96ce0dfeda84"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"220ea81c7063957c7032bf9acd715af9afeacdfa","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.supported_logging_types \u003d supported_logging_types"},{"line_number":42,"context_line":"        self.requires_rpc \u003d requires_rpc"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # The log driver should advertise itself as supported driver by calling"},{"line_number":45,"context_line":"    # register_driver() on the LoggingServiceDriverManager. Therefore,"},{"line_number":46,"context_line":"    # logging plugin can discover which resources types are supported by"},{"line_number":47,"context_line":"    # the log driver."},{"line_number":48,"context_line":"    @registry.receives(log_const.LOGGING_PLUGIN, [events.AFTER_INIT])"},{"line_number":49,"context_line":"    def _register(self, resource, event, trigger, **kwargs):"},{"line_number":50,"context_line":"        if self.is_loaded:"}],"source_content_type":"text/x-python","patch_set":24,"id":"df3967d1_74c39939","line":47,"range":{"start_line":44,"start_character":3,"end_line":47,"end_character":21},"in_reply_to":"df3967d1_c13a9396","updated":"2017-08-03 02:53:57.000000000","message":"IMO, Less config knobs are better. Operators no need to specify which logging drivers will be loaded in logging plugin, and no worry about compatible of the configuration. Does that make sense to you?","commit_id":"c6d2fe1784090020ac438eba2faf96ce0dfeda84"}],"neutron/services/logapi/drivers/manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"840198d418994b40f95cc75a3bbab97ffcfa1aad","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            new_log_types \u003d log_types \u0026 set(driver.supported_logging_types)"},{"line_number":56,"context_line":"            dropped_log_types \u003d log_types - new_log_types"},{"line_number":57,"context_line":"            if dropped_log_types:"},{"line_number":58,"context_line":"                LOG.debug(\"%(log_types)s log types disabled \""}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_7e854106","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":75},"updated":"2017-07-19 12:01:19.000000000","message":"qos folks seem to regret this semantics.  is this ok for you?","commit_id":"63c4e16b0f002031bb4a1b4ded14d3ec191c4be3"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"a128993b32490833cc5e45eca4582f1c95438d81","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            new_log_types \u003d log_types \u0026 set(driver.supported_logging_types)"},{"line_number":56,"context_line":"            dropped_log_types \u003d log_types - new_log_types"},{"line_number":57,"context_line":"            if dropped_log_types:"},{"line_number":58,"context_line":"                LOG.debug(\"%(log_types)s log types disabled \""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_f6b49f37","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":75},"in_reply_to":"1f1a1f67_7e854106","updated":"2017-07-24 02:46:25.000000000","message":"Basically, It\u0027s OK for me at the moment. However, I\u0027m not sure it\u0027s OK for you and others. So if you have any idea, feel free present it in here.","commit_id":"63c4e16b0f002031bb4a1b4ded14d3ec191c4be3"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"03126732968a836e9d2da11bf16aff5a477e1689","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            new_log_types \u003d log_types \u0026 set(driver.supported_logging_types)"},{"line_number":56,"context_line":"            dropped_log_types \u003d log_types - new_log_types"},{"line_number":57,"context_line":"            if dropped_log_types:"},{"line_number":58,"context_line":"                LOG.debug(\"%(log_types)s log types disabled \""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_d6dcfb19","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":75},"in_reply_to":"ff346bd7_56212b4d","updated":"2017-07-24 03:34:42.000000000","message":"Actually, I don\u0027t have much knowledge about this problem. So It\u0027s OK for me too, if this function will be returned a union of set of supported_logging_types of each log_drivers, same as https://review.openstack.org/#/c/461257/ has worked. Do you prefer this way?","commit_id":"63c4e16b0f002031bb4a1b4ded14d3ec191c4be3"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"30a3ec482797a607c83fa884031d2dec1214649a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            new_log_types \u003d log_types \u0026 set(driver.supported_logging_types)"},{"line_number":56,"context_line":"            dropped_log_types \u003d log_types - new_log_types"},{"line_number":57,"context_line":"            if dropped_log_types:"},{"line_number":58,"context_line":"                LOG.debug(\"%(log_types)s log types disabled \""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_aef7dbf5","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":75},"in_reply_to":"ff346bd7_d6dcfb19","updated":"2017-07-24 07:00:14.000000000","message":"Both semantics are OK for me at the moment. However, after I went though your references. I think, it should be followed\nhttps://review.openstack.org/#/c/461257/. So, we no need a new api to explore all logging types supported. What do you think?","commit_id":"63c4e16b0f002031bb4a1b4ded14d3ec191c4be3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"367d8672080cb44c15830e91dbb25bd2266ebb89","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Recalculate on every call to allow drivers determine supported"},{"line_number":53,"context_line":"        # logging types dynamically"},{"line_number":54,"context_line":"        for driver in self._drivers:"},{"line_number":55,"context_line":"            new_log_types \u003d log_types \u0026 set(driver.supported_logging_types)"},{"line_number":56,"context_line":"            dropped_log_types \u003d log_types - new_log_types"},{"line_number":57,"context_line":"            if dropped_log_types:"},{"line_number":58,"context_line":"                LOG.debug(\"%(log_types)s log types disabled \""}],"source_content_type":"text/x-python","patch_set":17,"id":"ff346bd7_56212b4d","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":75},"in_reply_to":"ff346bd7_f6b49f37","updated":"2017-07-24 03:05:27.000000000","message":"if it\u0027s ok for you, i don\u0027t have strong opinions either ways.\n\nsee https://review.openstack.org/#/c/461257/ and the referenced bug for the corresponding qos change.","commit_id":"63c4e16b0f002031bb4a1b4ded14d3ec191c4be3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"26544a72b93e83f9c889dec2af20f7c58049177f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"},{"line_number":46,"context_line":"    def supported_logging_types(self):"},{"line_number":47,"context_line":"        if not self._drivers:"},{"line_number":48,"context_line":"            return []"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log_types \u003d set()"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_e58699b9","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":21},"updated":"2017-07-27 11:05:32.000000000","message":"i guess this should return set().\ni don\u0027t think this special case is useful.","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b1ba3d6f01397e911c843cc898fb9d4b27d36e66","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @property"},{"line_number":46,"context_line":"    def supported_logging_types(self):"},{"line_number":47,"context_line":"        if not self._drivers:"},{"line_number":48,"context_line":"            return []"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log_types \u003d set()"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_1ed32ed7","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":21},"in_reply_to":"ff346bd7_e58699b9","updated":"2017-07-27 12:45:08.000000000","message":"Done","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6a75798cb153fc85b4d206180a7420b5d1d70d78","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        for driver in self._drivers:"},{"line_number":53,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":54,"context_line":"        LOG.debug(\"Supported logging types (logging types supported\""},{"line_number":55,"context_line":"                  \"by at least once loaded log_driver): %s\"), log_types"},{"line_number":56,"context_line":"        return log_types"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_603f9325","line":54,"range":{"start_line":54,"start_character":58,"end_line":54,"end_character":68},"updated":"2017-07-25 09:21:44.000000000","message":"missing space","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"055700d4e97d6a2a0e91f620cd6a8b2c80eddef5","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        for driver in self._drivers:"},{"line_number":53,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":54,"context_line":"        LOG.debug(\"Supported logging types (logging types supported\""},{"line_number":55,"context_line":"                  \"by at least once loaded log_driver): %s\"), log_types"},{"line_number":56,"context_line":"        return log_types"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_d70ca73c","line":54,"range":{"start_line":54,"start_character":58,"end_line":54,"end_character":68},"in_reply_to":"ff346bd7_603f9325","updated":"2017-07-26 02:09:19.000000000","message":"Can I update it in other patch-set?","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b1ba3d6f01397e911c843cc898fb9d4b27d36e66","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        for driver in self._drivers:"},{"line_number":53,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":54,"context_line":"        LOG.debug(\"Supported logging types (logging types supported\""},{"line_number":55,"context_line":"                  \"by at least once loaded log_driver): %s\"), log_types"},{"line_number":56,"context_line":"        return log_types"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_fe04ea4b","line":54,"range":{"start_line":54,"start_character":58,"end_line":54,"end_character":68},"in_reply_to":"ff346bd7_d70ca73c","updated":"2017-07-27 12:45:08.000000000","message":"Done","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"26544a72b93e83f9c889dec2af20f7c58049177f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        for driver in self._drivers:"},{"line_number":53,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":54,"context_line":"        LOG.debug(\"Supported logging types (logging types supported\""},{"line_number":55,"context_line":"                  \"by at least once loaded log_driver): %s\"), log_types"},{"line_number":56,"context_line":"        return log_types"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_c574b538","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":35},"updated":"2017-07-27 11:05:32.000000000","message":"one?","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b1ba3d6f01397e911c843cc898fb9d4b27d36e66","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        for driver in self._drivers:"},{"line_number":53,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":54,"context_line":"        LOG.debug(\"Supported logging types (logging types supported\""},{"line_number":55,"context_line":"                  \"by at least once loaded log_driver): %s\"), log_types"},{"line_number":56,"context_line":"        return log_types"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_de01263a","line":55,"range":{"start_line":55,"start_character":31,"end_line":55,"end_character":35},"in_reply_to":"ff346bd7_c574b538","updated":"2017-07-27 12:45:08.000000000","message":"Done","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class LoggingServiceDriverManager(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        self._drivers \u003d []"},{"line_number":32,"context_line":"        registry.notify(log_const.LOGGING_PLUGIN, events.AFTER_INIT, self)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_93e68016","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":26},"updated":"2017-07-31 09:23:18.000000000","message":"nit: Is self._drivers an order list? If not, it looks better to use set() instead. You can avoid registering duplicated entries at L.43 below.","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class LoggingServiceDriverManager(object):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self):"},{"line_number":31,"context_line":"        self._drivers \u003d []"},{"line_number":32,"context_line":"        registry.notify(log_const.LOGGING_PLUGIN, events.AFTER_INIT, self)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_69ab0d89","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":26},"in_reply_to":"df3967d1_93e68016","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        for driver in self._drivers:"},{"line_number":53,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":54,"context_line":"        LOG.debug(\"Supported logging types (logging types supported \""},{"line_number":55,"context_line":"                  \"by at least one loaded log_driver): %s\"), log_types"},{"line_number":56,"context_line":"        return log_types"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_b313c40d","line":55,"range":{"start_line":55,"start_character":57,"end_line":55,"end_character":70},"updated":"2017-07-31 09:23:18.000000000","message":"wrong comma and closing parenthesis?","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        for driver in self._drivers:"},{"line_number":53,"context_line":"            log_types |\u003d set(driver.supported_logging_types)"},{"line_number":54,"context_line":"        LOG.debug(\"Supported logging types (logging types supported \""},{"line_number":55,"context_line":"                  \"by at least one loaded log_driver): %s\"), log_types"},{"line_number":56,"context_line":"        return log_types"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_49ae0999","line":55,"range":{"start_line":55,"start_character":57,"end_line":55,"end_character":70},"in_reply_to":"df3967d1_b313c40d","updated":"2017-08-01 04:24:08.000000000","message":"Done! Thanks.","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"32db2a2a371d8e11c8b2392c3cdfb0466a35fc70","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"SKIPPED_VIF_TYPES \u003d ["},{"line_number":26,"context_line":"    portbindings.VIF_TYPE_UNBOUND,"},{"line_number":27,"context_line":"    portbindings.VIF_TYPE_BINDING_FAILED"},{"line_number":28,"context_line":"]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class LoggingServiceDriverManager(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_f802653e","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":1},"updated":"2017-08-08 04:23:18.000000000","message":"where is this used?","commit_id":"5166d861981ba2687147031d3ef23885add7e843"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"8f382c76e03e8f728641a411216842db24c7ec5a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"SKIPPED_VIF_TYPES \u003d ["},{"line_number":26,"context_line":"    portbindings.VIF_TYPE_UNBOUND,"},{"line_number":27,"context_line":"    portbindings.VIF_TYPE_BINDING_FAILED"},{"line_number":28,"context_line":"]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class LoggingServiceDriverManager(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f436f4f_a35f120d","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":1},"in_reply_to":"9f436f4f_f802653e","updated":"2017-08-08 04:43:07.000000000","message":"It should be removed.Done!","commit_id":"5166d861981ba2687147031d3ef23885add7e843"}],"neutron/services/logapi/logging_plugin.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"26544a72b93e83f9c889dec2af20f7c58049177f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        log_data \u003d log[\u0027log\u0027]"},{"line_number":67,"context_line":"        resource_type \u003d log_data[\u0027resource_type\u0027]"},{"line_number":68,"context_line":"        if resource_type not in self.supported_logging_types:"},{"line_number":69,"context_line":"            raise log_exc.InvalidLogReosurceType("},{"line_number":70,"context_line":"                resource_type\u003dresource_type)"},{"line_number":71,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":72,"context_line":"            # body \u0027log\u0027 contains both tenant_id and project_id"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_05263dcf","line":69,"range":{"start_line":69,"start_character":36,"end_line":69,"end_character":44},"updated":"2017-07-27 11:05:32.000000000","message":"this name seems to contain a typo.","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b1ba3d6f01397e911c843cc898fb9d4b27d36e66","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        log_data \u003d log[\u0027log\u0027]"},{"line_number":67,"context_line":"        resource_type \u003d log_data[\u0027resource_type\u0027]"},{"line_number":68,"context_line":"        if resource_type not in self.supported_logging_types:"},{"line_number":69,"context_line":"            raise log_exc.InvalidLogReosurceType("},{"line_number":70,"context_line":"                resource_type\u003dresource_type)"},{"line_number":71,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":72,"context_line":"            # body \u0027log\u0027 contains both tenant_id and project_id"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_3e9cb20c","line":69,"range":{"start_line":69,"start_character":36,"end_line":69,"end_character":44},"in_reply_to":"ff346bd7_05263dcf","updated":"2017-07-27 12:45:08.000000000","message":"Done","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"07f1090acb25cbb98bf853ee6fd8b1a77b5b5faf","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @property"},{"line_number":38,"context_line":"    def supported_logging_types(self):"},{"line_number":39,"context_line":"        # supported_logging_types will dynamic load from log_drivers"},{"line_number":40,"context_line":"        return self.driver_manager.supported_logging_types"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @db_base_plugin_common.filter_fields"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff346bd7_cb1f0206","line":39,"updated":"2017-07-28 08:40:05.000000000","message":"will be dynamically loaded?\nwill be set?","commit_id":"c5baa98074582ab0c901e082c14d51b39ff3e55e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @property"},{"line_number":38,"context_line":"    def supported_logging_types(self):"},{"line_number":39,"context_line":"        # supported_logging_types will be dynamically loaded from log_drivers"},{"line_number":40,"context_line":"        return self.driver_manager.supported_logging_types"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @db_base_plugin_common.filter_fields"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_f3a5ccb6","line":39,"range":{"start_line":39,"start_character":34,"end_line":39,"end_character":41},"updated":"2017-07-31 09:23:18.000000000","message":"-\u003e are ?","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @property"},{"line_number":38,"context_line":"    def supported_logging_types(self):"},{"line_number":39,"context_line":"        # supported_logging_types will be dynamically loaded from log_drivers"},{"line_number":40,"context_line":"        return self.driver_manager.supported_logging_types"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @db_base_plugin_common.filter_fields"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_0990014e","line":39,"range":{"start_line":39,"start_character":34,"end_line":39,"end_character":41},"in_reply_to":"df3967d1_f3a5ccb6","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"}],"neutron/tests/unit/services/logapi/drivers/test_base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"26544a72b93e83f9c889dec2af20f7c58049177f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # test support \u0027security_group\u0027"},{"line_number":56,"context_line":"        self.assertTrue("},{"line_number":57,"context_line":"            self.driver.is_logging_type_supported(\u0027security_group\u0027))"},{"line_number":58,"context_line":"        # test not support\u0027firewall\u0027"},{"line_number":59,"context_line":"        self.assertFalse(self.driver.is_logging_type_supported(\u0027firewall\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_c5c27534","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":27},"updated":"2017-07-27 11:05:32.000000000","message":"a missing space","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b1ba3d6f01397e911c843cc898fb9d4b27d36e66","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # test support \u0027security_group\u0027"},{"line_number":56,"context_line":"        self.assertTrue("},{"line_number":57,"context_line":"            self.driver.is_logging_type_supported(\u0027security_group\u0027))"},{"line_number":58,"context_line":"        # test not support\u0027firewall\u0027"},{"line_number":59,"context_line":"        self.assertFalse(self.driver.is_logging_type_supported(\u0027firewall\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_be8f82cb","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":27},"in_reply_to":"ff346bd7_c5c27534","updated":"2017-07-27 12:45:08.000000000","message":"Done","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_f3bcacbc","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2017-07-31 09:23:18.000000000","message":"This line looks unnecessary. I think this sentence has no meaning unless a copyright holder is written.","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2af309f27c5ae37bab24e534d4ace53e766356fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_9c3f5f24","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"df3967d1_e99edd61","updated":"2017-08-02 12:04:38.000000000","message":"I see the  similar ones in other files. Could you clean up all?","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_e99edd61","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"df3967d1_f3bcacbc","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            self.driver.is_vnic_compatible(portbindings.VNIC_NORMAL))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_is_logging_type_supported(self):"},{"line_number":55,"context_line":"        # test support \u0027security_group\u0027"},{"line_number":56,"context_line":"        self.assertTrue("},{"line_number":57,"context_line":"            self.driver.is_logging_type_supported(\u0027security_group\u0027))"},{"line_number":58,"context_line":"        # test not support \u0027firewall\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_93556053","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":39},"updated":"2017-07-31 09:23:18.000000000","message":"Is this comment needed?","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            self.driver.is_vnic_compatible(portbindings.VNIC_NORMAL))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_is_logging_type_supported(self):"},{"line_number":55,"context_line":"        # test support \u0027security_group\u0027"},{"line_number":56,"context_line":"        self.assertTrue("},{"line_number":57,"context_line":"            self.driver.is_logging_type_supported(\u0027security_group\u0027))"},{"line_number":58,"context_line":"        # test not support \u0027firewall\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_c999d979","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":39},"in_reply_to":"df3967d1_93556053","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"}],"neutron/tests/unit/services/logapi/drivers/test_manager.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"26544a72b93e83f9c889dec2af20f7c58049177f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Test calls happen to all drivers\"\"\""},{"line_number":44,"context_line":"    def test_driver_manager_empty_with_no_drivers(self):"},{"line_number":45,"context_line":"        driver_manager \u003d self._create_manager_with_drivers({})"},{"line_number":46,"context_line":"        self.assertEqual(len(driver_manager._drivers), 0)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_driver_manager_empty_with_no_loaded_drivers(self):"},{"line_number":49,"context_line":"        driver_manager \u003d self._create_manager_with_drivers("}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_68d8407a","line":46,"range":{"start_line":46,"start_character":44,"end_line":46,"end_character":52},"updated":"2017-07-27 11:05:32.000000000","message":"why don\u0027t you use \"drivers\" property?","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"b1ba3d6f01397e911c843cc898fb9d4b27d36e66","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Test calls happen to all drivers\"\"\""},{"line_number":44,"context_line":"    def test_driver_manager_empty_with_no_drivers(self):"},{"line_number":45,"context_line":"        driver_manager \u003d self._create_manager_with_drivers({})"},{"line_number":46,"context_line":"        self.assertEqual(len(driver_manager._drivers), 0)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_driver_manager_empty_with_no_loaded_drivers(self):"},{"line_number":49,"context_line":"        driver_manager \u003d self._create_manager_with_drivers("}],"source_content_type":"text/x-python","patch_set":19,"id":"ff346bd7_5ec416f5","line":46,"range":{"start_line":46,"start_character":44,"end_line":46,"end_character":52},"in_reply_to":"ff346bd7_68d8407a","updated":"2017-07-27 12:45:08.000000000","message":"Done","commit_id":"33b58a3809c68e5f3ded8424ff68d06c2437722a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b653cce08d2f2c9570717d13a257a8c80cbe1f74","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Test calls happen to all drivers\"\"\""},{"line_number":44,"context_line":"    def test_driver_manager_empty_with_no_drivers(self):"},{"line_number":45,"context_line":"        driver_manager \u003d self._create_manager_with_drivers({})"},{"line_number":46,"context_line":"        self.assertEqual(len(driver_manager.drivers), 0)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_driver_manager_empty_with_no_loaded_drivers(self):"},{"line_number":49,"context_line":"        driver_manager \u003d self._create_manager_with_drivers("}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_d66f56c3","line":46,"range":{"start_line":46,"start_character":25,"end_line":46,"end_character":56},"updated":"2017-07-31 09:23:18.000000000","message":"The suggested order of arguments is (expected, actual).","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"92e8edccd5008b839efcc11f47738187456a69dc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \"\"\"Test calls happen to all drivers\"\"\""},{"line_number":44,"context_line":"    def test_driver_manager_empty_with_no_drivers(self):"},{"line_number":45,"context_line":"        driver_manager \u003d self._create_manager_with_drivers({})"},{"line_number":46,"context_line":"        self.assertEqual(len(driver_manager.drivers), 0)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_driver_manager_empty_with_no_loaded_drivers(self):"},{"line_number":49,"context_line":"        driver_manager \u003d self._create_manager_with_drivers("}],"source_content_type":"text/x-python","patch_set":22,"id":"df3967d1_a98a1518","line":46,"range":{"start_line":46,"start_character":25,"end_line":46,"end_character":56},"in_reply_to":"df3967d1_d66f56c3","updated":"2017-08-01 04:24:08.000000000","message":"Done","commit_id":"d47c308e1a0813325dcb1cdc1852a8010b248b46"}]}
