)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b37fda7970599372f395655b117af2e22345f7e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"for off-link subnets."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I88e1c574bc429dc599ad7c956c03fa0688338186"},{"line_number":15,"context_line":"Partial-Bug: 1692486"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df140735_f2b9eecb","line":15,"updated":"2017-06-01 19:46:41.000000000","message":"Closes-Bug ?","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c21cbe32da7b198258cc1608d25ee8d762402ef3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"for off-link subnets."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I88e1c574bc429dc599ad7c956c03fa0688338186"},{"line_number":15,"context_line":"Partial-Bug: 1692486"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df140735_b4f8eb7a","line":15,"in_reply_to":"df140735_f2b9eecb","updated":"2017-06-02 11:49:49.000000000","message":"Done","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"159f6dbe603f879d33437caee1da73b15333fea1","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            return"},{"line_number":336,"context_line":"        # NOTE(kevinbenton): we don\u0027t exclude dhcp disabled subnets because"},{"line_number":337,"context_line":"        # they still change the indexes used for tags"},{"line_number":338,"context_line":"        old_non_local_subnets \u003d getattr(old_network, \u0027non_local_subnets\u0027, [])"},{"line_number":339,"context_line":"        new_non_local_subnets \u003d getattr(network, \u0027non_local_subnets\u0027, [])"},{"line_number":340,"context_line":"        old_cidrs \u003d [s.cidr for s in (old_network.subnets +"},{"line_number":341,"context_line":"                                      old_non_local_subnets)]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_1c4f8493","line":338,"updated":"2017-06-17 07:55:02.000000000","message":"getattr doesn\u0027t seem necessary here. the server is always upgraded first so we can always count on this field being present.","commit_id":"5de66135e597545002ed845768cecf66913a9d62"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b37fda7970599372f395655b117af2e22345f7e","unresolved":false,"context_lines":[{"line_number":869,"context_line":"            subnet_to_interface_ip \u003d self._make_subnet_interface_ip_map()"},{"line_number":870,"context_line":"        isolated_subnets \u003d self.get_isolated_subnets(self.network)"},{"line_number":871,"context_line":"        for i, subnet in enumerate(self.network.subnets +"},{"line_number":872,"context_line":"                                   self.network.non_local_subnets):"},{"line_number":873,"context_line":"            addr_mode \u003d getattr(subnet, \u0027ipv6_address_mode\u0027, None)"},{"line_number":874,"context_line":"            segment_id \u003d getattr(subnet, \u0027segment_id\u0027, None)"},{"line_number":875,"context_line":"            if (not subnet.enable_dhcp or"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_f22c4e03","line":872,"updated":"2017-06-01 19:46:41.000000000","message":"I think this will cause an issue for out-of-tree drivers, similar to what happened when I added segment_id below, think we\u0027ll need to see if the attribute is present.","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c21cbe32da7b198258cc1608d25ee8d762402ef3","unresolved":false,"context_lines":[{"line_number":869,"context_line":"            subnet_to_interface_ip \u003d self._make_subnet_interface_ip_map()"},{"line_number":870,"context_line":"        isolated_subnets \u003d self.get_isolated_subnets(self.network)"},{"line_number":871,"context_line":"        for i, subnet in enumerate(self.network.subnets +"},{"line_number":872,"context_line":"                                   self.network.non_local_subnets):"},{"line_number":873,"context_line":"            addr_mode \u003d getattr(subnet, \u0027ipv6_address_mode\u0027, None)"},{"line_number":874,"context_line":"            segment_id \u003d getattr(subnet, \u0027segment_id\u0027, None)"},{"line_number":875,"context_line":"            if (not subnet.enable_dhcp or"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_ac8ae5bb","line":872,"in_reply_to":"df140735_f22c4e03","updated":"2017-06-02 11:49:49.000000000","message":"Done","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"66a6a148b1fdff4286dc5d7de3438e52e02979db","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _enable_dhcp(self):"},{"line_number":199,"context_line":"        \"\"\"check if there is a subnet within the network with dhcp enabled.\"\"\""},{"line_number":200,"context_line":"        for subnet in self.network.subnets:"},{"line_number":201,"context_line":"            if subnet.enable_dhcp:"},{"line_number":202,"context_line":"                return True"},{"line_number":203,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_6ef1526b","line":200,"updated":"2017-06-02 19:06:56.000000000","message":"Does this also need a similar change?  For example, if there are only non-local subnets.  Should add a test as well.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"773917f09e302453a2159e11a36ff2c01743bfe8","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _enable_dhcp(self):"},{"line_number":199,"context_line":"        \"\"\"check if there is a subnet within the network with dhcp enabled.\"\"\""},{"line_number":200,"context_line":"        for subnet in self.network.subnets:"},{"line_number":201,"context_line":"            if subnet.enable_dhcp:"},{"line_number":202,"context_line":"                return True"},{"line_number":203,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_4637814e","line":200,"in_reply_to":"df140735_027f4715","updated":"2017-06-04 12:05:28.000000000","message":"The change does not break anything since there is logic in agent.py that ensures the driver is only called to enable dhcp on the network if a local subnet have DHCP enabled.\n\nneutron/agent/dhcp/agent.py\n290     def configure_dhcp_for_network(self, network):\n291         if not network.admin_state_up:\n292             return\n293 \n294         for subnet in network.subnets:\n295             if subnet.enable_dhcp:\n296                 if self.call_driver(\u0027enable\u0027, network):\n\n\n\nIf I was to add non_local_subnets in configure_dhcp_for_network() function the result is a HostNotConnectedToAnySegment Exception. \n\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent [req-514921fc-db73-4812-bf43-298949b9e6d9 - - - - -] Unable to enable dhcp for 8bbe074b-85fa-44a9-b252-43ef3c8cf1ef.\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent Traceback (most recent call last):\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/agent/dhcp/agent.py\", line 142, in call_driver\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     getattr(driver, action)(**action_kwargs)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/agent/linux/dhcp.py\", line 218, in enable\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     interface_name \u003d self.device_manager.setup(self.network)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/agent/linux/dhcp.py\", line 1399, in setup\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     self._cleanup_stale_devices(network, dhcp_port\u003dNone)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/oslo_utils/excutils.py\", line 220, in __exit__\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     self.force_reraise()\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/oslo_utils/excutils.py\", line 196, in force_reraise\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     six.reraise(self.type_, self.value, self.tb)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/agent/linux/dhcp.py\", line 1394, in setup\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     port \u003d self.setup_dhcp_port(network)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/agent/linux/dhcp.py\", line 1322, in setup_dhcp_port\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     dhcp_port \u003d setup_method(network, device_id, dhcp_subnets)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/agent/linux/dhcp.py\", line 1301, in _setup_new_dhcp_port\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     return self.plugin.create_dhcp_port({\u0027port\u0027: port_dict})\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/agent/dhcp/agent.py\", line 581, in create_dhcp_port\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     port\u003dport, host\u003dself.host)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/neutron/common/rpc.py\", line 151, in call\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     return self._original_context.call(ctxt, method, **kwargs)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/oslo_messaging/rpc/client.py\", line 169, in call\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     retry\u003dself.retry)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/oslo_messaging/transport.py\", line 98, in _send\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     timeout\u003dtimeout, retry\u003dretry)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py\", line 505, in send\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     retry\u003dretry)\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent   File \"/usr/lib/python2.7/site-packages/oslo_messaging/_drivers/amqpdriver.py\", line 496, in _send\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent     raise result\n2017-06-04 14:00:28.457 13871 ERROR neutron.agent.dhcp.agent RemoteError: Remote error: HostNotConnectedToAnySegment Host ocataleafs.lab.example.com is not connected to any segments on routed provider network \u00278bbe074b-85fa-44a9-b252-43ef3c8cf1ef\u0027.  It should be connected to one.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"995e83f2999d12b86b5fd317a9a53aa8041c74b6","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _enable_dhcp(self):"},{"line_number":199,"context_line":"        \"\"\"check if there is a subnet within the network with dhcp enabled.\"\"\""},{"line_number":200,"context_line":"        for subnet in self.network.subnets:"},{"line_number":201,"context_line":"            if subnet.enable_dhcp:"},{"line_number":202,"context_line":"                return True"},{"line_number":203,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_027f4715","line":200,"in_reply_to":"df140735_42065f1e","updated":"2017-06-02 20:27:47.000000000","message":"Oh, so unless we have at least one local subnet, don\u0027t start DHCP?  If the change I made causes a failure I\u0027m fine removing it.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4dbf1c20a33c7a6018a9226fc6f413f1ff5d9557","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _enable_dhcp(self):"},{"line_number":199,"context_line":"        \"\"\"check if there is a subnet within the network with dhcp enabled.\"\"\""},{"line_number":200,"context_line":"        for subnet in self.network.subnets:"},{"line_number":201,"context_line":"            if subnet.enable_dhcp:"},{"line_number":202,"context_line":"                return True"},{"line_number":203,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_d3d8de53","line":200,"in_reply_to":"df140735_4637814e","updated":"2017-06-05 14:53:08.000000000","message":"So I guess we should un-do this change to match the agent.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c34caa1d74b89729d9748f3a1f7529afb6f03a06","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _enable_dhcp(self):"},{"line_number":199,"context_line":"        \"\"\"check if there is a subnet within the network with dhcp enabled.\"\"\""},{"line_number":200,"context_line":"        for subnet in self.network.subnets:"},{"line_number":201,"context_line":"            if subnet.enable_dhcp:"},{"line_number":202,"context_line":"                return True"},{"line_number":203,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_42065f1e","line":200,"in_reply_to":"df140735_6ef1526b","updated":"2017-06-02 20:10:59.000000000","message":"My reason to leave this out is that unless we have a local subnet with dhcp, we do not have any ip to bind to an interface in the namespace?","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"66a6a148b1fdff4286dc5d7de3438e52e02979db","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        )"},{"line_number":564,"context_line":"        \"\"\""},{"line_number":565,"context_line":"        v6_nets \u003d dict((subnet.id, subnet) for subnet in"},{"line_number":566,"context_line":"                       self.network.subnets if subnet.ip_version \u003d\u003d 6)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"        for port in self.network.ports:"},{"line_number":569,"context_line":"            fixed_ips \u003d self._sort_fixed_ips_for_dnsmasq(port.fixed_ips,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_6ebf1261","line":566,"updated":"2017-06-02 19:06:56.000000000","message":"Here too.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"66a6a148b1fdff4286dc5d7de3438e52e02979db","unresolved":false,"context_lines":[{"line_number":626,"context_line":"            timestamp \u003d 0"},{"line_number":627,"context_line":"        else:"},{"line_number":628,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration"},{"line_number":629,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"},{"line_number":630,"context_line":"                                   if s.enable_dhcp]"},{"line_number":631,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":632,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_8ea5c649","line":629,"updated":"2017-06-02 19:06:56.000000000","message":"And here.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c34caa1d74b89729d9748f3a1f7529afb6f03a06","unresolved":false,"context_lines":[{"line_number":626,"context_line":"            timestamp \u003d 0"},{"line_number":627,"context_line":"        else:"},{"line_number":628,"context_line":"            timestamp \u003d int(time.time()) + self.conf.dhcp_lease_duration"},{"line_number":629,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"},{"line_number":630,"context_line":"                                   if s.enable_dhcp]"},{"line_number":631,"context_line":"        for host_tuple in self._iter_hosts():"},{"line_number":632,"context_line":"            port, alloc, hostname, name, no_dhcp, no_opts \u003d host_tuple"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_6253a318","line":629,"in_reply_to":"df140735_8ea5c649","updated":"2017-06-02 20:10:59.000000000","message":"+1","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"66a6a148b1fdff4286dc5d7de3438e52e02979db","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        filename \u003d self.get_conf_file_name(\u0027host\u0027)"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"        LOG.debug(\u0027Building host file: %s\u0027, filename)"},{"line_number":678,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"},{"line_number":679,"context_line":"                                   if s.enable_dhcp]"},{"line_number":680,"context_line":"        # NOTE(ihrachyshka): the loop should not log anything inside it, to"},{"line_number":681,"context_line":"        # avoid potential performance drop when lots of hosts are dumped"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_ae7d2ab3","line":678,"updated":"2017-06-02 19:06:56.000000000","message":"And here.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"66a6a148b1fdff4286dc5d7de3438e52e02979db","unresolved":false,"context_lines":[{"line_number":917,"context_line":"                )"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":920,"context_line":"                for s in self.network.subnets:"},{"line_number":921,"context_line":"                    sub_segment_id \u003d getattr(s, \u0027segment_id\u0027, None)"},{"line_number":922,"context_line":"                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":923,"context_line":"                            s.cidr !\u003d subnet.cidr and"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_8e538639","line":920,"updated":"2017-06-02 19:06:56.000000000","message":"We *don\u0027t* need to here.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"773917f09e302453a2159e11a36ff2c01743bfe8","unresolved":false,"context_lines":[{"line_number":917,"context_line":"                )"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":920,"context_line":"                for s in self.network.subnets:"},{"line_number":921,"context_line":"                    sub_segment_id \u003d getattr(s, \u0027segment_id\u0027, None)"},{"line_number":922,"context_line":"                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":923,"context_line":"                            s.cidr !\u003d subnet.cidr and"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_e6ffb5a8","line":920,"in_reply_to":"df140735_8e538639","updated":"2017-06-04 12:05:28.000000000","message":"Why not?\nWe should add on-link route to non_local_subnets with the same segment_id?","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4dbf1c20a33c7a6018a9226fc6f413f1ff5d9557","unresolved":false,"context_lines":[{"line_number":917,"context_line":"                )"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":920,"context_line":"                for s in self.network.subnets:"},{"line_number":921,"context_line":"                    sub_segment_id \u003d getattr(s, \u0027segment_id\u0027, None)"},{"line_number":922,"context_line":"                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":923,"context_line":"                            s.cidr !\u003d subnet.cidr and"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_6e6c85cd","line":920,"in_reply_to":"df140735_e6ffb5a8","updated":"2017-06-05 14:53:08.000000000","message":"Yes, I must have been looking at this from the agent point of view, but from the client view the non-local subnet could be on the same segment.","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"66a6a148b1fdff4286dc5d7de3438e52e02979db","unresolved":false,"context_lines":[{"line_number":1299,"context_line":"        # The ID that the DHCP port will have (or already has)."},{"line_number":1300,"context_line":"        device_id \u003d self.get_device_id(network)"},{"line_number":1301,"context_line":""},{"line_number":1302,"context_line":"        # Get the set of DHCP-enabled subnets on this network."},{"line_number":1303,"context_line":"        dhcp_subnets \u003d {subnet.id: subnet for subnet in network.subnets"},{"line_number":1304,"context_line":"                        if subnet.enable_dhcp}"},{"line_number":1305,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_2e111a5e","line":1302,"updated":"2017-06-02 19:06:56.000000000","message":"Should probably add \"local\" to this sentence","commit_id":"c26b861a53945fa2ed712401256d0c08a9e7d1ce"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b37fda7970599372f395655b117af2e22345f7e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                             tenant_id\u003dFAKE_TENANT_ID,"},{"line_number":152,"context_line":"                             admin_state_up\u003dTrue,"},{"line_number":153,"context_line":"                             subnets\u003d[fake_subnet1, fake_subnet2],"},{"line_number":154,"context_line":"                             non_local_subnets\u003d[],"},{"line_number":155,"context_line":"                             ports\u003d[fake_port1]))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"fake_network_ipv6 \u003d dhcp.NetModel(dict(id\u003dFAKE_NETWORK_UUID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_f2156e9d","line":154,"updated":"2017-06-01 19:46:41.000000000","message":"With the change I mentioned in the agent none of these would be necessary, it would just notice the attribute was not present.","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c21cbe32da7b198258cc1608d25ee8d762402ef3","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                             tenant_id\u003dFAKE_TENANT_ID,"},{"line_number":152,"context_line":"                             admin_state_up\u003dTrue,"},{"line_number":153,"context_line":"                             subnets\u003d[fake_subnet1, fake_subnet2],"},{"line_number":154,"context_line":"                             non_local_subnets\u003d[],"},{"line_number":155,"context_line":"                             ports\u003d[fake_port1]))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"fake_network_ipv6 \u003d dhcp.NetModel(dict(id\u003dFAKE_NETWORK_UUID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_c0d95df3","line":154,"in_reply_to":"df140735_f2156e9d","updated":"2017-06-02 11:49:49.000000000","message":"Done","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"80727d79a4fd09d80e26f181a64bea433f46827f","unresolved":false,"context_lines":[{"line_number":1577,"context_line":"            \u0027tag:tag0,option:router,192.168.0.1\\n\u0027"},{"line_number":1578,"context_line":"            \u0027tag:tag1,option:dns-server,8.8.8.8\\n\u0027"},{"line_number":1579,"context_line":"            \u0027tag:tag1,option:classless-static-route,169.254.169.254/32,\u0027"},{"line_number":1580,"context_line":"            \u0027192.168.2.1,192.168.0.0/24,0.0.0.0,0.0.0.0/0,192.168.2.1\\n\u0027"},{"line_number":1581,"context_line":"            \u0027tag:tag1,249,169.254.169.254/32,192.168.2.1,192.168.0.0/24,\u0027"},{"line_number":1582,"context_line":"            \u00270.0.0.0,0.0.0.0/0,192.168.2.1\\ntag:tag1,option:router,192.168.2.1\u0027"},{"line_number":1583,"context_line":"        ).lstrip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_7b3532f7","line":1580,"range":{"start_line":1580,"start_character":25,"end_line":1580,"end_character":47},"updated":"2017-05-29 01:17:54.000000000","message":"This is a link local route. We should\u0027nt see this, I dont see it on my test system. Probably unit test issue.","commit_id":"b4348a8d6d3fa0104ce5123d5e70f717f2030436"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b37fda7970599372f395655b117af2e22345f7e","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    def __init__(self):"},{"line_number":447,"context_line":"        self.id \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":448,"context_line":"        self.subnets \u003d [FakeV4SubnetMultipleAgentsWithoutDnsProvided()]"},{"line_number":449,"context_line":"        self.non_local_subnets \u003d []"},{"line_number":450,"context_line":"        self.ports \u003d [FakePort1(), FakePort2(), FakePort3(), FakeRouterPort(),"},{"line_number":451,"context_line":"                      FakePortMultipleAgents1(), FakePortMultipleAgents2()]"},{"line_number":452,"context_line":"        self.namespace \u003d \u0027qdhcp-ns\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_321f66b8","line":449,"updated":"2017-06-01 19:46:41.000000000","message":"Here too.","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"c21cbe32da7b198258cc1608d25ee8d762402ef3","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    def __init__(self):"},{"line_number":447,"context_line":"        self.id \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":448,"context_line":"        self.subnets \u003d [FakeV4SubnetMultipleAgentsWithoutDnsProvided()]"},{"line_number":449,"context_line":"        self.non_local_subnets \u003d []"},{"line_number":450,"context_line":"        self.ports \u003d [FakePort1(), FakePort2(), FakePort3(), FakeRouterPort(),"},{"line_number":451,"context_line":"                      FakePortMultipleAgents1(), FakePortMultipleAgents2()]"},{"line_number":452,"context_line":"        self.namespace \u003d \u0027qdhcp-ns\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_00d4f5bb","line":449,"in_reply_to":"df140735_321f66b8","updated":"2017-06-02 11:49:49.000000000","message":"Done","commit_id":"9a73a37ccc6d0a615fd87747bcf0bcdea6b2fe3f"}]}
