)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d810171edc404d3c98dfe91d6042affbcff4e959","unresolved":false,"context_lines":[{"line_number":14,"context_line":"[1] https://review.openstack.org/#/c/447150/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I715565627b2446533298b5905edbaa256bd84c92"},{"line_number":17,"context_line":"Closes-Bug: #1694190"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_aa97d790","line":17,"updated":"2017-05-30 07:42:07.000000000","message":"i\u0027m not sure if i agree this closes the bug.\nmy intention to filed the bug was about api semantics.","commit_id":"a808af7ff2ffa4711c7a59b6d530ab9fc6d003eb"}],"neutron/services/qos/drivers/linuxbridge/driver.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5ea6903f282a0d500528bb4398defe56194bc7f9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def create():"},{"line_number":46,"context_line":"        return LinuxBridgeDriver("},{"line_number":47,"context_line":"            name\u003d\u0027linuxbridge\u0027,"},{"line_number":48,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_TAP],"},{"line_number":49,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":50,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":51,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_78e3e106","line":48,"updated":"2017-05-29 22:09:22.000000000","message":"What is this used for? After an upgrade there will be a mix of both types (bridge for ones created before the upgrade and tap for new ones). Do we need to list both types?","commit_id":"cdbaf6c37ceeabaf2d792ba0f540f4566064dbce"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9f99a0f2cbd7ff6ca8aa520e0f0c1b15bcc81395","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def create():"},{"line_number":46,"context_line":"        return LinuxBridgeDriver("},{"line_number":47,"context_line":"            name\u003d\u0027linuxbridge\u0027,"},{"line_number":48,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_TAP],"},{"line_number":49,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":50,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":51,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_d898ad6b","line":48,"in_reply_to":"df140735_389b2973","updated":"2017-05-29 22:24:04.000000000","message":"So as I discussed on IRC with Kevin, it should have both vif_types as supported to not break existing ports with vif_type\u003d\"bridge\"","commit_id":"cdbaf6c37ceeabaf2d792ba0f540f4566064dbce"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"74fdbd5ee68ff6b672266a3638ab5ea6e82cb933","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def create():"},{"line_number":46,"context_line":"        return LinuxBridgeDriver("},{"line_number":47,"context_line":"            name\u003d\u0027linuxbridge\u0027,"},{"line_number":48,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_TAP],"},{"line_number":49,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":50,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":51,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_389b2973","line":48,"in_reply_to":"df140735_78e3e106","updated":"2017-05-29 22:16:10.000000000","message":"it\u0027s used to set list of vif_types which this QoS driver supports. This information is necessary for validation of rules during applying QoS rule to port/network. It\u0027s not set anywhere for old ports.\n\nDrivers using it in https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/base.py#L65\n\nand this method is used in manager:\nhttps://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/manager.py#L78","commit_id":"cdbaf6c37ceeabaf2d792ba0f540f4566064dbce"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f0d49c0de34ad0897295262959a19491cba877f8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def create():"},{"line_number":46,"context_line":"        return LinuxBridgeDriver("},{"line_number":47,"context_line":"            name\u003d\u0027linuxbridge\u0027,"},{"line_number":48,"context_line":"            vif_types\u003d[portbindings.VIF_TYPE_TAP],"},{"line_number":49,"context_line":"            vnic_types\u003d[portbindings.VNIC_NORMAL],"},{"line_number":50,"context_line":"            supported_rules\u003dSUPPORTED_RULES,"},{"line_number":51,"context_line":"            requires_rpc_notifications\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_0f513537","line":48,"in_reply_to":"df140735_d898ad6b","updated":"2017-05-30 07:27:57.000000000","message":"Done","commit_id":"cdbaf6c37ceeabaf2d792ba0f540f4566064dbce"}]}