)]}'
{"neutron/objects/qos/policy.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"359225aadfe174c5a7a20be1523475db7995bf7d","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                                                 db_error\u003de)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def detach_network(self, network_id):"},{"line_number":212,"context_line":"        network_binding_obj \u003d binding.QosPolicyNetworkBinding.get_object("},{"line_number":213,"context_line":"            self.obj_context, network_id\u003dnetwork_id)"},{"line_number":214,"context_line":"        if not network_binding_obj:"},{"line_number":215,"context_line":"            raise exceptions.NetworkQosBindingNotFound(net_id\u003dnetwork_id,"},{"line_number":216,"context_line":"                                                       policy_id\u003dself.id)"},{"line_number":217,"context_line":"        network_binding_obj.delete()"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def detach_port(self, port_id):"},{"line_number":220,"context_line":"        port_binding_obj \u003d binding.QosPolicyPortBinding.get_object("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_00069f87","line":217,"range":{"start_line":212,"start_character":8,"end_line":217,"end_character":36},"updated":"2017-06-08 21:33:24.000000000","message":"since you don\u0027t need the binding object, just call .delete_objects() and raise if result is 0.","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4503f4f1ba88e733472562d6faabd537a979e409","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                                                 db_error\u003de)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def detach_network(self, network_id):"},{"line_number":212,"context_line":"        network_binding_obj \u003d binding.QosPolicyNetworkBinding.get_object("},{"line_number":213,"context_line":"            self.obj_context, network_id\u003dnetwork_id)"},{"line_number":214,"context_line":"        if not network_binding_obj:"},{"line_number":215,"context_line":"            raise exceptions.NetworkQosBindingNotFound(net_id\u003dnetwork_id,"},{"line_number":216,"context_line":"                                                       policy_id\u003dself.id)"},{"line_number":217,"context_line":"        network_binding_obj.delete()"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def detach_port(self, port_id):"},{"line_number":220,"context_line":"        port_binding_obj \u003d binding.QosPolicyPortBinding.get_object("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_46597cfc","line":217,"range":{"start_line":212,"start_character":8,"end_line":217,"end_character":36},"in_reply_to":"bf091321_00069f87","updated":"2017-06-09 11:12:21.000000000","message":"Done","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"359225aadfe174c5a7a20be1523475db7995bf7d","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            return qos_default_policy.qos_policy_id"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def get_bound_networks(self):"},{"line_number":250,"context_line":"        return [nb.network_id for nb in"},{"line_number":251,"context_line":"                binding.QosPolicyNetworkBinding.get_objects(self.obj_context,"},{"line_number":252,"context_line":"                                                            policy_id\u003dself.id)]"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_40f3779f","line":250,"updated":"2017-06-08 21:33:24.000000000","message":"nit: wrapping in the middle of for-statement is not very conventional. Consider:\n\nreturn [\n    nb.network_id\n    for nb in binding....get_objects(...)\n]","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4503f4f1ba88e733472562d6faabd537a979e409","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            return qos_default_policy.qos_policy_id"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def get_bound_networks(self):"},{"line_number":250,"context_line":"        return [nb.network_id for nb in"},{"line_number":251,"context_line":"                binding.QosPolicyNetworkBinding.get_objects(self.obj_context,"},{"line_number":252,"context_line":"                                                            policy_id\u003dself.id)]"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_06f824c2","line":250,"in_reply_to":"bf091321_40f3779f","updated":"2017-06-09 11:12:21.000000000","message":"Done","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5415b4958592905cbd75dea9e900700fab795582","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                                                 db_error\u003de)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def detach_network(self, network_id):"},{"line_number":212,"context_line":"        network_binding_obj \u003d binding.QosPolicyNetworkBinding.delete_objects("},{"line_number":213,"context_line":"            self.obj_context, network_id\u003dnetwork_id)"},{"line_number":214,"context_line":"        if not network_binding_obj:"},{"line_number":215,"context_line":"            raise exceptions.NetworkQosBindingNotFound(net_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_3f6c4b07","line":212,"range":{"start_line":212,"start_character":8,"end_line":212,"end_character":28},"updated":"2017-06-09 17:53:54.000000000","message":"this is a number of records deleted, not objects. Rename into e.g. \u0027deleted\u0027.","commit_id":"30f93d8d54955b5f3bcefb4e2ec6b1a4b69f47ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a3c933501291abc54dcdb2d148f4a4c8a6047769","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                                                 db_error\u003de)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def detach_network(self, network_id):"},{"line_number":212,"context_line":"        network_binding_obj \u003d binding.QosPolicyNetworkBinding.delete_objects("},{"line_number":213,"context_line":"            self.obj_context, network_id\u003dnetwork_id)"},{"line_number":214,"context_line":"        if not network_binding_obj:"},{"line_number":215,"context_line":"            raise exceptions.NetworkQosBindingNotFound(net_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_8a055b7d","line":212,"range":{"start_line":212,"start_character":8,"end_line":212,"end_character":28},"in_reply_to":"7f231b9d_3f6c4b07","updated":"2017-06-09 18:22:04.000000000","message":"Done","commit_id":"30f93d8d54955b5f3bcefb4e2ec6b1a4b69f47ba"}],"neutron/tests/unit/objects/qos/test_binding.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"359225aadfe174c5a7a20be1523475db7995bf7d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    _test_class \u003d binding.QosPolicyNetworkBinding"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _create_test_qos_policy(self, **qos_policy_attrs):"},{"line_number":54,"context_line":"        qos_policy \u003d policy.QosPolicy(self.context, **qos_policy_attrs)"},{"line_number":55,"context_line":"        qos_policy.create()"},{"line_number":56,"context_line":"        return qos_policy"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def setUp(self):"},{"line_number":59,"context_line":"        super(QosPolicyNetworkBindingDbObjectTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_20f08390","line":56,"range":{"start_line":53,"start_character":8,"end_line":56,"end_character":25},"updated":"2017-06-08 21:33:24.000000000","message":"it\u0027s identical to lines 29+. maybe move into a common class (in test_base.py)?","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4503f4f1ba88e733472562d6faabd537a979e409","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    _test_class \u003d binding.QosPolicyNetworkBinding"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _create_test_qos_policy(self, **qos_policy_attrs):"},{"line_number":54,"context_line":"        qos_policy \u003d policy.QosPolicy(self.context, **qos_policy_attrs)"},{"line_number":55,"context_line":"        qos_policy.create()"},{"line_number":56,"context_line":"        return qos_policy"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def setUp(self):"},{"line_number":59,"context_line":"        super(QosPolicyNetworkBindingDbObjectTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_06d024f7","line":56,"range":{"start_line":53,"start_character":8,"end_line":56,"end_character":25},"in_reply_to":"bf091321_20f08390","updated":"2017-06-09 11:12:21.000000000","message":"Yes, you are right. That\u0027s better","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"359225aadfe174c5a7a20be1523475db7995bf7d","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"                        objclass.db_model(**objclass_fields)"},{"line_number":1291,"context_line":"                    ]"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"    def _create_test_network(self, name\u003d\u0027test-network1\u0027, id\u003dNone):"},{"line_number":1294,"context_line":"        id \u003d uuidutils.generate_uuid() if not id else id"},{"line_number":1295,"context_line":"        _network \u003d net_obj.Network(self.context, name\u003dname, id\u003did)"},{"line_number":1296,"context_line":"        _network.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_a01253b0","line":1293,"range":{"start_line":1293,"start_character":56,"end_line":1293,"end_character":59},"updated":"2017-06-08 21:33:24.000000000","message":"id is a keyword in python, so let\u0027s avoid overriding it in the scope of the method. \u0027network_id\u0027 maybe?","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4503f4f1ba88e733472562d6faabd537a979e409","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"                        objclass.db_model(**objclass_fields)"},{"line_number":1291,"context_line":"                    ]"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"    def _create_test_network(self, name\u003d\u0027test-network1\u0027, id\u003dNone):"},{"line_number":1294,"context_line":"        id \u003d uuidutils.generate_uuid() if not id else id"},{"line_number":1295,"context_line":"        _network \u003d net_obj.Network(self.context, name\u003dname, id\u003did)"},{"line_number":1296,"context_line":"        _network.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_51a49408","line":1293,"range":{"start_line":1293,"start_character":56,"end_line":1293,"end_character":59},"in_reply_to":"bf091321_a01253b0","updated":"2017-06-09 11:12:21.000000000","message":"Yes, I always make this kind of mistakes.","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"359225aadfe174c5a7a20be1523475db7995bf7d","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"                    ]"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"    def _create_test_network(self, name\u003d\u0027test-network1\u0027, id\u003dNone):"},{"line_number":1294,"context_line":"        id \u003d uuidutils.generate_uuid() if not id else id"},{"line_number":1295,"context_line":"        _network \u003d net_obj.Network(self.context, name\u003dname, id\u003did)"},{"line_number":1296,"context_line":"        _network.create()"},{"line_number":1297,"context_line":"        return _network"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_204523b4","line":1294,"range":{"start_line":1294,"start_character":42,"end_line":1294,"end_character":48},"updated":"2017-06-08 21:33:24.000000000","message":"(No action required) \u0027if id is None\u0027 would be more explicit considering the default value in 1293.","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4503f4f1ba88e733472562d6faabd537a979e409","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"                    ]"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"    def _create_test_network(self, name\u003d\u0027test-network1\u0027, id\u003dNone):"},{"line_number":1294,"context_line":"        id \u003d uuidutils.generate_uuid() if not id else id"},{"line_number":1295,"context_line":"        _network \u003d net_obj.Network(self.context, name\u003dname, id\u003did)"},{"line_number":1296,"context_line":"        _network.create()"},{"line_number":1297,"context_line":"        return _network"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_acb4b736","line":1294,"range":{"start_line":1294,"start_character":42,"end_line":1294,"end_character":48},"in_reply_to":"bf091321_204523b4","updated":"2017-06-09 11:12:21.000000000","message":"You are right","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"}],"neutron/tests/unit/objects/test_network.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"359225aadfe174c5a7a20be1523475db7995bf7d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            self.context, network_id\u003dobj.id)"},{"line_number":147,"context_line":"        self.assertEqual(qos_binding_obj2.policy_id, obj.qos_policy_id)"},{"line_number":148,"context_line":"        qos_binding_obj \u003d binding.QosPolicyNetworkBinding.get_object("},{"line_number":149,"context_line":"            self.context, network_id\u003dold_policy_id)"},{"line_number":150,"context_line":"        self.assertIsNone(qos_binding_obj)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_dns_domain(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf091321_404ff7bc","line":149,"updated":"2017-06-08 21:33:24.000000000","message":"again, passing qospolicy id as network_id. Of course it can\u0027t find anything in line 150.","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4503f4f1ba88e733472562d6faabd537a979e409","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            self.context, network_id\u003dobj.id)"},{"line_number":147,"context_line":"        self.assertEqual(qos_binding_obj2.policy_id, obj.qos_policy_id)"},{"line_number":148,"context_line":"        qos_binding_obj \u003d binding.QosPolicyNetworkBinding.get_object("},{"line_number":149,"context_line":"            self.context, network_id\u003dold_policy_id)"},{"line_number":150,"context_line":"        self.assertIsNone(qos_binding_obj)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_dns_domain(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f0e0f27_0c972393","line":149,"in_reply_to":"bf091321_404ff7bc","updated":"2017-06-09 11:12:21.000000000","message":"Yes, same mistake","commit_id":"d2d247aead24090da7f2b28d644f8ec27668842b"}]}
