)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6adb78395af0329fd8edaaccab5ac935d93c293f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        # tuple: min,max"},{"line_number":255,"context_line":"        if srcport:"},{"line_number":256,"context_line":"            if len(srcport) \u003d\u003d 2:"},{"line_number":257,"context_line":"                cmd.extend([\u0027srcport\u0027, str(srcport[0]), str(srcport[1])])"},{"line_number":258,"context_line":"            else:"},{"line_number":259,"context_line":"                raise n_exc.NetworkVxlanPortRangeError(vxlan_range\u003dsrcport)"},{"line_number":260,"context_line":"        if dstport:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_77f76df7","line":257,"range":{"start_line":257,"start_character":39,"end_line":257,"end_character":72},"updated":"2017-06-29 20:56:27.000000000","message":"what happens if this is mis-configured an min  \u003e max. Should we handle an exception here?","commit_id":"270cd93dee9f5b16af5aee5a524f1a8546f67f7a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"9ccafed7a01aef2bb9d2a50ecea0538ec4ddc6f5","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        # tuple: min,max"},{"line_number":255,"context_line":"        if srcport:"},{"line_number":256,"context_line":"            if len(srcport) \u003d\u003d 2:"},{"line_number":257,"context_line":"                cmd.extend([\u0027srcport\u0027, str(srcport[0]), str(srcport[1])])"},{"line_number":258,"context_line":"            else:"},{"line_number":259,"context_line":"                raise n_exc.NetworkVxlanPortRangeError(vxlan_range\u003dsrcport)"},{"line_number":260,"context_line":"        if dstport:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_8aa8911f","line":257,"range":{"start_line":257,"start_character":39,"end_line":257,"end_character":72},"in_reply_to":"3f1d235d_77f76df7","updated":"2017-06-30 12:21:22.000000000","message":"Good idea.","commit_id":"270cd93dee9f5b16af5aee5a524f1a8546f67f7a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"113d84ac5e142a9892fe39b6892252d907fc5fbf","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            cmd.append(\u0027proxy\u0027)"},{"line_number":254,"context_line":"        # tuple: min,max"},{"line_number":255,"context_line":"        if srcport:"},{"line_number":256,"context_line":"            if len(srcport) \u003d\u003d 2 and srcport[0] \u003c\u003d srcport[1]:"},{"line_number":257,"context_line":"                cmd.extend([\u0027srcport\u0027, str(srcport[0]), str(srcport[1])])"},{"line_number":258,"context_line":"            else:"},{"line_number":259,"context_line":"                raise n_exc.NetworkVxlanPortRangeError(vxlan_range\u003dsrcport)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_6d6d3231","line":256,"updated":"2017-07-02 08:06:07.000000000","message":"why is this validation not done when the agent starts?","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"e9a4220c11e3d6069ce873a6ee828f5ec059bb69","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            cmd.append(\u0027proxy\u0027)"},{"line_number":254,"context_line":"        # tuple: min,max"},{"line_number":255,"context_line":"        if srcport:"},{"line_number":256,"context_line":"            if len(srcport) \u003d\u003d 2 and srcport[0] \u003c\u003d srcport[1]:"},{"line_number":257,"context_line":"                cmd.extend([\u0027srcport\u0027, str(srcport[0]), str(srcport[1])])"},{"line_number":258,"context_line":"            else:"},{"line_number":259,"context_line":"                raise n_exc.NetworkVxlanPortRangeError(vxlan_range\u003dsrcport)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_c9a66c54","line":256,"in_reply_to":"3f1d235d_6d6d3231","updated":"2017-07-03 08:51:03.000000000","message":"The check was already there like this, I can refactor it, however it doesn\u0027t belong to the bug fixed in the patch.","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"}],"neutron/conf/plugins/ml2/drivers/linuxbridge.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"aeb0e5b53698492f768c244e572251b68dbaa3ce","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""},{"line_number":55,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":56,"context_line":"    cfg.PortOpt(\u0027udp_dstport\u0027,"},{"line_number":57,"context_line":"              help\u003d_(\"The UDP port used for VXLAN communication. By default, \""},{"line_number":58,"context_line":"                     \"the Linux kernel doesn\u0027t use the IANA assigned \""},{"line_number":59,"context_line":"                     \"standard value, so if you want to use it, this option \""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_40ce1763","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":28},"updated":"2017-06-06 08:45:05.000000000","message":"why to do it differently from ovs-agent?","commit_id":"8695b600e4e7186de90b0df12293a6cf508785c9"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"b8334de05d772a55a38ac61fab1fd75ff4dd3241","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""},{"line_number":55,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":56,"context_line":"    cfg.PortOpt(\u0027udp_dstport\u0027,"},{"line_number":57,"context_line":"              help\u003d_(\"The UDP port used for VXLAN communication. By default, \""},{"line_number":58,"context_line":"                     \"the Linux kernel doesn\u0027t use the IANA assigned \""},{"line_number":59,"context_line":"                     \"standard value, so if you want to use it, this option \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_426a6c80","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":28},"in_reply_to":"5f201791_bfbcbb69","updated":"2017-06-21 12:15:07.000000000","message":"I\u0027m open to change it, let\u0027s hear more opinions. But putting src and dst ports to different places is awkward. Also putting some vxlan-related options to [vxlan] and others to [default] is awkward, too, I think.","commit_id":"8695b600e4e7186de90b0df12293a6cf508785c9"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"6a6302910b58d315071880b4cecf6f0f62b3726a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""},{"line_number":55,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":56,"context_line":"    cfg.PortOpt(\u0027udp_dstport\u0027,"},{"line_number":57,"context_line":"              help\u003d_(\"The UDP port used for VXLAN communication. By default, \""},{"line_number":58,"context_line":"                     \"the Linux kernel doesn\u0027t use the IANA assigned \""},{"line_number":59,"context_line":"                     \"standard value, so if you want to use it, this option \""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_5ee5d7da","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":28},"in_reply_to":"df140735_40ce1763","updated":"2017-06-06 10:13:30.000000000","message":"- agent.vxlan_udp_port is defined in conf/plugins/ml2/drivers/ovs_conf.py\n- the OVS agent doesn\u0027t have a VXLAN section, but Linuxbridge has.\n\nThese are my reasons.","commit_id":"8695b600e4e7186de90b0df12293a6cf508785c9"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"a129774fd4efa92a5008e2a8ab1f6fd855893f64","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""},{"line_number":55,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":56,"context_line":"    cfg.PortOpt(\u0027udp_dstport\u0027,"},{"line_number":57,"context_line":"              help\u003d_(\"The UDP port used for VXLAN communication. By default, \""},{"line_number":58,"context_line":"                     \"the Linux kernel doesn\u0027t use the IANA assigned \""},{"line_number":59,"context_line":"                     \"standard value, so if you want to use it, this option \""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_9e648f4b","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":28},"in_reply_to":"df140735_5ee5d7da","updated":"2017-06-06 10:16:25.000000000","message":"+2 reasons:\n- to have it in the same place as srcport\n- OVS and Linuxbridge is not really used in the same cloud installation, so there\u0027s no real confusion during operations.","commit_id":"8695b600e4e7186de90b0df12293a6cf508785c9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"459e587ad24ce668154103dbb2f3fa89d4023287","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""},{"line_number":55,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":56,"context_line":"    cfg.PortOpt(\u0027udp_dstport\u0027,"},{"line_number":57,"context_line":"              help\u003d_(\"The UDP port used for VXLAN communication. By default, \""},{"line_number":58,"context_line":"                     \"the Linux kernel doesn\u0027t use the IANA assigned \""},{"line_number":59,"context_line":"                     \"standard value, so if you want to use it, this option \""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_bfbcbb69","line":56,"range":{"start_line":56,"start_character":17,"end_line":56,"end_character":28},"in_reply_to":"df140735_9e648f4b","updated":"2017-06-21 12:03:42.000000000","message":"i\u0027m not sure if i\u0027m convinced by these reasons. but probably it\u0027s just my preference.","commit_id":"8695b600e4e7186de90b0df12293a6cf508785c9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"113d84ac5e142a9892fe39b6892252d907fc5fbf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                     \"option in the ML2 plug-in configuration file on the \""},{"line_number":49,"context_line":"                     \"neutron server node(s).\")),"},{"line_number":50,"context_line":"    cfg.PortOpt(\u0027udp_srcport_min\u0027, default\u003d0,"},{"line_number":51,"context_line":"              help\u003d_(\"The minimum of the UDP source port range used for \""},{"line_number":52,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_4d239606","line":51,"updated":"2017-07-02 08:06:07.000000000","message":"please fix indentation here","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"e9a4220c11e3d6069ce873a6ee828f5ec059bb69","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                     \"option in the ML2 plug-in configuration file on the \""},{"line_number":49,"context_line":"                     \"neutron server node(s).\")),"},{"line_number":50,"context_line":"    cfg.PortOpt(\u0027udp_srcport_min\u0027, default\u003d0,"},{"line_number":51,"context_line":"              help\u003d_(\"The minimum of the UDP source port range used for \""},{"line_number":52,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_69d198cd","line":51,"in_reply_to":"3f1d235d_4d239606","updated":"2017-07-03 08:51:03.000000000","message":"Ok","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"113d84ac5e142a9892fe39b6892252d907fc5fbf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"              help\u003d_(\"The minimum of the UDP source port range used for \""},{"line_number":52,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""},{"line_number":55,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":56,"context_line":"    cfg.PortOpt(\u0027udp_dstport\u0027,"},{"line_number":57,"context_line":"              help\u003d_(\"The UDP port used for VXLAN communication. By default, \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_2d229a01","line":54,"updated":"2017-07-02 08:06:07.000000000","message":"ditto","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"e9a4220c11e3d6069ce873a6ee828f5ec059bb69","unresolved":false,"context_lines":[{"line_number":51,"context_line":"              help\u003d_(\"The minimum of the UDP source port range used for \""},{"line_number":52,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":53,"context_line":"    cfg.PortOpt(\u0027udp_srcport_max\u0027, default\u003d0,"},{"line_number":54,"context_line":"              help\u003d_(\"The maximum of the UDP source port range used for \""},{"line_number":55,"context_line":"                     \"VXLAN communication.\")),"},{"line_number":56,"context_line":"    cfg.PortOpt(\u0027udp_dstport\u0027,"},{"line_number":57,"context_line":"              help\u003d_(\"The UDP port used for VXLAN communication. By default, \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_49d49cbd","line":54,"in_reply_to":"3f1d235d_2d229a01","updated":"2017-07-03 08:51:03.000000000","message":"Ok","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"adf7dbd7cab930adf643285cc11e7021b009fc3b","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                       \u0027segmentation_id\u0027: segmentation_id})"},{"line_number":290,"context_line":"            args \u003d {\u0027dev\u0027: self.local_int,"},{"line_number":291,"context_line":"                    \u0027srcport\u0027: (cfg.CONF.VXLAN.udp_srcport_min,"},{"line_number":292,"context_line":"                                cfg.CONF.VXLAN.udp_srcport_max)}"},{"line_number":293,"context_line":"            if self.vxlan_mode \u003d\u003d lconst.VXLAN_MCAST:"},{"line_number":294,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"},{"line_number":295,"context_line":"            if cfg.CONF.VXLAN.ttl:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_7974da68","line":292,"updated":"2017-05-31 10:12:48.000000000","message":"so srcport 0,0 (the new default) has no effect on this, right?","commit_id":"0b4f20f29127ac26f1df320c4ea07ac561aeda7d"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"76d11cd86ec7cc835de21f777852cfa6c31626f8","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                       \u0027segmentation_id\u0027: segmentation_id})"},{"line_number":290,"context_line":"            args \u003d {\u0027dev\u0027: self.local_int,"},{"line_number":291,"context_line":"                    \u0027srcport\u0027: (cfg.CONF.VXLAN.udp_srcport_min,"},{"line_number":292,"context_line":"                                cfg.CONF.VXLAN.udp_srcport_max)}"},{"line_number":293,"context_line":"            if self.vxlan_mode \u003d\u003d lconst.VXLAN_MCAST:"},{"line_number":294,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"},{"line_number":295,"context_line":"            if cfg.CONF.VXLAN.ttl:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_f9634a19","line":292,"in_reply_to":"df140735_7974da68","updated":"2017-05-31 10:37:31.000000000","message":"No, these are the defaults, so doesn\u0027t matter if you specify srcport 0 0 or does not specify it at all for the \u0027ip link add\u0027 command.","commit_id":"0b4f20f29127ac26f1df320c4ea07ac561aeda7d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"113d84ac5e142a9892fe39b6892252d907fc5fbf","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                args[\u0027tos\u0027] \u003d cfg.CONF.VXLAN.tos"},{"line_number":333,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":334,"context_line":"                args[\u0027proxy\u0027] \u003d cfg.CONF.VXLAN.arp_responder"},{"line_number":335,"context_line":"            if cfg.CONF.VXLAN.udp_dstport:"},{"line_number":336,"context_line":"                args[\u0027dstport\u0027] \u003d cfg.CONF.VXLAN.udp_dstport"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_4d683620","line":335,"updated":"2017-07-02 08:06:07.000000000","message":"you do not need the if here.","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"e9a4220c11e3d6069ce873a6ee828f5ec059bb69","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                args[\u0027tos\u0027] \u003d cfg.CONF.VXLAN.tos"},{"line_number":333,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":334,"context_line":"                args[\u0027proxy\u0027] \u003d cfg.CONF.VXLAN.arp_responder"},{"line_number":335,"context_line":"            if cfg.CONF.VXLAN.udp_dstport:"},{"line_number":336,"context_line":"                args[\u0027dstport\u0027] \u003d cfg.CONF.VXLAN.udp_dstport"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_d12e1ca4","line":335,"in_reply_to":"3f1d235d_4d683620","updated":"2017-07-03 08:51:03.000000000","message":"Even if there is no default value?","commit_id":"20420c8e5a41d1dfaf1280eb8a3b4bba732c17e1"}],"releasenotes/notes/linuxbridge-vxlan-udp-ports-73b260efefa15a46.yaml":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6adb78395af0329fd8edaaccab5ac935d93c293f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    VXLAN.udp_srcport_max and VXLAN.udp_dstport config"},{"line_number":6,"context_line":"    options. To use the IANA assigned port number, set"},{"line_number":7,"context_line":"    VXLAN.udp_dstport to 4789. The default is not changed"},{"line_number":8,"context_line":"    from the Linux kernel defalult 8472."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f1d235d_176399de","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":34},"updated":"2017-06-29 20:56:27.000000000","message":"default","commit_id":"270cd93dee9f5b16af5aee5a524f1a8546f67f7a"},{"author":{"_account_id":18940,"name":"Gyorgy Szombathelyi","email":"gyurco@freemail.hu","username":"gyurco78"},"change_message_id":"9ccafed7a01aef2bb9d2a50ecea0538ec4ddc6f5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    VXLAN.udp_srcport_max and VXLAN.udp_dstport config"},{"line_number":6,"context_line":"    options. To use the IANA assigned port number, set"},{"line_number":7,"context_line":"    VXLAN.udp_dstport to 4789. The default is not changed"},{"line_number":8,"context_line":"    from the Linux kernel defalult 8472."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f1d235d_2a6dfd03","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":34},"in_reply_to":"3f1d235d_176399de","updated":"2017-06-30 12:21:22.000000000","message":"Ooops","commit_id":"270cd93dee9f5b16af5aee5a524f1a8546f67f7a"}]}
