)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3981635eed047633b758279827e439012e05a453","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-30 11:38:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api: Common way to define required extensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As some tests require extensions to be enabled on the server, this patch"},{"line_number":10,"context_line":"introduces a new class attribute to the API base class. If any extension"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_f2cb851b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2017-05-30 11:58:56.000000000","message":"API test ?","commit_id":"a273370e1a24175b9b84e3447689f84e1d43b5f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e76f241398981eab32fedcee58b33b57e0c19a9f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-30 11:38:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api: Common way to define required extensions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As some tests require extensions to be enabled on the server, this patch"},{"line_number":10,"context_line":"introduces a new class attribute to the API base class. If any extension"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_124cb99c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"in_reply_to":"df140735_f2cb851b","updated":"2017-05-30 12:04:54.000000000","message":"Done","commit_id":"a273370e1a24175b9b84e3447689f84e1d43b5f1"}],"TESTING.rst":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"86ae2a353ed70b51af63d7300c425899f43d0e4d","unresolved":false,"context_lines":[{"line_number":369,"context_line":"according to the API they\u0027re targeting."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"To create an API test, the testing class must at least inherit from"},{"line_number":372,"context_line":"neutron.tests.tempest.api.base.BaseNetworkTest base class. As some of tests"},{"line_number":373,"context_line":"may require certain extensions to be enabled, the base class provides"},{"line_number":374,"context_line":"``required_extensions`` class attribute which can be used by subclasses to"},{"line_number":375,"context_line":"define a list of required extensions for particular test class."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df140735_234f1635","line":372,"range":{"start_line":372,"start_character":67,"end_line":372,"end_character":75},"updated":"2017-06-01 21:31:30.000000000","message":"nit in case you roll another patchset: \u0027of the tests\u0027 or \u0027tests\u0027","commit_id":"814fbc05011b3204102c1f930fce24c2fc3c9b62"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0ec603d8e3a2105bc32ae254c7f06de3302281a8","unresolved":false,"context_lines":[{"line_number":369,"context_line":"according to the API they\u0027re targeting."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"To create an API test, the testing class must at least inherit from"},{"line_number":372,"context_line":"neutron.tests.tempest.api.base.BaseNetworkTest base class. As some of tests"},{"line_number":373,"context_line":"may require certain extensions to be enabled, the base class provides"},{"line_number":374,"context_line":"``required_extensions`` class attribute which can be used by subclasses to"},{"line_number":375,"context_line":"define a list of required extensions for particular test class."}],"source_content_type":"text/x-rst","patch_set":5,"id":"df140735_dcd57d1d","line":372,"range":{"start_line":372,"start_character":67,"end_line":372,"end_character":75},"in_reply_to":"df140735_234f1635","updated":"2017-06-06 01:21:20.000000000","message":"The gate job failed. Good chance to update.","commit_id":"814fbc05011b3204102c1f930fce24c2fc3c9b62"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3981635eed047633b758279827e439012e05a453","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if cls._ip_version \u003d\u003d 6 and not CONF.network_feature_enabled.ipv6:"},{"line_number":78,"context_line":"            raise cls.skipException(\"IPv6 Tests are disabled.\")"},{"line_number":79,"context_line":"        for req_ext in getattr(cls, \u0027required_extensions\u0027, []):"},{"line_number":80,"context_line":"            if not test.is_extension_enabled("},{"line_number":81,"context_line":"                    req_ext, \u0027network\u0027):"},{"line_number":82,"context_line":"                msg \u003d \"%s extension not enabled.\" % req_ext"},{"line_number":83,"context_line":"                raise cls.skipException(msg)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_b2874dd8","line":81,"range":{"start_line":80,"start_character":12,"end_line":81,"end_character":39},"updated":"2017-05-30 11:58:56.000000000","message":"Doesn\u0027t this fit in one line?","commit_id":"a273370e1a24175b9b84e3447689f84e1d43b5f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e76f241398981eab32fedcee58b33b57e0c19a9f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if cls._ip_version \u003d\u003d 6 and not CONF.network_feature_enabled.ipv6:"},{"line_number":78,"context_line":"            raise cls.skipException(\"IPv6 Tests are disabled.\")"},{"line_number":79,"context_line":"        for req_ext in getattr(cls, \u0027required_extensions\u0027, []):"},{"line_number":80,"context_line":"            if not test.is_extension_enabled("},{"line_number":81,"context_line":"                    req_ext, \u0027network\u0027):"},{"line_number":82,"context_line":"                msg \u003d \"%s extension not enabled.\" % req_ext"},{"line_number":83,"context_line":"                raise cls.skipException(msg)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_927689d8","line":81,"range":{"start_line":80,"start_character":12,"end_line":81,"end_character":39},"in_reply_to":"df140735_b2874dd8","updated":"2017-05-30 12:04:54.000000000","message":"Yep, thanks. My first version was not a list but a single extension so I compared to cls.required_extension which didn\u0027t fit :)","commit_id":"a273370e1a24175b9b84e3447689f84e1d43b5f1"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"598abbdf2cf2ac2b55249ec1a6a7880b9591460d","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    QosBandwidthLimitRuleTestJSON):"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    required_extensions \u003d ("},{"line_number":552,"context_line":"        QosBandwidthLimitRuleTestJSON.required_extensions +"},{"line_number":553,"context_line":"        [\u0027qos-bw-limit-direction\u0027]"},{"line_number":554,"context_line":"    )"},{"line_number":555,"context_line":"    scenarios \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_32670bba","line":552,"updated":"2017-06-05 19:34:44.000000000","message":"we could make the skip logic to walk through MRO I guess.","commit_id":"814fbc05011b3204102c1f930fce24c2fc3c9b62"}],"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"084d4a5274108d5266ca17f486873a36a56a8c73","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class TrunkTestJSONBase(base.BaseAdminNetworkTest):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    required_extensions \u003d [\u0027trunk\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        self.addCleanup(self.resource_cleanup)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0d4db871","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":35},"updated":"2017-05-30 12:11:13.000000000","message":"i guess TestTrunkDetailsJSON needs an update.","commit_id":"39b13289f04c36759c40cfba24ca3e305a19153e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"20a6daf28bc7a65170947b417b25ce8faa306896","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class TrunkTestJSONBase(base.BaseAdminNetworkTest):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    required_extensions \u003d [\u0027trunk\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        self.addCleanup(self.resource_cleanup)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_cdaa2084","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":35},"in_reply_to":"df140735_0d4db871","updated":"2017-05-30 12:24:47.000000000","message":"Do you mean TestTrunkDetailsJSON in test_trunk_details.py should inherit base.BaseAdminNetworkTest directly?","commit_id":"39b13289f04c36759c40cfba24ca3e305a19153e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cbea78653a94e326fd34578b2bc82019bae41020","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class TrunkTestJSONBase(base.BaseAdminNetworkTest):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    required_extensions \u003d [\u0027trunk\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        self.addCleanup(self.resource_cleanup)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_cdb7c086","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":35},"in_reply_to":"df140735_cdaa2084","updated":"2017-05-30 12:38:45.000000000","message":"TestTrunkDetailsJSON has a class attribute \"extension\", which is no longer checked after this change.\ni guess the minimum change would be to replace it with required_extension.","commit_id":"39b13289f04c36759c40cfba24ca3e305a19153e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bfd634c6579c5d2cb1198f6b9bfc108f92051754","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class TrunkTestJSONBase(base.BaseAdminNetworkTest):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    required_extensions \u003d [\u0027trunk\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def setUp(self):"},{"line_number":44,"context_line":"        self.addCleanup(self.resource_cleanup)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_88cbf651","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":35},"in_reply_to":"df140735_cdb7c086","updated":"2017-05-30 13:06:43.000000000","message":"Thanks, missed that.","commit_id":"39b13289f04c36759c40cfba24ca3e305a19153e"}]}
