)]}'
{"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"79bd9a1faf292669c2c6401f233720379dbc35f1","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                                   nic\u003dNone):"},{"line_number":229,"context_line":"        \"\"\"check ping server via source ssh connection"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param source: an ssh.Client connection from which to ping"},{"line_number":232,"context_line":"        :param dest: and IP to ping against"},{"line_number":233,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":234,"context_line":"        :param nic: specific network interface to ping from"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f4e5783_23d2e25d","line":231,"updated":"2017-10-10 23:14:44.000000000","message":"it\u0027s better to make this a separate change.\nesp. when it\u0027s the only change in this file.","commit_id":"539e22e5706419146db57a4642ff4ee9394aeaf1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3f41b3c23f4671ec4383dbdc9db8ff68dac479b8","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                                   nic\u003dNone):"},{"line_number":229,"context_line":"        \"\"\"check ping server via source ssh connection"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        :param source: an ssh.Client connection from which to ping"},{"line_number":232,"context_line":"        :param dest: and IP to ping against"},{"line_number":233,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":234,"context_line":"        :param nic: specific network interface to ping from"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_21126763","line":231,"in_reply_to":"5f4e5783_23d2e25d","updated":"2017-10-24 15:35:20.000000000","message":"Ah, right, that is a leftover from a previous version, I\u0027ll remove it","commit_id":"539e22e5706419146db57a4642ff4ee9394aeaf1"}],"neutron/tests/tempest/scenario/test_ipv6.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"100d052e56a73110b9f8d4a67c826b0f9ddacc80","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            self.assertTrue(test_utils.call_until_true(srv2_v6_addr_assigned,"},{"line_number":471,"context_line":"                            CONF.validation.ping_timeout, 1))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        self.check_remote_connectivity(sshv4_1, ips_from_api_2[\u00274\u0027])"},{"line_number":474,"context_line":"        self.check_remote_connectivity(sshv4_2, ips_from_api_1[\u00274\u0027])"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        for i in range(n_subnets6):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_6ef36e75","line":473,"range":{"start_line":473,"start_character":13,"end_line":473,"end_character":38},"updated":"2017-06-05 10:01:34.000000000","message":"check_remote_connectivity takes ssh.Client, not RemoteClient.","commit_id":"a4ed05dcad3eb8563bbbc212358a4ec01d1c59d9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0d1defd69d5a9031381f2a497ebcd0587a0400dd","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            self.assertTrue(test_utils.call_until_true(srv2_v6_addr_assigned,"},{"line_number":471,"context_line":"                            CONF.validation.ping_timeout, 1))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        self.check_remote_connectivity(sshv4_1, ips_from_api_2[\u00274\u0027])"},{"line_number":474,"context_line":"        self.check_remote_connectivity(sshv4_2, ips_from_api_1[\u00274\u0027])"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        for i in range(n_subnets6):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_6f4791be","line":473,"in_reply_to":"df140735_6ef36e75","updated":"2017-06-07 14:45:24.000000000","message":"Yes, you are right, this is different from what tempest does. Re-trying with a simplified client setup now.","commit_id":"a4ed05dcad3eb8563bbbc212358a4ec01d1c59d9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"100d052e56a73110b9f8d4a67c826b0f9ddacc80","unresolved":false,"context_lines":[{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    #@decorators.idempotent_id(\u0027317d3aa7-414e-4f4e-89ac-5aa0c81b6cc8\u0027)"},{"line_number":487,"context_line":"    #def test_slaac_from_os(self):"},{"line_number":488,"context_line":"    #    self._prepare_and_test(address6_mode\u003d\u0027slaac\u0027)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    #@decorators.idempotent_id(\u0027c4c0c611-de7b-4030-b9ca-d5dbcaf15429\u0027)"},{"line_number":491,"context_line":"    #def test_dhcp6_stateless_from_os(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ee065e52","line":488,"updated":"2017-06-05 10:01:34.000000000","message":"is this WIP?","commit_id":"a4ed05dcad3eb8563bbbc212358a4ec01d1c59d9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0d1defd69d5a9031381f2a497ebcd0587a0400dd","unresolved":false,"context_lines":[{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    #@decorators.idempotent_id(\u0027317d3aa7-414e-4f4e-89ac-5aa0c81b6cc8\u0027)"},{"line_number":487,"context_line":"    #def test_slaac_from_os(self):"},{"line_number":488,"context_line":"    #    self._prepare_and_test(address6_mode\u003d\u0027slaac\u0027)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    #@decorators.idempotent_id(\u0027c4c0c611-de7b-4030-b9ca-d5dbcaf15429\u0027)"},{"line_number":491,"context_line":"    #def test_dhcp6_stateless_from_os(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_8f230506","line":488,"in_reply_to":"df140735_ee065e52","updated":"2017-06-07 14:45:24.000000000","message":"I was still wondering whether we would only want the dhcpv6-stateful tests here or maybe also some of the others.\n\nRemoved for now, though there should also be a test for the dhcpv6 part of mode dhcpv6-stateless, but that\u0027ll go into another patch.","commit_id":"a4ed05dcad3eb8563bbbc212358a4ec01d1c59d9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f03c9a0f577e51ab1025bd5719e240da52f266a5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        cls.compute_security_groups_client \u003d ("},{"line_number":74,"context_line":"            clients.compute.SecurityGroupsClient())"},{"line_number":75,"context_line":"        cls.compute_security_group_rules_client \u003d ("},{"line_number":76,"context_line":"            clients.compute.SecurityGroupRulesClient())"},{"line_number":77,"context_line":"        # Neutron clients"},{"line_number":78,"context_line":"        cls.ports_client \u003d ("},{"line_number":79,"context_line":"            clients.network.PortsClient())"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_f21253b1","line":76,"updated":"2017-06-12 17:46:02.000000000","message":"I don\u0027t think we should be using the nova client for SGs.","commit_id":"ac0a9aa2f35be2e8a73bc7a360851c4a702876ff"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f03c9a0f577e51ab1025bd5719e240da52f266a5","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return subnet"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def _create_loginable_secgroup_rule(self, secgroup_id\u003dNone):"},{"line_number":184,"context_line":"        _client \u003d self.compute_security_groups_client"},{"line_number":185,"context_line":"        _client_rules \u003d self.compute_security_group_rules_client"},{"line_number":186,"context_line":"        if secgroup_id is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_32cc4b34","line":183,"updated":"2017-06-12 17:46:02.000000000","message":"There are classes in the base neutron tempest scenarios tests to do all this already, let\u0027s just use them instead.","commit_id":"ac0a9aa2f35be2e8a73bc7a360851c4a702876ff"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"79bd9a1faf292669c2c6401f233720379dbc35f1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        clients \u003d cls.get_client_manager()"},{"line_number":71,"context_line":"        cls.servers_client \u003d ("},{"line_number":72,"context_line":"            clients.compute.ServersClient())"},{"line_number":73,"context_line":"        # Nova security groups client"},{"line_number":74,"context_line":"        cls.compute_security_groups_client \u003d ("},{"line_number":75,"context_line":"            clients.compute.SecurityGroupsClient())"},{"line_number":76,"context_line":"        cls.compute_security_group_rules_client \u003d ("},{"line_number":77,"context_line":"            clients.compute.SecurityGroupRulesClient())"},{"line_number":78,"context_line":"        # Neutron clients"},{"line_number":79,"context_line":"        cls.ports_client \u003d ("},{"line_number":80,"context_line":"            clients.network.PortsClient())"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f4e5783_c32c2e49","line":77,"range":{"start_line":73,"start_character":0,"end_line":77,"end_character":55},"updated":"2017-10-10 23:14:44.000000000","message":"why to use nova SG api rather than neutron\u0027s?","commit_id":"539e22e5706419146db57a4642ff4ee9394aeaf1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3f41b3c23f4671ec4383dbdc9db8ff68dac479b8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        clients \u003d cls.get_client_manager()"},{"line_number":71,"context_line":"        cls.servers_client \u003d ("},{"line_number":72,"context_line":"            clients.compute.ServersClient())"},{"line_number":73,"context_line":"        # Nova security groups client"},{"line_number":74,"context_line":"        cls.compute_security_groups_client \u003d ("},{"line_number":75,"context_line":"            clients.compute.SecurityGroupsClient())"},{"line_number":76,"context_line":"        cls.compute_security_group_rules_client \u003d ("},{"line_number":77,"context_line":"            clients.compute.SecurityGroupRulesClient())"},{"line_number":78,"context_line":"        # Neutron clients"},{"line_number":79,"context_line":"        cls.ports_client \u003d ("},{"line_number":80,"context_line":"            clients.network.PortsClient())"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_7c17e446","line":77,"range":{"start_line":73,"start_character":0,"end_line":77,"end_character":55},"in_reply_to":"5f4e5783_c32c2e49","updated":"2017-10-24 15:35:20.000000000","message":"No particular reason, it was present as is in the tempest code this whole thing was mostly copied from. I can try to replace it with neutron client code, though.","commit_id":"539e22e5706419146db57a4642ff4ee9394aeaf1"}]}