)]}'
{"neutron/agent/rpc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c1472c194440756ce1189337b98f910c3772f59b","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            \u0027allowed_address_pairs\u0027: [{\u0027mac_address\u0027: o.mac_address,"},{"line_number":255,"context_line":"                                       \u0027ip_address\u0027: o.ip_address}"},{"line_number":256,"context_line":"                                      for o in port_obj.allowed_address_pairs],"},{"line_number":257,"context_line":"            \u0027port_security_enabled\u0027: getattr(port_obj.security,"},{"line_number":258,"context_line":"                                             \u0027port_security_enabled\u0027, True),"},{"line_number":259,"context_line":"            \u0027qos_policy_id\u0027: port_obj.qos_policy_id,"},{"line_number":260,"context_line":"            \u0027network_qos_policy_id\u0027: net_qos_policy_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_5454e6fd","line":257,"updated":"2017-06-02 16:02:16.000000000","message":"the problem with this is that security is itself an object field that can be None. I agree with the solution, Armando\u0027s concern with other fields doesn\u0027t seem to apply here.","commit_id":"817f39e49599c3308b5d619163a2426269633067"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9977046e9568ebaa43606d56d772c0fd416dfe46","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                      for o in port_obj.allowed_address_pairs],"},{"line_number":257,"context_line":"            \u0027port_security_enabled\u0027: getattr(port_obj.security,"},{"line_number":258,"context_line":"                                             \u0027port_security_enabled\u0027, True),"},{"line_number":259,"context_line":"            \u0027qos_policy_id\u0027: port_obj.qos_policy_id,"},{"line_number":260,"context_line":"            \u0027network_qos_policy_id\u0027: net_qos_policy_id,"},{"line_number":261,"context_line":"            \u0027profile\u0027: port_obj.binding.profile,"},{"line_number":262,"context_line":"            \u0027security_groups\u0027: list(port_obj.security_group_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_8373a64d","line":259,"updated":"2017-05-31 21:34:02.000000000","message":"this is another bomb waiting to go off:\n\nhttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/ml2/rpc.py#n143","commit_id":"817f39e49599c3308b5d619163a2426269633067"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c1472c194440756ce1189337b98f910c3772f59b","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                                      for o in port_obj.allowed_address_pairs],"},{"line_number":257,"context_line":"            \u0027port_security_enabled\u0027: getattr(port_obj.security,"},{"line_number":258,"context_line":"                                             \u0027port_security_enabled\u0027, True),"},{"line_number":259,"context_line":"            \u0027qos_policy_id\u0027: port_obj.qos_policy_id,"},{"line_number":260,"context_line":"            \u0027network_qos_policy_id\u0027: net_qos_policy_id,"},{"line_number":261,"context_line":"            \u0027profile\u0027: port_obj.binding.profile,"},{"line_number":262,"context_line":"            \u0027security_groups\u0027: list(port_obj.security_group_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_b416a248","line":259,"in_reply_to":"df140735_8373a64d","updated":"2017-06-02 16:02:16.000000000","message":"This will be None","commit_id":"817f39e49599c3308b5d619163a2426269633067"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9977046e9568ebaa43606d56d772c0fd416dfe46","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            \u0027qos_policy_id\u0027: port_obj.qos_policy_id,"},{"line_number":260,"context_line":"            \u0027network_qos_policy_id\u0027: net_qos_policy_id,"},{"line_number":261,"context_line":"            \u0027profile\u0027: port_obj.binding.profile,"},{"line_number":262,"context_line":"            \u0027security_groups\u0027: list(port_obj.security_group_ids)"},{"line_number":263,"context_line":"        }"},{"line_number":264,"context_line":"        LOG.debug(\"Returning: %s\", entry)"},{"line_number":265,"context_line":"        return entry"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_039d5658","line":262,"updated":"2017-05-31 21:34:02.000000000","message":"probably this one too if security groups are disabled in the env.","commit_id":"817f39e49599c3308b5d619163a2426269633067"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c1472c194440756ce1189337b98f910c3772f59b","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            \u0027qos_policy_id\u0027: port_obj.qos_policy_id,"},{"line_number":260,"context_line":"            \u0027network_qos_policy_id\u0027: net_qos_policy_id,"},{"line_number":261,"context_line":"            \u0027profile\u0027: port_obj.binding.profile,"},{"line_number":262,"context_line":"            \u0027security_groups\u0027: list(port_obj.security_group_ids)"},{"line_number":263,"context_line":"        }"},{"line_number":264,"context_line":"        LOG.debug(\"Returning: %s\", entry)"},{"line_number":265,"context_line":"        return entry"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_d419167a","line":262,"in_reply_to":"df140735_039d5658","updated":"2017-06-02 16:02:16.000000000","message":"This will be empty list","commit_id":"817f39e49599c3308b5d619163a2426269633067"}]}
