)]}'
{"neutron/objects/qos/rule_type.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9dbb2b8aaa0bc8dc776aea3d314accf59bbe27df","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron.plugins.common import constants"},{"line_number":14,"context_line":"from neutron_lib.plugins import directory"},{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from oslo_utils import versionutils"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_17de7f3d","side":"PARENT","line":13,"updated":"2017-10-09 19:25:27.000000000","message":"LOL, this was misplaced to start with","commit_id":"779a8d31e7afcd20671e7a09309f68339471f1d9"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"64a91d9fd4459621f71a7fe05321f7d9df0cbb86","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Maps extension alias to service type that"},{"line_number":31,"context_line":"# can be implemented by the core plugin."},{"line_number":32,"context_line":"EXT_TO_SERVICE_MAPPING \u003d {"},{"line_number":33,"context_line":"    \u0027dummy\u0027: DUMMY,"},{"line_number":34,"context_line":"    \u0027lbaas\u0027: LOADBALANCER,"},{"line_number":35,"context_line":"    \u0027lbaasv2\u0027: LOADBALANCERV2,"},{"line_number":36,"context_line":"    \u0027fwaas\u0027: FIREWALL,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_6c4ce4c7","side":"PARENT","line":33,"updated":"2017-10-08 20:33:41.000000000","message":"why this one is removed? Is it related to this patch?","commit_id":"d58c1b91b71e5aa3f7ebf5d9d0ef60a3781c556c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"22426ee761bc8ca4ea3093c5dbd183eda8de117e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Maps extension alias to service type that"},{"line_number":31,"context_line":"# can be implemented by the core plugin."},{"line_number":32,"context_line":"EXT_TO_SERVICE_MAPPING \u003d {"},{"line_number":33,"context_line":"    \u0027dummy\u0027: DUMMY,"},{"line_number":34,"context_line":"    \u0027lbaas\u0027: LOADBALANCER,"},{"line_number":35,"context_line":"    \u0027lbaasv2\u0027: LOADBALANCERV2,"},{"line_number":36,"context_line":"    \u0027fwaas\u0027: FIREWALL,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_8fe259d4","side":"PARENT","line":33,"in_reply_to":"7f515b1d_4301e069","updated":"2017-10-09 17:25:22.000000000","message":"ok, thx for explanation. It\u0027s fine for me","commit_id":"d58c1b91b71e5aa3f7ebf5d9d0ef60a3781c556c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e705b89967281cf9528a2c50f605b2aa01941988","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Maps extension alias to service type that"},{"line_number":31,"context_line":"# can be implemented by the core plugin."},{"line_number":32,"context_line":"EXT_TO_SERVICE_MAPPING \u003d {"},{"line_number":33,"context_line":"    \u0027dummy\u0027: DUMMY,"},{"line_number":34,"context_line":"    \u0027lbaas\u0027: LOADBALANCER,"},{"line_number":35,"context_line":"    \u0027lbaasv2\u0027: LOADBALANCERV2,"},{"line_number":36,"context_line":"    \u0027fwaas\u0027: FIREWALL,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_4301e069","side":"PARENT","line":33,"in_reply_to":"7f515b1d_6c4ce4c7","updated":"2017-10-09 15:21:54.000000000","message":"It\u0027s moved to the dummy_plugin in the unit test package as part of this patch [1] as it\u0027s only used by tests. This is part of the effort to rehome and clean up the common constants so have included it herein. If others think it belongs in its own patch, I can refactor as needed.\n\n\n[1] https://review.openstack.org/#/c/469495/4/neutron/tests/unit/dummy_plugin.py","commit_id":"d58c1b91b71e5aa3f7ebf5d9d0ef60a3781c556c"}],"neutron/tests/unit/test_manager.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":46,"context_line":"        if \u0027dummy\u0027 not in ext_mapping:"},{"line_number":47,"context_line":"            ext_mapping[\u0027dummy\u0027] \u003d dummy_plugin.DUMMY_SERVICE_TYPE"},{"line_number":48,"context_line":"        super(NeutronManagerTestCase, self).setUp()"},{"line_number":49,"context_line":"        self.config_parse()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_1a01066b","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":18},"updated":"2017-10-09 20:10:04.000000000","message":"Why not dummy_plugin.RESOURCE_NAME?","commit_id":"cc11d41177040d869ed12a47bcdeb182be37c16a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":46,"context_line":"        if \u0027dummy\u0027 not in ext_mapping:"},{"line_number":47,"context_line":"            ext_mapping[\u0027dummy\u0027] \u003d dummy_plugin.DUMMY_SERVICE_TYPE"},{"line_number":48,"context_line":"        super(NeutronManagerTestCase, self).setUp()"},{"line_number":49,"context_line":"        self.config_parse()"},{"line_number":50,"context_line":"        self.setup_coreplugin(load_plugins\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_5a309e56","line":47,"range":{"start_line":47,"start_character":24,"end_line":47,"end_character":31},"updated":"2017-10-09 20:10:04.000000000","message":"ditto","commit_id":"cc11d41177040d869ed12a47bcdeb182be37c16a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def tearDown(self):"},{"line_number":55,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":56,"context_line":"        if \u0027dummy\u0027 in ext_mapping:"},{"line_number":57,"context_line":"            del ext_mapping[\u0027dummy\u0027]"},{"line_number":58,"context_line":"        super(NeutronManagerTestCase, self).tearDown()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_3a31625a","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":18},"updated":"2017-10-09 20:10:04.000000000","message":"ditto","commit_id":"cc11d41177040d869ed12a47bcdeb182be37c16a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def tearDown(self):"},{"line_number":55,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":56,"context_line":"        if \u0027dummy\u0027 in ext_mapping:"},{"line_number":57,"context_line":"            del ext_mapping[\u0027dummy\u0027]"},{"line_number":58,"context_line":"        super(NeutronManagerTestCase, self).tearDown()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_service_plugin_is_loaded(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_fa3e2a27","line":57,"range":{"start_line":57,"start_character":28,"end_line":57,"end_character":35},"updated":"2017-10-09 20:10:04.000000000","message":"ditto","commit_id":"cc11d41177040d869ed12a47bcdeb182be37c16a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":46,"context_line":"        if \u0027dummy\u0027 not in ext_mapping:"},{"line_number":47,"context_line":"            ext_mapping[\u0027dummy\u0027] \u003d dummy_plugin.DUMMY_SERVICE_TYPE"},{"line_number":48,"context_line":"        super(NeutronManagerTestCase, self).setUp()"},{"line_number":49,"context_line":"        self.config_parse()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_1a8466d2","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":18},"updated":"2017-10-09 20:10:04.000000000","message":"why not dummy_plugin.RESOURCE_NAME?","commit_id":"782ec319c24d64ea2537363de22079510e9cb52c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"2dd6d450f177f01d86864a3461bf24bcff45d1af","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":46,"context_line":"        if \u0027dummy\u0027 not in ext_mapping:"},{"line_number":47,"context_line":"            ext_mapping[\u0027dummy\u0027] \u003d dummy_plugin.DUMMY_SERVICE_TYPE"},{"line_number":48,"context_line":"        super(NeutronManagerTestCase, self).setUp()"},{"line_number":49,"context_line":"        self.config_parse()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f4e5783_4a268517","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":18},"in_reply_to":"7f515b1d_1a8466d2","updated":"2017-10-16 13:12:01.000000000","message":"Yeah good point","commit_id":"782ec319c24d64ea2537363de22079510e9cb52c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":46,"context_line":"        if \u0027dummy\u0027 not in ext_mapping:"},{"line_number":47,"context_line":"            ext_mapping[\u0027dummy\u0027] \u003d dummy_plugin.DUMMY_SERVICE_TYPE"},{"line_number":48,"context_line":"        super(NeutronManagerTestCase, self).setUp()"},{"line_number":49,"context_line":"        self.config_parse()"},{"line_number":50,"context_line":"        self.setup_coreplugin(load_plugins\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_fa6cea36","line":47,"range":{"start_line":47,"start_character":24,"end_line":47,"end_character":31},"updated":"2017-10-09 20:10:04.000000000","message":"ditto","commit_id":"782ec319c24d64ea2537363de22079510e9cb52c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def tearDown(self):"},{"line_number":55,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":56,"context_line":"        if \u0027dummy\u0027 in ext_mapping:"},{"line_number":57,"context_line":"            del ext_mapping[\u0027dummy\u0027]"},{"line_number":58,"context_line":"        super(NeutronManagerTestCase, self).tearDown()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_9a6f3627","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":18},"updated":"2017-10-09 20:10:04.000000000","message":"ditto","commit_id":"782ec319c24d64ea2537363de22079510e9cb52c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"851afbd8d97ed2693ca30200c9e2da54ff5db157","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    def tearDown(self):"},{"line_number":55,"context_line":"        ext_mapping \u003d constants.EXT_TO_SERVICE_MAPPING"},{"line_number":56,"context_line":"        if \u0027dummy\u0027 in ext_mapping:"},{"line_number":57,"context_line":"            del ext_mapping[\u0027dummy\u0027]"},{"line_number":58,"context_line":"        super(NeutronManagerTestCase, self).tearDown()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_service_plugin_is_loaded(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_7a623a40","line":57,"range":{"start_line":57,"start_character":28,"end_line":57,"end_character":35},"updated":"2017-10-09 20:10:04.000000000","message":"ditto","commit_id":"782ec319c24d64ea2537363de22079510e9cb52c"}]}
