)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7520dcce38f4fd4d68c67479a12ced7fa81285e7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"to the inheritance order."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I56f9de31524aeef262cf2a78be3abf8487c21a12"},{"line_number":16,"context_line":"Closes-Bug: # 1695101"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_60a61656","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":14},"updated":"2017-06-02 07:35:47.000000000","message":"please remove gap","commit_id":"e95a5e69a62ef0b93c46bc2beebb5ad534f889d3"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c1398de5821fe65e58efc4f7feeb334bd969a897","unresolved":false,"context_lines":[{"line_number":961,"context_line":"            update_port \u003d self._core_plugin.update_port("},{"line_number":962,"context_line":"                context, address_pair_port[\u0027id\u0027], {\u0027port\u0027: port_data})"},{"line_number":963,"context_line":"            return update_port"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"# NOTE: The order in which the parent classes are inherited sometimes"},{"line_number":966,"context_line":"# determines the functions defined in those classes to be executed."},{"line_number":967,"context_line":"# So any new classes that are created should be on the top of the list"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_dc6dd4cc","line":964,"updated":"2017-06-02 02:53:30.000000000","message":"Class would need 2 spaces ( the comment start at Line #965 and #963 minimizes the gap to 1)","commit_id":"e95a5e69a62ef0b93c46bc2beebb5ad534f889d3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5b96032d2be7454d4f446209c50cbb611239cdd","unresolved":false,"context_lines":[{"line_number":965,"context_line":"# NOTE: The order in which the parent classes are inherited sometimes"},{"line_number":966,"context_line":"# determines the functions defined in those classes to be executed."},{"line_number":967,"context_line":"# So any new classes that are created should be on the top of the list."},{"line_number":968,"context_line":""},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"class L3_NAT_with_dvr_db_mixin(DVRResourceOperationHandler,"},{"line_number":971,"context_line":"                               _DVRAgentInterfaceMixin,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf091321_7382f051","line":968,"updated":"2017-06-08 07:51:23.000000000","message":"The comment is related to the class below so spaces could be removed. Please rather add 2nd space after #964, I believe this was the comment in PS1 about","commit_id":"b0887b741fc57ffad52a7e35a302e730698418cb"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fb58ad8cd6f4c8339ec7db4483dfa8f8968eff75","unresolved":false,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":"# NOTE: The order in which the parent classes are inherited sometimes"},{"line_number":967,"context_line":"# determines the functions defined in those classes to be executed."},{"line_number":968,"context_line":"# So any new classes that are created should be on the top of the list."},{"line_number":969,"context_line":"class L3_NAT_with_dvr_db_mixin(DVRResourceOperationHandler,"},{"line_number":970,"context_line":"                               _DVRAgentInterfaceMixin,"},{"line_number":971,"context_line":"                               l3_attrs_db.ExtraAttributesMixin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f0e0f27_ba918df4","line":968,"range":{"start_line":968,"start_character":38,"end_line":968,"end_character":70},"updated":"2017-06-09 08:02:03.000000000","message":"this might seem ambiguous, does \u0027on top\u0027 mean the last or the first element? The fix moves l3_db.L3_NAT_db_mixin to be the last and DVRResourceOperationHandler to be the first, so it\u0027s a bit confusing","commit_id":"ed16d76278cbd70c08420e4b8a2b48966186733d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"28bcfcbe7caad01e5d09d968f797870c4c7f7233","unresolved":false,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":"# NOTE: The order in which the parent classes are inherited sometimes"},{"line_number":967,"context_line":"# determines the functions defined in those classes to be executed."},{"line_number":968,"context_line":"# So any new classes that are created should be on the top of the list."},{"line_number":969,"context_line":"class L3_NAT_with_dvr_db_mixin(DVRResourceOperationHandler,"},{"line_number":970,"context_line":"                               _DVRAgentInterfaceMixin,"},{"line_number":971,"context_line":"                               l3_attrs_db.ExtraAttributesMixin,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_e5c6e49a","line":968,"range":{"start_line":968,"start_character":38,"end_line":968,"end_character":70},"in_reply_to":"9f0e0f27_ba918df4","updated":"2017-06-13 17:40:45.000000000","message":"will fix the NOTE.","commit_id":"ed16d76278cbd70c08420e4b8a2b48966186733d"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fb58ad8cd6f4c8339ec7db4483dfa8f8968eff75","unresolved":false,"context_lines":[{"line_number":719,"context_line":"    def test_dvr_gateway_host_binding_is_set(self):"},{"line_number":720,"context_line":"        router \u003d self._create_router()"},{"line_number":721,"context_line":"        private_net1 \u003d self._make_network(self.fmt, \u0027net1\u0027, True)"},{"line_number":722,"context_line":"        test_allocation_pools \u003d [{\u0027start\u0027: \u002710.1.0.2\u0027,"},{"line_number":723,"context_line":"                                  \u0027end\u0027: \u002710.1.0.20\u0027}]"},{"line_number":724,"context_line":"        kwargs \u003d {\u0027arg_list\u0027: (external_net.EXTERNAL,),"},{"line_number":725,"context_line":"                  external_net.EXTERNAL: True}"},{"line_number":726,"context_line":"        ext_net \u003d self._make_network(self.fmt, \u0027\u0027, True, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f0e0f27_baf2ad99","line":723,"range":{"start_line":722,"start_character":8,"end_line":723,"end_character":54},"updated":"2017-06-09 08:02:03.000000000","message":"just curious, why is this needed for the test?","commit_id":"ed16d76278cbd70c08420e4b8a2b48966186733d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"28bcfcbe7caad01e5d09d968f797870c4c7f7233","unresolved":false,"context_lines":[{"line_number":719,"context_line":"    def test_dvr_gateway_host_binding_is_set(self):"},{"line_number":720,"context_line":"        router \u003d self._create_router()"},{"line_number":721,"context_line":"        private_net1 \u003d self._make_network(self.fmt, \u0027net1\u0027, True)"},{"line_number":722,"context_line":"        test_allocation_pools \u003d [{\u0027start\u0027: \u002710.1.0.2\u0027,"},{"line_number":723,"context_line":"                                  \u0027end\u0027: \u002710.1.0.20\u0027}]"},{"line_number":724,"context_line":"        kwargs \u003d {\u0027arg_list\u0027: (external_net.EXTERNAL,),"},{"line_number":725,"context_line":"                  external_net.EXTERNAL: True}"},{"line_number":726,"context_line":"        ext_net \u003d self._make_network(self.fmt, \u0027\u0027, True, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_c23abe32","line":723,"range":{"start_line":722,"start_character":8,"end_line":723,"end_character":54},"in_reply_to":"9f0e0f27_baf2ad99","updated":"2017-06-13 17:40:45.000000000","message":"It was a copy paste. But I used it for creating a subnet, let me try it without the allocation_pool.","commit_id":"ed16d76278cbd70c08420e4b8a2b48966186733d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"fb58ad8cd6f4c8339ec7db4483dfa8f8968eff75","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        router_handle \u003d ("},{"line_number":751,"context_line":"            self.l3_plugin.list_active_sync_routers_on_active_l3_agent("},{"line_number":752,"context_line":"                self.context, self.l3_agent[\u0027host\u0027], [router[\u0027id\u0027]]))"},{"line_number":753,"context_line":"        self.assertEqual(self.l3_agent[\u0027host\u0027],"},{"line_number":754,"context_line":"                         router_handle[0][\u0027gw_port_host\u0027])"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_allowed_address_pairs_update_arp_entry(self):"},{"line_number":757,"context_line":"        HOST1 \u003d \u0027host1\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f0e0f27_1a399940","line":754,"range":{"start_line":753,"start_character":8,"end_line":754,"end_character":58},"updated":"2017-06-09 08:02:03.000000000","message":"is this failing without the fix?","commit_id":"ed16d76278cbd70c08420e4b8a2b48966186733d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"28bcfcbe7caad01e5d09d968f797870c4c7f7233","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        router_handle \u003d ("},{"line_number":751,"context_line":"            self.l3_plugin.list_active_sync_routers_on_active_l3_agent("},{"line_number":752,"context_line":"                self.context, self.l3_agent[\u0027host\u0027], [router[\u0027id\u0027]]))"},{"line_number":753,"context_line":"        self.assertEqual(self.l3_agent[\u0027host\u0027],"},{"line_number":754,"context_line":"                         router_handle[0][\u0027gw_port_host\u0027])"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_allowed_address_pairs_update_arp_entry(self):"},{"line_number":757,"context_line":"        HOST1 \u003d \u0027host1\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_422fcef5","line":754,"range":{"start_line":753,"start_character":8,"end_line":754,"end_character":58},"in_reply_to":"9f0e0f27_1a399940","updated":"2017-06-13 17:40:45.000000000","message":"Yes it is failing without the fix.\n\nI see a KeyError: \u0027gw_port_host\u0027 without the fix. So it seems to be a valid test case.","commit_id":"ed16d76278cbd70c08420e4b8a2b48966186733d"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5b96032d2be7454d4f446209c50cbb611239cdd","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"        router \u003d ("},{"line_number":1109,"context_line":"            self.plugin.list_active_sync_routers_on_active_l3_agent("},{"line_number":1110,"context_line":"                self.admin_ctx, self.agent2[\u0027host\u0027], [router[\u0027id\u0027]]))"},{"line_number":1111,"context_line":"        if not len(router) \u003d\u003d 0:"},{"line_number":1112,"context_line":"            self.assertEqual(self.agent2[\u0027host\u0027], router[0][\u0027gw_port_host\u0027])"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    def test_ensure_host_set_on_ports_binds_correctly(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf091321_13e61446","line":1111,"range":{"start_line":1111,"start_character":8,"end_line":1111,"end_character":32},"updated":"2017-06-08 07:51:23.000000000","message":"if it\u0027s \"0\" the test will also pass, is it ok?","commit_id":"b0887b741fc57ffad52a7e35a302e730698418cb"}]}
