)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"59d46f846623de45f52b4baecb257a9c2f5a2ea9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"          (on the set of networks with an HA interface on a router)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"A basic test shows a drastic improvements, from minutes to around"},{"line_number":28,"context_line":"one second, in the processing of a sync_routers call with 256 routers."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I3a00c8fbb245ab3b6d93bdaa97f3435570992791"},{"line_number":31,"context_line":"Related-Bug: 1692971"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_1a57b55a","line":28,"updated":"2017-06-02 17:48:52.000000000","message":"if that were to be true, you rock big time :)","commit_id":"e3b2e518b19031198e62c0ba4d9480c1ffeff570"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"59d46f846623de45f52b4baecb257a9c2f5a2ea9","unresolved":false,"context_lines":[{"line_number":636,"context_line":"        for router in routers_dict.values():"},{"line_number":637,"context_line":"            interface \u003d router.get(constants.HA_INTERFACE_KEY)"},{"line_number":638,"context_line":"            if interface:"},{"line_number":639,"context_line":"                self._populate_mtu_and_subnets_for_ports(context, [interface])"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"        # If this is a DVR+HA router, but the agent is question is in \u0027dvr\u0027"},{"line_number":642,"context_line":"        # mode (as opposed to \u0027dvr_snat\u0027), then we want to always return it"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_da2b7d92","side":"PARENT","line":639,"updated":"2017-06-02 17:48:52.000000000","message":"Calling this method goes all the way back to the initial implementation:\n\nhttps://review.openstack.org/#/c/64553/77/neutron/db/l3_hamode_db.py@450\n\nIt sounds increasingly likely you find a genuine bottleneck!","commit_id":"e91777ae2f078767fef628868aba2796576d0d39"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"59d46f846623de45f52b4baecb257a9c2f5a2ea9","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if interface:"},{"line_number":640,"context_line":"                interfaces.append(interface)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        self._populate_mtu_and_subnets_for_ports(context, interfaces)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        # If this is a DVR+HA router, but the agent is question is in \u0027dvr\u0027"},{"line_number":645,"context_line":"        # mode (as opposed to \u0027dvr_snat\u0027), then we want to always return it"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_fa0be126","line":642,"updated":"2017-06-02 17:48:52.000000000","message":"I think here we just have to be careful that now interfaces may be accidentally stale. The difference between this pattern and the existing one is that you\u0027d be calling _populate_mtu_and_subnets_for_ports on interfaces that might be gone, though I think that\u0027s unlikely as routers_dict itself may be stale.","commit_id":"e3b2e518b19031198e62c0ba4d9480c1ffeff570"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f5f440f042c0b40bee0d5a3ee67c8b06f588893d","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if interface:"},{"line_number":640,"context_line":"                interfaces.append(interface)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        self._populate_mtu_and_subnets_for_ports(context, interfaces)"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        # If this is a DVR+HA router, but the agent is question is in \u0027dvr\u0027"},{"line_number":645,"context_line":"        # mode (as opposed to \u0027dvr_snat\u0027), then we want to always return it"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_eef9e2c7","line":642,"updated":"2017-06-02 17:59:00.000000000","message":"Same issue applies to original logic. In fact, the one-at-a-time probably made the original logic even more exposed to stale stuff.","commit_id":"e3b2e518b19031198e62c0ba4d9480c1ffeff570"}]}
